From nobody Mon Feb 2 05:55:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1769155089; cv=none; d=zohomail.com; s=zohoarc; b=cZlb48eyR4+zxPzdnmPEbXZcLOGdfYaLdKUGKK88rLcFvuQZkj7oa1FSUgPgnga2TQHjQgS9kws9+wLgVHBaBRfdtVlNXcCq+AYBOdY/v7EYVKOAXBrLaIO6PFHS0E6oFcHZZ/LbHKbsfnBrowwxv9TIj73LoUcRceknFqSuRMQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769155089; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=haoBAonCJkOFZ939eWw9VpTGvjqfl7p/RYvb7itBqow=; b=C9XVYhuOwNJ2VsiR8FkSdhDhW2tligTWzRP4OSz9OpK1Ehu/6DWBtxeU9CG7VKI8bQ60UIzV4pEf9UR5a1keEq/6OZ6NMA9NhigHZmn1NdfhUnmzkccTAXxRjUj4ymyEM2Gjgc+r9nblJdT7NWICEadfjiyReDNL2oPfFnMxB10= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1769155089297391.788764502581; Thu, 22 Jan 2026 23:58:09 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 2F95941B92; Fri, 23 Jan 2026 02:58:08 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B80F741B13; Fri, 23 Jan 2026 02:57:27 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 716754191D; Fri, 23 Jan 2026 02:57:23 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BA4773FB39 for ; Fri, 23 Jan 2026 02:57:22 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-Pyva3JzxNEqxlF4O_HNx-g-1; Fri, 23 Jan 2026 02:57:20 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 64F361869D94 for ; Fri, 23 Jan 2026 07:57:13 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A8C4018004D8 for ; Fri, 23 Jan 2026 07:57:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769155042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=haoBAonCJkOFZ939eWw9VpTGvjqfl7p/RYvb7itBqow=; b=c/vKhzody2DuixRf/8WXS/8NvNWlJ5K3nLfBdLop3w6eUDtv2Bahx3DiuejOoVzoayy2XX 1eGliKlfOJbL6SlL00g3vtYvzwAUF/hpXAOd7LsCiwRiagLVM36kEccPlCMkWmJ6CU5GCx 6HEpxOyOXnjEkNth+39Jl7DSZ7NQM4E= X-MC-Unique: Pyva3JzxNEqxlF4O_HNx-g-1 X-Mimecast-MFC-AGG-ID: Pyva3JzxNEqxlF4O_HNx-g_1769155039 To: devel@lists.libvirt.org Subject: [PATCH 1/2] qemuSnapshotDiskHasBackingDisk: Avoid call of virStorageSourceIsSameLocation with NULL argument Date: Fri, 23 Jan 2026 08:57:09 +0100 Message-ID: <4d607d4a96a10a95a94afd4ffd7827d0c6aea7a8.1769154986.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FM5cnzWdXYbpma2IqFm8_sl2TXztzRbrcnFX0r54KCU_1769155039 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7BFNEJERU4KVNUF4L2Y7ZEKONJFG626C X-Message-ID-Hash: 7BFNEJERU4KVNUF4L2Y7ZEKONJFG626C X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1769155089888158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa When the 'backingStore' pointer is not populated the function calls 'virStorageSourceGetMetadata' to try to populate it but if the on-disk metadata doesn't have a backing image (e.g. if it's the 'base' image of the chain) the 'backingStore' pointer will still be NULL. The function then calls 'virStorageSourceIsSameLocation' but the internal functions for dealing with storage sources don't handle NULL gracefully. Since for the base image there's nothing to update we need to skip the code if there's no backing store. Closes: https://gitlab.com/libvirt/libvirt/-/issues/844 Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index e738afffc3..8f58df3b45 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -3147,7 +3147,8 @@ qemuSnapshotDiskHasBackingDisk(void *payload, if (!disk->src->backingStore) ignore_value(virStorageSourceGetMetadata(disk->src, uid, gid, = 1, false)); - if (virStorageSourceIsSameLocation(disk->src->backingStore, iterda= ta->diskSrc)) { + if (disk->src->backingStore && + virStorageSourceIsSameLocation(disk->src->backingStore, iterda= ta->diskSrc)) { struct _qemuSnapshotDisksWithBackingStoreData *data =3D g_new0(struct _qemuSnapshotDisksWithBackingStoreData, 1); --=20 2.52.0 From nobody Mon Feb 2 05:55:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1769155124; cv=none; d=zohomail.com; s=zohoarc; b=F0PZLJXPgOaKDva0KLOcNV8f/ecrzx9JaxdGK4rk4ntIuxXyAyaljoCe3qkNnKyFTd9jPnB7h8p07XRbSMsac8z1f35ilbGf9eUT/pxBGr3AjVoZbDMe7N9d/ngBht6HpYkTe+T1REgNffas0OsKi9vvp+JjMx/ndr8iqNAUvrA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769155124; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=AC7HZbVtcEiVwB0pCqrt4qkvn0/1Z1C5DhC/pwcrxy0=; b=l09q04OZ4c4QwFkCrZItNT96z8Bg3UUvTfADXDaTbS51pLIThJ6VW4sDh3Z1etQ/ggFeMk0zNoBCWcUwqkO0t7SDPEV/GK9D++/LTCrTdioONncRRhKiy1ebfA1q0kInXp4Zz5l+TaEwKG75OXXUp+Z1uXjNqwueN79p1sxPKnk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 176915512432149.375725069388864; Thu, 22 Jan 2026 23:58:44 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6D1EF419E5; Fri, 23 Jan 2026 02:58:43 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B80D441C8C; Fri, 23 Jan 2026 02:57:29 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 0E8EB4191D; Fri, 23 Jan 2026 02:57:24 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C26A03FB39 for ; Fri, 23 Jan 2026 02:57:23 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552--1C26zO5MCyW7TkzlF1bLg-1; Fri, 23 Jan 2026 02:57:21 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 98AE418909A7 for ; Fri, 23 Jan 2026 07:57:14 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D6E7F1800999 for ; Fri, 23 Jan 2026 07:57:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769155043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AC7HZbVtcEiVwB0pCqrt4qkvn0/1Z1C5DhC/pwcrxy0=; b=XhZn64l6UxBHht/MnkT1J6dVHKnX1OXGWmie0+9bCqxYcmUuzAZ6VgjS5uzizGalusRvyp vFH80CgDhkmEeVTtXuamBRjosqlPhUnm0M5Fl6xBKn4jaCzTcULjJkNyOIpG+dSaEbiAkR wEwiw+KGc+ieSNpJmRYf3vUvVSHgcyw= X-MC-Unique: -1C26zO5MCyW7TkzlF1bLg-1 X-Mimecast-MFC-AGG-ID: -1C26zO5MCyW7TkzlF1bLg_1769155041 To: devel@lists.libvirt.org Subject: [PATCH 2/2] qemuSnapshotUpdateBackingStore: Remove stale comment Date: Fri, 23 Jan 2026 08:57:10 +0100 Message-ID: <02eaa0e736c6d9e4675bebd216ff2ecbba940680.1769154986.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: T-u2VtKhVTMGfgTwEkp_0hJIEv0XrTKDnNooeoe-yRA_1769155041 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Y6FLYSKLIM6A2WXZRRGABFIY2NTZUVFJ X-Message-ID-Hash: Y6FLYSKLIM6A2WXZRRGABFIY2NTZUVFJ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1769155129931154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The code does a 'qemu-img rebase' rather than a 'qemu-img create' what the commit suggests. Since we enumerate all arguments right below, there's no need for a comment. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 8f58df3b45..19bb6f8b37 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -3710,7 +3710,6 @@ qemuSnapshotUpdateBackingStore(qemuSnapshotDeleteExte= rnalData *data) struct _qemuSnapshotDisksWithBackingStoreData *backingData =3D cur= ->data; g_autoptr(virCommand) cmd =3D NULL; - /* creates cmd line args: qemu-img create -f qcow2 -o */ if (!(cmd =3D virCommandNewArgList("qemu-img", "rebase", "-u", --=20 2.52.0