From nobody Fri Nov 21 09:59:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763614026; cv=none; d=zohomail.com; s=zohoarc; b=klCAxDTRwh67QQ73x0xtgQnhnIDef143/rl/WF/9GTfy50UBhZqvTXBgx80WJ6RxSs5dF5AcB83tlRH3CJWGV4j8Utr/CzWN4Sxq/Nx8vpB5NXt8RX0adlmefjhuA9VJtm2pmhlNTGGRcYAU3DyoZ9yr6mhb4LQBfXUwsuyBvWQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763614026; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=F19aSFFV9zRPOzE37IwfiuGQI108iF9tgTQ+dcx8/yE=; b=D4ihEeRa8b4IbgowAAHzxnRY6w/Y40vBpkHYzY2VyOd2msXKUwDmUXJLGlqNrP8rgxgyRf9qO7Ne/pZDSH2sVEV0rwxbWqgdIDee1lJFJ7BnOb6eoS2YCzepkUOkGbCjAE6GMcxDYSQOx94FYQ/zE2ps1lIzjxJ0+hNlDeVQcMo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763614026765946.596644215352; Wed, 19 Nov 2025 20:47:06 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id D123E4412A; Wed, 19 Nov 2025 23:47:05 -0500 (EST) Received: from [172.19.199.50] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 1821044169; Wed, 19 Nov 2025 23:45:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DB3BA419DD; Wed, 19 Nov 2025 23:43:42 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F120841B7C for ; Wed, 19 Nov 2025 23:43:41 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-YTrC98InNY2Oi_a_qaxSsA-1; Wed, 19 Nov 2025 23:43:40 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5BD7919560AD for ; Thu, 20 Nov 2025 04:43:39 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.37]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5FABB19540E7 for ; Thu, 20 Nov 2025 04:43:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763613821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F19aSFFV9zRPOzE37IwfiuGQI108iF9tgTQ+dcx8/yE=; b=VdDJhaUrk+gX3IR6l9vzJZJs+4fOxot20+IpHshi1HQ2yTlPnrW9mhY6BYIu0o3wq27zaS 5E1z9MSxsatLsypgViv9hVvYqqSbJGJGqqtAUlJAZ1bUsV/4HO/1y1tEbreMBsIJFoYzQV L1LYybY8QUYM4tE1qTg9igVXG60szn4= X-MC-Unique: YTrC98InNY2Oi_a_qaxSsA-1 X-Mimecast-MFC-AGG-ID: YTrC98InNY2Oi_a_qaxSsA_1763613819 To: devel@lists.libvirt.org Subject: [libvirt PATCH 1/3] qemu: drop postcopy-migration.sysctl Date: Thu, 20 Nov 2025 05:42:58 +0100 Message-ID: <52b4131e5ac30512408f71fd575a8fc26c05070a.1763613780.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EjgBZCjPVF-A0LlRnObS_q6NdnuGmzwu8b6JXHpzcqQ_1763613819 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3H4SOWSIZB5CSGARXZ55DCCJWM7IX5C3 X-Message-ID-Hash: 3H4SOWSIZB5CSGARXZ55DCCJWM7IX5C3 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763614030224019100 From: J=C3=A1n Tomko Since e2bc742fcc64da4c8370a71b65fd8c01ff3f9d41 we do not install it on RHEL nor Fedora. OpenSUSE is also new enough that it disables the installation. On Debian, sysctl files are only installed as an example. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/qemu/meson.build | 8 -------- src/qemu/postcopy-migration.sysctl | 6 ------ 2 files changed, 14 deletions(-) delete mode 100644 src/qemu/postcopy-migration.sysctl diff --git a/src/qemu/meson.build b/src/qemu/meson.build index 5cf20f426f..ff9a904277 100644 --- a/src/qemu/meson.build +++ b/src/qemu/meson.build @@ -210,14 +210,6 @@ if conf.has('WITH_QEMU') 'in_file': files('virtqemud.init.in'), } =20 - if conf.has('WITH_USERFAULTFD_SYSCTL') - install_data( - 'postcopy-migration.sysctl', - install_dir: prefix / 'lib' / 'sysctl.d', - rename: [ '60-qemu-postcopy-migration.conf' ], - ) - endif - virt_install_dirs +=3D [ confdir / 'qemu', confdir / 'qemu' / 'autostart', diff --git a/src/qemu/postcopy-migration.sysctl b/src/qemu/postcopy-migrati= on.sysctl deleted file mode 100644 index db3f11e49f..0000000000 --- a/src/qemu/postcopy-migration.sysctl +++ /dev/null @@ -1,6 +0,0 @@ -# This is needed to support post-copy migration for QEMU run by libvirt, -# i.e., unprivileged, as userfaultfd is by default only available to -# privileged processes. -# It can be safely overridden by a file in /etc/sysctl.d/ in case post-copy -# migration is not used on the host. --vm.unprivileged_userfaultfd =3D 1 --=20 2.51.1 From nobody Fri Nov 21 09:59:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763614074; cv=none; d=zohomail.com; s=zohoarc; b=dRGiuN0tEElsydLDW4SkFqQjMsxxEeunE9dyDNOsoVjjqy9o8CT3xnvmz5mS8ZdAsEj0AW2vRdozuFASvkbRIUW+VKoSXfNjjKyrBMvVs80djNl9+NJp6XiMngRoK4JIAosb2bq3fij3C9ljg/pPwqd7Og3xBy3iaGL8HKBe1Ns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763614074; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=ACXpgDJnX+M3ngAuSU4TXJuceVpYN2A4KfMnMGGLP8s=; b=exFKGrEHB9B+LRc8JLpG0CYr3ji9w8o5uoerIH0ufvLCz1WjzTClkZkh3q391kowq9q/jTrXQXvJ4O5m5jtz7JvIHI4KsoCIp9y00uD10U1phLCvcHXSMhBla0LEExnST4GTRw6AJ8H6RIoF+6WiWe9hYbITjQ21x92u/+6FT/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 176361407477386.34190986960505; Wed, 19 Nov 2025 20:47:54 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3319344146; Wed, 19 Nov 2025 23:47:54 -0500 (EST) Received: from [172.19.199.50] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 630E8441EE; Wed, 19 Nov 2025 23:46:18 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6BB1A419DD; Wed, 19 Nov 2025 23:43:44 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 886DB41B7C for ; Wed, 19 Nov 2025 23:43:43 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-y6PTHxCMMxGi162TYPaCKg-1; Wed, 19 Nov 2025 23:43:41 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C712718AB414 for ; Thu, 20 Nov 2025 04:43:40 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.37]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E20BE19540E7 for ; Thu, 20 Nov 2025 04:43:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763613823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACXpgDJnX+M3ngAuSU4TXJuceVpYN2A4KfMnMGGLP8s=; b=Ge/AYhHqwhigDhPrrjbGO1VwGBBYbs4lwScAIJhutebqouEF3Jh3A1oYr83fA5vBnhEYCa 1twaylEcFDLNnFhpFFb+6xeW5JpVMFCKjy0D+Xd0B/0R80i1UsYGIpCbC1gQ+wb2hLEDfS vHMKhFIs7j++PlaatAC3baDu039IZAU= X-MC-Unique: y6PTHxCMMxGi162TYPaCKg-1 X-Mimecast-MFC-AGG-ID: y6PTHxCMMxGi162TYPaCKg_1763613820 To: devel@lists.libvirt.org Subject: [libvirt PATCH 2/3] spec: drop with_userfaultfd_sysctl Date: Thu, 20 Nov 2025 05:42:59 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZMvx63WOJQRa7YNVYbOtc-87eK3kgRB-i9ilC2o6WN8_1763613820 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: R6FQ5EZ53Z52ZCCDUD2MQ5B64WE56BTH X-Message-ID-Hash: R6FQ5EZ53Z52ZCCDUD2MQ5B64WE56BTH X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763614076681018900 From: J=C3=A1n Tomko It has no effect anymore. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- libvirt.spec.in | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 79738bd7bb..8314fbeb34 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -91,7 +91,6 @@ =20 # Other optional features %define with_numactl 0%{!?_without_numactl:1} -%define with_userfaultfd_sysctl 0%{!?_without_userfaultfd_sysctl:1} =20 # A few optional bits off by default, we enable later %define with_fuse 0 @@ -259,12 +258,6 @@ %define enable_werror -Dwerror=3Dfalse -Dgit_werror=3Ddisabled %endif =20 -# Fedora and RHEL-9 are new enough to support /dev/userfaultfd, which -# does not require enabling vm.unprivileged_userfaultfd sysctl. -%if 0%{?fedora} || 0%{?rhel} - %define with_userfaultfd_sysctl 0 -%endif - %define tls_priority "@LIBVIRT,SYSTEM" =20 # libvirt 8.1.0 stops distributing any sysconfig files. @@ -1329,12 +1322,6 @@ exit 1 %define arg_remote_mode -Dremote_default_mode=3Dlegacy %endif =20 -%if %{with_userfaultfd_sysctl} - %define arg_userfaultfd_sysctl -Duserfaultfd_sysctl=3Denabled -%else - %define arg_userfaultfd_sysctl -Duserfaultfd_sysctl=3Ddisabled -%endif - %define when %(date +"%%F-%%T") %define where %(hostname) %define who %{?packager}%{!?packager:Unknown} @@ -1418,7 +1405,6 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Dqemu_datadir=3D%{qemu_datadir} \ -Dtls_priority=3D%{tls_priority} \ -Dsysctl_config=3Denabled \ - %{?arg_userfaultfd_sysctl} \ -Dssh_proxy=3Denabled \ %{?enable_werror} \ -Dexpensive_tests=3Denabled \ @@ -1506,7 +1492,6 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Dstorage_vstorage=3Ddisabled \ -Dstorage_zfs=3Ddisabled \ -Dsysctl_config=3Ddisabled \ - -Duserfaultfd_sysctl=3Ddisabled \ -Dssh_proxy=3Ddisabled \ -Dtests=3Ddisabled \ -Dudev=3Ddisabled \ @@ -2314,9 +2299,6 @@ exit 0 %if %{with_qemu} %files daemon-driver-qemu %config(noreplace) %{_sysconfdir}/libvirt/virtqemud.conf - %if %{with_userfaultfd_sysctl} -%config(noreplace) %{_prefix}/lib/sysctl.d/60-qemu-postcopy-migration.conf - %endif %{_datadir}/augeas/lenses/virtqemud.aug %{_datadir}/augeas/lenses/tests/test_virtqemud.aug %{_unitdir}/virtqemud.service --=20 2.51.1 From nobody Fri Nov 21 09:59:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763614119; cv=none; d=zohomail.com; s=zohoarc; b=T4AGnIbOQpPKSQNjz61nKWdA0PRh+RV0rz6LNrhMpPmBlNpvoHTEQfMbZK+T186cv0+Xcc8/K6XIMCax2NwwZ8SgNLuUp3XF4RjgLqi54cqpitWLQVk+CLli/TkUSegybqILmloS8lCAfMTgR0A9E7PZzCBc7lY6ZT3pDBH5g0w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763614119; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=nT+RFj+QzRiXnmCDrBTU1fVR4Ud1k1KQXGMWYjY8Uyc=; b=WD38PJOTX7bIz9NKIOBYBQT3EWExUoevA6aRoKnkdzail5UqM0kYv5cF6Y/DiqEowUx0PnhOK6zoeU+7wJIRd7Dytc9oSJrdzJsW/I6+FpkperLCihjsxWeADzxGTB777GlvWsHvMvmINSi3IvELeC+0xsuUPltqH8gqsjeaXzQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763614119770404.0389183735074; Wed, 19 Nov 2025 20:48:39 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3EBAC3F872; Wed, 19 Nov 2025 23:48:39 -0500 (EST) Received: from [172.19.199.50] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 597B341BB6; Wed, 19 Nov 2025 23:46:25 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6199644003; Wed, 19 Nov 2025 23:43:45 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9F6D7419DD for ; Wed, 19 Nov 2025 23:43:44 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-aTtIV7RnOUmMpnowgNjY2Q-1; Wed, 19 Nov 2025 23:43:43 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5425A180034F for ; Thu, 20 Nov 2025 04:43:42 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.37]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 69E9C19540E8 for ; Thu, 20 Nov 2025 04:43:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763613824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nT+RFj+QzRiXnmCDrBTU1fVR4Ud1k1KQXGMWYjY8Uyc=; b=L/J1F+w7bUkLUXQH0YIOVUqbE0bUOVOQ1VCLLHzp2xkT0f0I9BLxKDGPpnOhE3W/LmUdOO oxPc4nz93VgxPZLVaisjmMsXxFdX/mTIqWZBbhVNLASZM4vaKioYR9FG1SB9CFVzburSj1 fom4P3bPurM2Vcwxr5SjuEJqZAN6SiM= X-MC-Unique: aTtIV7RnOUmMpnowgNjY2Q-1 X-Mimecast-MFC-AGG-ID: aTtIV7RnOUmMpnowgNjY2Q_1763613822 To: devel@lists.libvirt.org Subject: [libvirt PATCH 3/3] build: drop userfaultfd_sysctl option Date: Thu, 20 Nov 2025 05:43:00 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Wlz9jOlQa0Qs-BocBUqYtRX78QQSWOwrIhgDAGUwFJg_1763613822 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JWAEG6KPCFRWETV2UNYHBQ52QLUNAJNE X-Message-ID-Hash: JWAEG6KPCFRWETV2UNYHBQ52QLUNAJNE X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763614120632018900 From: J=C3=A1n Tomko It has no effect anymore. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- meson.build | 7 ------- meson_options.txt | 2 -- 2 files changed, 9 deletions(-) diff --git a/meson.build b/meson.build index c1871de64c..6ac9d01952 100644 --- a/meson.build +++ b/meson.build @@ -2029,12 +2029,6 @@ elif get_option('sysctl_config').enabled() error('sysctl configuration is supported only on linux') endif =20 -if not get_option('userfaultfd_sysctl').disabled() and conf.has('WITH_SYSC= TL') - conf.set('WITH_USERFAULTFD_SYSCTL', 1) -elif get_option('userfaultfd_sysctl').enabled() - error('userfaultfd_sysctl option requires sysctl_config to be enabled') -endif - prio =3D get_option('tls_priority') if prio =3D=3D 'auto' # If local OS has 'crypto-policies' then default to that @@ -2345,7 +2339,6 @@ misc_summary =3D { 'sysctl config': conf.has('WITH_SYSCTL'), 'tests': tests_enabled, 'TLS priority': conf.get_unquoted('TLS_PRIORITY'), - 'userfaultfd sysctl': conf.has('WITH_USERFAULTFD_SYSCTL'), 'virt-host-validate': conf.has('WITH_HOST_VALIDATE'), 'virt-login-shell': conf.has('WITH_LOGIN_SHELL'), 'Warning Flags': supported_cc_flags, diff --git a/meson_options.txt b/meson_options.txt index 8b6b26dfc6..e12ace4e11 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -132,6 +132,4 @@ option('nbdkit_config_default', type: 'feature', value:= 'auto', description: 'Wh option('pm_utils', type: 'feature', value: 'auto', description: 'use pm-ut= ils for power management') option('ssh_proxy', type: 'feature', value: 'auto', description: 'Build ss= h-proxy for ssh over vsock') option('sysctl_config', type: 'feature', value: 'auto', description: 'Whet= her to install sysctl configs') -# dep:sysctl_config -option('userfaultfd_sysctl', type: 'feature', value: 'auto', description: = 'Whether to install sysctl config for enabling unprivileged userfaultfd') option('tls_priority', type: 'string', value: 'auto', description: 'set th= e default TLS session priority string') --=20 2.51.1