From nobody Sun Oct 5 00:06:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=smartx.com ARC-Seal: i=1; a=rsa-sha256; t=1758274656; cv=none; d=zohomail.com; s=zohoarc; b=jLVdcRLWlf8PBVmTUgHyoesoVd82Hdeeoq+YzJp20kMZcG2meG8Mj3dWaUkQ1GUI3c5iCSLC9H5/k7TKkJXDiWmXNnDZThSaABfURX7EDzz3YEteJ+7d0Plw7aIddWlTu/V7wvOvRuPrhbN48GPEalkKMg87E9nAJhDgUFU17zA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758274656; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=wwJRb//gGDt/CwrQzan/HT85aY8N00rOHxM+/uv7uvY=; b=P6umUzghjGlBrghewOBJNfFMn0Ie9RHGh9ceMWOU4R29re0PynTVVkHnq6YHdHaW0qZ3rd3JI0k3JMag1uGrbGHYTux2b3D5UCz1KywVLJugiX77O2L5f0YS8es7QqQbHYbhLzX71QVq1VBnqgAdskJKVEghAB2o3pcB1quUTMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1758274656481116.45869379364296; Fri, 19 Sep 2025 02:37:36 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 80A4741A28; Fri, 19 Sep 2025 05:37:35 -0400 (EDT) Received: from [172.19.199.10] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id EA15241AD6; Fri, 19 Sep 2025 05:36:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1A80C3FD25; Fri, 19 Sep 2025 05:32:13 -0400 (EDT) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 285633F936 for ; Fri, 19 Sep 2025 05:32:12 -0400 (EDT) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-24458272c00so20905725ad.3 for ; Fri, 19 Sep 2025 02:32:12 -0700 (PDT) Received: from Hyman-Dev-Euler.zelin.local ([193.246.161.124]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33046a4d0basm6513063a91.27.2025.09.19.02.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Sep 2025 02:32:10 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1758274331; x=1758879131; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wwJRb//gGDt/CwrQzan/HT85aY8N00rOHxM+/uv7uvY=; b=gJUqGOXFaYQN+BoczF2kCnBX2O5HNpRKlhy88/n0wE320B3+q+X9z6HMnJoaftF1wx aGyuoi3xZl+iov34XA6gCSLp9fSFndTww1lW8T5v1MiRiwv08/p5pM301oulswvFIkPG HnX8nn44ayo7hLIC4rrZlt6TjLT/2Ya4D3GALNbdHZsqm0V/1dCt75Zam479PDK1ci8/ kqllvdbd7qGw/nEmXjN7oDMVE29i8+9yVUs6Y5tUIiByWAwMBdKua0m5QaIGNQo2ouiG 0b0/WteoyrkmiiXfKOIC7zbbVczpzJDfSK4pg2UMDYRQwlSdGn6GkxDof4Y6GvvJLTYX l4HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758274331; x=1758879131; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wwJRb//gGDt/CwrQzan/HT85aY8N00rOHxM+/uv7uvY=; b=NECwmn6coyoRt47IXOl3DE4Yhu+p5b18LYUUM6fCj0MQX+jAUyabRvLznFFLhZcqLv xAsDMt0M7rbJbeIjWelyfo4LdUm9A7qVVn9VXXe2X5KL1h2p+ei5oWZmAvB1Z1OHTvPO upxb3lOTi0Q3Zt0wtQYSI+ao4KmyKObBe5mgu40TbrCE72K8u9rrQk6hZeH2ojJHkk+F QoW1M8IKkaVOyS1JW1Kqd4TGGQUy293wfo+JBeuCaar7r8OhGfLNxwKEhssCoTNDTxCJ VhXms2oqlNTCqifrQxGIn2TSql4EK9rcZo0qBK+Bd8//ukgYElfiL0Thp0WOff/oKUTG yBJQ== X-Gm-Message-State: AOJu0Ywt7+NgkBm8nx65tCvv+7j6GjJiKIh543PWB8U/amjcc5USz4CB M/GLByKAnqQiwXm8ctGqA7HigJs0AYcrNB8J1P0Zmi0KIZYSt+OVb0n7WCk90f4kXDU1iwMC3B6 18kWe4151BA== X-Gm-Gg: ASbGncsFBtKys1Ocw/Ys9QvCcUlPAyEph2Lkb3zml3OgrIamERSNs+esBQsWWKGrJDo O02SdUu7oc2zPcsClpr4dmNQ1zEQh1Tr9XnuZFnjvcdVWChBlkMLo31JMlKktM6zX3fFBr9/icG wR8EAdrpjRx8ESUXi5yQ35frsKXlcZlxLW3cA9Vjwj4h4tncZp5aFuJZ6/YGZBn7jRFcdnMdI84 8bm9ispslF2cGpJGbO0y0gbNMI6SI2OoSpEXyKv5BMH4Q/lYiyJsnPb0q8IAPStilJQRrJzz72u PaSI8qZ2qZe8ygu0HVOnHA2eCHjRDZuF6+I+myXyCCoy668+TByuS5cKQzc4NAaE6v21MVuMSBV HSlJ3J/89WFW2pa8iIqc7uo5c9m0f4BMZGKw10+dwzyWd2Xfqx3L3uCnm2Rsl0A== X-Google-Smtp-Source: AGHT+IGnMI2T8sni2FmVL0V6AYduQVYNhonBtIWLUYW0ajzUpBduRkePsy5fDFVYOW5h0jo7gOhhsg== X-Received: by 2002:a17:902:ecd1:b0:269:6052:3536 with SMTP id d9443c01a7336-269ba5347camr37077455ad.45.1758274330383; Fri, 19 Sep 2025 02:32:10 -0700 (PDT) From: yong.huang@smartx.com To: devel@lists.libvirt.org Subject: [PATCH 1/1] domain_conf: Do not omit private data when formatting the status XML Date: Fri, 19 Sep 2025 17:09:08 +0800 Message-Id: <10fa127f470d70496424ae656ea6b27da7605acd.1758272260.git.yong.huang@smartx.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: R4FKABK7X2L2RHZYIG27FMP4MZAYPSGZ X-Message-ID-Hash: R4FKABK7X2L2RHZYIG27FMP4MZAYPSGZ X-MailFrom: yong.huang@smartx.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: yong.huang@smartx.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @smartx-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1758274657026116600 Content-Type: text/plain; charset="utf-8" From: Hyman Huang Add a thorough check in the virDomainObjSave path to make sure that private data in the status XML file always exists for the running VM so that we won't lose them after restart the service. --- src/conf/domain_conf.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 281846dfbe..74af08e584 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -29542,9 +29542,24 @@ virDomainObjFormat(virDomainObj *obj, obj->deprecations[i]); } =20 - if (xmlopt->privateData.format && - xmlopt->privateData.format(&buf, obj) < 0) - return NULL; + if (xmlopt->privateData.format) { + if (xmlopt->privateData.format(&buf, obj) < 0) + return NULL; + } else { + /* + * Add a thorough check in the virDomainObjSave path to make + * sure that private data in the status XML file always exists + * for the running VM so that we won't lose them after restart + * the service. + */ + if (virDomainObjIsActive(obj) && + (obj->def->virtType =3D=3D VIR_DOMAIN_VIRT_KVM)) { + VIR_WARN("Do not omit private data when formatting the" + " status XML for a %s VM", + virDomainStateTypeToString(state)); + return NULL; + } + } =20 if (virDomainDefFormatInternal(obj->def, xmlopt, &buf, flags) < 0) return NULL; --=20 2.27.0