From nobody Sun Oct 5 00:06:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757663455; cv=none; d=zohomail.com; s=zohoarc; b=Vx21AYITa1yru87MtDhmENR8rfM7IJ+M8HeQiaz5X0VJ/ziKlXgjAfQaX2TgvMPG8kH/XK81yOu7MHkSI6KTGQ/HqUPBZJhn2p7iurYEOdW97cggWL/R6Nn8OrApNtoaNEc5jgslNcGRxb2CYB543AcRXzc36W+NJU+Knk4vLZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757663455; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=pLkQfiY5eraOEvVTD3br+JcAbPUvnEWSw0XTNzS05gU=; b=ThSwTX/ZBcvW4AJy0e/f1g9YTnsaskgR7juBZMvx09sXwMA/t4Qq8eyktz8/S1+6gLlBUTlZuK2x9vpig8ECXVSLkwijZKZhz4AbqkUqfF0vH6oh8TcH9s8RZmxGp+OIz3ErEJRd59uUh2F0O238MAa7YAt35t32Hv8m4Ak+Zns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757663455330101.26008170576029; Fri, 12 Sep 2025 00:50:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 305B043EB7; Fri, 12 Sep 2025 03:50:53 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id A121543DC2; Fri, 12 Sep 2025 03:50:03 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0838741B1E; Fri, 12 Sep 2025 03:49:51 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E27044199A for ; Fri, 12 Sep 2025 03:49:50 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-ZEqK-hk9PMO3_1tSU5lcLw-1; Fri, 12 Sep 2025 03:49:49 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 671C7180034D for ; Fri, 12 Sep 2025 07:49:48 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B79061800452 for ; Fri, 12 Sep 2025 07:49:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757663390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLkQfiY5eraOEvVTD3br+JcAbPUvnEWSw0XTNzS05gU=; b=d6EPGi0EGR1HsFs091ebN8/gS7GA1tJmPW2FyxsaSMaT5/V+e8ggfR/2sEHzAUjbvEQeAg LN6T03Q63Xr3GNjaV/NH0NEW5+2NVVswLQJ48xioVSzqk2BNy867swHj+zyQeN0pgoBcri s8MHmZCzr2FHgPsAXNwF3vd7/0h4DkM= X-MC-Unique: ZEqK-hk9PMO3_1tSU5lcLw-1 X-Mimecast-MFC-AGG-ID: ZEqK-hk9PMO3_1tSU5lcLw_1757663388 To: devel@lists.libvirt.org Subject: [PATCH 1/5] ch: Emit event on device attach Date: Fri, 12 Sep 2025 09:49:37 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZVTeXrTVxV6MX78C5EUzDuXQdK96eZBZ1yPGfIcpm9o_1757663388 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RCXU32AG7ABYKEQR4UDKAKBLWTWMIEI7 X-Message-ID-Hash: RCXU32AG7ABYKEQR4UDKAKBLWTWMIEI7 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757663458427116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik When a device is attached to a running guest we ought to emit the VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/ch/ch_hotplug.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/ch/ch_hotplug.c b/src/ch/ch_hotplug.c index 0a55a57069..e7734e2ff0 100644 --- a/src/ch/ch_hotplug.c +++ b/src/ch/ch_hotplug.c @@ -52,23 +52,26 @@ chDomainAddDisk(virCHMonitor *mon, } =20 static int -chDomainAttachDeviceLive(virDomainObj *vm, +chDomainAttachDeviceLive(virCHDriver *driver, + virDomainObj *vm, virDomainDeviceDef *dev) { int ret =3D -1; virCHDomainObjPrivate *priv =3D vm->privateData; virCHMonitor *mon =3D priv->monitor; + const char *alias =3D NULL; =20 switch (dev->type) { - case VIR_DOMAIN_DEVICE_DISK: { + case VIR_DOMAIN_DEVICE_DISK: if (chDomainAddDisk(mon, vm, dev->data.disk) < 0) { break; } =20 + alias =3D dev->data.disk->info.alias; dev->data.disk =3D NULL; ret =3D 0; break; - } + case VIR_DOMAIN_DEVICE_NET: case VIR_DOMAIN_DEVICE_LEASE: case VIR_DOMAIN_DEVICE_FS: @@ -104,6 +107,13 @@ chDomainAttachDeviceLive(virDomainObj *vm, break; } =20 + if (alias) { + virObjectEvent *event; + + event =3D virDomainEventDeviceAddedNewFromObj(vm, alias); + virObjectEventStateQueue(driver->domainEventState, event); + } + return ret; } =20 @@ -148,7 +158,7 @@ chDomainAttachDeviceLiveAndUpdateConfig(virDomainObj *v= m, return -1; } =20 - if (chDomainAttachDeviceLive(vm, devLive) < 0) { + if (chDomainAttachDeviceLive(driver, vm, devLive) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Failed to add device")); return -1; --=20 2.49.1 From nobody Sun Oct 5 00:06:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757663510; cv=none; d=zohomail.com; s=zohoarc; b=Ek8uXD0O7aAWOpkZGlLIFqI7b9ZqTfpEmkmzomCIUSUSHYlJ+d6+B/RD5e8Fo8h6P2cHkp/NLV18OHagX27c1N39Zwbm/s19kesxr739LZmMvF2fdaCfx+eKaU0WtSE5y4VK37m4g1fJZA1/3GlHYhhNdFg0/YVb1Fe5qNkDjTU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757663510; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Eb483r59BILbeAvyyFJ/6M8xUyoipn1M4OR9Km0zIB4=; b=IR+JshWOmdvUrHeYUisq5nBqPlXT6ZS0LTPRoDEIAIY+TJyIxR1ON+IoMNJ6qtPgxe4H7gLO2kslT9e0vfRGshLejIWVeYB1JY6K9IL5+6ejgZ+o8+NyUeayaihhZcLvtUNHL7gUlA+wGUhzUWcdfNkLc/QKmp7ifNZ74SCjH1g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757663510211947.608362980858; Fri, 12 Sep 2025 00:51:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2871041CAC; Fri, 12 Sep 2025 03:51:49 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 662DB41BB1; Fri, 12 Sep 2025 03:50:11 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DBF7C41B1E; Fri, 12 Sep 2025 03:49:52 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 04CC541B1C for ; Fri, 12 Sep 2025 03:49:51 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-8WBiijdBNxyf5sxYqUYhTw-1; Fri, 12 Sep 2025 03:49:50 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 886CC1800451 for ; Fri, 12 Sep 2025 07:49:49 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D7340180035E for ; Fri, 12 Sep 2025 07:49:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757663391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eb483r59BILbeAvyyFJ/6M8xUyoipn1M4OR9Km0zIB4=; b=Phr3PO+ShDkrfpD+leCriYtyuKQ30Jw8lakhmm65PM/+SnsbNXc8dAaFhmuKtjwOVp14JJ C0PZPCUHElqUe1cCkRnUp9zBpUzSXGydLy4WyfMHsrXPT2Fx9/9I0Nz/2CnlIaf5LlZJqq rvwTc7A1mDc320s9HN5mfrl2kXVZz20= X-MC-Unique: 8WBiijdBNxyf5sxYqUYhTw-1 X-Mimecast-MFC-AGG-ID: 8WBiijdBNxyf5sxYqUYhTw_1757663389 To: devel@lists.libvirt.org Subject: [PATCH 2/5] ch: Emit event on device attach Date: Fri, 12 Sep 2025 09:49:38 +0200 Message-ID: <6bc0027364efc44b25bb0838c3571f89e497f38b.1757663360.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Uy3h-O8qjO5r3cxDclH9_tfYYzLfrZXxU3I4Kstocw4_1757663389 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UMG5MB74IKCA6GBWFW2WC4PEKF3CAMF4 X-Message-ID-Hash: UMG5MB74IKCA6GBWFW2WC4PEKF3CAMF4 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757663511309116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik When a device is detached from a running guest we ought to emit the VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/ch/ch_hotplug.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_hotplug.c b/src/ch/ch_hotplug.c index e7734e2ff0..b953fe4c6c 100644 --- a/src/ch/ch_hotplug.c +++ b/src/ch/ch_hotplug.c @@ -267,12 +267,15 @@ chDomainRemoveDevice(virDomainObj *vm, =20 =20 static int -chDomainDetachDeviceLive(virDomainObj *vm, +chDomainDetachDeviceLive(virCHDriver *driver, + virDomainObj *vm, virDomainDeviceDef *match) { virDomainDeviceDef detach =3D { .type =3D match->type }; virDomainDeviceInfo *info =3D NULL; virCHDomainObjPrivate *priv =3D vm->privateData; + virObjectEvent *event =3D NULL; + g_autofree char *alias =3D NULL; =20 switch (match->type) { case VIR_DOMAIN_DEVICE_DISK: @@ -339,6 +342,11 @@ chDomainDetachDeviceLive(virDomainObj *vm, return -1; } =20 + /* Save the alias to use when sending a DEVICE_REMOVED event after all + * other tear down is complete. + */ + alias =3D g_strdup(info->alias); + if (virCHMonitorRemoveDevice(priv->monitor, info->alias) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Invalid response from CH. Disk removal failed.")= ); @@ -348,6 +356,9 @@ chDomainDetachDeviceLive(virDomainObj *vm, if (chDomainRemoveDevice(vm, &detach) < 0) return -1; =20 + event =3D virDomainEventDeviceRemovedNewFromObj(vm, alias); + virObjectEventStateQueue(driver->domainEventState, event); + return 0; } =20 @@ -386,7 +397,7 @@ chDomainDetachDeviceLiveAndUpdateConfig(virCHDriver *dr= iver, return -1; } =20 - if (chDomainDetachDeviceLive(vm, dev_live) < 0) { + if (chDomainDetachDeviceLive(driver, vm, dev_live) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could detach device")); return -1; --=20 2.49.1 From nobody Sun Oct 5 00:06:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757663620; cv=none; d=zohomail.com; s=zohoarc; b=Qa/77Twe1ZDGS8m4FFN/nDtI7yJ+jqPNH0SVs2Lyzzo2+jjIsz3R69yi0CNdzEcFlmQMtk2IlHa3NAXr7aZIHwqKYZZM6oBml9RI7WROLrQWo7beXBViAhAGNbeuY6Nj0OXEia1DjLSbBCr333JypxowXSwDC44smheFk+/wYfs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757663620; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=rZC/UYaBUYdVx3Q7HzJoucU8h/Koxjn0RAipVz8/veo=; b=nYGCNuZPbwv40UmL+EDZq1ogFWdPTBm6OJfjdpyrjgjYYzkrjCfL1ZA0MaZxPlgRDpp0XxmkJZ6+nmDdcXbklKKhis2yadbnIwkxrY1+J9xBM/WM70Ir0fRmcrB1h13I+P2vHDvqoL2H3d80D9zfjyHvuaq2jMSVqfzjkq5ANJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757663620801575.0917400084692; Fri, 12 Sep 2025 00:53:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C0C3441B8C; Fri, 12 Sep 2025 03:53:39 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 88F1443E80; Fri, 12 Sep 2025 03:50:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id EA2E941B26; Fri, 12 Sep 2025 03:49:54 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D5E004199A for ; Fri, 12 Sep 2025 03:49:53 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-mWF5bTObOt-2UHKXcKzeCg-1; Fri, 12 Sep 2025 03:49:51 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C14941944F0C for ; Fri, 12 Sep 2025 07:49:50 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F03B11800452 for ; Fri, 12 Sep 2025 07:49:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757663393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rZC/UYaBUYdVx3Q7HzJoucU8h/Koxjn0RAipVz8/veo=; b=Ia5+vknftDNMJLTjzlRhhaCsDNrzb1zHSPJQu/813vk/YfulkczC+TBQxBgIoXtXCp7ojL ImYRESbAVg/0wbLIYRWfA6Xeiu/a1CgpagcqGpO22VnqM9PbpsZBsKHNEDOf4ddvEnt3Q9 O01puLuHH5yNKx8moEhKt/Qbl51hPf4= X-MC-Unique: mWF5bTObOt-2UHKXcKzeCg-1 X-Mimecast-MFC-AGG-ID: mWF5bTObOt-2UHKXcKzeCg_1757663390 To: devel@lists.libvirt.org Subject: [PATCH 3/5] ch: Propagate lifecycle events Date: Fri, 12 Sep 2025 09:49:39 +0200 Message-ID: <2698b6785ce7f3ba0111b23eba8116845826b0b3.1757663360.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hxN0_di2snxPbBMjRwdCheVTbl5YKo1ADHXVQ3FhISc_1757663390 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CIVHQPK3UQ6YITRWJ7BAJW6YWDCICO3K X-Message-ID-Hash: CIVHQPK3UQ6YITRWJ7BAJW6YWDCICO3K X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757663622299116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik We already have a thread that listens on cloud-hypervisor's monitor for incoming events and processes them. What is missing though, is emitting of corresponding lifecycle events. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/ch/ch_events.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/src/ch/ch_events.c b/src/ch/ch_events.c index cd2f92a493..5125f26912 100644 --- a/src/ch/ch_events.c +++ b/src/ch/ch_events.c @@ -25,6 +25,7 @@ #include "ch_domain.h" #include "ch_events.h" #include "ch_process.h" +#include "domain_event.h" #include "virfile.h" #include "virlog.h" =20 @@ -65,6 +66,58 @@ virCHEventStopProcess(virDomainObj *vm, return 0; } =20 + +static void +virCHProcessEmitEvent(virDomainObj *vm, + virCHEvent ev) +{ + virCHDriver *driver =3D CH_DOMAIN_PRIVATE(vm)->driver; + virObjectEvent *event =3D NULL; + + switch (ev) { + case VIR_CH_EVENT_VM_BOOTED: + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_STARTED, + VIR_DOMAIN_EVENT_STARTED= _BOOTED); + break; + case VIR_CH_EVENT_VM_PAUSED: + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_SUSPEND= ED, + VIR_DOMAIN_EVENT_SUSPEND= ED_PAUSED); + break; + case VIR_CH_EVENT_VM_RESUMED: + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_RESUMED, + VIR_DOMAIN_EVENT_RESUMED= _UNPAUSED); + break; + case VIR_CH_EVENT_VM_REBOOTED: + event =3D virDomainEventRebootNewFromObj(vm); + break; + case VIR_CH_EVENT_VMM_SHUTDOWN: + case VIR_CH_EVENT_VM_SHUTDOWN: + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_SHUTDOW= N, + VIR_DOMAIN_EVENT_SHUTDOW= N_FINISHED); + break; + case VIR_CH_EVENT_VMM_STARTING: + case VIR_CH_EVENT_VM_BOOTING: + case VIR_CH_EVENT_VM_REBOOTING: + case VIR_CH_EVENT_VM_DELETED: + case VIR_CH_EVENT_VM_PAUSING: + case VIR_CH_EVENT_VM_RESUMING: + case VIR_CH_EVENT_VM_SNAPSHOTTING: + case VIR_CH_EVENT_VM_SNAPSHOTTED: + case VIR_CH_EVENT_VM_RESTORING: + case VIR_CH_EVENT_VM_RESTORED: + case VIR_CH_EVENT_LAST: + default: + break; + } + + virObjectEventStateQueue(driver->domainEventState, event); +} + + static int virCHProcessEvent(virCHMonitor *mon, virJSONValue *eventJSON) @@ -91,6 +144,8 @@ virCHProcessEvent(virCHMonitor *mon, ev =3D virCHEventTypeFromString(full_event); VIR_DEBUG("%s: Source: %s, Event: %s, ev: %d", vm->def->name, source, = event, ev); =20 + virCHProcessEmitEvent(vm, ev); + switch (ev) { case VIR_CH_EVENT_VMM_STARTING: case VIR_CH_EVENT_VM_BOOTING: --=20 2.49.1 From nobody Sun Oct 5 00:06:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757663703; cv=none; d=zohomail.com; s=zohoarc; b=cdctxPa+WFl0Bssm+st26qCSdJdB0zxO3jOzecGl3s9HLXHd3I4WWCXutQn9Qo8FVAP+mFX71WjkLdJz310nuAXkTg/j+zN/eCC8z/jx/YbANvsclWmkUnAqySjU8ScoGJId+tgHpCpyahABJ1fcuqNWrGFxLOivVNELlYJNoKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757663703; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=CDG9+3XnLyK/WFJiqOGmlG0UgObqmfaJdgvkf4FcEsg=; b=l7XziFb4Stelv77/+kFChb7/a4ZuNP4ZQIEoVjW6CBPGk0Drc8/rNw+cKpTGrwMgXIu1vo+6BqyWFLJrQDXF6quj8vHl+Eb1Bzst5ZbzEd3A+SuBqabnlvl5TmbextUYnDYoJqb5Gmwj6jw/X7GLwaUDpS6wPSjNNfgU6Oz9Kv8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757663703037776.8126706779863; Fri, 12 Sep 2025 00:55:03 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id EEE4941BB6; Fri, 12 Sep 2025 03:55:01 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 15AAD41B78; Fri, 12 Sep 2025 03:50:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3D2F74199A; Fri, 12 Sep 2025 03:49:55 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3D23D41B1C for ; Fri, 12 Sep 2025 03:49:54 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-BbgTJioQOz6nH4xH_3hWPw-1; Fri, 12 Sep 2025 03:49:52 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B8D4C180028D for ; Fri, 12 Sep 2025 07:49:51 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 13FA318004D8 for ; Fri, 12 Sep 2025 07:49:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757663393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CDG9+3XnLyK/WFJiqOGmlG0UgObqmfaJdgvkf4FcEsg=; b=TLb/XFs5PSzYmk0dHP/ATuX3zzFdZQU8szkm3rkm0IGW9YAJtAX9KPK2nxbUq7F48T8C97 Kwtg3kTSIPTEdWIKk5+8TCtUeP8Jx6xVwHXOa94tQLMT3VcBtGBTCqxZwoyVileXwA7sbz PFoKyAhQPi9DYauBazJxeey3RsHHiCY= X-MC-Unique: BbgTJioQOz6nH4xH_3hWPw-1 X-Mimecast-MFC-AGG-ID: BbgTJioQOz6nH4xH_3hWPw_1757663391 To: devel@lists.libvirt.org Subject: [PATCH 4/5] ch: Implement virConnectDomainEventRegister() Date: Fri, 12 Sep 2025 09:49:40 +0200 Message-ID: <81727c910762e605eee5b05ab84526463e5dbc93.1757663360.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gIxhMRbYcD_VMcQpaWqtEJ_l2qKv2Ylw6t9hAo586Z8_1757663391 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HGJWQ5WKLQV6OR6DLS2NLPAEHVSQAMKH X-Message-ID-Hash: HGJWQ5WKLQV6OR6DLS2NLPAEHVSQAMKH X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757663705466116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/ch/ch_driver.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 0a516f3384..d16e2ed3aa 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -2434,6 +2434,27 @@ static int chDomainDetachDevice(virDomainPtr dom, co= nst char *xml) VIR_DOMAIN_AFFECT_LIVE); } =20 + +static int +chConnectDomainEventRegister(virConnectPtr conn, + virConnectDomainEventCallback callback, + void *opaque, + virFreeCallback freecb) +{ + virCHDriver *driver =3D conn->privateData; + + if (virConnectDomainEventRegisterEnsureACL(conn) < 0) + return -1; + + if (virDomainEventStateRegister(conn, + driver->domainEventState, + callback, opaque, freecb) < 0) + return -1; + + return 0; +} + + /* Function Tables */ static virHypervisorDriver chHypervisorDriver =3D { .name =3D "CH", @@ -2499,6 +2520,7 @@ static virHypervisorDriver chHypervisorDriver =3D { .domainAttachDeviceFlags =3D chDomainAttachDeviceFlags, /* 11.8.0 */ .domainDetachDevice =3D chDomainDetachDevice, /* 11.8.0 */ .domainDetachDeviceFlags =3D chDomainDetachDeviceFlags, /* 11.8.0 */ + .connectDomainEventRegister =3D chConnectDomainEventRegister, /* 11.8.= 0 */ }; =20 static virConnectDriver chConnectDriver =3D { --=20 2.49.1 From nobody Sun Oct 5 00:06:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757663780; cv=none; d=zohomail.com; s=zohoarc; b=mgGawjYInoW2k+W6pHraAriApFZKBsiNe/fO4OAwtkehBboQnPEEiOcyPl5f4HxEFLkxJtnbB7vATawwVJNSY+BwYauMLtH+JWvc9AbhsUx/qPrkkRbDMrAkR5vVfYhXvO3cD5FerELPHhM0RKAn63lUlry5zEOQwKgS7N3nN48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757663780; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=odnusWOw2A0hFYze8SFn/1k+X36nIEpw2hjGM87Kmw4=; b=gLBIaLcYjiVr1ArZloeITifa9Vvc9Kwc/oYukh2PzNeESpsT7RjubM/GjDvpI6vzYHBLANBBS/WKLizyY3asdn10t5SZoFBPXS2ltV/NLX6ZXVW3pEHj40JswmMlMBiCQ4BU1eIM00vTmhrlgug1mb92SAIoKskgFMUT7rzWw1Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757663780730184.18578698855742; Fri, 12 Sep 2025 00:56:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D319F41A7E; Fri, 12 Sep 2025 03:56:19 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 57C4B43EEA; Fri, 12 Sep 2025 03:50:38 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id AD02543DD5; Fri, 12 Sep 2025 03:50:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 63BD341B58 for ; Fri, 12 Sep 2025 03:49:56 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-ap4Qx4fVMXCeRS3wzaRDMg-1; Fri, 12 Sep 2025 03:49:53 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFE471800366 for ; Fri, 12 Sep 2025 07:49:52 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2BA7B180035E for ; Fri, 12 Sep 2025 07:49:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757663396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odnusWOw2A0hFYze8SFn/1k+X36nIEpw2hjGM87Kmw4=; b=XrrElm8YXRYq/FlCufUSwAgyWyjMMTB7A+AXFMXF8XKKfELlnGTNQKLze5lncwLvSxomPd ciLqXNakEVFvWhHEI5WKQ0UL7pgnIg45CtfpwExHp9oe2JEO8e6lHCHRKHz9zLhj8kprhv TfpZrv6HaUWQB2+6sI6fdE2g1QS/O4M= X-MC-Unique: ap4Qx4fVMXCeRS3wzaRDMg-1 X-Mimecast-MFC-AGG-ID: ap4Qx4fVMXCeRS3wzaRDMg_1757663392 To: devel@lists.libvirt.org Subject: [PATCH 5/5] ch: Implement virConnectDomainEventDeregister() Date: Fri, 12 Sep 2025 09:49:41 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TiHdrJbAkOzZ3mGvoM8QEtJH1ml_a0x32eING9utLdc_1757663392 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MRKEQJ4IQANQ6SZ26Y7CIN5VBLWXN7TH X-Message-ID-Hash: MRKEQJ4IQANQ6SZ26Y7CIN5VBLWXN7TH X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757663782198116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/ch/ch_driver.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index d16e2ed3aa..ad13306c4c 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -2455,6 +2455,24 @@ chConnectDomainEventRegister(virConnectPtr conn, } =20 =20 +static int +chConnectDomainEventDeregister(virConnectPtr conn, + virConnectDomainEventCallback callback) +{ + virCHDriver *driver =3D conn->privateData; + + if (virConnectDomainEventDeregisterEnsureACL(conn) < 0) + return -1; + + if (virDomainEventStateDeregister(conn, + driver->domainEventState, + callback) < 0) + return -1; + + return 0; +} + + /* Function Tables */ static virHypervisorDriver chHypervisorDriver =3D { .name =3D "CH", @@ -2521,6 +2539,7 @@ static virHypervisorDriver chHypervisorDriver =3D { .domainDetachDevice =3D chDomainDetachDevice, /* 11.8.0 */ .domainDetachDeviceFlags =3D chDomainDetachDeviceFlags, /* 11.8.0 */ .connectDomainEventRegister =3D chConnectDomainEventRegister, /* 11.8.= 0 */ + .connectDomainEventDeregister =3D chConnectDomainEventDeregister, /* 1= 1.8.0 */ }; =20 static virConnectDriver chConnectDriver =3D { --=20 2.49.1