From nobody Mon Sep 8 21:39:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748937841; cv=none; d=zohomail.com; s=zohoarc; b=d3eqkIRMPqctVVldyvP+in4FuhGwbxyRbP71qZseryG8F+pleAx+4CJnIPsNh8mt3tC3lwr1BYxE0gH7Ba3bIoZug7505qX7XtOzH4UjJ0XFBsq/JUfh3j0IzcJKo7fIiHgwyz3bK9JdA6qmC8tQxsI3tkKVBT/3tqbFzqeohzM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748937841; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Vw8gk0sYlsvVDiXTTK+oRh/E4DNz303XV1YJuiHzLcY=; b=YS6BVE9L8tNmFNBjyZcxzmioh+C1Q/xw3UwvufbojvSbFV1a6UONURWFZKulX+r3vnvqUDaapouZHSQbj59w7CCNEFXKLW5In+KiA+FsqqnijcScXF9Gb/RD8kHCxtQ/DTa2o5/l1I80VZVtrB/w37Hn6hxXhXqQlww2IrjG6Xw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748937841185963.8091013267766; Tue, 3 Jun 2025 01:04:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 154111490; Tue, 3 Jun 2025 04:04:00 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 37C7F15AE; Tue, 3 Jun 2025 04:03:26 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0D5EE121F; Tue, 3 Jun 2025 04:03:22 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8AF2E121F for ; Tue, 3 Jun 2025 04:03:21 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-HmlJSDjwN5-3Ltbm5nQtFg-1; Tue, 03 Jun 2025 04:03:19 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D785C1956078 for ; Tue, 3 Jun 2025 08:03:18 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2260E19560A3 for ; Tue, 3 Jun 2025 08:03:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748937801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hMb4K+WVL68Q3elGOz6gBc7cRUxVPcpSboILtk/AKss=; b=ikdKaIeQie14J4maRVV8Rm0ea9q1NxAX/mRXsz/Oh2yCbHMG7MsDkOTuY5immTlTMKGp2g iEoxpeUxS143itt2j5uANwYIKtpej6R1kqW6y2TrtrCC16cLYIpsrcgka6o002BZu6D/m7 dOiT/KJ4Gf4dXrLd0XU01TzPsZnELnk= X-MC-Unique: HmlJSDjwN5-3Ltbm5nQtFg-1 X-Mimecast-MFC-AGG-ID: HmlJSDjwN5-3Ltbm5nQtFg_1748937799 To: devel@lists.libvirt.org Subject: [PATCH v2 1/2] qemu: Don't accept VIR_DUMP_LIVE flag in qemuDomainCoreDumpWithFormat() Date: Tue, 3 Jun 2025 10:03:12 +0200 Message-ID: <388509397ac040c91b37f20cc824a10fccb2a959.1748936608.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: D_ldakC_lbw3xA3LHXtFz2cnNrZbHdyc2dDx4s3j9J0_1748937799 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: TOHVQJFCPCPVTQ62VE7XLRWFNUSQP4PI X-Message-ID-Hash: TOHVQJFCPCPVTQ62VE7XLRWFNUSQP4PI X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748937843452116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik QEMU can't really do live dumps of guest memory. It's because inside of dump_init() the vm_stop() is called basically unconditionally (the only condition is whether vCPUs are running). Hence, there is no way for us to do live dumps and thus honor VIR_DUMP_LIVE flag. Instead of silently pretending the flag works, reject it with appropriate error message. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/646 Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index aef313ae9c..b3b0ee66f8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3162,7 +3162,7 @@ qemuDomainCoreDumpWithFormat(virDomainPtr dom, int ret =3D -1; virObjectEvent *event =3D NULL; =20 - virCheckFlags(VIR_DUMP_LIVE | VIR_DUMP_CRASH | + virCheckFlags(VIR_DUMP_CRASH | VIR_DUMP_BYPASS_CACHE | VIR_DUMP_RESET | VIR_DUMP_MEMORY_ONLY, -1); =20 --=20 2.49.0 From nobody Mon Sep 8 21:39:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748937856; cv=none; d=zohomail.com; s=zohoarc; b=kHKqk2jmJAYNjmgkv0/LpM8YrForPmKGO/0RQPQhFb3KpVAZQ/jp3dQBYFvW8ssOTX7xT3rG9d9fvkdi95dpx77G0Ovn9R51PexfQn0+XtifyRNdTRCUXJzkHeGYWkatstfZsrAKoqxtMID9Gxd936kD6OZWvx+9ZaisrEoisjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748937856; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=416odm8OfTDaXUVP3VKHz13snOm4P2GHbZACsefpOVs=; b=moQ9JLdMbHeGUT3+N241uVlAM9ecYkuGF2hHjHZro9+yowSqUYbg+k29gpz+Sly8bIJ75lpqPowk3tOLRINMA+QTCIo8EOVn0Um0Kmi+d2UPiK8pa9Ok+VW0+Bz8C/utxtgfdQcdVenHWpzVBKB60rD4T2fS150R1PerVl4NkaY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748937856172315.51757636749153; Tue, 3 Jun 2025 01:04:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 207BD1474; Tue, 3 Jun 2025 04:04:15 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EDEDA15D7; Tue, 3 Jun 2025 04:03:28 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0DC40121C; Tue, 3 Jun 2025 04:03:23 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8E3FA121F for ; Tue, 3 Jun 2025 04:03:22 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-jJD-MmTXOReOADCpG5cZXQ-1; Tue, 03 Jun 2025 04:03:20 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 151981955D99 for ; Tue, 3 Jun 2025 08:03:20 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5450019560A3 for ; Tue, 3 Jun 2025 08:03:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748937802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8ttw6LaMYHL2QFKUAvloe/qv1hEuzTnc3hd6dBnGIY=; b=Bmd90PZj3PtmzER3dPqKFdO2SESH71EahXsC9z3lXm+yLU+Bt2cKoFRjvRS0D9fyQ+EKk2 WfpKXf/XME6V3+FQBEV6gNZc6U+OdlsKCOwvPsejr9L9haeYiM6XlrhUYWai8Ko4MfFwqz AT0JC3s/h2KWxXgu8GaIaVGuJxAccbM= X-MC-Unique: jJD-MmTXOReOADCpG5cZXQ-1 X-Mimecast-MFC-AGG-ID: jJD-MmTXOReOADCpG5cZXQ_1748937800 To: devel@lists.libvirt.org Subject: [PATCH v2 2/2] NEWS: Document removal of support of VIR_DUMP_LIVE flag from QEMU driver Date: Tue, 3 Jun 2025 10:03:13 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kBxK0K33kQZa1zbaAgoIK-aR8jo2QU6WgnpnV_GGDq0_1748937800 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZKTMLYJGX7LOOCO7S34M2XFEAFUKRVVU X-Message-ID-Hash: ZKTMLYJGX7LOOCO7S34M2XFEAFUKRVVU X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748937857693116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 160aac0b31..b97f86ffb6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,13 @@ v11.5.0 (unreleased) =20 * **Removed features** =20 + * qemu: Don't accept VIR_DUMP_LIVE flag in virDomainCoreDumpWithFormat() + + Unfortunately, QEMU always pauses vCPUs when doing a core dump. Theref= ore, + there is no way for Libvirt to honor VIR_DUMP_LIVE flag semantics. Ins= tead + of silently pretending the flag works, an appropriate error is now + reported. + * **New features** =20 * **Improvements** --=20 2.49.0