From nobody Mon Sep 8 22:02:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747414674; cv=none; d=zohomail.com; s=zohoarc; b=AM29MGZhvZVBNU6xBHFq0Ku9LQAjAlKf7f+mYvzE0qs3FuYpTeJhAV/U2YPfCd/7dHMj01Fi02lpB2Bdaq009NXScqcZ0dmdOcHL2OQzc3pyhhTqkjcgEnmjQLldOivUPVE56EuMpqvKKTBni0KVfan1n4bvPye0XZbWiJ+LhSo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747414674; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=O03C1aOA9YQy2vBBUPe9Fh0HibUju2RU6tC01wtDTp4=; b=k+VxkY4S+o5qP0a4xX1kLPFmhCcPMsAv9BstcHG0m6QEpTr13X5ZJg1EBCNu1lCZ3HHhtsAfItqfvX/OVwuWCQxybzGVFZQuEr57YcfUmDPcpwmkx6/k2kQOLseTaG2E91nx1vtfS+sqA+vnIJKrfC85lQ3L8bltl468PizM0l0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747414674260168.62198664158484; Fri, 16 May 2025 09:57:54 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 451891634; Fri, 16 May 2025 12:57:53 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id ECCED15DC; Fri, 16 May 2025 12:57:07 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D6E74147F; Fri, 16 May 2025 12:57:04 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3E55A147E for ; Fri, 16 May 2025 12:57:04 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-MILqwoIQMRe9E8ksIuCX6w-1; Fri, 16 May 2025 12:57:02 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9FC801800370 for ; Fri, 16 May 2025 16:57:01 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E6C7819560B7 for ; Fri, 16 May 2025 16:57:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747414624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/m8zgywVlSAAa36HIYO+f7qBfmTuswK+QF5ajQpfqo4=; b=PUlONvQRECvAaty2ERtCJ0ZnOwwoqCrtGw3B4cK25s+Hmr543YZvYCZkeyQvsBMbBy8iDa mJmXBHrjC8jntvQ+j687HteN8lRT7uMpt1YoQ2mK2p/OlfCIAx+ayV4D52RImAPCmy5Xrp Qh8F31E7/01J8NqdIGTWHEYhP9unnk0= X-MC-Unique: MILqwoIQMRe9E8ksIuCX6w-1 X-Mimecast-MFC-AGG-ID: MILqwoIQMRe9E8ksIuCX6w_1747414621 To: devel@lists.libvirt.org Subject: [libvirt PATCH 1/2] build: prohibit inline functions in C files by syntax-check Date: Fri, 16 May 2025 18:56:36 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5CO5E0pdTQHvI2SGOXjoxAgkGocNOOth3N4Z5ISrVFo_1747414621 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XRO4PQPUG7RLLM6O7IFTDY2WWTAOA6AB X-Message-ID-Hash: XRO4PQPUG7RLLM6O7IFTDY2WWTAOA6AB X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747414676366116600 Content-Type: text/plain; charset="utf-8" From: J=C3=A1n Tomko Signed-off-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- build-aux/syntax-check.mk | 10 ++++++++++ src/hyperv/hyperv_wmi.c | 2 +- src/locking/lock_daemon.c | 4 ++-- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_saveimage.c | 2 +- src/rpc/virnetserver.c | 8 ++++---- src/storage/storage_util.c | 4 ++-- src/util/virhashcode.c | 4 ++-- src/util/virthreadpool.c | 2 +- src/util/virxml.c | 2 +- tools/nss/libvirt_nss.c | 2 +- 12 files changed, 27 insertions(+), 17 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 09d3a5620c..62e1604e94 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1349,6 +1349,13 @@ sc_rst_since: halt=3D'format :since: correctly' \ $(_sc_search_regexp) =20 +sc_prohibit_inline_functions: + @prohibit=3D'\binline\b' \ + in_vc_files=3D'\.c$$' \ + exclude=3D'exempt from syntax-check' \ + halt=3D'avoid inline functions in .c files' \ + $(_sc_search_regexp) + =20 ## ---------- ## ## Exceptions ## @@ -1506,6 +1513,9 @@ exclude_file_name_regexp--sc_black =3D \ exclude_file_name_regexp--sc_spacing-check =3D \ ^scripts/rpcgen/tests/test_demo\.[ch]$$ =20 +exclude_file_name_regexp--sc_prohibit_inline_functions =3D \ + ^src/storage_file/storage_source.*.c$$ + ## -------------- ## ## Implementation ## ## -------------- ## diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 040bcfec11..eee42b5c70 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -187,7 +187,7 @@ hypervFreeInvokeParams(hypervInvokeParamsList *params) } =20 =20 -static inline void +static void hypervCheckParams(hypervInvokeParamsList *params) { if (params->nbParams + 1 > params->nbAvailParams) { diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index 0b86300b43..1017fc65b1 100644 --- a/src/locking/lock_daemon.c +++ b/src/locking/lock_daemon.c @@ -93,13 +93,13 @@ virLockDaemonFree(virLockDaemon *lockd) g_free(lockd); } =20 -static inline void +static void virLockDaemonLock(virLockDaemon *lockd) { g_mutex_lock(&lockd->lock); } =20 -static inline void +static void virLockDaemonUnlock(virLockDaemon *lockd) { g_mutex_unlock(&lockd->lock); diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index f0601924ae..b1f50b6c67 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -2767,7 +2767,7 @@ qemuBlockThrottleFilterGetNodename(virDomainThrottleF= ilterDef *filter) * * Build "arguments" part of "blockdev-add" QMP cmd. */ -static inline virJSONValue * +static virJSONValue * qemuBlockThrottleFilterGetProps(virDomainThrottleFilterDef *filter, const char *parentNodeName) { diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 08069ffac8..fec48edfc1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2033,7 +2033,7 @@ qemuBuildBlockStorageSourceAttachDataCommandline(virC= ommand *cmd, } =20 =20 -static inline bool +static bool qemuDiskConfigThrottleGroupEnabled(const virDomainThrottleGroupDef *group) { return !!group->group_name && diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index 702df641a0..aa030798ce 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -48,7 +48,7 @@ VIR_ENUM_IMPL(qemuSaveFormat, "sparse", ); =20 -static inline void +static void qemuSaveImageBswapHeader(virQEMUSaveHeader *hdr) { hdr->version =3D GUINT32_SWAP_LE_BE(hdr->version); diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 91219c3eed..bad9bff2d5 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -78,8 +78,8 @@ static virClass *virNetServerClass; static void virNetServerDispose(void *obj); static void virNetServerUpdateServicesLocked(virNetServer *srv, bool enabled); -static inline size_t virNetServerTrackPendingAuthLocked(virNetServer *srv); -static inline size_t virNetServerTrackCompletedAuthLocked(virNetServer *sr= v); +static size_t virNetServerTrackPendingAuthLocked(virNetServer *srv); +static size_t virNetServerTrackCompletedAuthLocked(virNetServer *srv); =20 static int virNetServerOnceInit(void) @@ -901,14 +901,14 @@ virNetServerShutdownWait(virNetServer *srv) } =20 =20 -static inline size_t +static size_t virNetServerTrackPendingAuthLocked(virNetServer *srv) { return ++srv->nclients_unauth; } =20 =20 -static inline size_t +static size_t virNetServerTrackCompletedAuthLocked(virNetServer *srv) { return --srv->nclients_unauth; diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 28d5fce4f0..8f7fc6cc01 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -98,13 +98,13 @@ virStorageBackendNamespaceInit(int poolType, * Upon success, return 0. Otherwise, return -1 and set errno. */ #ifdef __linux__ -static inline int +static int reflinkCloneFile(int dest_fd, int src_fd) { return ioctl(dest_fd, FICLONE, src_fd); } #else -static inline int +static int reflinkCloneFile(int dest_fd G_GNUC_UNUSED, int src_fd G_GNUC_UNUSED) { diff --git a/src/util/virhashcode.c b/src/util/virhashcode.c index baa7a0b1c0..7430018d6e 100644 --- a/src/util/virhashcode.c +++ b/src/util/virhashcode.c @@ -35,7 +35,7 @@ static uint32_t rotl32(uint32_t x, int8_t r) } =20 /* slower than original but handles platforms that do only aligned reads */ -static inline uint32_t getblock(const uint8_t *p, int i) +static uint32_t getblock(const uint8_t *p, int i) { uint32_t r; size_t size =3D sizeof(r); @@ -48,7 +48,7 @@ static inline uint32_t getblock(const uint8_t *p, int i) /* * Finalization mix - force all bits of a hash block to avalanche */ -static inline uint32_t fmix(uint32_t h) +static uint32_t fmix(uint32_t h) { h ^=3D h >> 16; h *=3D 0x85ebca6b; diff --git a/src/util/virthreadpool.c b/src/util/virthreadpool.c index e00accd9eb..34a705d797 100644 --- a/src/util/virthreadpool.c +++ b/src/util/virthreadpool.c @@ -82,7 +82,7 @@ struct virThreadPoolWorkerData { /* Test whether the worker needs to quit if the current number of workers = @count * is greater than @limit actually allows. */ -static inline bool virThreadPoolWorkerQuitHelper(size_t count, size_t limi= t) +static bool virThreadPoolWorkerQuitHelper(size_t count, size_t limit) { return count > limit; } diff --git a/src/util/virxml.c b/src/util/virxml.c index ad967a2564..9d46e5f32f 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -1152,7 +1152,7 @@ virXMLParseHelper(int domcode, else if (url) docname =3D url; else - docname =3D "[inline data]"; + docname =3D "[inline data]"; /* exempt from syntax-check */ =20 /* Set up a parser context so we can catch the details of XML errors. = */ pctxt =3D xmlNewParserCtxt(); diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c index 3d634b5ae8..69bf59850e 100644 --- a/tools/nss/libvirt_nss.c +++ b/tools/nss/libvirt_nss.c @@ -230,7 +230,7 @@ NSS_NAME(gethostbyname2)(const char *name, int af, stru= ct hostent *result, errnop, herrnop, NULL, NULL); } =20 -static inline void * +static void * move_and_align(void *buf, size_t len, size_t *idx) { char *buffer =3D buf; --=20 2.49.0 From nobody Mon Sep 8 22:02:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747414692; cv=none; d=zohomail.com; s=zohoarc; b=XT70GG2U0YsxvdUD6XwHEdvgT3tUg/CvqdfOc3QRPfrf6oKc/ey0pFWlaZGwHatO3QhPRzsnRHtNaaPYXNyauTrsD6FV9fWAetmRWG8eBd4XSdygcl0U7LDMyNNWrso/IyGEkZhpERA2yvXKwesSm2IioySkoR1spWkZhm/sllU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747414692; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=1MRoK+vE2b5jxk1GxcNi7pl/Px6r8tjG2ElsnpyKLRA=; b=bLrzAL/sPQ3Ozq/mpbJBAhohq1PdKgpd21kGikulSEqSVTSGJXmnALwB/AVPJpB3EBDVle8FR9vbRLMaScsBn65cUfuXKdW9ISZNoLTL34GZ+gmknEgrZP9gUUMt7FarOHYOCU59i0+SF21xQ1TBgXHFdexoFH60pTgwUYdC4mo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747414692125741.1696462885888; Fri, 16 May 2025 09:58:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1C59B148E; Fri, 16 May 2025 12:58:11 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B640516E4; Fri, 16 May 2025 12:57:10 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E6BBB1479; Fri, 16 May 2025 12:57:05 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 73FAB147E for ; Fri, 16 May 2025 12:57:05 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344--3g5y7ZSOE6hQgWxducBKQ-1; Fri, 16 May 2025 12:57:03 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA7C01800258 for ; Fri, 16 May 2025 16:57:02 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 15ECA1956094 for ; Fri, 16 May 2025 16:57:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747414625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+1tnf+rENZe6wVm6umXgazAaqk/5BrcpM1p0AmC8tkw=; b=SZC1q54Ik5ZIO0CckeLcxnnf1sZ3peeiWw+MjCNQMTgB9rOFua2jsXSAJcQfi5X7tOcuyb SgG9A6COP/CzC2BokW9ni3Ihr/sqNhGLWOwi1J8O/pbUYv+P8OufHpMonYotEJRkc2t2Ba 4tmUwHrx3OERPiN5xhzXFbCXZ1KqmjM= X-MC-Unique: -3g5y7ZSOE6hQgWxducBKQ-1 X-Mimecast-MFC-AGG-ID: -3g5y7ZSOE6hQgWxducBKQ_1747414622 To: devel@lists.libvirt.org Subject: [libvirt PATCH 2/2] build: do not use -Winline Date: Fri, 16 May 2025 18:56:37 +0200 Message-ID: <3db563fbaf0a584372a481fb42388761f8e48679.1747414597.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YpqE-RnTUe9oH3nON-xxGUWQB2y46BZspI7o4BmIzxk_1747414622 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6QJ2AXUJ3T3733F2W64HJUZZXJHKC3QF X-Message-ID-Hash: 6QJ2AXUJ3T3733F2W64HJUZZXJHKC3QF X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747414694283116600 Content-Type: text/plain; charset="utf-8" From: J=C3=A1n Tomko We don't really care if a function cannot be inlined. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- meson.build | 6 ------ 1 file changed, 6 deletions(-) diff --git a/meson.build b/meson.build index bb0436e072..a46c2a7037 100644 --- a/meson.build +++ b/meson.build @@ -438,12 +438,6 @@ cc_flags +=3D [ '-Wwrite-strings', ] =20 -if get_option('optimization') !=3D 'g' - # Seemingly insignificant changes in the source program can cause the wa= rnings - # produced by -Winline to appear or disappear. - cc_flags +=3D [ '-Winline' ] -endif - if cc.get_id() =3D=3D 'clang' # Stop CLang from doing inter-procedural analysis of calls # between functions in the same compilation unit. Such an --=20 2.49.0