From nobody Mon Sep 8 21:39:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747139197; cv=none; d=zohomail.com; s=zohoarc; b=Mt+pa/OTX4ffOrWzBstcv4sINsC248XO+HfJdjs0h5jPj21TnQ1Q5TQEbsaXPjIBHruYh6AFzo7Unu5f0ghZpK0UcKehQLW+O3NACSPho7nuWLWbsPRrdZV/DkhgIMZHAqAkszPdZqwDeSgHkJ1o3vrTyZP39ramPNoYQnjAATc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747139197; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=3K5/nUD4lMhLRsvL9b7rWBcGIW0OIwkhV5wX/6pn5PQ=; b=abb/g5lSdBFHzd9eGge1eOqlAhnvacBC3t+t4jSGC5n1k5vjXgBgXokuhO3VQAACXnTwOIaPEqJiqXEoRiqc1exsCy2gJfMsK5ckAJ64P+rJV3EbbSwJ9h0TiEqO6gD3znGJ4UjYTwF4OrB00IUWPo4u8WKejt8XYBPZo4zFsSc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747139197427699.6425897804874; Tue, 13 May 2025 05:26:37 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 98A2CE30; Tue, 13 May 2025 08:26:36 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 05DB310F3; Tue, 13 May 2025 08:26:04 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A505ECD2; Tue, 13 May 2025 08:26:00 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 30D83CCA for ; Tue, 13 May 2025 08:26:00 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-bDaEKj3sM-ivq8puc6G2cw-1; Tue, 13 May 2025 08:25:57 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA1D618001E0 for ; Tue, 13 May 2025 12:25:56 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DEA2B1801490; Tue, 13 May 2025 12:25:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747139159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBsNRGKWm4W62DxJ83pq2C4T2+GaObG1VNUig241dqM=; b=PgfgsdB+YaW6nBEXciv27Nrr7EVMNYwrYAaC4KQmWDI3OKSerz5Ri1NDsdxwp8tvIgJoBK KeH2EiAx1FRod8RQvXHmcY+gEqfbn34OqBqQe5QSugkrQHuAYmhzNvQ+q3msRLltlFyRhw iAz26hGODfMScV/RFOHgmu9Zvwv0Xnw= X-MC-Unique: bDaEKj3sM-ivq8puc6G2cw-1 X-Mimecast-MFC-AGG-ID: bDaEKj3sM-ivq8puc6G2cw_1747139157 To: devel@lists.libvirt.org Subject: [PATCH 1/2] virNetDevTapCreate: Use error message hinting to multiqueue use only when opening multiple queues Date: Tue, 13 May 2025 14:25:50 +0200 Message-ID: <442d8dd7b63f794b07b8d25596fce6c2cbf45153.1747139127.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HxvGhJFK2lMiL8b_ANkYgMV8u8INrY1UptrKzwMVYUg_1747139157 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YKLKZNDGDB3SQ4GIUDZNRX4UHSXL3NZ7 X-Message-ID-Hash: YKLKZNDGDB3SQ4GIUDZNRX4UHSXL3NZ7 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747139198972019000 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Due to a logic bug the error message mentioning mult_queue operation would be mentioned also when a single queue would be opened on an externally managed tap device. Adjust the condition to trigger only when multiple queues are in use. Fixes: f6fb097e11a Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- src/util/virnetdevtap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index 1dc77f0f5c..648d095dfc 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -231,7 +231,7 @@ int virNetDevTapCreate(char **ifname, if (ioctl(fd, TUNSETIFF, &ifr) < 0) { if (flags & VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING && - tapfdSize > 0) { + tapfdSize > 1) { virReportSystemError(errno, _("Unable to create multiple fds for = tap device %1$s (maybe existing device was created without multi_queue flag= )"), *ifname); --=20 2.49.0 From nobody Mon Sep 8 21:39:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747139212; cv=none; d=zohomail.com; s=zohoarc; b=hmXXND1LAUZyqEshtw34a2TFFaAXpjX8sV4ctkLd8GVg9cWOUwp6hzuzFgkI6lUYpWEMAxLGQ/xNueLi0sWrsAZ1oMmdyLjJOT3uYt9oN59jPZQ1mRD2JpsBwhhUKa2H2M3Sj82SsV2oZpPklqqZY/oWkgNns4PlI/ZC0cYEVkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747139212; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=2GI8qG3FgGEaG3ir0kaCru+vuSkVva12uczIs5u1/zU=; b=h3yRcpmWb/iocVx+F1vW4sZP5WDyL5XkXoJzwTLGbpFgpJAKcX6tiNHFIyDRoqhAGqWuPNR5XfrDQtlDtHFrPDNDvYulwU+9QVBwWUME/jZNiWj2nAolBN7XY5tjuWxjS+A6IRMi5jKEUPY2aA2r3R3BbmfiUzoHEWS8p2OUKfA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747139212611791.3630588116301; Tue, 13 May 2025 05:26:52 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 09524CEF; Tue, 13 May 2025 08:26:52 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3EBF7CF0; Tue, 13 May 2025 08:26:05 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 19AFAD76; Tue, 13 May 2025 08:26:02 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7D00CCCA for ; Tue, 13 May 2025 08:26:01 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-0KBtzhd3MPK2gg7Br3bcWg-1; Tue, 13 May 2025 08:25:59 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 860AB195D03A for ; Tue, 13 May 2025 12:25:58 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7EEF81800359; Tue, 13 May 2025 12:25:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747139161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aC7mwL1HCuwj2MKyJ1r2VUDdJk+LRBVxvWcplvlcsYo=; b=XztpqIEmVnKWQbcUy0yu/7lY+HdLbcYTjvTYrHvhf0U5wqpb/Em68b+F7Sj+aTuzH/NwMO tuOlHWPtmDCEFcisBV+HAVyKq3rorsDQ1w1ul0V1mmlwzspa/L68P838X70NHOyKYrbpOR 7XuyxMEwWmGU6jfaIZdno/TVU32T3VY= X-MC-Unique: 0KBtzhd3MPK2gg7Br3bcWg-1 X-Mimecast-MFC-AGG-ID: 0KBtzhd3MPK2gg7Br3bcWg_1747139158 To: devel@lists.libvirt.org Subject: [PATCH 2/2] virDomainNetDefCheckABIStability: Consider virtio 'queues' ABI Date: Tue, 13 May 2025 14:25:51 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OIqOL8RoRL40KSojJDO9QCWnAKQk1_qtINt76pw-3h8_1747139158 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: D25HPB6H4HZEJOXW6HIIB2YP7MYOZ2TP X-Message-ID-Hash: D25HPB6H4HZEJOXW6HIIB2YP7MYOZ2TP X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747139213259019000 Content-Type: text/plain; charset="utf-8" From: Peter Krempa While the queue count itself is not a guest visible property, libvirt uses it to calculate the 'vectors' property of the 'virtio-net' device which is ABI. Since we don't expose control of 'vectors' explicitly, consider 'queues' ABI. Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- src/conf/domain_conf.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 542d6ade91..b3b0bd7329 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -20801,6 +20801,17 @@ virDomainNetDefCheckABIStability(virDomainNetDef *= src, return false; } + /* The number of queues is used to calculate the value for 'vectors' + * (see qemuBuildNicDevProps) which is machine ABI thus we need to ens= ure + * that the number of queues is kept in sync */ + if (virDomainNetIsVirtioModel(src) && + (src->driver.virtio.queues !=3D dst->driver.virtio.queues)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target virtio network queue count '%1$d' does no= t match source '%2$d'"), + dst->driver.virtio.queues, src->driver.virtio.queue= s); + return false; + } + if (!virDomainVirtioOptionsCheckABIStability(src->virtio, dst->virtio)) return false; --=20 2.49.0