From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486703; cv=none; d=zohomail.com; s=zohoarc; b=TCSlf/l/m+LbSAR0VuI6UhaA+bdA7VAFcDlqvITv7tyGg+yrBY6UODD/Tp5e22u63aMIc74yOlEhhBk60k+SCj4FPe53IU3OpuHhPhr+Ev/vaqwae+LJSdkOCwxNy3kxEb8j5IHucuK3PO8nFVwyscAnZODkUXIxH2iKhEWUefw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486703; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=WyLSXRLLhIMThLfejkol6zRvzoGL0aMVGuAK0reOzBo=; b=K+RyhIChoHHzqriAnZUvj9KABzJxTeLbIpyENd1yaU6YY/j8+Sxo8sxLRVr3IAaHAXytE4zIp4kQMw5/eX4H3f+g+ncTzRHfCMDf7XlkfetHAr9AxbqZTS4Zspi45lVAyGZArjXf+0y490efEf1uvue9syyKPK5Ws1Jv1urqaao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174248670356173.86956018951798; Thu, 20 Mar 2025 09:05:03 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id EBBFB1738; Thu, 20 Mar 2025 12:05:02 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 35CBA15A5; Thu, 20 Mar 2025 12:04:26 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E29E71278; Thu, 20 Mar 2025 12:04:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 30C6B1241 for ; Thu, 20 Mar 2025 12:04:12 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-4ULA_TC5Mmu60IQ1NmDk8A-1; Thu, 20 Mar 2025 12:04:10 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D2735180882E for ; Thu, 20 Mar 2025 16:04:09 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 073D719373C4 for ; Thu, 20 Mar 2025 16:04:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h3TGI/1y8uUOYXxfKFu6KlGDQDmbzdatvdO93RNNYhE=; b=de4SGdrS6YP5ePymiPDS5eBb1+HwuUaXiAZXGZx6W1yyUOnBMmXPakOVv8A3c2nS21R9ax DN8G6Xuwef2iejncYbPdEGSxrXJ5seJ/cNyIA2I3iZh/dOrFY5nIxs+OvO6s5QvSHg5Z4x Ughzw8TtGkii9VCnkWKKoZCZhfaJh2A= X-MC-Unique: 4ULA_TC5Mmu60IQ1NmDk8A-1 X-Mimecast-MFC-AGG-ID: 4ULA_TC5Mmu60IQ1NmDk8A_1742486649 To: devel@lists.libvirt.org Subject: [PATCH 1/8] lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT' Date: Thu, 20 Mar 2025 17:03:58 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vxEULJwortAc8A3Vxh7tDaWdyId8EjLJIQi-YhyLz4s_1742486649 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 57CZ7QBWPSLBI6LPYE5CZA4YKEFOHSIJ X-Message-ID-Hash: 57CZ7QBWPSLBI6LPYE5CZA4YKEFOHSIJ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486704585019000 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Introduce a new special error code for guest agent commands. The error code will be specifically reported only when an actual command (not a sync) was issued to the guest agent and the timeout time was reached. This will allow users and management applications to differentiate between the cases when the sync timed out and thus there's no risk in the agent actually having executed the command and when the actual command was sent. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- include/libvirt/virterror.h | 2 ++ src/util/virerror.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 224eddc9e4..7a2cc2b4bd 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -349,6 +349,8 @@ typedef enum { VIR_ERR_CHECKPOINT_INCONSISTENT =3D 109, /* checkpoint can't be used (= Since: 6.10.0) */ VIR_ERR_MULTIPLE_DOMAINS =3D 110, /* more than one matching domain= found (Since: 7.1.0) */ VIR_ERR_NO_NETWORK_METADATA =3D 111, /* Network metadata is not prese= nt (Since: 9.7.0) */ + VIR_ERR_AGENT_COMMAND_TIMEOUT =3D 112,/* guest agent didn't respond to= a non-sync + command within timeout (Since: = 11.2.0) */ # ifdef VIR_ENUM_SENTINELS VIR_ERR_NUMBER_LAST /* (Since: 5.0.0) */ diff --git a/src/util/virerror.c b/src/util/virerror.c index 227a182417..f89bfbc530 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -1290,6 +1290,9 @@ static const virErrorMsgTuple virErrorMsgStrings[] = =3D { [VIR_ERR_NO_NETWORK_METADATA] =3D { N_("metadata not found"), N_("metadata not found: %1$s") }, + [VIR_ERR_AGENT_COMMAND_TIMEOUT] =3D { + N_("guest agent command timed out"), + N_("guest agent command timed out: %1$s") }, }; G_STATIC_ASSERT(G_N_ELEMENTS(virErrorMsgStrings) =3D=3D VIR_ERR_NUMBER_LAS= T); --=20 2.48.1 From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486727; cv=none; d=zohomail.com; s=zohoarc; b=T9m4mJMNVs0JHm6y1+BMdXHb6ZIXC3jXZJ4kq0BPXVbV2PCw/dKAKREKvv6cYCW4fvb7+veJyHT7e751sf88f/kG1P4CbWQcTCgu/ozFLL+jDlc8l5ZQeryT2gWygjon+jtJ8ZeloIIXxeosVKWaM3gDud50FqhVDhZ7VC7rGCw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486727; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=wvAzSZV2le5dIXlauZyXx230lieoMX9aw6xyA3SfMWw=; b=P6gqcLhTLFMoBawT8tkVnM/iQO2iX9gCVnGL4oZ9a9uTOXo5of+dTfLl/pZIK0ja4N3XghCPMMRaRSg9yzNJFjTy8loC8YInapQ7YpYi1XrmVlwHmxBmAUkGJmH5aYgrHOhA+nCAJBaD2fsFJ8wOxC3XgJaby7gWdflMaDDYEbQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174248672724046.6265563290026; Thu, 20 Mar 2025 09:05:27 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AB7781604; Thu, 20 Mar 2025 12:05:26 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 296901781; Thu, 20 Mar 2025 12:04:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0841B127E; Thu, 20 Mar 2025 12:04:14 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 80C831274 for ; Thu, 20 Mar 2025 12:04:13 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-MrFLNgu5PfWWWzhbz4_xMA-1; Thu, 20 Mar 2025 12:04:11 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2F184196D2E2 for ; Thu, 20 Mar 2025 16:04:11 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F7B819373C4 for ; Thu, 20 Mar 2025 16:04:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wvudvRGh2KlUEARWPUtWvcQ3jLubZ3yCXlJucCnvoRY=; b=gt4uF+QBhcpK3nySf2oB9yxzNHXNTMfzDaa1cItAxkqzAB0dX2Jl+WYd5hc0C4IRH/CNCJ cLBH4MaJhDJ0aoqQwPK6xGFgX5hl3JCNwV+l3J/EXWYGhKQrukh9PFNB1O1j+C3Pn2h6sr vVwadH8oAHALFHFVzwrvBO0Z2FsqaJI= X-MC-Unique: MrFLNgu5PfWWWzhbz4_xMA-1 X-Mimecast-MFC-AGG-ID: MrFLNgu5PfWWWzhbz4_xMA_1742486651 To: devel@lists.libvirt.org Subject: [PATCH 2/8] qemu: agent: Differentiate timeouts when syncing from command timeout Date: Thu, 20 Mar 2025 17:03:59 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eYO23S7YT33rGaNzP_WqMw9OrfY3VjXnhzikOufiPDk_1742486651 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WT2HR454NIBIBYB6F55BQCI3PCC2C4FY X-Message-ID-Hash: WT2HR454NIBIBYB6F55BQCI3PCC2C4FY X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: <> List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486728702019000 Content-Type: text/plain; charset="utf-8" From: Peter Krempa As the guest agent code uses timeouts it is possible that we stop waiting before the guest agent replies. If this happens while syncing everything is okay because we didn't send any state-changing command. In case when the timeout happens after a real command was transmitted it's unknown if the guest-agent processed it or not. Use the new special error code VIR_ERR_AGENT_COMMAND_TIMEOUT for cases when we sent non-sync commands, so that the management applications or users have possibility to react to this situation. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_agent.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 6f5aab5bf2..879c3a8f41 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -707,6 +707,7 @@ void qemuAgentClose(qemuAgent *agent) * @msg: Message * @seconds: number of seconds to wait for the result, it can be either * -2, -1, 0 or positive. + * @report_sync: On timeout; report synchronization error instead of the n= ormal error * * Send @msg to agent @agent. If @seconds is equal to * VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK(-2), this function will block forev= er @@ -720,9 +721,11 @@ void qemuAgentClose(qemuAgent *agent) * -2 on timeout, * -1 otherwise */ -static int qemuAgentSend(qemuAgent *agent, - qemuAgentMessage *msg, - int seconds) +static int +qemuAgentSend(qemuAgent *agent, + qemuAgentMessage *msg, + int seconds, + bool report_sync) { int ret =3D -1; unsigned long long then =3D 0; @@ -751,8 +754,15 @@ static int qemuAgentSend(qemuAgent *agent, if ((then && virCondWaitUntil(&agent->notify, &agent->parent.lock,= then) < 0) || (!then && virCondWait(&agent->notify, &agent->parent.lock) < 0= )) { if (errno =3D=3D ETIMEDOUT) { - virReportError(VIR_ERR_AGENT_UNRESPONSIVE, "%s", - _("Guest agent not available for now")); + if (report_sync) { + virReportError(VIR_ERR_AGENT_UNRESPONSIVE, + _("guest agent didn't respond to synchr= onization within '%1$d' seconds"), + seconds); + } else { + virReportError(VIR_ERR_AGENT_COMMAND_TIMEOUT, + _("guest agent didn't respond to comman= d within '%1$d' seconds"), + seconds); + } ret =3D -2; } else { virReportSystemError(errno, "%s", @@ -817,7 +827,7 @@ qemuAgentGuestSyncSend(qemuAgent *agent, VIR_DEBUG("Sending guest-sync command with ID: %llu", id); - rc =3D qemuAgentSend(agent, &sync_msg, timeout); + rc =3D qemuAgentSend(agent, &sync_msg, timeout, true); rxObj =3D g_steal_pointer(&sync_msg.rxObject); VIR_DEBUG("qemuAgentSend returned: %d", rc); @@ -1040,7 +1050,7 @@ qemuAgentCommandFull(qemuAgent *agent, VIR_DEBUG("Send command '%s' for write, seconds =3D %d", cmdstr, secon= ds); - ret =3D qemuAgentSend(agent, &msg, seconds); + ret =3D qemuAgentSend(agent, &msg, seconds, false); VIR_DEBUG("Receive command reply ret=3D%d rxObject=3D%p", ret, msg.rxObject); --=20 2.48.1 From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486744; cv=none; d=zohomail.com; s=zohoarc; b=HAkmWauFTHtoGKAyfv0q60soMfcd8N59BaLG8ETrKfetyOs/3LotH3m2gkdzGE55ZihKUmrBN33A+IUsxRHCRUuUZ/I15qIspIS4DUKJQjEIEsa5x4GuxAzmgUypeIsr2FkwVClgl524rblfLlNMcles43y9D3AxR8yrC5lyBr8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486744; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=LlMtX8h70JJ7rWagBQu+BGHn1t5ez7XqbwUNAT8gvKY=; b=nzGbSE6XTfAqpqCVDB5Q2eRNoEaa21CC91MxQ4URfYU/l4uO1tH2DtHMO/tI9tRWNAz36Z7bv1q3Zihe0GvbJYSzLedu8HX+5gyfFzb7mkLqRmM7u1enlGjm/vuKCtxxJcRd0t8jtXZkvhg8RB1F8BYJ5zdkVPhP5R5JzKcmeIU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742486744967869.7360933551186; Thu, 20 Mar 2025 09:05:44 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 03EC51524; Thu, 20 Mar 2025 12:05:44 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8909B15D8; Thu, 20 Mar 2025 12:04:43 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9CCC81278; Thu, 20 Mar 2025 12:04:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 15C881241 for ; Thu, 20 Mar 2025 12:04:15 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-0jtl0bNKOjSVupNeZ3G8lg-1; Thu, 20 Mar 2025 12:04:13 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 89A51180AF52 for ; Thu, 20 Mar 2025 16:04:12 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AEB6A19373C4 for ; Thu, 20 Mar 2025 16:04:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ye2MJ6Zlssc6temiQpWjMtduiXFrMHUr98cAMvw8Bo=; b=R5k4coK+4149N2WH0zu4QVur42jrKyL0vhFQDB3Zuh4MHd+eTLck068Xk4GPhC+ATgtQpj 53KfHiID4Z9sKFcqRaDO4rpcv1KnQOomY5nBT5r1eql61vBOcYa0eNW9422m8Loob7dACs aw68nnYKC/E46cp7YxHCF0U3LXB19ug= X-MC-Unique: 0jtl0bNKOjSVupNeZ3G8lg-1 X-Mimecast-MFC-AGG-ID: 0jtl0bNKOjSVupNeZ3G8lg_1742486652 To: devel@lists.libvirt.org Subject: [PATCH 3/8] qemuAgentCommandFull: Use VIR_ERR_AGENT_COMMAND_TIMEOUT when agent disappears Date: Thu, 20 Mar 2025 17:04:00 +0100 Message-ID: <4e7e5b4f84aaac35b34541dfd338b455da6a19bb.1742486491.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hWhhy3MguYzFKz1klRRzhpDP888-kcpcxrWSfcyX-ko_1742486652 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: S4OX52KR47U6GNE3ISFRQXOM4DVX7ODB X-Message-ID-Hash: S4OX52KR47U6GNE3ISFRQXOM4DVX7ODB X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486747819019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa When the agent disappears after geting a proper command we ought to report the same error code as if we timed out as it's uncertain whether the guest agent did anything. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 879c3a8f41..b22c9d7e85 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1066,7 +1066,7 @@ qemuAgentCommandFull(qemuAgent *agent, virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Missing agent reply object")); } else { - virReportError(VIR_ERR_AGENT_UNRESPONSIVE, "%s", + virReportError(VIR_ERR_AGENT_COMMAND_TIMEOUT, "%s", _("Guest agent disappeared while executing = command")); } ret =3D -1; --=20 2.48.1 From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486768; cv=none; d=zohomail.com; s=zohoarc; b=EjAy0+ZbxIIWJfB2G6J8/ejz80C38Ps/emk+fX6aSPGSLiTiS5gfvNTrx8FZTgkxJOUWt85CVg4hmkDFJ9nj0vqnpmCZNGdePL7/wz5snR+Ngp7fJoJraaQzQDAgS6H2ErMIjJSi8VUHPLz1bhvqQYnbKqqOYTfuYWEz8tARbwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486768; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=gyB/1wqafo93nIlQ+JkvMJ58//Oqa/LN54vtoMkIYx4=; b=NvmkR0XS8d754bJWxoZ3sFmjSh/+pfr095n553MdUf1bPgfL6JPwfRXfvWdtLqIwyKXznfvkCMGyb3w15zDIrcinABOb0rZc7EfTJL23rWwEcfCsa1D3ne+/vRoEvP/wKZYS+ir2AQ4Kpce+EKuIrsTElgwJpMa6LpbMVnctccE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742486768140504.0964887375901; Thu, 20 Mar 2025 09:06:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8921415DF; Thu, 20 Mar 2025 12:06:07 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4AE2215F2; Thu, 20 Mar 2025 12:04:44 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D09EE1274; Thu, 20 Mar 2025 12:04:16 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 51CDF1274 for ; Thu, 20 Mar 2025 12:04:16 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-xezWYDu8MAWC8MMagrK07g-1; Thu, 20 Mar 2025 12:04:14 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 14FFF180049D for ; Thu, 20 Mar 2025 16:04:14 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1F34419373C4 for ; Thu, 20 Mar 2025 16:04:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OnBIy30F3ykRtuIuXlpSSrmZVcSNhQK660bqc/0aOaQ=; b=fjmPbOy/YLKkhGieCum5R/2aGIHAoAPKknMu3sB515qEXxd61+kxAzXECEUrrsccC5zEoj GXQ5prIb99xZ9gfykgq25HU9ATW7eWF+2YXqtxNFSyjPScKiizqy5ROIKgWmH4yb9GMH47 a7LTb6E4Ynch+sPTHGflrTqpOpP6EPo= X-MC-Unique: xezWYDu8MAWC8MMagrK07g-1 X-Mimecast-MFC-AGG-ID: xezWYDu8MAWC8MMagrK07g_1742486654 To: devel@lists.libvirt.org Subject: [PATCH 4/8] docs: Point to VIR_ERR_AGENT_COMMAND_TIMEOUT when setting timeout Date: Thu, 20 Mar 2025 17:04:01 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DUYKnZ4F_ij1AeQeNJjsYy-Upow_p9pZqYEoIi02BJE_1742486654 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QYKYXIIB6GXWMSHHI2D6MN2LPEUNUFZX X-Message-ID-Hash: QYKYXIIB6GXWMSHHI2D6MN2LPEUNUFZX X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486768962019000 Content-Type: text/plain; charset="utf-8" From: Peter Krempa In addition to the error constant appearing add docs hinting that this new error code can be produced on timeouts. The most relevant place is to do it when setting the timeout. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- docs/manpages/virsh.rst | 3 +++ src/libvirt-domain.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index baced15dec..6f31bd9ca3 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -2909,6 +2909,9 @@ values: libvirt daemon), * 0 - do not wait at all, +In all guest-agent based APIs when a timeout happens if an actual command = was +send to the guest agent the returned error code will be +VIR_ERR_AGENT_COMMAND_TIMEOUT. guestinfo --------- diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4e78c687d5..09c29df462 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -13519,6 +13519,10 @@ int virDomainSetLaunchSecurityState(virDomainPtr d= omain, * VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_NOWAIT(0): does not wait. * positive value: wait for @timeout seconds * + * In all guest-agent based APIs when a timeout happens if an actual comma= nd + * was send to the guest agent the returned error code will be + * VIR_ERR_AGENT_COMMAND_TIMEOUT. + * * Returns 0 on success, -1 on failure * * Since: 5.10.0 --=20 2.48.1 From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486835; cv=none; d=zohomail.com; s=zohoarc; b=S+C71mtqbtgEHaGXMRcUe0lae3bHtVx9VD3T+sVwd1hVBvRluiNSgABh0s57MXMIUVf4kA4xZM2Cd4AidhQTuZ3C+Z9yq3k8zBd/NFV+audFZfyASCiGSW4ZO7R4ueOL2WIWgdE+4I4KA8poM5xv1lNIXpmLWX2dOt9Q/tGNihI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486835; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=8doVc+bE8g4nMcfsbsbrs+kCWECMMrcZzdq69KIR1LY=; b=M36umeZJB8e8Y24mtAGiYCP0aBxiO8VpH7YO/hp5L4fk854/KN3LGxUABn4OgCEUyb+tcE9mm8z6DH8kdh4Ta1z4dvrvJ3CuBFMwCRNUoFu8Dq+Cr4yRdHNna2+eWNvBORD6XoesQtpC5pMPtCIxJlxJbBwZ9/0eEUdprmz7GOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742486835015703.3074275165893; Thu, 20 Mar 2025 09:07:15 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id F397B15FD; Thu, 20 Mar 2025 12:07:13 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AD4EB165A; Thu, 20 Mar 2025 12:04:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B6C2615A3; Thu, 20 Mar 2025 12:04:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2B6DD15A0 for ; Thu, 20 Mar 2025 12:04:17 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-77rL_f4uOMayTP8iPj39Bw-1; Thu, 20 Mar 2025 12:04:16 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4EBEB180AF4E for ; Thu, 20 Mar 2025 16:04:15 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7403719373C4 for ; Thu, 20 Mar 2025 16:04:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BRviVuZ/+3Svc23Yyrevu089t9213QmA8HfnMB16s8E=; b=iD9GGb2fcpjlMXv5K17ksOE5+BUDOXj3qveKB57XPhp9G1CGXf/DyNbvl/PdgiEMzWapi6 qN5pOs/+4Z9d2VpjP7LBt+IFJIDiRo4liQl+6Sv7aFfouz8VF6E41DpF8GGlCW46ycQtrz TS6lAfMIRPLSuL0qRZE6OTJarvebn04= X-MC-Unique: 77rL_f4uOMayTP8iPj39Bw-1 X-Mimecast-MFC-AGG-ID: 77rL_f4uOMayTP8iPj39Bw_1742486655 To: devel@lists.libvirt.org Subject: [PATCH 5/8] lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_FAILED' Date: Thu, 20 Mar 2025 17:04:02 +0100 Message-ID: <866ab7cd630d565389367857142d1037dbd4e147.1742486492.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AbbaO9-SKsQOYT-ZmRUAzFcC9cpznQzUocLHsGT9unY_1742486655 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CPDCQ326IV3WE6VJXDS5FQCW2KGXOLJ5 X-Message-ID-Hash: CPDCQ326IV3WE6VJXDS5FQCW2KGXOLJ5 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486838128019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Add a special error code for when the guest agent returned a failure message. Allow management applications to deterministically detect failure of the guest agent command. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- include/libvirt/virterror.h | 2 ++ src/util/virerror.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 7a2cc2b4bd..f02da046a3 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -351,6 +351,8 @@ typedef enum { VIR_ERR_NO_NETWORK_METADATA =3D 111, /* Network metadata is not prese= nt (Since: 9.7.0) */ VIR_ERR_AGENT_COMMAND_TIMEOUT =3D 112,/* guest agent didn't respond to= a non-sync command within timeout (Since: = 11.2.0) */ + VIR_ERR_AGENT_COMMAND_FAILED =3D 113, /* guest agent responded with fa= ilure + to a command (Since: 11.2.0) */ # ifdef VIR_ENUM_SENTINELS VIR_ERR_NUMBER_LAST /* (Since: 5.0.0) */ diff --git a/src/util/virerror.c b/src/util/virerror.c index f89bfbc530..abb014b522 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -1293,6 +1293,9 @@ static const virErrorMsgTuple virErrorMsgStrings[] = =3D { [VIR_ERR_AGENT_COMMAND_TIMEOUT] =3D { N_("guest agent command timed out"), N_("guest agent command timed out: %1$s") }, + [VIR_ERR_AGENT_COMMAND_FAILED] =3D { + N_("guest agent command failed"), + N_("guest agent command failed: %1$s") }, }; G_STATIC_ASSERT(G_N_ELEMENTS(virErrorMsgStrings) =3D=3D VIR_ERR_NUMBER_LAS= T); --=20 2.48.1 From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486853; cv=none; d=zohomail.com; s=zohoarc; b=QBcAUrFhWeCkj1Xps72UNlUSeLYbUsl+MdmqgsAwV1WnuEj8lQny2wkQMEMcNhNnPkpsriziqakNUgiGUQgLzmjqD1kY8HMj21d01YL0bO0rTwxBryrTuvFNkg/6fvHBGTLeDzjLi1ETmINuAmaWbRd4tsP+O2j/1wmr09b2QSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486853; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=0oJfIyoUKsoYP3dnnyRDlO9WUeo9+FeQex/vduEqP6w=; b=OxhRukc37MBSloShCKT+afro6dMoG1oLaOfoFGEsYZgatboI3YTk2R9WU+w0hdpwbCKv93rVUKZM9pF2I/j9As9X0viMEL3SPWzF/UPbRp/tg5k1B5Qjm1DbFTb/HL3KRapS9+uMx7I4iq5GRBFNtPQw1MdhXyTkessByh/2dPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742486853826443.8865793316802; Thu, 20 Mar 2025 09:07:33 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DC78C1274; Thu, 20 Mar 2025 12:07:32 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7687C173E; Thu, 20 Mar 2025 12:04:51 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BC42E15D2; Thu, 20 Mar 2025 12:04:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 10AEA1596 for ; Thu, 20 Mar 2025 12:04:19 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-56dO2uLLO8uFl7EBWSCCrg-1; Thu, 20 Mar 2025 12:04:17 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A0A0E1800259 for ; Thu, 20 Mar 2025 16:04:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C749219373C4 for ; Thu, 20 Mar 2025 16:04:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SxyMP71O2S7E+YBVplA4t5Z3IbiXjdnJhN+71NKI2bk=; b=M98DSv3ACImUuFbamgZD1w0BKtCGUxmRd97kHC60FpzwOjnrf4UWW7fDyDCPijfJKJoHVG 8PG/8oTxCu5MfFeckUdBeSuQIjfzBAGE0QfVDJvd2nd+7qwNuvuowBe0pLOdOvSWXG4RrG sOKeoU+2QpMcAEydNwv8ig56xZFJkNg= X-MC-Unique: 56dO2uLLO8uFl7EBWSCCrg-1 X-Mimecast-MFC-AGG-ID: 56dO2uLLO8uFl7EBWSCCrg_1742486656 To: devel@lists.libvirt.org Subject: [PATCH 6/8] qemuAgentCheckError: Use 'VIR_ERR_AGENT_COMMAND_FAILED' Date: Thu, 20 Mar 2025 17:04:03 +0100 Message-ID: <427364ccdef866d78245b0ca5c383eed1c0a8b9b.1742486492.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zH8SPQN9wOLjK91Y9T5IoSkiZcQxKUkzlC54aNBpgso_1742486656 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KOKYPXCQIXBLDXC7O4L2FUIRG4L25HLS X-Message-ID-Hash: KOKYPXCQIXBLDXC7O4L2FUIRG4L25HLS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486856071019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa In the two cases when we know that the command returned failure switch to the new error code so that management applications can programatically detect failure of the guest agent command. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_agent.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index b22c9d7e85..d4eb4897a4 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -985,7 +985,7 @@ qemuAgentCheckError(virJSONValue *cmd, /* Only send the user the command name + friendly error */ if (!error) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_AGENT_COMMAND_FAILED, _("unable to execute QEMU agent command '%1$s'"= ), qemuAgentCommandName(cmd)); return -1; @@ -999,7 +999,7 @@ qemuAgentCheckError(virJSONValue *cmd, return -2; } - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_AGENT_COMMAND_FAILED, _("unable to execute QEMU agent command '%1$s': %2$= s"), qemuAgentCommandName(cmd), qemuAgentStringifyError(error)); --=20 2.48.1 From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486807; cv=none; d=zohomail.com; s=zohoarc; b=G+JZj3BAak92ATrnilwPqcz527iAt8E63iPjjYnfpTiGMT2ci7y6K1h2Wpve0Yzxh/5sPZHG0IWRLCkuaG0pFUTyMPLH0Lqa2ZytyY7/OvH96psv1tJvBawdc4X9Olds0dq/KJIh7rJ/uAYjl849gC8ZnEcQP5sXl8LYEMeLRbw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486807; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=goezSB4YSdbTOMFIbXzPEzyhhYdKB3BtT411f6Yxs38=; b=hLkZykGcZPVt549l65ptFZ63MFzJG7fpndRoSVuby4rOcQnSU16qMUCKVHybKPkEjgpHNrPM2uWJ7wcwqb2JbjzsHCr03zIDtLITYHIb2wSkS2cojDfOVjzfsT2yaSz2nSTwWh+xOBtsZVkGY3TKRPU9iU0FqFaGD6LdfgNCN5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742486807928500.736607803336; Thu, 20 Mar 2025 09:06:47 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 012FC1773; Thu, 20 Mar 2025 12:06:46 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D554214F4; Thu, 20 Mar 2025 12:04:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AE41B15D8; Thu, 20 Mar 2025 12:04:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CFB0A15A7 for ; Thu, 20 Mar 2025 12:04:26 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-kJuFbKPrOlmp6ceL21THkw-1; Thu, 20 Mar 2025 12:04:18 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F239519373D7 for ; Thu, 20 Mar 2025 16:04:17 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2596519373C4 for ; Thu, 20 Mar 2025 16:04:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4TusvmdghCyy2mkJdfc21kiHfmg9bquJq2aInnV2aqE=; b=QFq//3JTre+uRHpZGa07qtSrdjvkOs7Y1TQHHOt42uJfTCXYLou5zBB7T7sIMx/J52ObjF vCf7pBMNo0DlLMjmwBlRJ/L5d4RydhERupMJNDD2IkYyBcGDUSiBhvKGoGMxutDXRmV1F8 0EkKXvsBCwbJgiCahQm5en/aziigV78= X-MC-Unique: kJuFbKPrOlmp6ceL21THkw-1 X-Mimecast-MFC-AGG-ID: kJuFbKPrOlmp6ceL21THkw_1742486658 To: devel@lists.libvirt.org Subject: [PATCH 7/8] qemuAgentCheckError: Rewort error if neither return nor error is found Date: Thu, 20 Mar 2025 17:04:04 +0100 Message-ID: <4be7ca9bfb78519a88164820fe7d364914048876.1742486492.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QrHgYAMvY_RS-KMB3WDN3WlkhCLBCM_HihdWcePsrrM_1742486658 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6CPN575MOZPBW5B3EETY3VZ2NG4IFWJQ X-Message-ID-Hash: 6CPN575MOZPBW5B3EETY3VZ2NG4IFWJQ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486809971019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Disambiguate the case from other types of error. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index d4eb4897a4..ee0921eca6 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1013,7 +1013,7 @@ qemuAgentCheckError(virJSONValue *cmd, VIR_DEBUG("Neither 'return' nor 'error' is set in the JSON reply %= s: %s", NULLSTR(cmdstr), NULLSTR(replystr)); virReportError(VIR_ERR_INTERNAL_ERROR, - _("unable to execute QEMU agent command '%1$s'"), + _("QEMU agent command '%1$s' returned neither error= nor success"), qemuAgentCommandName(cmd)); return -1; } --=20 2.48.1 From nobody Mon Dec 15 14:44:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486788; cv=none; d=zohomail.com; s=zohoarc; b=LF+dQueoMdURWco6Zafk1soT0U3vV/6mPQcIcu6aFWR74nMB+EH9TQ6baLo6QGYrQadeuFiWK45Yo+SOKEanLYATDWeCoOKSomHBJOKH+seI+pSsIckD7GWCmnq9MVGKSIkz+Zvbk71RnSV92twnMxbW7Xxx90tslSEKaF0Feow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486788; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=O0vb0Z7185EHCw/sOsU6nGtvRkhHocr6V++ApUnu4YU=; b=dyMHcW8SWL+E/CEQL4CSw+jdAIJih1mMsG5deiDtIDw6vU1xxccifdEYPjI7L51af+G0e0toEpgg81BmTYD0s1kABXANesZocRh4P60OjeQ8/IFfsUygVCRcm05DuNJ44AEFuIfcEZHsW0FfO8UWeiMc+0qi2GhHtaabN5zsISI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742486788599772.1260010817699; Thu, 20 Mar 2025 09:06:28 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A23C71389; Thu, 20 Mar 2025 12:06:27 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 1D7311602; Thu, 20 Mar 2025 12:04:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9B8C515B5; Thu, 20 Mar 2025 12:04:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1F3A314E7 for ; Thu, 20 Mar 2025 12:04:27 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-_w3j0n-vNn2oZ921txtddw-1; Thu, 20 Mar 2025 12:04:20 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6F6FE196B373 for ; Thu, 20 Mar 2025 16:04:19 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8BFE7192ED65 for ; Thu, 20 Mar 2025 16:04:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDBgiVP6SGR46F2DtkYQtAqWzmN4u50XuIxJcoYkyDU=; b=gQQpw1mM2Mt4cqFlVzrKRKNSpsYPPte2SSEYVUpyXN1jAtnSbNz60lm82oDaBkL8iMb03r gaPOuyZULLvkrjX2xfzyNTYRgU+C+en9nstO8HRac4FauleXVGHOiP9a5FrStLO2yUnS+s Hi7ypAi/pZA5iRcpe2yOrUBflASUgZs= X-MC-Unique: _w3j0n-vNn2oZ921txtddw-1 X-Mimecast-MFC-AGG-ID: _w3j0n-vNn2oZ921txtddw_1742486659 To: devel@lists.libvirt.org Subject: [PATCH 8/8] NEWS: Mention guest agent error code improvements Date: Thu, 20 Mar 2025 17:04:05 +0100 Message-ID: <8a1546d9f777a8aba553ac88ad9f0255d0db0858.1742486492.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vAFKcHiNSETyDfcgsmHyjXDj90FIL3Ju_qKFFZRiD-Q_1742486659 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XAPEFP4RJNLWP7PKRAZ2UBOF65FUB2DM X-Message-ID-Hash: XAPEFP4RJNLWP7PKRAZ2UBOF65FUB2DM X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486789965019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- NEWS.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 98ca838642..b2f3415001 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -37,6 +37,16 @@ v11.2.0 (unreleased) * **Improvements** + * qemu: Improved guest agent corner case error reporting + + The APIs using the guest agent now report two specific error codes aim= ed at + helping management applications and also users to differentiate between + the guest agent timing out while libvirt is attempting synchronisation= , thus + no harm would be done and while being issued a command. + + The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and + ``VIR_ERR_AGENT_COMMAND_FAILED``. + * **Bug fixes** --=20 2.48.1