[PATCH 0/8] qemu: Improve guest agent corner case errors

Peter Krempa via Devel posted 8 patches 1 month, 1 week ago
NEWS.rst                    | 10 ++++++++++
docs/manpages/virsh.rst     |  3 +++
include/libvirt/virterror.h |  4 ++++
src/libvirt-domain.c        |  4 ++++
src/qemu/qemu_agent.c       | 32 +++++++++++++++++++++-----------
src/util/virerror.c         |  6 ++++++
6 files changed, 48 insertions(+), 11 deletions(-)
[PATCH 0/8] qemu: Improve guest agent corner case errors
Posted by Peter Krempa via Devel 1 month, 1 week ago
This series introduces two new error codes aimed to help management
applications to better in deciding when corner cases of guest agent
interaction are encountered.

Peter Krempa (8):
  lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT'
  qemu: agent: Differentiate timeouts when syncing from command timeout
  qemuAgentCommandFull: Use VIR_ERR_AGENT_COMMAND_TIMEOUT when agent
    disappears
  docs: Point to VIR_ERR_AGENT_COMMAND_TIMEOUT when setting timeout
  lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_FAILED'
  qemuAgentCheckError: Use 'VIR_ERR_AGENT_COMMAND_FAILED'
  qemuAgentCheckError: Rewort error if neither return nor error is found
  NEWS: Mention guest agent error code improvements

 NEWS.rst                    | 10 ++++++++++
 docs/manpages/virsh.rst     |  3 +++
 include/libvirt/virterror.h |  4 ++++
 src/libvirt-domain.c        |  4 ++++
 src/qemu/qemu_agent.c       | 32 +++++++++++++++++++++-----------
 src/util/virerror.c         |  6 ++++++
 6 files changed, 48 insertions(+), 11 deletions(-)

-- 
2.48.1
Re: [PATCH 0/8] qemu: Improve guest agent corner case errors
Posted by Ján Tomko via Devel 1 month, 1 week ago
On a Thursday in 2025, Peter Krempa via Devel wrote:
>This series introduces two new error codes aimed to help management
>applications to better in deciding when corner cases of guest agent
>interaction are encountered.
>
>Peter Krempa (8):
>  lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT'
>  qemu: agent: Differentiate timeouts when syncing from command timeout
>  qemuAgentCommandFull: Use VIR_ERR_AGENT_COMMAND_TIMEOUT when agent
>    disappears
>  docs: Point to VIR_ERR_AGENT_COMMAND_TIMEOUT when setting timeout
>  lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_FAILED'
>  qemuAgentCheckError: Use 'VIR_ERR_AGENT_COMMAND_FAILED'
>  qemuAgentCheckError: Rewort error if neither return nor error is found
>  NEWS: Mention guest agent error code improvements
>
> NEWS.rst                    | 10 ++++++++++
> docs/manpages/virsh.rst     |  3 +++
> include/libvirt/virterror.h |  4 ++++
> src/libvirt-domain.c        |  4 ++++
> src/qemu/qemu_agent.c       | 32 +++++++++++++++++++++-----------
> src/util/virerror.c         |  6 ++++++
> 6 files changed, 48 insertions(+), 11 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano