[PATCH 00/17] qemu: Clean up various unneeded capabilities

Peter Krempa posted 17 patches 1 month, 2 weeks ago
src/libvirt_private.syms                      |  1 -
src/qemu/qemu_backup.c                        | 18 ---------
src/qemu/qemu_block.c                         |  4 --
src/qemu/qemu_blockjob.c                      | 20 ++--------
src/qemu/qemu_capabilities.c                  | 33 +++++------------
src/qemu/qemu_capabilities.h                  | 14 +++----
src/qemu/qemu_checkpoint.c                    | 18 +--------
src/qemu/qemu_command.c                       | 31 +++-------------
src/qemu/qemu_domain.c                        | 23 ------------
src/qemu/qemu_domain.h                        |  4 --
src/qemu/qemu_driver.c                        | 37 +++++--------------
src/qemu/qemu_migration.c                     | 10 +----
src/qemu/qemu_monitor.c                       | 28 +-------------
src/qemu/qemu_monitor_json.c                  |  2 +-
src/qemu/qemu_monitor_priv.h                  |  4 --
src/qemu/qemu_snapshot.c                      |  4 --
src/util/virqemu.c                            | 36 ------------------
src/util/virqemu.h                            |  3 --
.../caps_10.0.0_s390x.xml                     |  7 ----
.../caps_10.0.0_x86_64+amdsev.xml             |  7 ----
.../caps_10.0.0_x86_64.xml                    |  7 ----
.../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  7 ----
.../caps_6.2.0_x86_64.xml                     |  7 ----
.../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  7 ----
.../caps_7.0.0_x86_64.xml                     |  7 ----
.../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  7 ----
.../caps_7.1.0_x86_64.xml                     |  7 ----
tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  7 ----
.../caps_7.2.0_x86_64+hvf.xml                 |  7 ----
.../caps_7.2.0_x86_64.xml                     |  7 ----
.../caps_8.0.0_x86_64.xml                     |  7 ----
.../qemucapabilitiesdata/caps_8.1.0_s390x.xml |  7 ----
.../caps_8.1.0_x86_64.xml                     |  7 ----
.../caps_8.2.0_aarch64.xml                    |  7 ----
.../caps_8.2.0_armv7l.xml                     |  7 ----
.../caps_8.2.0_loongarch64.xml                |  7 ----
.../qemucapabilitiesdata/caps_8.2.0_s390x.xml |  7 ----
.../caps_8.2.0_x86_64.xml                     |  7 ----
.../qemucapabilitiesdata/caps_9.0.0_sparc.xml |  7 ----
.../caps_9.0.0_x86_64.xml                     |  7 ----
.../caps_9.1.0_riscv64.xml                    |  7 ----
.../qemucapabilitiesdata/caps_9.1.0_s390x.xml |  7 ----
.../caps_9.1.0_x86_64.xml                     |  7 ----
.../caps_9.2.0_aarch64+hvf.xml                |  7 ----
.../qemucapabilitiesdata/caps_9.2.0_s390x.xml |  7 ----
.../caps_9.2.0_x86_64+amdsev.xml              |  7 ----
.../caps_9.2.0_x86_64.xml                     |  7 ----
tests/qemucommandutiltest.c                   | 30 ---------------
48 files changed, 40 insertions(+), 483 deletions(-)
[PATCH 00/17] qemu: Clean up various unneeded capabilities
Posted by Peter Krempa 1 month, 2 weeks ago
The recent bump of minimum qemu version resulted into some capabilities
always being present. I've noticed one while doing a review and from
there I removed a few others, mostly storage related ones as well.

Peter Krempa (17):
  qemuBuildCompatDeprecatedCommandLine: Assume that
    QEMU_CAPS_COMPAT_DEPRECATED is supported
  qemu: capabilities: Retire QEMU_CAPS_COMPAT_DEPRECATED
  qemuBuildObjectCommandlineFromJSON: Assume all qemus support
    QEMU_CAPS_OBJECT_JSON
  qemu: monitor: Drop support for extra wrapper for 'object_add'
  util: Drop 'virQEMUBuildCommandLineJSONArrayBitmap'
  qemu: capabilities: Retire QEMU_CAPS_OBJECT_JSON
  qemu: monitor: Always assume support for
    QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT
  qemu: capabilities: Retire QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT
  qemu: Always assume supprot for QEMU_CAPS_BLOCKDEV_REOPEN
  qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_REOPEN
  qemu: Always assume support for
    QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY
  qemu: capabilities: Retire
    QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY
  qemu: Always assume support for QEMU_CAPS_INCREMENTAL_BACKUP
  qemu: capabilites: Retire QEMU_CAPS_INCREMENTAL_BACKUP
  qemu: domain: Remove qemuDomainSupportsCheckpointsBlockjobs
  qemu: migration: Always assume support for
    QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING
  qemu: capabilites: Retire
    QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING

 src/libvirt_private.syms                      |  1 -
 src/qemu/qemu_backup.c                        | 18 ---------
 src/qemu/qemu_block.c                         |  4 --
 src/qemu/qemu_blockjob.c                      | 20 ++--------
 src/qemu/qemu_capabilities.c                  | 33 +++++------------
 src/qemu/qemu_capabilities.h                  | 14 +++----
 src/qemu/qemu_checkpoint.c                    | 18 +--------
 src/qemu/qemu_command.c                       | 31 +++-------------
 src/qemu/qemu_domain.c                        | 23 ------------
 src/qemu/qemu_domain.h                        |  4 --
 src/qemu/qemu_driver.c                        | 37 +++++--------------
 src/qemu/qemu_migration.c                     | 10 +----
 src/qemu/qemu_monitor.c                       | 28 +-------------
 src/qemu/qemu_monitor_json.c                  |  2 +-
 src/qemu/qemu_monitor_priv.h                  |  4 --
 src/qemu/qemu_snapshot.c                      |  4 --
 src/util/virqemu.c                            | 36 ------------------
 src/util/virqemu.h                            |  3 --
 .../caps_10.0.0_s390x.xml                     |  7 ----
 .../caps_10.0.0_x86_64+amdsev.xml             |  7 ----
 .../caps_10.0.0_x86_64.xml                    |  7 ----
 .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  7 ----
 .../caps_6.2.0_x86_64.xml                     |  7 ----
 .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  7 ----
 .../caps_7.0.0_x86_64.xml                     |  7 ----
 .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  7 ----
 .../caps_7.1.0_x86_64.xml                     |  7 ----
 tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  7 ----
 .../caps_7.2.0_x86_64+hvf.xml                 |  7 ----
 .../caps_7.2.0_x86_64.xml                     |  7 ----
 .../caps_8.0.0_x86_64.xml                     |  7 ----
 .../qemucapabilitiesdata/caps_8.1.0_s390x.xml |  7 ----
 .../caps_8.1.0_x86_64.xml                     |  7 ----
 .../caps_8.2.0_aarch64.xml                    |  7 ----
 .../caps_8.2.0_armv7l.xml                     |  7 ----
 .../caps_8.2.0_loongarch64.xml                |  7 ----
 .../qemucapabilitiesdata/caps_8.2.0_s390x.xml |  7 ----
 .../caps_8.2.0_x86_64.xml                     |  7 ----
 .../qemucapabilitiesdata/caps_9.0.0_sparc.xml |  7 ----
 .../caps_9.0.0_x86_64.xml                     |  7 ----
 .../caps_9.1.0_riscv64.xml                    |  7 ----
 .../qemucapabilitiesdata/caps_9.1.0_s390x.xml |  7 ----
 .../caps_9.1.0_x86_64.xml                     |  7 ----
 .../caps_9.2.0_aarch64+hvf.xml                |  7 ----
 .../qemucapabilitiesdata/caps_9.2.0_s390x.xml |  7 ----
 .../caps_9.2.0_x86_64+amdsev.xml              |  7 ----
 .../caps_9.2.0_x86_64.xml                     |  7 ----
 tests/qemucommandutiltest.c                   | 30 ---------------
 48 files changed, 40 insertions(+), 483 deletions(-)

-- 
2.48.1
Re: [PATCH 00/17] qemu: Clean up various unneeded capabilities
Posted by Ján Tomko 1 month, 2 weeks ago
On a Wednesday in 2025, Peter Krempa wrote:
>The recent bump of minimum qemu version resulted into some capabilities
>always being present. I've noticed one while doing a review and from
>there I removed a few others, mostly storage related ones as well.
>
>Peter Krempa (17):
>  qemuBuildCompatDeprecatedCommandLine: Assume that
>    QEMU_CAPS_COMPAT_DEPRECATED is supported
>  qemu: capabilities: Retire QEMU_CAPS_COMPAT_DEPRECATED
>  qemuBuildObjectCommandlineFromJSON: Assume all qemus support
>    QEMU_CAPS_OBJECT_JSON
>  qemu: monitor: Drop support for extra wrapper for 'object_add'
>  util: Drop 'virQEMUBuildCommandLineJSONArrayBitmap'
>  qemu: capabilities: Retire QEMU_CAPS_OBJECT_JSON
>  qemu: monitor: Always assume support for
>    QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT
>  qemu: capabilities: Retire QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT
>  qemu: Always assume supprot for QEMU_CAPS_BLOCKDEV_REOPEN
>  qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_REOPEN
>  qemu: Always assume support for
>    QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY
>  qemu: capabilities: Retire
>    QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY
>  qemu: Always assume support for QEMU_CAPS_INCREMENTAL_BACKUP
>  qemu: capabilites: Retire QEMU_CAPS_INCREMENTAL_BACKUP
>  qemu: domain: Remove qemuDomainSupportsCheckpointsBlockjobs
>  qemu: migration: Always assume support for
>    QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING
>  qemu: capabilites: Retire
>    QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano