From nobody Mon Sep 8 21:39:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1738150921219502.62940237058956; Wed, 29 Jan 2025 03:42:01 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 9CA0A13F1; Wed, 29 Jan 2025 06:42:00 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3A00B15A4; Wed, 29 Jan 2025 06:41:27 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 1D62613C7; Wed, 29 Jan 2025 06:41:24 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9BF2D13A7 for ; Wed, 29 Jan 2025 06:41:23 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119--nTuq4WuMnibh-Q4xTtr2A-1; Wed, 29 Jan 2025 06:41:21 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 20A371956059 for ; Wed, 29 Jan 2025 11:41:21 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.23]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0DD331801407 for ; Wed, 29 Jan 2025 11:41:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738150883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zcKLbI7oSy8xwmnkGsmyE3SG/33WeL1/CJbiCosTYoQ=; b=icsF8aJfkCPF/CMwgyDAKAeI7IkmME0t7ckVTrSIaCCMv+bQb+6zhtAYRhhVO8oqKtl6FA J76BvAaMvW0GroBH2yP9RalhLmLtUTEu3Nvg7W9zNedLgQwn6dVCf9MAVbL/Q2KyMNblcW DT3JHrzFLpDRVv7qe+0LsNw9zM6osGE= X-MC-Unique: -nTuq4WuMnibh-Q4xTtr2A-1 X-Mimecast-MFC-AGG-ID: -nTuq4WuMnibh-Q4xTtr2A From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 1/3] docs: Document that 'vcpu.delay' statistic is in nanoseconds Date: Wed, 29 Jan 2025 12:41:14 +0100 Message-ID: <42f6e90f6d0ba36fc3dd6d26202d6031b17beaad.1738150739.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Pjss0AqahgGeKQbksmr5YJJLCMsPbNGhPcZNk_t6Pxk_1738150881 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7556EVS27OSGT6UMDOLWKK3ROSDIQD5K X-Message-ID-Hash: 7556EVS27OSGT6UMDOLWKK3ROSDIQD5K X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738150923406019000 Content-Type: text/plain; charset="utf-8" From: Assaf Admi Add nanoseconds units for vcpu.delay doc, as it's based on '/proc//task//schedstat' (see 'qemuGetSchedstatDelay()'). 'schedstat' is in nanoseconds, according to https://docs.kernel.org/scheduler/sched-stats.html#proc-pid-schedstat. Signed-off-by: aadmi Reviewed-by: Peter Krempa --- docs/manpages/virsh.rst | 2 +- src/libvirt-domain.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index bf0436621b..868b354b2f 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -2441,7 +2441,7 @@ When selecting the *--state* group the following fiel= ds are returned: no (may indicate the processor is idle or even disabled, depending on the architecture) * ``vcpu..delay`` - time the vCPU thread was enqueued by the - host scheduler, but was waiting in the queue instead of running. + host scheduler, but was waiting in the queue instead of running (in nano= seconds). Exposed to the VM as a steal time. This group of statistics also reports additional hypervisor-originating pe= r-vCPU diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index efccafc4d2..088e486b6b 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12331,7 +12331,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * "vcpu..delay" - time the vCPU thread was enqueued by the * host scheduler, but was waiting in the queue * instead of running. Exposed to the VM as a ste= al - * time. + * time. (in nanoseconds) * * This group of statistics also reports additional hypervisor-originat= ing * per-vCPU stats. The hypervisor-specific statistics in this group hav= e the --=20 2.48.1 From nobody Mon Sep 8 21:39:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1738150942157261.0793726643235; Wed, 29 Jan 2025 03:42:22 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 7A77915CE; Wed, 29 Jan 2025 06:42:21 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id CF39715E1; Wed, 29 Jan 2025 06:41:37 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id D725C1560; Wed, 29 Jan 2025 06:41:33 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A1C22157D for ; Wed, 29 Jan 2025 06:41:25 -0500 (EST) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-vDnRZmiHNcyIhf8rh8Px5g-1; Wed, 29 Jan 2025 06:41:23 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 08F4F1955F2D for ; Wed, 29 Jan 2025 11:41:23 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.23]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B7F9D1800900 for ; Wed, 29 Jan 2025 11:41:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738150885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ILtuJTTVFUmOv4bUj4VTOehMl9dBy78J/5jutj68mLo=; b=IKTVYWyUt7SDncNfb21JfERPlRsIh3MAltSxgYgaFwKRz0FPiFlsKGN9MQJguvlosxQ8eT BF1NjXiO/8DxrDPS5DlFYuNdSIRNTzaJIMsKSpvqlkp4NuxBm9q71UAUYD6/AAjAQY5ZRa WiFM5cLm25s81BAQjmAd9mE6OuyitI4= X-MC-Unique: vDnRZmiHNcyIhf8rh8Px5g-1 X-Mimecast-MFC-AGG-ID: vDnRZmiHNcyIhf8rh8Px5g From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 2/3] virsh: pool-list: remove unnecessary spaces to align behavior Date: Wed, 29 Jan 2025 12:41:15 +0100 Message-ID: <96a90c93b3589f312c853af2d96ee43758b5fa19.1738150739.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EqvIEhpFetU0z_BeCaGVoAZuZorMDjQp7fx4d59q0W4_1738150883 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PFU56GXXEIP4UGG5FD7VZHS66QRFGIBV X-Message-ID-Hash: PFU56GXXEIP4UGG5FD7VZHS66QRFGIBV X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738150943536019000 Content-Type: text/plain; charset="utf-8" From: Philipp Schuster By removing the unnecessary spaces, the behavior is aligned with `virsh list --all --name` and `virsh net-list --all --name`. Without this change, one can't do something like the following easily: `virsh pool-list --all --name | xargs -I {} virsh pool-start \"{}\"` as no pool `"foo "` (with all the spaces) actually exist. Although the removed comment states that the additional spaces were kept to maintain backwards compatibility, the commit [0] and the old behavior are from 2010 when libvirt was at version 0.8.1. For the sake of sanity, the behavior should be aligned with other parts of the CLI. [0] https://gitlab.com/libvirt/libvirt/-/commit/415b14903e816aeb98d6f9c16fb= a045686cb0765 Signed-off-by: Philipp Schuster Reviewed-by: Peter Krempa --- tools/virsh-pool.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index f9aad8ded0..4cd7b7ba0b 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -1270,11 +1270,6 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd G_GNU= C_UNUSED) } } - /* If the --details option wasn't selected, we output the pool - * info using the fixed string format from previous versions to - * maintain backward compatibility. - */ - /* Output basic info then return if --details option not selected */ if (!details) { if (uuid || name) { @@ -1287,7 +1282,7 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd G_GNUC= _UNUSED) if (name) { const char *name_str =3D virStoragePoolGetName(list->pools[i]); - vshPrint(ctl, "%-20s\n", name_str); + vshPrint(ctl, "%s\n", name_str); } } ret =3D true; --=20 2.48.1 From nobody Mon Sep 8 21:39:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1738150957667785.3985785146559; Wed, 29 Jan 2025 03:42:37 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 71CFC13F7; Wed, 29 Jan 2025 06:42:37 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C3CEE15AF; Wed, 29 Jan 2025 06:41:41 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6E88C1495; Wed, 29 Jan 2025 06:41:37 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6F5C715A8 for ; Wed, 29 Jan 2025 06:41:27 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-Za5r-kl0OjCuT_j0JHrd8w-1; Wed, 29 Jan 2025 06:41:25 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B95EB1955DCC for ; Wed, 29 Jan 2025 11:41:24 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.23]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7F8631801494 for ; Wed, 29 Jan 2025 11:41:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738150887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=opk8OnafXQ2zOjxO8j/33B1D0VlAJ1CzRPrjzQPwIAU=; b=AqqSFuUvglXNCg2uqvf6hwhOjv+COz7n8oA6hgu9SSagpQzrA1sGijiqW+ygIB3StBSoyD i9m/bDJ5fHZs8DS1PXSsqoGsWdygAWPUaiA6nSO6S1eZeY8ULGjwN+ieMkTg03HWNRoUeV HphyoLzCjYj6jNlSMX46AHUWMdzrDbA= X-MC-Unique: Za5r-kl0OjCuT_j0JHrd8w-1 X-Mimecast-MFC-AGG-ID: Za5r-kl0OjCuT_j0JHrd8w From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 3/3] tools: Move libvirt-guests lock file out of subsys directory Date: Wed, 29 Jan 2025 12:41:16 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IY92i9Ex8n0wJO4oRkymnDgwsKFFTIQNes4UrfSH1VE_1738150884 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: M6UMAE5STKXFQDGYBAKXKQJPZBHTG2OF X-Message-ID-Hash: M6UMAE5STKXFQDGYBAKXKQJPZBHTG2OF X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738150959512019000 Content-Type: text/plain; charset="utf-8" From: Bronek Kozicki This directory might not exist on systems not supporting old SystemV interf= aces. Signed-off-by: Bronek Kozicki Reviewed-by: Peter Krempa --- tools/libvirt-guests.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index c3c5954e17..f2db1282ad 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -44,7 +44,7 @@ test -f "$initconfdir"/libvirt-guests && . "$initconfdir"/libvirt-guests LISTFILE=3D"$localstatedir"/lib/libvirt/libvirt-guests -VAR_SUBSYS_LIBVIRT_GUESTS=3D"$localstatedir"/lock/subsys/libvirt-guests +VAR_SUBSYS_LIBVIRT_GUESTS=3D"$localstatedir"/lock/libvirt-guests RETVAL=3D0 --=20 2.48.1