From nobody Thu Dec 26 14:51:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732782794229850.3755429800651; Thu, 28 Nov 2024 00:33:14 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id A7CCEC18; Thu, 28 Nov 2024 03:33:13 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 68FCB1826; Thu, 28 Nov 2024 03:32:37 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 431C217CB; Thu, 28 Nov 2024 03:32:35 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BBF9F178F for ; Thu, 28 Nov 2024 03:32:34 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-j4CFKL7LPRSnEMPKnKoF8A-1; Thu, 28 Nov 2024 03:32:32 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 88135195609F for ; Thu, 28 Nov 2024 08:32:31 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8FF4F195605A for ; Thu, 28 Nov 2024 08:32:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732782754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UTM4IloUwECuFz421HVSej9ecpc0UEgwjFWB++HbjI=; b=bAYSczpvQdy8QHs7bVIb5Ee1YdrU1rNfrYpU7lrUAA9rB/2gT/13w3ZyzvL5KbkdOUUfbg A3FVqF3MWiI8PXPJCIItvSFiI5qS1B2z4x8mRbSiicyb6gxfI6Z2/+dDPDIOpgkT2ezOVH JQjJlgSV8tbCJ2ko/JjK5q2Ewrj6j1o= X-MC-Unique: j4CFKL7LPRSnEMPKnKoF8A-1 X-Mimecast-MFC-AGG-ID: j4CFKL7LPRSnEMPKnKoF8A From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 1/5] schemas: domain: Make subelement of NFS disk source optional Date: Thu, 28 Nov 2024 09:32:23 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MxyYdKrPalH89XYcuV9VVGx_hxK_cII2i2hy0YwE4sU_1732782751 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3P4JQSSQCLG6EWMJYOPMOZJ4SZFTAQG6 X-Message-ID-Hash: 3P4JQSSQCLG6EWMJYOPMOZJ4SZFTAQG6 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732782794890019100 Content-Type: text/plain; charset="utf-8" Both the 'user' and 'group' attribute are optional so can be empty. Allow it to be omitted completely. The parser and qemu code can handle that. The schema was introduced in 943871f971d680f72726a9d6e9330eec264f6588 and in d018c8dc9ebcd0496c7a564bc2e8b1c9cbd8d96f an offending test was added. Fixes: 943871f971d680f72726a9d6e9330eec264f6588 Fixes: d018c8dc9ebcd0496c7a564bc2e8b1c9cbd8d96f Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/conf/schemas/domaincommon.rng | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 7415c37b65..b3fdbf7ffb 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -2010,18 +2010,20 @@ - - - - - - - - - - - - + + + + + + + + + + + + + + --=20 2.47.0 From nobody Thu Dec 26 14:51:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732782812205291.92286308437997; Thu, 28 Nov 2024 00:33:32 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 87D0818B9; Thu, 28 Nov 2024 03:33:31 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 31FFD1863; Thu, 28 Nov 2024 03:32:44 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 9404917EF; Thu, 28 Nov 2024 03:32:39 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1533517D0 for ; Thu, 28 Nov 2024 03:32:37 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-_fSjji4xPaSRV1EIhhFNrg-1; Thu, 28 Nov 2024 03:32:34 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E6ABF1955D58 for ; Thu, 28 Nov 2024 08:32:32 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 174A2195605A for ; Thu, 28 Nov 2024 08:32:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732782756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oX6kMlTmRlxICN8MuG3WECeEqx8pYU5poe/DsmlrwYw=; b=gkv4n2rJg4Pw8wEAWTq22DEQbLaE+p03BhNPE2dIpr3qWcxxTDBI2mQc163nrtnCs+Rz2i FLT4qkbcTJgu59U8/VuSp7FjecuEsMT+fGq0UTNLuxE1Dm4GWGpWn9hv0dm5z70YI/3uWH gOEnLpnFoN4XqAfTGANIUKDyhipoqTg= X-MC-Unique: _fSjji4xPaSRV1EIhhFNrg-1 X-Mimecast-MFC-AGG-ID: _fSjji4xPaSRV1EIhhFNrg From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 2/5] schemas: domaincaps: Add schema for 'panic' device Date: Thu, 28 Nov 2024 09:32:24 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FHo7Cgb11LkK9kS6cWnG8A8gaE1egmSPX4KXS6LTPl8_1732782753 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: APYXV4P3OLMOJGDHX2KEJXTZH6EMOUXX X-Message-ID-Hash: APYXV4P3OLMOJGDHX2KEJXTZH6EMOUXX X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732782813076019100 Content-Type: text/plain; charset="utf-8" Due to 'virschematest' being broken commit a52cd504b3618c67abf3a07c669 introduced a new element to the domain caps but didn't add schema for it. Fixes: a52cd504b3618c67abf3a07c669fd5e5ab18aa50 Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/conf/schemas/domaincaps.rng | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/conf/schemas/domaincaps.rng b/src/conf/schemas/domaincaps.= rng index f9b87c8a59..142a54d1d7 100644 --- a/src/conf/schemas/domaincaps.rng +++ b/src/conf/schemas/domaincaps.rng @@ -215,6 +215,9 @@ + + + @@ -288,6 +291,13 @@ + + + + + + + --=20 2.47.0 From nobody Thu Dec 26 14:51:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732782828610873.4686958293651; Thu, 28 Nov 2024 00:33:48 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id E24821BEC; Thu, 28 Nov 2024 03:33:47 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C7508C66; Thu, 28 Nov 2024 03:32:55 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id D437E19A7; Thu, 28 Nov 2024 03:32:50 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D72C718FB for ; Thu, 28 Nov 2024 03:32:37 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-Mqhnw5UAO5eHRFCqtq74lg-1; Thu, 28 Nov 2024 03:32:35 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 56A3D1955D9E for ; Thu, 28 Nov 2024 08:32:34 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7D2F2195605A for ; Thu, 28 Nov 2024 08:32:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732782757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VsE8RmezQbz9YXeEKeRrypXWcavViujIq/57AdtcCv8=; b=HTHTrJKRGvvkQa1TedQzqg9qdFXe7QYpnZjp8liJoRvQ5SIzonbjfXn3kSUPCzs6P/p9iZ cUpRZdNpPeA54tmWQKhBvk+26hxEToGhTQYTDlUCnegx2xfo03sD5MqICBV2meGwWtsrPJ /QGj/SLbawE0VCNw8Kd8MPvNhDZK8Js= X-MC-Unique: Mqhnw5UAO5eHRFCqtq74lg-1 X-Mimecast-MFC-AGG-ID: Mqhnw5UAO5eHRFCqtq74lg From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 3/5] schemas: domaincaps: Add schema for 'canonical' cpu model name Date: Thu, 28 Nov 2024 09:32:25 +0100 Message-ID: <63113acdb1f06bea451b192a50f4d6f504ea0fce.1732782657.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: E2COypVMfXc2VQPb_xs18u7ZuMFsNIP9E8u5rdnXK_A_1732782754 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FZZJW5MTOAIDHTKYWSTQBOSOC53KA6CS X-Message-ID-Hash: FZZJW5MTOAIDHTKYWSTQBOSOC53KA6CS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732782829091019100 Content-Type: text/plain; charset="utf-8" Due to 'virschematest' being broken commit fff2bbee7feb0fdfbf40aac4fe9 forgot to add schema for the new attribute. Fixes: fff2bbee7feb0fdfbf40aac4fe9efd070f72ce9e Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/conf/schemas/domaincaps.rng | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/conf/schemas/domaincaps.rng b/src/conf/schemas/domaincaps.= rng index 142a54d1d7..40bae6e578 100644 --- a/src/conf/schemas/domaincaps.rng +++ b/src/conf/schemas/domaincaps.rng @@ -164,6 +164,11 @@ + + + + + --=20 2.47.0 From nobody Thu Dec 26 14:51:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732782846118778.8699842776203; Thu, 28 Nov 2024 00:34:06 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8AF3817F3; Thu, 28 Nov 2024 03:34:05 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8F5981980; Thu, 28 Nov 2024 03:32:57 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6CCDFE6A; Thu, 28 Nov 2024 03:32:51 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 40D48180C for ; Thu, 28 Nov 2024 03:32:40 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-43O863AoOmeRg5B2pP7Ksg-1; Thu, 28 Nov 2024 03:32:36 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E67D61955F3F for ; Thu, 28 Nov 2024 08:32:35 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EA9FF195605A for ; Thu, 28 Nov 2024 08:32:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732782759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uaDjy2GumajUStWmWzDCxMySawaXh8OAG6Gqm6SWPBA=; b=aEsqq0tdAkBrvSpFFLyWRS9LUtByJUJRxGPoiZiEKTuHSOwwZPdXtPxUKomkUU5r5lpGvZ Yq9vQTHq9B6KzxBPM2cO4DAnuDKHqvlGKjQbhuq1igY92XyYW/jxa2iuekjrAIUdha5Qpo sQ9ItG36mp2cRpJlqeEEJGeG/G59sdk= X-MC-Unique: 43O863AoOmeRg5B2pP7Ksg-1 X-Mimecast-MFC-AGG-ID: 43O863AoOmeRg5B2pP7Ksg From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 4/5] schemas: domaincaps: Add schema for CPU 'blockers' Date: Thu, 28 Nov 2024 09:32:26 +0100 Message-ID: <08041369552f80fcf7fc3d6101a3c61bec30cbe9.1732782657.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BWNoujRwDPz5YvZb2n0EXi4iOIsk6yR1I-1MkdMXbK0_1732782756 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FXCXVJK7OPFZ7XXTNQKMVRJIVPS5F4PG X-Message-ID-Hash: FXCXVJK7OPFZ7XXTNQKMVRJIVPS5F4PG X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732782847097019100 Content-Type: text/plain; charset="utf-8" Due to broken 'virschematest' commit f4dc248a952aaebcc793c7809c6c083d9 forgot to introduce schema for the new element. Fixes: f4dc248a952aaebcc793c7809c6c083d9cc30d0c Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/conf/schemas/domaincaps.rng | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/conf/schemas/domaincaps.rng b/src/conf/schemas/domaincaps.= rng index 40bae6e578..3559d2ae05 100644 --- a/src/conf/schemas/domaincaps.rng +++ b/src/conf/schemas/domaincaps.rng @@ -174,6 +174,20 @@ + + + + + + + + + + + + + + --=20 2.47.0 From nobody Thu Dec 26 14:51:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732782863272457.6812233451418; Thu, 28 Nov 2024 00:34:23 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id AC35817CE; Thu, 28 Nov 2024 03:34:22 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 5DDCA196D; Thu, 28 Nov 2024 03:32:59 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 0FE1212A3; Thu, 28 Nov 2024 03:32:52 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B71CE17F5 for ; Thu, 28 Nov 2024 03:32:40 -0500 (EST) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-fiCbI8EvOuaAC7_xyX-w1w-1; Thu, 28 Nov 2024 03:32:38 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 98C63195419B for ; Thu, 28 Nov 2024 08:32:37 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AF01B195605A for ; Thu, 28 Nov 2024 08:32:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732782760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6IgaIDBPNtaWN7dNqVD3q0/HMpzRivEvBOcggXOD4Y=; b=PpPHf0LJFe5XQTNNTJ/Chq1pZcxtvqoaqcGvXklRUv187NXr+5YddQWZ+PxMQOAeEXhOn8 gdb1MejnpNMu6SvWLBCGfKDeT+YeB0nOfIehMLZLfgpJ5rrWUHFOlxpcSaCtR6ykbYYqe4 eczNQOK47KC2811IuGtzD3j5/PKryD4= X-MC-Unique: fiCbI8EvOuaAC7_xyX-w1w-1 X-Mimecast-MFC-AGG-ID: fiCbI8EvOuaAC7_xyX-w1w From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 5/5] virschematest: Don't skip all "directory" tests Date: Thu, 28 Nov 2024 09:32:27 +0100 Message-ID: <275dd26c482b8eaccda7f6b1b174e0b4546002c3.1732782657.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6dGs_tyGkMMfhrqLN4nCK9GGRbIhiKQuV2UmxfkLqBM_1732782757 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QDZHXTCOY6YCHEC6MCSNKX2CX3FHJQ5H X-Message-ID-Hash: QDZHXTCOY6YCHEC6MCSNKX2CX3FHJQ5H X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732782865189019100 Content-Type: text/plain; charset="utf-8" Due to a bug in the optimization to avoid testing symlinked tests multiple times all tests were skipped. In commit f997fcca71a16b102e6ee663 I made an attempt to optimize the tests by avoiding testing symlinks. This optimization was buggy as I've passed the 'd_name' field of 'struct dirent' which is just the filename to 'g_lstat()'. 'g_lstat()' obviously always failed with ENOENT. As the logic checked only for successful return of 'g_lstat()' the optimizatio was a dud. Now in 4d8ebbfee83edb2 the 'g_lstat()' call was replaced by 'virFileIsLink()' checking all non-zero values. This meant that if 'virFileIsLink()' failed the test was skipped. Now since a bad argument was passed this failed always and thus was always skipped making 'virschematest' useless. Fix it by passing the full path of the test and also explicitly check for '1' return value instead of any non-zero. Fixes: f997fcca71a16b102e6ee663a3fb86bed8de9d7d Fixes: 4d8ebbfee83edb26b19a62465b9f98d0126db991 Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- tests/virschematest.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/virschematest.c b/tests/virschematest.c index 5d3fa32de4..e08ae21738 100644 --- a/tests/virschematest.c +++ b/tests/virschematest.c @@ -124,8 +124,6 @@ testSchemaDir(const char *schema, continue; if (ent->d_name[0] =3D=3D '.') continue; - if (virFileIsLink(ent->d_name)) - continue; if (filter && !g_regex_match(filter, ent->d_name, 0, NULL)) continue; @@ -134,11 +132,14 @@ testSchemaDir(const char *schema, g_strv_contains(entry->skip, ent->d_name)) continue; + xml_path =3D g_strdup_printf("%s/%s", dir_path, ent->d_name); + + if (virFileIsLink(xml_path) =3D=3D 1) + continue; + if (entry->exceptions) exception =3D g_strv_contains(entry->exceptions, ent->d_name); - xml_path =3D g_strdup_printf("%s/%s", dir_path, ent->d_name); - if (testSchemaFile(schema, validator, xml_path, exception) < 0) ret =3D -1; } --=20 2.47.0