On Tue, Nov 26, 2024 at 16:16:11 +0100, Peter Krempa wrote:
> Couple fixes for the <dataStore> feature when used with blockjobs:
> - fixes for qemuBlockReopenAccess (code driving 'blockdev-reopen' in
> qemu) for bugs noticed during testing of <dataStore>
> - the 'auto-read-only' qemu feature doesn't apply od the 'data-file'
> blockdevs, thus libvirt needs to handle them explicitly
> - lookup of the node name associated with the <dataStore> volume in the
> chains (for block threshold event handling)
>
> Peter Krempa (8):
> qemuBlockReopenAccess: Add debug log entry about state of the image
> qemuBlockReopenAccess: Fix update of 'readonly' state
> qemuBlockReopenAccess: Don't require backing chain terminator for
> non-chained images
> qemu: block: Ensure that <dataStore> is in appropriate state
> qemu: snapshot: Change 'data-file' to read-only after snapshot
> qemuDomainVirStorageSourceFindByNodeName: Extract nodename matching
> qemuDomainVirStorageSourceFindByNodeName: Match also '<dataStore>'
> sources
> qemuDomainGetStorageSourceByDevstr: Lookup also '<dataStore>'
>
> src/qemu/qemu_block.c | 60 +++++++++++++++++++++++++++++++---------
> src/qemu/qemu_blockjob.c | 16 ++++++++++-
> src/qemu/qemu_domain.c | 38 +++++++++++++++++++++----
> src/qemu/qemu_snapshot.c | 12 ++++++--
> 4 files changed, 105 insertions(+), 21 deletions(-)
After addressing my comments in 5/8 and 6/8...
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>