[PATCH 0/9] qemu: snapshot: Fix internal snapshot reversion with NVRAM image

Peter Krempa posted 9 patches 3 weeks ago
src/qemu/qemu_block.c                         |   1 +
src/qemu/qemu_blockjob.c                      |   2 +
src/qemu/qemu_blockjob.h                      |   1 +
src/qemu/qemu_command.c                       |   5 +-
src/qemu/qemu_conf.h                          |   3 -
src/qemu/qemu_domain.c                        | 106 +----
src/qemu/qemu_domain.h                        |   8 -
src/qemu/qemu_driver.c                        |   3 -
src/qemu/qemu_monitor.c                       |  16 +
src/qemu/qemu_monitor.h                       |  19 +-
src/qemu/qemu_monitor_json.c                  |  49 +-
src/qemu/qemu_monitor_json.h                  |   7 +
src/qemu/qemu_process.c                       |   7 +
src/qemu/qemu_snapshot.c                      | 437 ++++++++++++++++--
src/qemu/qemu_snapshot.h                      |   5 +
tests/qemublocktest.c                         |  14 +-
.../bitmap/snapshots-internal.out             |   2 +-
17 files changed, 511 insertions(+), 174 deletions(-)
[PATCH 0/9] qemu: snapshot: Fix internal snapshot reversion with NVRAM image
Posted by Peter Krempa 3 weeks ago
This series fixes two things:

 - inactive snapshot handling with NVRAM image
 - use of '-loadvm' commandline option to revert snapshots, both are
   individually described

Peter Krempa (9):
  qemu: Don't store path to qemu img
  qemuDomainSnapshotForEachQcow2Raw: Remove 'driver' argument
  qemu: Move 'qemuDomainSnapshotForEachQcow2(Raw)' to qemu_snapshot.c
  qemuSnapshotForEachQcow2: Refactor
  qemuSnapshotForEachQcow2: Handle also NVRAM image for internal
    snapshots
  qemu: monitor: Add monitor infrastructure for 'snapshot-load' QMP
    command
  qemu: Add enum entries for 'snapshot-load' qemu job
  qemu: monitor: Extract vmstate presence for internal snapshots in
    qemuBlockGetNamedNodeData
  qemu: Avoid use of '-loadvm' commandline argument for internal
    snapshot reversion

 src/qemu/qemu_block.c                         |   1 +
 src/qemu/qemu_blockjob.c                      |   2 +
 src/qemu/qemu_blockjob.h                      |   1 +
 src/qemu/qemu_command.c                       |   5 +-
 src/qemu/qemu_conf.h                          |   3 -
 src/qemu/qemu_domain.c                        | 106 +----
 src/qemu/qemu_domain.h                        |   8 -
 src/qemu/qemu_driver.c                        |   3 -
 src/qemu/qemu_monitor.c                       |  16 +
 src/qemu/qemu_monitor.h                       |  19 +-
 src/qemu/qemu_monitor_json.c                  |  49 +-
 src/qemu/qemu_monitor_json.h                  |   7 +
 src/qemu/qemu_process.c                       |   7 +
 src/qemu/qemu_snapshot.c                      | 437 ++++++++++++++++--
 src/qemu/qemu_snapshot.h                      |   5 +
 tests/qemublocktest.c                         |  14 +-
 .../bitmap/snapshots-internal.out             |   2 +-
 17 files changed, 511 insertions(+), 174 deletions(-)

-- 
2.47.0
Re: [PATCH 0/9] qemu: snapshot: Fix internal snapshot reversion with NVRAM image
Posted by Michal Prívozník 3 weeks ago
On 11/15/24 09:39, Peter Krempa wrote:
> This series fixes two things:
> 
>  - inactive snapshot handling with NVRAM image
>  - use of '-loadvm' commandline option to revert snapshots, both are
>    individually described
> 
> Peter Krempa (9):
>   qemu: Don't store path to qemu img
>   qemuDomainSnapshotForEachQcow2Raw: Remove 'driver' argument
>   qemu: Move 'qemuDomainSnapshotForEachQcow2(Raw)' to qemu_snapshot.c
>   qemuSnapshotForEachQcow2: Refactor
>   qemuSnapshotForEachQcow2: Handle also NVRAM image for internal
>     snapshots
>   qemu: monitor: Add monitor infrastructure for 'snapshot-load' QMP
>     command
>   qemu: Add enum entries for 'snapshot-load' qemu job
>   qemu: monitor: Extract vmstate presence for internal snapshots in
>     qemuBlockGetNamedNodeData
>   qemu: Avoid use of '-loadvm' commandline argument for internal
>     snapshot reversion
> 
>  src/qemu/qemu_block.c                         |   1 +
>  src/qemu/qemu_blockjob.c                      |   2 +
>  src/qemu/qemu_blockjob.h                      |   1 +
>  src/qemu/qemu_command.c                       |   5 +-
>  src/qemu/qemu_conf.h                          |   3 -
>  src/qemu/qemu_domain.c                        | 106 +----
>  src/qemu/qemu_domain.h                        |   8 -
>  src/qemu/qemu_driver.c                        |   3 -
>  src/qemu/qemu_monitor.c                       |  16 +
>  src/qemu/qemu_monitor.h                       |  19 +-
>  src/qemu/qemu_monitor_json.c                  |  49 +-
>  src/qemu/qemu_monitor_json.h                  |   7 +
>  src/qemu/qemu_process.c                       |   7 +
>  src/qemu/qemu_snapshot.c                      | 437 ++++++++++++++++--
>  src/qemu/qemu_snapshot.h                      |   5 +
>  tests/qemublocktest.c                         |  14 +-
>  .../bitmap/snapshots-internal.out             |   2 +-
>  17 files changed, 511 insertions(+), 174 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal