From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 173079355916977.25199564723869; Mon, 4 Nov 2024 23:59:19 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 04CDE13E7; Tue, 5 Nov 2024 02:59:17 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EF0EF12BC; Tue, 5 Nov 2024 02:58:20 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id C5DF4E76; Tue, 5 Nov 2024 02:58:17 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4B2D8E72 for ; Tue, 5 Nov 2024 02:58:17 -0500 (EST) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-dHNOfnDXMG-lBry-bIOTQA-1; Tue, 05 Nov 2024 02:58:15 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12B791955BF2 for ; Tue, 5 Nov 2024 07:58:15 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 434EF300018D for ; Tue, 5 Nov 2024 07:58:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fl0INLD3RhpLLuM4dKrAcip8Bxxi7pDGAPOFdcCdtZY=; b=M59cxoDwyDVRNuqpz+Uf2LsyfwyFep/yzRNi0Q9ObhPGVmC1wm9jSOFN0VRcq7OVFBkwv/ V0efCS25VdmDhr+Nd3BNyy+yqM/STjq0vcpOWJopwppUrXKIr0BZKqy9tN446SVM6EQTxp 4IpDJbyBKsv1EJzKGWqXOY6FcknbmQs= X-MC-Unique: dHNOfnDXMG-lBry-bIOTQA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 01/13] qemuPrepareNVRAM: Don't attempt to create NVRAM on block device Date: Tue, 5 Nov 2024 08:57:59 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FZ5IV32NSEN3TAXXWNK77GYIIS5Y72OH X-Message-ID-Hash: FZ5IV32NSEN3TAXXWNK77GYIIS5Y72OH X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793560339116600 Content-Type: text/plain; charset="utf-8" 'virFileRewrite()' which is used to setup the NVRAM image if it doesn't exist or when it is requested by the user forcibly replaces the destination file by the file it creates. For block devices this overwrites the device node file or the symlink pointing to the device node by a regular file instead of formatting it. As this not only makes the VM fail to start but also breaks user's /dev/ filesystem forbid it for now. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/qemu/qemu_process.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0815bffe3c..7a40e09d47 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4609,6 +4609,14 @@ qemuPrepareNVRAM(virQEMUDriver *driver, if (virFileExists(loader->nvram->path) && !reset_nvram) return 0; + /* virFileRewrite() would overwrite the device node-file/symlink rathe= r than + * just write the data to it, thus block-device nvram is not yet suppo= rted */ + if (virStorageSourceIsBlockLocal(loader->nvram)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("creation or formatting of nvram type=3D'block' i= s not supported")); + return -1; + } + if (!loader->nvramTemplate) { virReportError(VIR_ERR_OPERATION_FAILED, _("unable to find any master var store for loader: = %1$s"), --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793587680833.0799006569073; Mon, 4 Nov 2024 23:59:47 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8E0431255; Tue, 5 Nov 2024 02:59:46 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AF36911B1; Tue, 5 Nov 2024 02:58:24 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 3D1FDE72; Tue, 5 Nov 2024 02:58:19 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AEF10D94 for ; Tue, 5 Nov 2024 02:58:18 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-jVfJR_EuOW-CYnHfXfghEQ-1; Tue, 05 Nov 2024 02:58:17 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 587531955E99 for ; Tue, 5 Nov 2024 07:58:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 901A53000198 for ; Tue, 5 Nov 2024 07:58:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azipwOFJWD6xW51TJ0TjdvYE9PDsracNMkKH22NihSI=; b=RUrOfX9WFzUZ1QFsEKKXqXCoqOTaqW1Q4okAQ0mhAxb9J6jlZan6owzO7Q0sz9WUsaGlyN KZySwOdwPXxkXPvASBsAzFvinrQT/tVI35hS7gME56fGKdT+miH7JBDcWcNc602CS1YD71 FSDMHbH1xPorXti9I0Ft/N4x12EP/vg= X-MC-Unique: jVfJR_EuOW-CYnHfXfghEQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 02/13] qemuFirmwareEnsureNVRAM: Don't try to setup non-local nvram Date: Tue, 5 Nov 2024 08:58:00 +0100 Message-ID: <3da8e66ee4360ad2e0171aff339fdd3c1cecb23c.1730793407.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: E75VS2CNN6W5HMO5PHM4V7EXMAB7X54F X-Message-ID-Hash: E75VS2CNN6W5HMO5PHM4V7EXMAB7X54F X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793588750116600 Content-Type: text/plain; charset="utf-8" 'qemuFirmwareEnsureNVRAM' which fills the NVRAM configuration bits which may be missing was basing it's decision to do something based on whether the 'path' field was set. This is insufficient if remote storage is to be considered. Use 'virStorageSourceIsEmpty()' instead as that properly considers remote filesystems and explain why the source is unref'd when the function decides to rewrite the config. The 'firmware-auto-efi-format-nvram-qcow2-network-nbd' is modified to omit filling the 'path' field, which without this fix would result in the nvram to be reset to a local file. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/qemu/qemu_firmware.c | 11 ++++++----- ...-format-nvram-qcow2-network-nbd.x86_64-latest.args | 2 +- ...i-format-nvram-qcow2-network-nbd.x86_64-latest.xml | 2 +- ...rmware-auto-efi-format-nvram-qcow2-network-nbd.xml | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 914f8596bd..5c247b1cf2 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1054,13 +1054,14 @@ qemuFirmwareEnsureNVRAM(virDomainDef *def, if (loader->nvram && !loader->nvram->format) loader->nvram->format =3D loader->format; - /* If the source already exists and is fully specified, including - * the path, leave it alone */ - if (loader->nvram && loader->nvram->path) - return; + if (loader->nvram) { + /* Nothing to do if a proper NVRAM backend is already configured */ + if (!virStorageSourceIsEmpty(loader->nvram)) + return; - if (loader->nvram) + /* otherwise we want to reset and re-populate the definition */ virObjectUnref(loader->nvram); + } loader->nvram =3D virStorageSourceNew(); loader->nvram->type =3D VIR_STORAGE_TYPE_FILE; diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-net= work-nbd.x86_64-latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-forma= t-nvram-qcow2-network-nbd.x86_64-latest.args index 77babdc147..f78b4e7abf 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.x86_64-latest.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,"discard= ":"unmap"}' \ -blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ --blockdev '{"driver":"nbd","server":{"type":"inet","host":"example.org","p= ort":"6000"},"export":"bar","node-name":"libvirt-pflash1-storage","auto-rea= d-only":true,"discard":"unmap"}' \ +-blockdev '{"driver":"nbd","server":{"type":"inet","host":"example.org","p= ort":"6000"},"node-name":"libvirt-pflash1-storage","auto-read-only":true,"d= iscard":"unmap"}' \ -blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ -machine pc-i440fx-4.0,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc= .ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-format,acpi= =3Don \ -accel tcg \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-net= work-nbd.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format= -nvram-qcow2-network-nbd.x86_64-latest.xml index 35865b23c5..cc87905306 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/e= dk2/ovmf/OVMF_CODE_4M.qcow2 - + diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-net= work-nbd.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-n= etwork-nbd.xml index 0028bde4d7..d604840edd 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.xml @@ -6,7 +6,7 @@ hvm - + --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793639712701.853837647758; Tue, 5 Nov 2024 00:00:39 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 959EB11C5; Tue, 5 Nov 2024 03:00:38 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AEB0412E9; Tue, 5 Nov 2024 02:58:47 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id DA27812CA; Tue, 5 Nov 2024 02:58:42 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5B98611AF for ; Tue, 5 Nov 2024 02:58:20 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-hXYYvgjBNKOlXbCPlpvCKA-1; Tue, 05 Nov 2024 02:58:18 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E1E5A1955F57 for ; Tue, 5 Nov 2024 07:58:17 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D55F23000198 for ; Tue, 5 Nov 2024 07:58:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nmw/5TqDBbM0ibMyr1WRIsU3PzLy70IRRxwu5n9CTUw=; b=SOLsqNlWQuqmtDfaaQt3Lwj6qhoPFUkG1VxhNdU7gKVt451bsJ1Q+49iRYIQad5gkyJKOV IqaoAlTg8ACrKQ8yXHk9Uic9ri337Q2ILO7KpQhnhE3a55mN/p6bYEZRNzN67rsnxTDDlX 496Rs52Nq03pInq6B5nWEayPsnwu/L0= X-MC-Unique: hXYYvgjBNKOlXbCPlpvCKA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 03/13] qemu: Install backing store terminators for 'pflash' blockdevs Date: Tue, 5 Nov 2024 08:58:01 +0100 Message-ID: <475b11967bbdb0054fc43f040a13cec8a9b91af6.1730793407.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: F6IQ4R3H7FIJVIGIZAN6COVG2HPZURB3 X-Message-ID-Hash: F6IQ4R3H7FIJVIGIZAN6COVG2HPZURB3 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793641444116600 Content-Type: text/plain; charset="utf-8" The qemu driver does support qcow2 images for the firmware and nvram pflash devices, but we do not do the full backing chain setup for them as we don't expect that those images would actually have a backing store. We don't tell that to qemu though which theoretically can lead to qemu probing the backing store from the image itself. We don't want that for now. Deny qemu probing the backing store by installing a "terminator" empty virStorageSource as 'backingStore' for pflash and nvram. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/qemu/qemu_domain.c | 2 ++ .../firmware-auto-efi-aarch64.aarch64-latest.abi-update.args | 4 ++-- ...auto-efi-format-loader-qcow2-nvram-path.x86_64-latest.args | 4 ++-- .../firmware-auto-efi-format-loader-qcow2.x86_64-latest.args | 4 ++-- ...auto-efi-format-nvram-qcow2-network-nbd.x86_64-latest.args | 4 ++-- ...rmware-auto-efi-format-nvram-qcow2-path.x86_64-latest.args | 4 ++-- .../firmware-auto-efi-format-nvram-qcow2.x86_64-latest.args | 4 ++-- ...mware-auto-efi-loader-secure.x86_64-latest.abi-update.args | 4 ++-- .../firmware-auto-efi-riscv64.riscv64-latest.abi-update.args | 4 ++-- .../firmware-auto-efi.x86_64-latest.abi-update.args | 4 ++-- 10 files changed, 20 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7b702cfc6b..a256775960 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -12069,11 +12069,13 @@ qemuDomainInitializePflashStorageSource(virDomain= Obj *vm, pflash0->format =3D def->os.loader->format; pflash0->path =3D g_strdup(def->os.loader->path); pflash0->readonly =3D false; + pflash0->backingStore =3D virStorageSourceNew(); /* terminator */ virTristateBoolToBool(def->os.loader->readonly, &pflash0->readonly); qemuBlockStorageSourceSetFormatNodename(pflash0, g_strdup("libvirt-pfl= ash0-format")); qemuBlockStorageSourceSetStorageNodename(pflash0, g_strdup("libvirt-pf= lash0-storage")); if (def->os.loader->nvram) { + def->os.loader->nvram->backingStore =3D virStorageSourceNew(); /* = terminator */ if (qemuDomainPrepareStorageSourceBlockdevNodename(NULL, def->os.loader-= >nvram, "libvirt-pflash= 1", diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest= .abi-update.args b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-= latest.abi-update.args index 30f86aa046..3e20cb4aa5 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.abi-up= date.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.abi-up= date.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/aarch64/QEMU_EFI-s= ilent-pflash.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":= true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.qcow2","node-name":"libvirt-pflash1-storage","auto-read-only":true,"di= scard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine virt-4.0,usb=3Doff,gic-version=3D2,dump-guest-core=3Doff,memory-b= ackend=3Dmach-virt.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-p= flash1-format,acpi=3Don \ -accel tcg \ -cpu cortex-a15 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-nv= ram-path.x86_64-latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-forma= t-loader-qcow2-nvram-path.x86_64-latest.args index e8d7d580f7..2694e0676f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-nvram-pat= h.x86_64-latest.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-nvram-pat= h.x86_64-latest.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= secboot.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,= "discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/path/to/guest_VARS.qcow2","node-n= ame":"libvirt-pflash1-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine pc-q35-4.0,usb=3Doff,smm=3Don,dump-guest-core=3Doff,memory-backen= d=3Dpc.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-forma= t,acpi=3Don \ -accel kvm \ -cpu qemu64 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2.x8= 6_64-latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qc= ow2.x86_64-latest.args index 790fb619e8..2bc7a1b9d5 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2.x86_64-la= test.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2.x86_64-la= test.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= secboot.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,= "discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.qcow2","node-name":"libvirt-pflash1-storage","auto-read-only":true,"di= scard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine pc-q35-4.0,usb=3Doff,smm=3Don,dump-guest-core=3Doff,memory-backen= d=3Dpc.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-forma= t,acpi=3Don \ -accel kvm \ -cpu qemu64 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-net= work-nbd.x86_64-latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-forma= t-nvram-qcow2-network-nbd.x86_64-latest.args index f78b4e7abf..e8e6157f67 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.x86_64-latest.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-network-nb= d.x86_64-latest.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,"discard= ":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"nbd","server":{"type":"inet","host":"example.org","p= ort":"6000"},"node-name":"libvirt-pflash1-storage","auto-read-only":true,"d= iscard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine pc-i440fx-4.0,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc= .ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-format,acpi= =3Don \ -accel tcg \ -cpu qemu64 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-pat= h.x86_64-latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram= -qcow2-path.x86_64-latest.args index e8d7d580f7..2694e0676f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-path.x86_6= 4-latest.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-path.x86_6= 4-latest.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= secboot.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,= "discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/path/to/guest_VARS.qcow2","node-n= ame":"libvirt-pflash1-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine pc-q35-4.0,usb=3Doff,smm=3Don,dump-guest-core=3Doff,memory-backen= d=3Dpc.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-forma= t,acpi=3Don \ -accel kvm \ -cpu qemu64 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2.x86= _64-latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow= 2.x86_64-latest.args index 790fb619e8..2bc7a1b9d5 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2.x86_64-lat= est.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2.x86_64-lat= est.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= secboot.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,= "discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.qcow2","node-name":"libvirt-pflash1-storage","auto-read-only":true,"di= scard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine pc-q35-4.0,usb=3Doff,smm=3Don,dump-guest-core=3Doff,memory-backen= d=3Dpc.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-forma= t,acpi=3Don \ -accel kvm \ -cpu qemu64 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-l= atest.abi-update.args b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secu= re.x86_64-latest.abi-update.args index 790fb619e8..2bc7a1b9d5 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.a= bi-update.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.a= bi-update.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= secboot.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,= "discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.qcow2","node-name":"libvirt-pflash1-storage","auto-read-only":true,"di= scard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine pc-q35-4.0,usb=3Doff,smm=3Don,dump-guest-core=3Doff,memory-backen= d=3Dpc.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-forma= t,acpi=3Don \ -accel kvm \ -cpu qemu64 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-latest= .abi-update.args b/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-= latest.abi-update.args index e10575bf81..f467f71d72 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-latest.abi-up= date.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-latest.abi-up= date.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/riscv/RISCV_VIRT_C= ODE.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,"dis= card":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.qcow2","node-name":"libvirt-pflash1-storage","auto-read-only":true,"di= scard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine virt,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Driscv_virt_= board.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-format= ,acpi=3Doff \ -accel tcg \ -cpu rv64 \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-upda= te.args b/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-update.= args index 790fb619e8..2bc7a1b9d5 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-update.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-update.args @@ -11,9 +11,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ -blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE_4M.= secboot.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,= "discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"qcow2","file":"libvirt-pflash0-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.qcow2","node-name":"libvirt-pflash1-storage","auto-read-only":true,"di= scard":"unmap"}' \ --blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"qcow2","file":"libvirt-pflash1-storage","backing":null}' \ -machine pc-q35-4.0,usb=3Doff,smm=3Don,dump-guest-core=3Doff,memory-backen= d=3Dpc.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-forma= t,acpi=3Don \ -accel kvm \ -cpu qemu64 \ --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793661801963.9228953163218; Tue, 5 Nov 2024 00:01:01 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id C0EBE1274; Tue, 5 Nov 2024 03:01:00 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 633FC130A; Tue, 5 Nov 2024 02:58:49 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 02DD1E7C; Tue, 5 Nov 2024 02:58:42 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AF4D512C2 for ; Tue, 5 Nov 2024 02:58:21 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-MR51IOf5Pc2mQkFnWIReow-1; Tue, 05 Nov 2024 02:58:20 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 402D21955DAE for ; Tue, 5 Nov 2024 07:58:19 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 70F4B300018D for ; Tue, 5 Nov 2024 07:58:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=utidtcVR9o4EKzdVaDFyGkvb/0IeijVPGdjqIW+W6cQ=; b=L5JKhKyIPtpSs2PmQeBxSHHCvTPf+3IFvxDlGklsPUMO51i/5r10K+jN+eWz6mQhQ2K84k MzTzBMf/ZRk7RqymbgNY3b2hebfQFuhEekULzJLZ2eDEX2unvwlqdded/cO3kMWgIgCdkg STf/EW6QHfEy15jjSRGY6aHyiG/SvHk= X-MC-Unique: MR51IOf5Pc2mQkFnWIReow-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 04/13] conf: domain: Clarify nvram/loader format logic Date: Tue, 5 Nov 2024 08:58:02 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZSBCPTEH2ZAU5CYBT6CCQL3CS6KMR7NO X-Message-ID-Hash: ZSBCPTEH2ZAU5CYBT6CCQL3CS6KMR7NO X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793663083116600 Content-Type: text/plain; charset="utf-8" Restructure the code to assign first (as this is simpler to refactor in the future) and avoid mixing implicit value checks with explicit ones by checking for _NONE. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6d7dee7956..4dda943c73 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17129,15 +17129,16 @@ virDomainLoaderDefParseXMLNvram(virDomainLoaderDe= f *loader, &format, VIR_STORAGE_FILE_NONE) < 0) { return -1; } - if (format && - format !=3D VIR_STORAGE_FILE_RAW && - format !=3D VIR_STORAGE_FILE_QCOW2) { + src->format =3D format; + + if (src->format !=3D VIR_STORAGE_FILE_NONE && + src->format !=3D VIR_STORAGE_FILE_RAW && + src->format !=3D VIR_STORAGE_FILE_QCOW2) { virReportError(VIR_ERR_XML_ERROR, _("Unsupported nvram format '%1$s'"), - virStorageFileFormatTypeToString(format)); + virStorageFileFormatTypeToString(src->format)); return -1; } - src->format =3D format; if ((typePresent =3D virXMLPropEnum(nvramNode, "type", virStorageTypeFromString, VIR_XML_PR= OP_NONE, @@ -17219,15 +17220,17 @@ virDomainLoaderDefParseXMLLoader(virDomainLoaderD= ef *loader, &format, VIR_STORAGE_FILE_NONE) < 0) { return -1; } - if (format && - format !=3D VIR_STORAGE_FILE_RAW && - format !=3D VIR_STORAGE_FILE_QCOW2) { + + loader->format =3D format; + + if (loader->format !=3D VIR_STORAGE_FILE_NONE && + loader->format !=3D VIR_STORAGE_FILE_RAW && + loader->format !=3D VIR_STORAGE_FILE_QCOW2) { virReportError(VIR_ERR_XML_ERROR, _("Unsupported loader format '%1$s'"), - virStorageFileFormatTypeToString(format)); + virStorageFileFormatTypeToString(loader->format)); return -1; } - loader->format =3D format; return 0; } --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793702812873.1469372823974; Tue, 5 Nov 2024 00:01:42 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id AA1EBC32; Tue, 5 Nov 2024 03:01:41 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3EC4E1293; Tue, 5 Nov 2024 02:58:52 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 2074312E9; Tue, 5 Nov 2024 02:58:44 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 48F7AE76 for ; Tue, 5 Nov 2024 02:58:23 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-J737TMyfN2mgqVyHgbNApQ-1; Tue, 05 Nov 2024 02:58:21 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A3D6F19560BD for ; Tue, 5 Nov 2024 07:58:20 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B796D3000198 for ; Tue, 5 Nov 2024 07:58:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qdJGdPL4ywbNGj89exeTqTEFlB4NK1YxsYvjIowLLbo=; b=RX4XlgSuftBvlbe2EH2uzOIpdTn0nxsFpz1HqMy5Ko23LAqnMn0yP5sXNQZyS9jX5+ZCLC +t0fnQTC0r4nb7UROPmpWRFAnrlcJPc6jhHMzubtsbbkoWW2OB0jvBM8bQQAqRdxeZOyqc NhDaCkLJax8wCJVx/NHHexvLjW+Ni38= X-MC-Unique: J737TMyfN2mgqVyHgbNApQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 05/13] docs: formatdomain: Clarify that NVRAM template is also being autoselected Date: Tue, 5 Nov 2024 08:58:03 +0100 Message-ID: <8c0df6f78ee82527b6b2c763bf6b7efa57e26d55.1730793407.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: AFQ7UXXHAKKF7GFMT3M4ZQUGUF7SCR4I X-Message-ID-Hash: AFQ7UXXHAKKF7GFMT3M4ZQUGUF7SCR4I X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793703173116600 Content-Type: text/plain; charset="utf-8" The NVRAM template file may be autoselected same as the loader/firmware image. Add a hint that this can occur and also that it doesn't necessarily need to be from the 'qemu.conf' configured files. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- docs/formatdomain.rst | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d16e00661a..f6d86b26f4 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -268,12 +268,14 @@ harddisk, cdrom, network) determining where to obtain= /find the boot image. Some UEFI firmwares may want to use a non-volatile memory to store some variables. In the host, this is represented as a file and the absolute = path to the file is stored in this element. Moreover, when the domain is sta= rted - up libvirt copies so called master NVRAM store file defined in ``qemu.c= onf``. - If needed, the ``template`` attribute can be used to per domain overrid= e map - of master NVRAM stores from the config file. Note, that for transient d= omains - if the NVRAM file has been created by libvirt it is left behind and it = is - management application's responsibility to save and remove file (if nee= ded to - be persistent). :since:`Since 1.2.8` + up libvirt copies so called master NVRAM store file either selected by = the + firmware autoselection process or defined in ``qemu.conf``. + If needed, the ``template`` attribute can be used to override the + automatically chosen NVRAM template. + + Note, that for transient domains if the NVRAM file has been created by + libvirt it is left behind and it is management application's responsibi= lity + to save and remove file (if needed to be persistent). :since:`Since 1.2= .8` :since:`Since 8.5.0`, it's possible for the element to have ``type`` a= ttribute (accepts values ``file``, ``block`` and ``network``) in that case the N= VRAM --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793802924535.5289449603442; Tue, 5 Nov 2024 00:03:22 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 9310C11FD; Tue, 5 Nov 2024 03:03:21 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 98319129C; Tue, 5 Nov 2024 02:58:53 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 64D021219; Tue, 5 Nov 2024 02:58:47 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A781912CE for ; Tue, 5 Nov 2024 02:58:24 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-oQ8xUmCUOg-hciz6t2ZxuA-1; Tue, 05 Nov 2024 02:58:22 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0BAAD1954B03 for ; Tue, 5 Nov 2024 07:58:22 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 09319300018D for ; Tue, 5 Nov 2024 07:58:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dMNSVrpwDQJgeoH0mQ+pg9/worRsI876/PPq/0ailHo=; b=Dp5Fczmunw0lHk2Aa5oZ6WUdepr0LlhYsGBzATyOHsabBBe/MRzLggMZzCR1nemEMuPmD0 qJjwzvG2LjwdGQ07Y0V9OYQtodNxpt4xXfnReSBGB9c3eQSW8fPkzFDR+QoudGYhKlm6B4 1oHfi+6jgLKi6z/si7uKiVSi/pZ2Plw= X-MC-Unique: oQ8xUmCUOg-hciz6t2ZxuA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 06/13] firmware: Add 'templateFormat' XML attribute and plumb it in Date: Tue, 5 Nov 2024 08:58:04 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EJEDS7XW7KRGXCCRB7MTVIXAEE3466OF X-Message-ID-Hash: EJEDS7XW7KRGXCCRB7MTVIXAEE3466OF X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793804244116600 Content-Type: text/plain; charset="utf-8" Currently the qemu firmware code weirdly depends on the 'format' field of the nvram image itself to do the auto-selection process as well as then uses it to declare the actual type to qemu. As it's not technically required that the template and the on disk image share the type introduce a 'templateFormat' field which will split off from the shared purpose of the type and will be used for the selection and instantiation process, while 'format' will be left for the actual type of the on disk image. This patch introduces the field, adds XML infrastructure as well as plumbs it to the firmware bits. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- docs/formatdomain.rst | 10 ++++--- src/conf/domain_conf.c | 21 ++++++++++++++ src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng | 17 ++++++++--- src/qemu/qemu_firmware.c | 29 +++++++++++++++---- .../aarch64-virt-graphics.aarch64-latest.xml | 2 +- ...ch64-virt-headless-mmio.aarch64-latest.xml | 2 +- .../aarch64-virt-headless.aarch64-latest.xml | 2 +- ...-efi-aarch64.aarch64-latest.abi-update.xml | 2 +- ...rmware-auto-efi-aarch64.aarch64-latest.xml | 2 +- ...e-auto-efi-enrolled-keys.x86_64-latest.xml | 2 +- ...-loader-qcow2-nvram-path.x86_64-latest.xml | 2 +- ...-efi-format-loader-qcow2.x86_64-latest.xml | 2 +- ...t-loader-raw.aarch64-latest.abi-update.xml | 2 +- ...o-efi-format-loader-raw.aarch64-latest.xml | 2 +- ...-format-nvram-qcow2-path.x86_64-latest.xml | 2 +- ...o-efi-format-nvram-qcow2.x86_64-latest.xml | 2 +- ...auto-efi-loader-insecure.x86_64-latest.xml | 2 +- ...are-auto-efi-loader-path.x86_64-latest.xml | 2 +- ...loader-secure.x86_64-latest.abi-update.xml | 2 +- ...e-auto-efi-loader-secure.x86_64-latest.xml | 2 +- ...ngarch64.loongarch64-latest.abi-update.xml | 2 +- ...uto-efi-loongarch64.loongarch64-latest.xml | 2 +- ...uto-efi-no-enrolled-keys.x86_64-latest.xml | 2 +- ...ware-auto-efi-no-secboot.x86_64-latest.xml | 2 +- ...ware-auto-efi-nvram-file.x86_64-latest.xml | 2 +- ...ware-auto-efi-nvram-path.x86_64-latest.xml | 2 +- ...-auto-efi-nvram-template.x86_64-latest.xml | 2 +- ...-efi-riscv64.riscv64-latest.abi-update.xml | 2 +- ...irmware-auto-efi-secboot.x86_64-latest.xml | 2 +- ...irmware-auto-efi-smm-off.x86_64-latest.xml | 2 +- ...ware-auto-efi.x86_64-latest.abi-update.xml | 2 +- .../firmware-auto-efi.x86_64-latest.xml | 2 +- ...fi-aarch64-legacy-paths.aarch64-latest.xml | 2 +- ...manual-efi-acpi-aarch64.aarch64-latest.xml | 2 +- ...ware-manual-efi-acpi-q35.x86_64-latest.xml | 2 +- ...ware-manual-efi-features.x86_64-latest.xml | 2 +- ...manual-efi-loader-secure.x86_64-latest.xml | 2 +- ...rolled-keys-legacy-paths.x86_64-latest.xml | 2 +- ...ual-efi-no-enrolled-keys.x86_64-latest.xml | 2 +- ...-no-secboot-legacy-paths.x86_64-latest.xml | 2 +- ...re-manual-efi-no-secboot.x86_64-latest.xml | 2 +- ...nual-efi-noacpi-aarch64.aarch64-latest.xml | 2 +- ...re-manual-efi-nvram-file.x86_64-latest.xml | 2 +- ...anual-efi-nvram-template.x86_64-latest.xml | 2 +- ...efi-secboot-legacy-paths.x86_64-latest.xml | 2 +- ...mware-manual-efi-secboot.x86_64-latest.xml | 2 +- .../firmware-manual-efi.x86_64-latest.xml | 2 +- ...f-aarch64-virt-headless.aarch64-latest.xml | 2 +- .../hvf-x86_64-q35-headless.x86_64-latest.xml | 2 +- .../pvpanic-pci-aarch64.aarch64-latest.xml | 2 +- ...-pci-no-address-aarch64.aarch64-latest.xml | 2 +- .../virtio-iommu-aarch64.aarch64-latest.xml | 2 +- 53 files changed, 113 insertions(+), 61 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index f6d86b26f4..8a4e643c97 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -271,7 +271,10 @@ harddisk, cdrom, network) determining where to obtain/= find the boot image. up libvirt copies so called master NVRAM store file either selected by = the firmware autoselection process or defined in ``qemu.conf``. If needed, the ``template`` attribute can be used to override the - automatically chosen NVRAM template. + automatically chosen NVRAM template and ``templateFormat`` to specify t= he + format for the template file (currently supported are ``raw`` and ``qco= w2``). + When firmware auto-selection is in use the ``templateFormat`` field ref= lects + the format of the picked template. :since:`Since 10.10.0 (QEMU only)` Note, that for transient domains if the NVRAM file has been created by libvirt it is left behind and it is management application's responsibi= lity @@ -285,9 +288,8 @@ harddisk, cdrom, network) determining where to obtain/f= ind the boot image. **Note:** ``network`` backed NVRAM the variables are not instantiated f= rom the ``template`` and it's user's responsibility to provide a valid NVRA= M image. - This element supports a ``format`` attribute, which has the same semant= ics - as the attribute of the same name for the ```` element. - :since:`Since 9.2.0 (QEMU only)` + This element supports a ``format`` attribute, which specifies the format + of the NVRAM image. :since:`Since 9.2.0 (QEMU only)` It is not valid to provide this element if the loader is marked as stateless. diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4dda943c73..744bc1ac34 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17124,6 +17124,22 @@ virDomainLoaderDefParseXMLNvram(virDomainLoaderDef= *loader, loader->nvramTemplate =3D virXMLPropString(nvramNode, "template"); + if (virXMLPropEnumDefault(nvramNode, "templateFormat", + virStorageFileFormatTypeFromString, VIR_XML_= PROP_NONE, + &format, VIR_STORAGE_FILE_NONE) < 0) { + return -1; + } + loader->nvramTemplateFormat =3D format; + + if (loader->nvramTemplateFormat !=3D VIR_STORAGE_FILE_NONE && + loader->nvramTemplateFormat !=3D VIR_STORAGE_FILE_RAW && + loader->nvramTemplateFormat !=3D VIR_STORAGE_FILE_QCOW2) { + virReportError(VIR_ERR_XML_ERROR, + _("Unsupported nvram template format '%1$s'"), + virStorageFileFormatTypeToString(loader->nvramTempl= ateFormat)); + return -1; + } + if (virXMLPropEnumDefault(nvramNode, "format", virStorageFileFormatTypeFromString, VIR_XML_= PROP_NONE, &format, VIR_STORAGE_FILE_NONE) < 0) { @@ -26796,6 +26812,11 @@ virDomainLoaderDefFormatNvram(virBuffer *buf, virBufferEscapeString(&attrBuf, " template=3D'%s'", loader->nvramTempl= ate); + if (loader->nvramTemplateFormat > VIR_STORAGE_FILE_NONE) { + virBufferAsprintf(&attrBuf, " templateFormat=3D'%s'", + virStorageFileFormatTypeToString(loader->nvramTe= mplateFormat)); + } + if (loader->nvram) { virStorageSource *src =3D loader->nvram; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index a15af4fae3..62de6f1003 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2337,6 +2337,7 @@ struct _virDomainLoaderDef { virStorageSource *nvram; bool newStyleNVRAM; char *nvramTemplate; /* user override of path to master nvram */ + virStorageFileFormat nvramTemplateFormat; }; virDomainLoaderDef *virDomainLoaderDefNew(void); diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index efb5f00d77..28797d0122 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -348,6 +348,11 @@ + + + + + @@ -7857,12 +7862,16 @@ + + + raw + qcow2 + + + - - raw - qcow2 - + diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 5c247b1cf2..d9d21b4771 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1065,7 +1065,13 @@ qemuFirmwareEnsureNVRAM(virDomainDef *def, loader->nvram =3D virStorageSourceNew(); loader->nvram->type =3D VIR_STORAGE_TYPE_FILE; - loader->nvram->format =3D loader->format; + + /* The nvram template format should be always present but as a failsaf= e, + * duplicate the loader format if it is not available. */ + if (loader->nvramTemplateFormat > VIR_STORAGE_FILE_NONE) + loader->nvram->format =3D loader->nvramTemplateFormat; + else + loader->nvram->format =3D loader->format; if (loader->nvram->format =3D=3D VIR_STORAGE_FILE_RAW) { /* The extension used by raw edk2 builds has historically @@ -1422,8 +1428,16 @@ qemuFirmwareEnableFeaturesModern(virDomainDef *def, * We can't create or reset non-local NVRAM files, so filling * in nvramTemplate for those would be misleading */ VIR_FREE(loader->nvramTemplate); - if (!loader->nvram || - (loader->nvram && virStorageSourceIsLocalStorage(loader->n= vram))) { + loader->nvramTemplateFormat =3D VIR_STORAGE_FILE_NONE; + + if (!loader->nvram || virStorageSourceIsLocalStorage(loader->n= vram)) { + /* validation when parsing the JSON files ensures that we = get + * only 'raw' and 'qcow2' here. Fall back to sharing forma= t with loader */ + if (flash->nvram_template.format) + loader->nvramTemplateFormat =3D virStorageFileFormatTy= peFromString(flash->nvram_template.format); + else + loader->nvramTemplateFormat =3D loader->format; + loader->nvramTemplate =3D g_strdup(flash->nvram_template.f= ilename); } } @@ -1661,7 +1675,7 @@ qemuFirmwareFillDomainLegacy(virQEMUDriver *driver, loader->format =3D VIR_STORAGE_FILE_RAW; /* Only use the default template path if one hasn't been - * provided by the user. + * provided by the user. Assume that the template is in 'raw' form= at. * * In addition to fully-custom templates, which are a valid * use case, we could simply be in a situation where @@ -1682,8 +1696,13 @@ qemuFirmwareFillDomainLegacy(virQEMUDriver *driver, * In this case, the global default is to have Secure Boot * disabled, but the domain configuration explicitly enables * it, and we shouldn't overrule this choice */ - if (!loader->nvramTemplate) + if (!loader->nvramTemplate) { loader->nvramTemplate =3D g_strdup(cfg->firmwares[i]->nvram); + loader->nvramTemplateFormat =3D VIR_STORAGE_FILE_RAW; + } + + if (loader->nvramTemplateFormat =3D=3D VIR_STORAGE_FILE_NONE) + loader->nvramTemplateFormat =3D VIR_STORAGE_FILE_RAW; VIR_DEBUG("decided on firmware '%s' template '%s'", loader->path, NULLSTR(loader->nvramTemplate)); diff --git a/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml= b/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml index c7bddf4063..f6cfe2b63c 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml @@ -16,7 +16,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-lates= t.xml b/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml index 1b2d6e70bd..56d40b0a9d 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml @@ -16,7 +16,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml= b/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml index 5029092842..c8fa37a644 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml @@ -16,7 +16,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest= .abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-l= atest.abi-update.xml index 0088f3324b..1a9baa8cc1 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.abi-up= date.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.abi-up= date.xml @@ -11,7 +11,7 @@ /usr/share/e= dk2/aarch64/QEMU_EFI-silent-pflash.qcow2 - /var/lib/libvirt/qemu/nvram/guest_VARS.qcow2 + /var/lib/libvirt/qemu/nvram/gues= t_VARS.qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest= .xml b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml index 38c680fabd..c6f3a5fe6b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-l= atest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-la= test.xml index 332d931ba1..729d2d911d 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-latest.x= ml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-latest.x= ml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib= /libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-nv= ram-path.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format= -loader-qcow2-nvram-path.x86_64-latest.xml index 49fdfc5c5f..dd044ac091 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-nvram-pat= h.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-nvram-pat= h.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_CODE_4M.secboot.qcow2 - /path/to/guest_VARS.qcow2 + /path/to/guest_VARS.qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2.x8= 6_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qco= w2.x86_64-latest.xml index f4ff7a0fc2..7cdc7eec1f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2.x86_64-la= test.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2.x86_64-la= test.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_CODE_4M.secboot.qcow2 - /var/lib/libvirt/qemu/nvram/guest_VARS.qcow2 + /var/lib/libvirt/qemu/nvram/guest_V= ARS.qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarc= h64-latest.abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-= loader-raw.aarch64-latest.abi-update.xml index ee22b16831..195b446a0a 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.abi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.abi-update.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= var/lib/libvirt/qemu/nvram/guest_VARS.raw + /var/lib/libvirt/qemu/nvram/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarc= h64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.= aarch64-latest.xml index 38c680fabd..c6f3a5fe6b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-pat= h.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-= qcow2-path.x86_64-latest.xml index 49fdfc5c5f..dd044ac091 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-path.x86_6= 4-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2-path.x86_6= 4-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_CODE_4M.secboot.qcow2 - /path/to/guest_VARS.qcow2 + /path/to/guest_VARS.qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2.x86= _64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2= .x86_64-latest.xml index f4ff7a0fc2..7cdc7eec1f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2.x86_64-lat= est.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-qcow2.x86_64-lat= est.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_CODE_4M.secboot.qcow2 - /var/lib/libvirt/qemu/nvram/guest_VARS.qcow2 + /var/lib/libvirt/qemu/nvram/guest_V= ARS.qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64= -latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_6= 4-latest.xml index 4812c4e600..6690c45940 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64-latest= .xml @@ -11,7 +11,7 @@ /usr/share/edk2= /ovmf/OVMF_CODE.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-lat= est.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest= .xml index 6b8dc886a6..430613f5fd 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-l= atest.abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secur= e.x86_64-latest.abi-update.xml index f4ff7a0fc2..7cdc7eec1f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.a= bi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.a= bi-update.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_CODE_4M.secboot.qcow2 - /var/lib/libvirt/qemu/nvram/guest_VARS.qcow2 + /var/lib/libvirt/qemu/nvram/guest_V= ARS.qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-l= atest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-la= test.xml index 332d931ba1..729d2d911d 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.x= ml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.x= ml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib= /libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch6= 4-latest.abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch= 64.loongarch64-latest.abi-update.xml index 0ae744619f..8ba1bd0f81 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.abi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.abi-update.xml @@ -11,7 +11,7 @@ /usr/share/edk2/loongarch64/Q= EMU_EFI.fd - /var/lib/= libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarc= h64-latest.xml index 0ae744619f..8ba1bd0f81 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.xml @@ -11,7 +11,7 @@ /usr/share/edk2/loongarch64/Q= EMU_EFI.fd - /var/lib/= libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86= _64-latest.xml index 9cf30551a9..53381bd10e 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_64-lates= t.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.x= ml index 6b8dc886a6..430613f5fd 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.x= ml index ada0411fb3..1672edd458 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.x= ml index 135744cb7d..94dd6a29b9 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to= /guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-= latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-= latest.xml index 9cf30551a9..53381bd10e 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-latest.= xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-latest.= xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-latest= .abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-l= atest.abi-update.xml index d0a60c5bb8..125bd021e7 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-latest.abi-up= date.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-riscv64.riscv64-latest.abi-up= date.xml @@ -11,7 +11,7 @@ /usr/share/e= dk2/riscv/RISCV_VIRT_CODE.qcow2 - /var/lib/libvirt/qemu/nvram/guest_VARS.qcow2 + /var/lib/libvirt/qemu/nvram/guest_VARS.= qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.= xml b/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml index 332d931ba1..729d2d911d 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib= /libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.= xml b/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml index febaad7eae..c53e9f9692 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-upda= te.xml b/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-update.x= ml index f4ff7a0fc2..7cdc7eec1f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.abi-update.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_CODE_4M.secboot.qcow2 - /var/lib/libvirt/qemu/nvram/guest_VARS.qcow2 + /var/lib/libvirt/qemu/nvram/guest_V= ARS.qcow2 diff --git a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml b/te= sts/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml index 332d931ba1..729d2d911d 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib= /libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths= .aarch64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-leg= acy-paths.aarch64-latest.xml index b53f39a72e..c4ab86c675 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths.aarch6= 4-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths.aarch6= 4-latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/AAVMF/AAVMF_CODE.f= d - /var/lib/libvirt/qe= mu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64= -latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch6= 4-latest.xml index 637676d4ed..0dc32d0ce9 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64-latest= .xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.x= ml index a4af4ec25a..e7b764b9b0 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /path/to/guest_V= ARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.x= ml index 4d6f2f20aa..67d90c4b1c 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64= -latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_6= 4-latest.xml index 6c3355a3f6..a8c52c9819 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64-latest= .xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to= /guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-leg= acy-paths.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-= enrolled-keys-legacy-paths.x86_64-latest.xml index b8c2dfef66..7e2b963537 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-legacy-pat= hs.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-legacy-pat= hs.x86_64-latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/OVM= F/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu= /nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86= _64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys= .x86_64-latest.xml index 083562ab0b..dd69b42726 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86_64-lat= est.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86_64-lat= est.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to/guest_V= ARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-pa= ths.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboo= t-legacy-paths.x86_64-latest.xml index cfd7a6824f..cd48e5e7b9 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-paths.x86= _64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-paths.x86= _64-latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/OVMF/OVMF_CODE.fd<= /loader> - /var/lib/libvirt/qemu= /nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-la= test.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-late= st.xml index a4af4ec25a..e7b764b9b0 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /path/to/guest_V= ARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch= 64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aa= rch64-latest.xml index 52f9fac842..fd217afb89 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch64-late= st.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch64-late= st.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-la= test.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-late= st.xml index ada0411fb3..1672edd458 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86= _64-latest.xml index 4d6f2f20aa..67d90c4b1c 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_64-lates= t.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt= /qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths= .x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-secboot-lega= cy-paths.x86_64-latest.xml index 9027123558..e6db577de4 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths.x86_64= -latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths.x86_64= -latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/OVM= F/OVMF_CODE.secboot.fd - /var/lib/libv= irt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-lates= t.xml b/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml index 6c3355a3f6..a8c52c9819 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to= /guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml b/= tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml index 5bdc9bd4c1..4615cd8db8 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /path/to/guest_V= ARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest= .xml b/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml index dba840237a..f26cce3028 100644 --- a/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= var/lib/libvirt/qemu/nvram/test_VARS.fd + /var/lib/libvirt/qemu/nvram/test_VARS.fd diff --git a/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xm= l b/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml index 6c6c1ea8b0..2291362b53 100644 --- a/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib= /libvirt/qemu/nvram/test_VARS.fd + /var/lib/libvirt/qemu/nvram/test_VARS.fd diff --git a/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml b= /tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml index d318aa63a1..5db6e99736 100644 --- a/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-l= atest.xml b/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-la= test.xml index 92a81991e2..eabe7c0b4d 100644 --- a/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-latest.x= ml +++ b/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-latest.x= ml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml = b/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml index bc6d210458..398ae4e3de 100644 --- a/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /= var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793973692862.7907228758697; Tue, 5 Nov 2024 00:06:13 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6C64B13A9; Tue, 5 Nov 2024 03:06:12 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 000FE12E4; Tue, 5 Nov 2024 02:59:07 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8BB0611F2; Tue, 5 Nov 2024 02:58:59 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5F42512ED for ; Tue, 5 Nov 2024 02:58:26 -0500 (EST) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-7GTEZl8bMy6sSLDPQUs1YA-1; Tue, 05 Nov 2024 02:58:24 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B8FB1955BF4 for ; Tue, 5 Nov 2024 07:58:23 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A36483000198 for ; Tue, 5 Nov 2024 07:58:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qJoamgXETXagcFtjOWpfpxTsW0SbK3H1UCuBwvWGNXk=; b=Qps+sbremERHLtfSSBrPTZsSQK0wON+fzPccl9D68puNfxtHyBYSiVgNtfAvwTWz8sjFVC FRP33nEcNfLcKC0SG+QZZ2wUPY9IOPA3LUlLdmCGguK78Ds3FO7Hk1rTT9ExmOpmgmhe81 FeE86rfthTFxPRXgo344jBy6JcswKSo= X-MC-Unique: 7GTEZl8bMy6sSLDPQUs1YA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 07/13] conf: domain: Output 'format' attribute of '' also for' raw images Date: Tue, 5 Nov 2024 08:58:05 +0100 Message-ID: <30e615f8d979b7b5557132267cd04ffd9d8374f0.1730793407.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FVCXJWL25KR3GJXFAGFGDULXD7GNXIQE X-Message-ID-Hash: FVCXJWL25KR3GJXFAGFGDULXD7GNXIQE X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793975309116600 Content-Type: text/plain; charset="utf-8" As the 'format' field is meant to carry the format of the nvram image we should output it even when the image is 'raw'. Currently this is not a problem but later patches will allow mismatch between the nvram format and loader format (as nothing really technically requires them to be the same and this then could become problem). Modify the condition and update tests. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 3 +-- tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml | 2 +- .../aarch64-virt-headless-mmio.aarch64-latest.xml | 2 +- tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml | 2 +- .../firmware-auto-efi-aarch64.aarch64-latest.xml | 2 +- .../firmware-auto-efi-enrolled-keys.x86_64-latest.xml | 2 +- ...re-auto-efi-format-loader-raw.aarch64-latest.abi-update.xml | 2 +- .../firmware-auto-efi-format-loader-raw.aarch64-latest.xml | 2 +- .../firmware-auto-efi-loader-insecure.x86_64-latest.xml | 2 +- .../firmware-auto-efi-loader-path.x86_64-latest.xml | 2 +- .../firmware-auto-efi-loader-secure.x86_64-latest.xml | 2 +- ...ware-auto-efi-loongarch64.loongarch64-latest.abi-update.xml | 2 +- .../firmware-auto-efi-loongarch64.loongarch64-latest.xml | 2 +- .../firmware-auto-efi-no-enrolled-keys.x86_64-latest.xml | 2 +- .../firmware-auto-efi-no-secboot.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-file.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-network-iscsi.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-network-nbd.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-path.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-template.x86_64-latest.xml | 2 +- .../firmware-auto-efi-secboot.x86_64-latest.xml | 2 +- .../firmware-auto-efi-smm-off.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml | 2 +- ...firmware-manual-efi-aarch64-legacy-paths.aarch64-latest.xml | 2 +- .../firmware-manual-efi-acpi-aarch64.aarch64-latest.xml | 2 +- .../firmware-manual-efi-acpi-q35.x86_64-latest.xml | 2 +- .../firmware-manual-efi-features.x86_64-latest.xml | 2 +- ...rmware-manual-efi-loader-path-nonstandard.x86_64-latest.xml | 2 +- .../firmware-manual-efi-loader-secure.x86_64-latest.xml | 2 +- ...-manual-efi-no-enrolled-keys-legacy-paths.x86_64-latest.xml | 2 +- .../firmware-manual-efi-no-enrolled-keys.x86_64-latest.xml | 2 +- ...rmware-manual-efi-no-secboot-legacy-paths.x86_64-latest.xml | 2 +- .../firmware-manual-efi-no-secboot.x86_64-latest.xml | 2 +- .../firmware-manual-efi-noacpi-aarch64.aarch64-latest.xml | 2 +- .../firmware-manual-efi-nvram-file.x86_64-latest.xml | 2 +- .../firmware-manual-efi-nvram-network-iscsi.x86_64-latest.xml | 2 +- .../firmware-manual-efi-nvram-network-nbd.x86_64-latest.xml | 2 +- ...are-manual-efi-nvram-template-nonstandard.x86_64-latest.xml | 2 +- .../firmware-manual-efi-nvram-template.x86_64-latest.xml | 2 +- .../firmware-manual-efi-secboot-legacy-paths.x86_64-latest.xml | 2 +- .../firmware-manual-efi-secboot.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml | 2 +- .../hvf-aarch64-virt-headless.aarch64-latest.xml | 2 +- .../qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml | 2 +- .../pvpanic-pci-no-address-aarch64.aarch64-latest.xml | 2 +- tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml | 2 +- 47 files changed, 47 insertions(+), 48 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 744bc1ac34..9d2aeb1086 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26833,8 +26833,7 @@ virDomainLoaderDefFormatNvram(virBuffer *buf, return -1; } - if (src->format && - src->format !=3D VIR_STORAGE_FILE_RAW) { + if (src->format !=3D VIR_STORAGE_FILE_NONE) { virBufferEscapeString(&attrBuf, " format=3D'%s'", virStorageFileFormatTypeToString(src->fo= rmat)); } diff --git a/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml= b/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml index f6cfe2b63c..31a5165fc3 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml @@ -16,7 +16,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-lates= t.xml b/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml index 56d40b0a9d..dc2bce05dc 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml @@ -16,7 +16,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml= b/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml index c8fa37a644..24edcc5ab3 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml @@ -16,7 +16,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest= .xml b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml index c6f3a5fe6b..e07881f8cf 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-l= atest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-la= test.xml index 729d2d911d..e454303158 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-latest.x= ml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-latest.x= ml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarc= h64-latest.abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-= loader-raw.aarch64-latest.abi-update.xml index 195b446a0a..44ef2c89f9 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.abi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.abi-update.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /var/lib/libvirt/qemu/nvram/guest_VARS.raw + /var/lib/libvirt/qemu/nvram/guest_VARS= .raw diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarc= h64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.= aarch64-latest.xml index c6f3a5fe6b..e07881f8cf 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64= -latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_6= 4-latest.xml index 6690c45940..f3c93e648a 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64-latest= .xml @@ -11,7 +11,7 @@ /usr/share/edk2= /ovmf/OVMF_CODE.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-lat= est.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest= .xml index 430613f5fd..9ad97a9c37 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-l= atest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-la= test.xml index 729d2d911d..e454303158 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.x= ml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.x= ml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch6= 4-latest.abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch= 64.loongarch64-latest.abi-update.xml index 8ba1bd0f81..6137d3448b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.abi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.abi-update.xml @@ -11,7 +11,7 @@ /usr/share/edk2/loongarch64/Q= EMU_EFI.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarc= h64-latest.xml index 8ba1bd0f81..6137d3448b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.xml @@ -11,7 +11,7 @@ /usr/share/edk2/loongarch64/Q= EMU_EFI.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86= _64-latest.xml index 53381bd10e..875943f097 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_64-lates= t.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.x= ml index 430613f5fd..9ad97a9c37 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.x= ml index 1672edd458..317868a136 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-iscsi.x8= 6_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-isc= si.x86_64-latest.xml index 23ff713347..da5816f3cd 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-iscsi.x86_64-la= test.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-iscsi.x86_64-la= test.xml @@ -10,7 +10,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x86_= 64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x= 86_64-latest.xml index a318069d1d..3fc9b5f79c 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x86_64-late= st.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x86_64-late= st.xml @@ -10,7 +10,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.x= ml index 94dd6a29b9..d0eea64666 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to/guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-= latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-= latest.xml index 53381bd10e..875943f097 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-latest.= xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-latest.= xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.= xml b/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml index 729d2d911d..e454303158 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.= xml b/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml index c53e9f9692..5fc4a8c5cc 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml b/te= sts/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml index 729d2d911d..e454303158 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths= .aarch64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-leg= acy-paths.aarch64-latest.xml index c4ab86c675..293ffb95bd 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths.aarch6= 4-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths.aarch6= 4-latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/AAVMF/AAVMF_CODE.f= d - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64= -latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch6= 4-latest.xml index 0dc32d0ce9..8dc07ab101 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64-latest= .xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.x= ml index e7b764b9b0..ee3f0c5331 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /path/to/guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.x= ml index 67d90c4b1c..05cd789c27 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-loader-path-nonstand= ard.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-loader-pa= th-nonstandard.x86_64-latest.xml index 039c485706..09a0ef382e 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-loader-path-nonstandard.x86= _64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-loader-path-nonstandard.x86= _64-latest.xml @@ -7,7 +7,7 @@ hvm /path/to/OVMF_CODE.fd - /var/lib/libvirt/qemu/nvram/= guest_VARS.fd + /var/lib/libv= irt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64= -latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_6= 4-latest.xml index a8c52c9819..d14adaea21 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64-latest= .xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to/guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-leg= acy-paths.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-= enrolled-keys-legacy-paths.x86_64-latest.xml index 7e2b963537..7258679199 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-legacy-pat= hs.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-legacy-pat= hs.x86_64-latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/OVM= F/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86= _64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys= .x86_64-latest.xml index dd69b42726..b1b3a268cb 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86_64-lat= est.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86_64-lat= est.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to/guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-pa= ths.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboo= t-legacy-paths.x86_64-latest.xml index cd48e5e7b9..f89b371a4c 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-paths.x86= _64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-paths.x86= _64-latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/OVMF/OVMF_CODE.fd<= /loader> - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-la= test.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-late= st.xml index e7b764b9b0..ee3f0c5331 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /path/to/guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch= 64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aa= rch64-latest.xml index fd217afb89..4e14737696 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch64-late= st.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch64-late= st.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /path/to/guest_VARS.raw + /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-la= test.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-late= st.xml index 1672edd458..317868a136 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-iscsi.= x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network= -iscsi.x86_64-latest.xml index 23ff713347..da5816f3cd 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-iscsi.x86_64-= latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-iscsi.x86_64-= latest.xml @@ -10,7 +10,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-nbd.x8= 6_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-n= bd.x86_64-latest.xml index a318069d1d..3fc9b5f79c 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-nbd.x86_64-la= test.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-nbd.x86_64-la= test.xml @@ -10,7 +10,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - + diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template-nonst= andard.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-= template-nonstandard.x86_64-latest.xml index 5433650516..f8de279178 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template-nonstandard.= x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template-nonstandard.= x86_64-latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt/qemu/nvram/= guest_VARS.fd + /var/lib/libv= irt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86= _64-latest.xml index 67d90c4b1c..05cd789c27 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_64-lates= t.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths= .x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-secboot-lega= cy-paths.x86_64-latest.xml index e6db577de4..72dfc6feb1 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths.x86_64= -latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths.x86_64= -latest.xml @@ -7,7 +7,7 @@ hvm /usr/share/OVM= F/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-lates= t.xml b/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml index a8c52c9819..d14adaea21 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /path/to/guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml b/= tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml index 4615cd8db8..e92738ef10 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/ovmf/OVMF_COD= E.fd - /path/to/guest_VARS.fd + /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest= .xml b/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml index f26cce3028..375879256e 100644 --- a/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /var/lib/libvirt/qemu/nvram/test_VARS.fd + /var/lib/libvirt/qemu/nvram/test_VARS.= fd diff --git a/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xm= l b/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml index 2291362b53..316d6bd9ea 100644 --- a/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd - /var/lib/libvirt/qemu/nvram/test_VARS.fd + /var/lib/libvirt/qemu/nvram/test_VARS.fd diff --git a/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml b= /tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml index 5db6e99736..9da2f68224 100644 --- a/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-l= atest.xml b/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-la= test.xml index eabe7c0b4d..5296fbb414 100644 --- a/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-latest.x= ml +++ b/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-latest.x= ml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml = b/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml index 398ae4e3de..de5e747cf2 100644 --- a/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml @@ -11,7 +11,7 @@ /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /var/lib/libvirt/qemu/nvram/guest_VARS= .fd --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17307941410921013.5033712595731; Tue, 5 Nov 2024 00:09:01 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id B7A28B26; Tue, 5 Nov 2024 03:08:59 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 1F65013B8; Tue, 5 Nov 2024 02:59:15 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id AAB9311C8; Tue, 5 Nov 2024 02:59:00 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E6CCB11DD for ; Tue, 5 Nov 2024 02:58:27 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-Pt5GjPo6MvCYkc8mzSMjGQ-1; Tue, 05 Nov 2024 02:58:25 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 04A30195608D for ; Tue, 5 Nov 2024 07:58:25 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F2C99300019B for ; Tue, 5 Nov 2024 07:58:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qiJ4C/nXj9sj/JxJ+XEiwxWw50a6Aur3fFKZ5FBF7Ws=; b=GJfiMFFFGxFe00dY4MoSLCFapRUMx8DCHu8vqNFJCYWvKmmGAG/AShNaZVBSbgblD5sRBG tWvhr/+L0izNe+EpTQwsMP7gwfqkbNqoVDDh4yaIfkos2BvGQ+kn4CeiRIvYkXzId6mq3c J/5iB5ysDV4SLX2EjK6JDu28joQgqbc= X-MC-Unique: Pt5GjPo6MvCYkc8mzSMjGQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 08/13] conf: Always format firmware image format Date: Tue, 5 Nov 2024 08:58:06 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: K2KXZVKRPDPGVCH2BI4HNUSH4IGNM7C6 X-Message-ID-Hash: K2KXZVKRPDPGVCH2BI4HNUSH4IGNM7C6 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730794143331116600 Content-Type: text/plain; charset="utf-8" The code historically skipped the 'format' field for 'raw' images as we didn't output it when no format support was present. Stop misleading and output the format also for 'raw' images. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 5 ++--- .../qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml | 2 +- .../aarch64-virt-headless-mmio.aarch64-latest.xml | 2 +- .../qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml | 2 +- .../firmware-auto-bios-stateless.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/firmware-auto-bios.x86_64-latest.xml | 2 +- .../firmware-auto-efi-aarch64.aarch64-latest.xml | 2 +- .../firmware-auto-efi-enrolled-keys.x86_64-latest.xml | 2 +- ...-auto-efi-format-loader-raw.aarch64-latest.abi-update.xml | 2 +- .../firmware-auto-efi-format-loader-raw.aarch64-latest.xml | 2 +- .../firmware-auto-efi-loader-insecure.x86_64-latest.xml | 2 +- ...rmware-auto-efi-loader-path-nonstandard.x86_64-latest.xml | 2 +- .../firmware-auto-efi-loader-path.x86_64-latest.xml | 2 +- .../firmware-auto-efi-loader-secure.x86_64-latest.xml | 2 +- ...re-auto-efi-loongarch64.loongarch64-latest.abi-update.xml | 2 +- .../firmware-auto-efi-loongarch64.loongarch64-latest.xml | 2 +- .../firmware-auto-efi-no-enrolled-keys.x86_64-latest.xml | 2 +- .../firmware-auto-efi-no-secboot.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-file.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-network-iscsi.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-network-nbd.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-path.x86_64-latest.xml | 2 +- ...are-auto-efi-nvram-template-nonstandard.x86_64-latest.xml | 2 +- .../firmware-auto-efi-nvram-template.x86_64-latest.xml | 2 +- .../firmware-auto-efi-rw-pflash.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.xml | 2 +- .../firmware-auto-efi-secboot.x86_64-latest.xml | 2 +- .../firmware-auto-efi-smm-off.x86_64-latest.xml | 2 +- .../firmware-auto-efi-stateless.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml | 2 +- .../firmware-manual-bios-stateless.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/firmware-manual-bios.x86_64-latest.xml | 2 +- ...rmware-manual-efi-aarch64-legacy-paths.aarch64-latest.xml | 2 +- .../firmware-manual-efi-acpi-aarch64.aarch64-latest.xml | 2 +- .../firmware-manual-efi-acpi-q35.x86_64-latest.xml | 2 +- .../firmware-manual-efi-features.x86_64-latest.xml | 2 +- ...ware-manual-efi-loader-path-nonstandard.x86_64-latest.xml | 2 +- .../firmware-manual-efi-loader-secure.x86_64-latest.xml | 2 +- ...anual-efi-no-enrolled-keys-legacy-paths.x86_64-latest.xml | 2 +- .../firmware-manual-efi-no-enrolled-keys.x86_64-latest.xml | 2 +- ...ware-manual-efi-no-secboot-legacy-paths.x86_64-latest.xml | 2 +- .../firmware-manual-efi-no-secboot.x86_64-latest.xml | 2 +- .../firmware-manual-efi-noacpi-aarch64.aarch64-latest.xml | 2 +- .../firmware-manual-efi-nvram-file.x86_64-latest.xml | 2 +- ...firmware-manual-efi-nvram-network-iscsi.x86_64-latest.xml | 2 +- .../firmware-manual-efi-nvram-network-nbd.x86_64-latest.xml | 2 +- ...e-manual-efi-nvram-template-nonstandard.x86_64-latest.xml | 2 +- .../firmware-manual-efi-nvram-template.x86_64-latest.xml | 2 +- .../firmware-manual-efi-rw-implicit.x86_64-latest.xml | 2 +- .../firmware-manual-efi-rw-legacy-paths.x86_64-latest.xml | 2 +- .../firmware-manual-efi-rw-modern-paths.x86_64-latest.xml | 2 +- .../qemuxmlconfdata/firmware-manual-efi-rw.x86_64-latest.xml | 2 +- ...irmware-manual-efi-secboot-legacy-paths.x86_64-latest.xml | 2 +- .../firmware-manual-efi-secboot.x86_64-latest.xml | 2 +- .../firmware-manual-efi-stateless.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml | 2 +- .../hvf-aarch64-virt-headless.aarch64-latest.xml | 2 +- .../hvf-x86_64-q35-headless.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml | 2 +- .../pvpanic-pci-no-address-aarch64.aarch64-latest.xml | 2 +- .../qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml | 2 +- tests/xlconfigdata/test-disk-positional-parms-full.xml | 2 +- tests/xlconfigdata/test-disk-positional-parms-partial.xml | 2 +- tests/xlconfigdata/test-disk-qed.xml | 2 +- tests/xlconfigdata/test-fullvirt-acpi-slic.xml | 2 +- tests/xlconfigdata/test-fullvirt-cpuid.xml | 2 +- .../test-fullvirt-direct-kernel-boot-bogus-extra.xml | 2 +- .../xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml | 2 +- tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml | 2 +- tests/xlconfigdata/test-fullvirt-hpet-timer.xml | 2 +- tests/xlconfigdata/test-fullvirt-hypervisor-features.xml | 2 +- tests/xlconfigdata/test-fullvirt-multi-timer.xml | 2 +- tests/xlconfigdata/test-fullvirt-multiserial.xml | 2 +- tests/xlconfigdata/test-fullvirt-multiusb.xml | 2 +- tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml | 2 +- tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 2 +- tests/xlconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xlconfigdata/test-fullvirt-ovmf.xml | 2 +- tests/xlconfigdata/test-fullvirt-ovswitch-tagged.xml | 2 +- tests/xlconfigdata/test-fullvirt-ovswitch-trunked.xml | 2 +- tests/xlconfigdata/test-fullvirt-pci.xml | 2 +- tests/xlconfigdata/test-fullvirt-tsc-timer.xml | 2 +- tests/xlconfigdata/test-fullvirt-type.xml | 2 +- tests/xlconfigdata/test-fullvirt-vnuma.xml | 2 +- tests/xlconfigdata/test-net-fakemodel.xml | 2 +- tests/xlconfigdata/test-new-disk.xml | 2 +- tests/xlconfigdata/test-qemu-passthrough.xml | 2 +- tests/xlconfigdata/test-rbd-multihost-noauth.xml | 2 +- tests/xlconfigdata/test-spice-features.xml | 2 +- tests/xlconfigdata/test-spice.xml | 2 +- tests/xlconfigdata/test-vif-multi-ip.xml | 2 +- tests/xlconfigdata/test-vif-rate.xml | 2 +- tests/xlconfigdata/test-vif-typename.xml | 2 +- tests/xmconfigdata/test-escape-paths.xml | 2 +- tests/xmconfigdata/test-fullvirt-default-feature.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-hpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-nohpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-localtime.xml | 2 +- tests/xmconfigdata/test-fullvirt-net-netfront.xml | 2 +- tests/xmconfigdata/test-fullvirt-new-cdrom.xml | 2 +- tests/xmconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xmconfigdata/test-fullvirt-parallel-tcp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-file.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-null.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pipe.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pty.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-stdio.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-tcp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-udp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-unix.xml | 2 +- tests/xmconfigdata/test-fullvirt-sound.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbmouse.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbtablet.xml | 2 +- tests/xmconfigdata/test-fullvirt-utc.xml | 2 +- tests/xmconfigdata/test-no-source-cdrom.xml | 2 +- tests/xmconfigdata/test-pci-dev-syntax.xml | 2 +- tests/xmconfigdata/test-pci-devs.xml | 2 +- 118 files changed, 119 insertions(+), 120 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9d2aeb1086..1439c6bdac 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26871,9 +26871,8 @@ virDomainLoaderDefFormat(virBuffer *buf, virTristateBoolTypeToString(loader->stateless)); } - if (loader->format && - loader->format !=3D VIR_STORAGE_FILE_RAW) { - virBufferEscapeString(&loaderAttrBuf, " format=3D'%s'", + if (loader->format > VIR_STORAGE_FILE_NONE) { + virBufferAsprintf(&loaderAttrBuf, " format=3D'%s'", virStorageFileFormatTypeToString(loader->for= mat)); } diff --git a/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml= b/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml index 31a5165fc3..6f3287d52d 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-graphics.aarch64-latest.xml @@ -15,7 +15,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-lates= t.xml b/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml index dc2bce05dc..295c14c828 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-headless-mmio.aarch64-latest.xml @@ -15,7 +15,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml= b/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml index 24edcc5ab3..0b96654010 100644 --- a/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/aarch64-virt-headless.aarch64-latest.xml @@ -15,7 +15,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-auto-bios-stateless.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-bios-stateless.x86_64-latest.x= ml index e69f8c01d0..31b83b5593 100644 --- a/tests/qemuxmlconfdata/firmware-auto-bios-stateless.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-bios-stateless.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/seabios/bios-256k.bi= n + /usr/share/seabi= os/bios-256k.bin diff --git a/tests/qemuxmlconfdata/firmware-auto-bios.x86_64-latest.xml b/t= ests/qemuxmlconfdata/firmware-auto-bios.x86_64-latest.xml index ffff5a79e2..d7471baa61 100644 --- a/tests/qemuxmlconfdata/firmware-auto-bios.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-bios.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/seabios/bios-256k.bin + /usr/share/seabios/bios-256k.bin diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest= .xml b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml index e07881f8cf..0ee421fe6f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-aarch64.aarch64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-l= atest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-la= test.xml index e454303158..79ab55751b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-latest.x= ml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-enrolled-keys.x86_64-latest.x= ml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarc= h64-latest.abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-= loader-raw.aarch64-latest.abi-update.xml index 44ef2c89f9..f95e2d2465 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.abi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.abi-update.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /var/lib/libvirt/qemu/nvram/guest_VARS= .raw diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarc= h64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.= aarch64-latest.xml index e07881f8cf..0ee421fe6f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-raw.aarch64-lat= est.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64= -latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_6= 4-latest.xml index f3c93e648a..28da16a5b4 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-insecure.x86_64-latest= .xml @@ -10,7 +10,7 @@ - /usr/share/edk2= /ovmf/OVMF_CODE.fd + = /usr/share/edk2/ovmf/OVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path-nonstandar= d.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path-n= onstandard.x86_64-latest.xml index f68cddf8df..1f09253a16 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path-nonstandard.x86_6= 4-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path-nonstandard.x86_6= 4-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /path/to/OVMF_CODE.fd + /path/to/OVMF_= CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-lat= est.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest= .xml index 9ad97a9c37..e85b1be965 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-path.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-l= atest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-la= test.xml index e454303158..79ab55751b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.x= ml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loader-secure.x86_64-latest.x= ml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch6= 4-latest.abi-update.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch= 64.loongarch64-latest.abi-update.xml index 6137d3448b..c69d053cec 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.abi-update.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.abi-update.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/loongarch64/Q= EMU_EFI.fd + /usr/share/edk= 2/loongarch64/QEMU_EFI.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarc= h64-latest.xml index 6137d3448b..c69d053cec 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-loongarch64.loongarch64-lates= t.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/loongarch64/Q= EMU_EFI.fd + /usr/share/edk= 2/loongarch64/QEMU_EFI.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86= _64-latest.xml index 875943f097..33134d405f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-no-enrolled-keys.x86_64-lates= t.xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.x= ml index 9ad97a9c37..e85b1be965 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-no-secboot.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.x= ml index 317868a136..dac07adb3e 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-file.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-iscsi.x8= 6_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-isc= si.x86_64-latest.xml index da5816f3cd..b21932d1b8 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-iscsi.x86_64-la= test.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-iscsi.x86_64-la= test.xml @@ -9,7 +9,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x86_= 64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x= 86_64-latest.xml index 3fc9b5f79c..6418ff6c3c 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x86_64-late= st.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-network-nbd.x86_64-late= st.xml @@ -9,7 +9,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.x= ml index d0eea64666..7f680e9fc5 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-path.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template-nonstan= dard.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-temp= late-nonstandard.x86_64-latest.xml index 6dcf5f23f7..fbb51f1734 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template-nonstandard.x8= 6_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template-nonstandard.x8= 6_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-= latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-= latest.xml index 875943f097..33134d405f 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-latest.= xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-nvram-template.x86_64-latest.= xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-lates= t.xml b/tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.xml index 3ced80f78b..c9bca900af 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - + diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.xml b= /tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.xml index c2d0c33a0b..4e744b69a3 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - + diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.= xml b/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml index e454303158..79ab55751b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-secboot.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.= xml b/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml index 5fc4a8c5cc..c36c2b7b9d 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-smm-off.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-stateless.x86_64-lates= t.xml b/tests/qemuxmlconfdata/firmware-auto-efi-stateless.x86_64-latest.xml index 006d338b3e..aa94bb32db 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-stateless.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-stateless.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/= edk2/ovmf/OVMF.amdsev.fd + /usr/share/edk2/ovmf/OVMF.amdsev.fd diff --git a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml b/te= sts/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml index e454303158..79ab55751b 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-bios-stateless.x86_64-la= test.xml b/tests/qemuxmlconfdata/firmware-manual-bios-stateless.x86_64-late= st.xml index 5787482b36..4f7bd872f6 100644 --- a/tests/qemuxmlconfdata/firmware-manual-bios-stateless.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-bios-stateless.x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/seabios/bios.bin + /usr/share/seabi= os/bios.bin diff --git a/tests/qemuxmlconfdata/firmware-manual-bios.x86_64-latest.xml b= /tests/qemuxmlconfdata/firmware-manual-bios.x86_64-latest.xml index 56932d7fee..040c31b5b9 100644 --- a/tests/qemuxmlconfdata/firmware-manual-bios.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-bios.x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/seabios/bios.bin + /usr/share/seabios/bios.bin diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths= .aarch64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-leg= acy-paths.aarch64-latest.xml index 293ffb95bd..2e5c4fe584 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths.aarch6= 4-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-aarch64-legacy-paths.aarch6= 4-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/AAVMF/AAVMF_CODE.f= d + /usr/share/AAV= MF/AAVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64= -latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch6= 4-latest.xml index 8dc07ab101..392601c167 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-aarch64.aarch64-latest= .xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.x= ml index ee3f0c5331..0a4367ea75 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-acpi-q35.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-late= st.xml b/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.x= ml index 05cd789c27..5f958ec758 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-features.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-loader-path-nonstand= ard.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-loader-pa= th-nonstandard.x86_64-latest.xml index 09a0ef382e..783a82336c 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-loader-path-nonstandard.x86= _64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-loader-path-nonstandard.x86= _64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /path/to/OVMF_CODE.fd + /path/to/OVMF_= CODE.fd /var/lib/libv= irt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64= -latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_6= 4-latest.xml index d14adaea21..3465be2eb0 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64-latest= .xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-loader-secure.x86_64-latest= .xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-leg= acy-paths.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-= enrolled-keys-legacy-paths.x86_64-latest.xml index 7258679199..76a9b62f19 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-legacy-pat= hs.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys-legacy-pat= hs.x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/OVM= F/OVMF_CODE.secboot.fd + /usr/share/OVMF/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86= _64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys= .x86_64-latest.xml index b1b3a268cb..97515f917e 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86_64-lat= est.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-enrolled-keys.x86_64-lat= est.xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-pa= ths.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboo= t-legacy-paths.x86_64-latest.xml index f89b371a4c..d2d9777284 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-paths.x86= _64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot-legacy-paths.x86= _64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/OVMF/OVMF_CODE.fd<= /loader> + /usr/share/OVM= F/OVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-la= test.xml b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-late= st.xml index ee3f0c5331..0a4367ea75 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-no-secboot.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch= 64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aa= rch64-latest.xml index 4e14737696..e8289954e3 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch64-late= st.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-noacpi-aarch64.aarch64-late= st.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /path/to/guest_VARS.raw diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-la= test.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-late= st.xml index 317868a136..dac07adb3e 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-file.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-iscsi.= x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network= -iscsi.x86_64-latest.xml index da5816f3cd..b21932d1b8 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-iscsi.x86_64-= latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-iscsi.x86_64-= latest.xml @@ -9,7 +9,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-nbd.x8= 6_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-n= bd.x86_64-latest.xml index 3fc9b5f79c..6418ff6c3c 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-nbd.x86_64-la= test.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-network-nbd.x86_64-la= test.xml @@ -9,7 +9,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template-nonst= andard.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-= template-nonstandard.x86_64-latest.xml index f8de279178..6c83568f62 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template-nonstandard.= x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template-nonstandard.= x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /var/lib/libv= irt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_6= 4-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86= _64-latest.xml index 05cd789c27..5f958ec758 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_64-lates= t.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-nvram-template.x86_64-lates= t.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-rw-implicit.x86_64-l= atest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-rw-implicit.x86_64-la= test.xml index 3411e337e8..919c9030f0 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-rw-implicit.x86_64-latest.x= ml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-rw-implicit.x86_64-latest.x= ml @@ -6,7 +6,7 @@ 1 hvm - /path/to/guest_BOTH.fd + /path/to/guest_BOTH.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-rw-legacy-paths.x86_= 64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-rw-legacy-paths.x= 86_64-latest.xml index c5baedc42c..eaf8ce41bb 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-rw-legacy-paths.x86_64-late= st.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-rw-legacy-paths.x86_64-late= st.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/OVMF/OVMF_CODE.fd + /usr/share/OVMF= /OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-rw-modern-paths.x86_= 64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-rw-modern-paths.x= 86_64-latest.xml index 0d755a4306..38c515c647 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-rw-modern-paths.x86_64-late= st.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-rw-modern-paths.x86_64-late= st.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/edk2/ovmf/OVMF_CODE= .fd + /usr/share/edk2= /ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-rw.x86_64-latest.xml= b/tests/qemuxmlconfdata/firmware-manual-efi-rw.x86_64-latest.xml index 94ceb88b49..5ffac0e811 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-rw.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-rw.x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /path/to/guest_BOTH.fd + /path/to/guest_= BOTH.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths= .x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-secboot-lega= cy-paths.x86_64-latest.xml index 72dfc6feb1..10e1450db6 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths.x86_64= -latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-secboot-legacy-paths.x86_64= -latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/OVM= F/OVMF_CODE.secboot.fd + /usr/share/OVMF/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-lates= t.xml b/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml index d14adaea21..3465be2eb0 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-secboot.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-stateless.x86_64-lat= est.xml b/tests/qemuxmlconfdata/firmware-manual-efi-stateless.x86_64-latest= .xml index e4ed6a154b..f55f17b09a 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-stateless.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi-stateless.x86_64-latest.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/= edk2/ovmf/OVMF_CODE.fd + /usr/share/edk2/ovmf/OVMF_CODE.fd diff --git a/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml b/= tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml index e92738ef10..7c92aeb391 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/firmware-manual-efi.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/ovmf/OVMF_COD= E.fd + /usr/share/edk= 2/ovmf/OVMF_CODE.fd /path/to/guest_VARS.fd diff --git a/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest= .xml b/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml index 375879256e..6399756654 100644 --- a/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/hvf-aarch64-virt-headless.aarch64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /var/lib/libvirt/qemu/nvram/test_VARS.= fd diff --git a/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xm= l b/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml index 316d6bd9ea..55ff2783f9 100644 --- a/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/hvf-x86_64-q35-headless.x86_64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.secboot.fd + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /var/lib/libvirt/qemu/nvram/test_VARS.fd diff --git a/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml b= /tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml index 9da2f68224..5cbb6ad8d4 100644 --- a/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/pvpanic-pci-aarch64.aarch64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-l= atest.xml b/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-la= test.xml index 5296fbb414..cc77b9579f 100644 --- a/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-latest.x= ml +++ b/tests/qemuxmlconfdata/pvpanic-pci-no-address-aarch64.aarch64-latest.x= ml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml = b/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml index de5e747cf2..614cd2c5f5 100644 --- a/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml +++ b/tests/qemuxmlconfdata/virtio-iommu-aarch64.aarch64-latest.xml @@ -10,7 +10,7 @@ - /usr/share/edk2/aarch64/QEMU_= EFI-silent-pflash.raw + /usr/share/edk= 2/aarch64/QEMU_EFI-silent-pflash.raw /var/lib/libvirt/qemu/nvram/guest_VARS= .fd diff --git a/tests/xlconfigdata/test-disk-positional-parms-full.xml b/tests= /xlconfigdata/test-disk-positional-parms-full.xml index 8961ad5d82..47c0a59d90 100644 --- a/tests/xlconfigdata/test-disk-positional-parms-full.xml +++ b/tests/xlconfigdata/test-disk-positional-parms-full.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-disk-positional-parms-partial.xml b/te= sts/xlconfigdata/test-disk-positional-parms-partial.xml index 308011b015..e38f553af7 100644 --- a/tests/xlconfigdata/test-disk-positional-parms-partial.xml +++ b/tests/xlconfigdata/test-disk-positional-parms-partial.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-disk-qed.xml b/tests/xlconfigdata/test= -disk-qed.xml index 8e782c19c6..c825456a1b 100644 --- a/tests/xlconfigdata/test-disk-qed.xml +++ b/tests/xlconfigdata/test-disk-qed.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-acpi-slic.xml b/tests/xlconfi= gdata/test-fullvirt-acpi-slic.xml index 9727422f62..366d877624 100644 --- a/tests/xlconfigdata/test-fullvirt-acpi-slic.xml +++ b/tests/xlconfigdata/test-fullvirt-acpi-slic.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader /sys/firmware/acpi/tables/SLIC
 diff --git a/tests/xlconfigdata/test-fullvirt-cpuid.xml b/tests/xlconfigdat= a/test-fullvirt-cpuid.xml index e953e76303..20ef789b60 100644 --- a/tests/xlconfigdata/test-fullvirt-cpuid.xml +++ b/tests/xlconfigdata/test-fullvirt-cpuid.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extr= a.xml b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml index 41b82387ee..cc32cdd550 100644 --- a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml +++ b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader /tmp/vmlinuz /tmp/initrd ignore_loglvl diff --git a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml = b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml index 41b82387ee..cc32cdd550 100644 --- a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml +++ b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader /tmp/vmlinuz /tmp/initrd ignore_loglvl diff --git a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml b/test= s/xlconfigdata/test-fullvirt-direct-kernel-boot.xml index 41b82387ee..cc32cdd550 100644 --- a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml +++ b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader /tmp/vmlinuz /tmp/initrd ignore_loglvl diff --git a/tests/xlconfigdata/test-fullvirt-hpet-timer.xml b/tests/xlconf= igdata/test-fullvirt-hpet-timer.xml index 51b6994312..3ea80b22e0 100644 --- a/tests/xlconfigdata/test-fullvirt-hpet-timer.xml +++ b/tests/xlconfigdata/test-fullvirt-hpet-timer.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-hypervisor-features.xml b/tes= ts/xlconfigdata/test-fullvirt-hypervisor-features.xml index c36290bb6a..fcdbc4763f 100644 --- a/tests/xlconfigdata/test-fullvirt-hypervisor-features.xml +++ b/tests/xlconfigdata/test-fullvirt-hypervisor-features.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-multi-timer.xml b/tests/xlcon= figdata/test-fullvirt-multi-timer.xml index 5c9e526fa7..d52773f60c 100644 --- a/tests/xlconfigdata/test-fullvirt-multi-timer.xml +++ b/tests/xlconfigdata/test-fullvirt-multi-timer.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-multiserial.xml b/tests/xlcon= figdata/test-fullvirt-multiserial.xml index d099a182c8..90c77e0893 100644 --- a/tests/xlconfigdata/test-fullvirt-multiserial.xml +++ b/tests/xlconfigdata/test-fullvirt-multiserial.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-multiusb.xml b/tests/xlconfig= data/test-fullvirt-multiusb.xml index 85f36cf9ed..a5112c659c 100644 --- a/tests/xlconfigdata/test-fullvirt-multiusb.xml +++ b/tests/xlconfigdata/test-fullvirt-multiusb.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml b/test= s/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml index 439e3b119c..f3057514fa 100644 --- a/tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml +++ b/tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-nestedhvm.xml b/tests/xlconfi= gdata/test-fullvirt-nestedhvm.xml index f8412ffce7..318d7c746c 100644 --- a/tests/xlconfigdata/test-fullvirt-nestedhvm.xml +++ b/tests/xlconfigdata/test-fullvirt-nestedhvm.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-nohap.xml b/tests/xlconfigdat= a/test-fullvirt-nohap.xml index 8167ea0133..37d0919d49 100644 --- a/tests/xlconfigdata/test-fullvirt-nohap.xml +++ b/tests/xlconfigdata/test-fullvirt-nohap.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-ovmf.xml b/tests/xlconfigdata= /test-fullvirt-ovmf.xml index da3954dba9..b71b3e7687 100644 --- a/tests/xlconfigdata/test-fullvirt-ovmf.xml +++ b/tests/xlconfigdata/test-fullvirt-ovmf.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/share/qemu/ovmf-x86_64-x= en.bin + /usr/share/qem= u/ovmf-x86_64-xen.bin diff --git a/tests/xlconfigdata/test-fullvirt-ovswitch-tagged.xml b/tests/x= lconfigdata/test-fullvirt-ovswitch-tagged.xml index 3256f616db..561c5f444c 100644 --- a/tests/xlconfigdata/test-fullvirt-ovswitch-tagged.xml +++ b/tests/xlconfigdata/test-fullvirt-ovswitch-tagged.xml @@ -6,7 +6,7 @@ 8 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-ovswitch-trunked.xml b/tests/= xlconfigdata/test-fullvirt-ovswitch-trunked.xml index 46c0a0f8f8..1d531cec99 100644 --- a/tests/xlconfigdata/test-fullvirt-ovswitch-trunked.xml +++ b/tests/xlconfigdata/test-fullvirt-ovswitch-trunked.xml @@ -6,7 +6,7 @@ 8 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-pci.xml b/tests/xlconfigdata/= test-fullvirt-pci.xml index 6826d14b9e..71fc0b7de8 100644 --- a/tests/xlconfigdata/test-fullvirt-pci.xml +++ b/tests/xlconfigdata/test-fullvirt-pci.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-tsc-timer.xml b/tests/xlconfi= gdata/test-fullvirt-tsc-timer.xml index f048486380..52518c1329 100644 --- a/tests/xlconfigdata/test-fullvirt-tsc-timer.xml +++ b/tests/xlconfigdata/test-fullvirt-tsc-timer.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-type.xml b/tests/xlconfigdata= /test-fullvirt-type.xml index 6d79300fa9..b094fb2505 100644 --- a/tests/xlconfigdata/test-fullvirt-type.xml +++ b/tests/xlconfigdata/test-fullvirt-type.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-fullvirt-vnuma.xml b/tests/xlconfigdat= a/test-fullvirt-vnuma.xml index 99092817de..c474c33600 100644 --- a/tests/xlconfigdata/test-fullvirt-vnuma.xml +++ b/tests/xlconfigdata/test-fullvirt-vnuma.xml @@ -6,7 +6,7 @@ 8 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-net-fakemodel.xml b/tests/xlconfigdata= /test-net-fakemodel.xml index 031af99cb8..4ba1de61e4 100644 --- a/tests/xlconfigdata/test-net-fakemodel.xml +++ b/tests/xlconfigdata/test-net-fakemodel.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-new-disk.xml b/tests/xlconfigdata/test= -new-disk.xml index 8961ad5d82..47c0a59d90 100644 --- a/tests/xlconfigdata/test-new-disk.xml +++ b/tests/xlconfigdata/test-new-disk.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-qemu-passthrough.xml b/tests/xlconfigd= ata/test-qemu-passthrough.xml index 5de35143c0..4794851c02 100644 --- a/tests/xlconfigdata/test-qemu-passthrough.xml +++ b/tests/xlconfigdata/test-qemu-passthrough.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-rbd-multihost-noauth.xml b/tests/xlcon= figdata/test-rbd-multihost-noauth.xml index df26f6cf02..59581e5f67 100644 --- a/tests/xlconfigdata/test-rbd-multihost-noauth.xml +++ b/tests/xlconfigdata/test-rbd-multihost-noauth.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-spice-features.xml b/tests/xlconfigdat= a/test-spice-features.xml index 11b5f0f665..b762faff20 100644 --- a/tests/xlconfigdata/test-spice-features.xml +++ b/tests/xlconfigdata/test-spice-features.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-spice.xml b/tests/xlconfigdata/test-sp= ice.xml index 745ae3b5c5..ffd64d27b7 100644 --- a/tests/xlconfigdata/test-spice.xml +++ b/tests/xlconfigdata/test-spice.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-vif-multi-ip.xml b/tests/xlconfigdata/= test-vif-multi-ip.xml index 9498518263..f494362440 100644 --- a/tests/xlconfigdata/test-vif-multi-ip.xml +++ b/tests/xlconfigdata/test-vif-multi-ip.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-vif-rate.xml b/tests/xlconfigdata/test= -vif-rate.xml index 037d410d13..052f9c074a 100644 --- a/tests/xlconfigdata/test-vif-rate.xml +++ b/tests/xlconfigdata/test-vif-rate.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xlconfigdata/test-vif-typename.xml b/tests/xlconfigdata/= test-vif-typename.xml index d08eff7299..38e0227f84 100644 --- a/tests/xlconfigdata/test-vif-typename.xml +++ b/tests/xlconfigdata/test-vif-typename.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-escape-paths.xml b/tests/xmconfigdata/= test-escape-paths.xml index 57930b6913..654c08009d 100644 --- a/tests/xmconfigdata/test-escape-paths.xml +++ b/tests/xmconfigdata/test-escape-paths.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader&test + /usr/lib/xen/boot/hvmloader&te= st diff --git a/tests/xmconfigdata/test-fullvirt-default-feature.xml b/tests/x= mconfigdata/test-fullvirt-default-feature.xml index ba8d4299a1..dffd2665f2 100644 --- a/tests/xmconfigdata/test-fullvirt-default-feature.xml +++ b/tests/xmconfigdata/test-fullvirt-default-feature.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-force-hpet.xml b/tests/xmconf= igdata/test-fullvirt-force-hpet.xml index ba8d4299a1..dffd2665f2 100644 --- a/tests/xmconfigdata/test-fullvirt-force-hpet.xml +++ b/tests/xmconfigdata/test-fullvirt-force-hpet.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-force-nohpet.xml b/tests/xmco= nfigdata/test-fullvirt-force-nohpet.xml index eaf5206227..286377e32a 100644 --- a/tests/xmconfigdata/test-fullvirt-force-nohpet.xml +++ b/tests/xmconfigdata/test-fullvirt-force-nohpet.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-localtime.xml b/tests/xmconfi= gdata/test-fullvirt-localtime.xml index 5574405002..895df986e7 100644 --- a/tests/xmconfigdata/test-fullvirt-localtime.xml +++ b/tests/xmconfigdata/test-fullvirt-localtime.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-net-netfront.xml b/tests/xmco= nfigdata/test-fullvirt-net-netfront.xml index fb8d0e017e..4c824ae883 100644 --- a/tests/xmconfigdata/test-fullvirt-net-netfront.xml +++ b/tests/xmconfigdata/test-fullvirt-net-netfront.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-new-cdrom.xml b/tests/xmconfi= gdata/test-fullvirt-new-cdrom.xml index 9e44651a4d..5d52a55184 100644 --- a/tests/xmconfigdata/test-fullvirt-new-cdrom.xml +++ b/tests/xmconfigdata/test-fullvirt-new-cdrom.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-nohap.xml b/tests/xmconfigdat= a/test-fullvirt-nohap.xml index 82caa1e842..b5c1452e77 100644 --- a/tests/xmconfigdata/test-fullvirt-nohap.xml +++ b/tests/xmconfigdata/test-fullvirt-nohap.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml b/tests/xmco= nfigdata/test-fullvirt-parallel-tcp.xml index c96079c5ba..8074abe3e3 100644 --- a/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml +++ b/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-file.xml b/tests/xmcon= figdata/test-fullvirt-serial-file.xml index 69b4958f6e..b9f0d6a728 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-file.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-file.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-null.xml b/tests/xmcon= figdata/test-fullvirt-serial-null.xml index 3d07c394f8..955bc30951 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-null.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-null.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-pipe.xml b/tests/xmcon= figdata/test-fullvirt-serial-pipe.xml index 617db43dd1..b426cabef4 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-pipe.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-pipe.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-pty.xml b/tests/xmconf= igdata/test-fullvirt-serial-pty.xml index e6bc2908a4..5e0dfe84e8 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-pty.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-pty.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-stdio.xml b/tests/xmco= nfigdata/test-fullvirt-serial-stdio.xml index 9d0c2ebcc1..f3ef1e60b9 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-stdio.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-stdio.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml b/tests= /xmconfigdata/test-fullvirt-serial-tcp-telnet.xml index 372c859853..2747b2bf44 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-tcp.xml b/tests/xmconf= igdata/test-fullvirt-serial-tcp.xml index 774fe59362..c29e5f96db 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-tcp.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-tcp.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-udp.xml b/tests/xmconf= igdata/test-fullvirt-serial-udp.xml index 0f2450a7dd..b2975d88ba 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-udp.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-udp.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-serial-unix.xml b/tests/xmcon= figdata/test-fullvirt-serial-unix.xml index 2cb8b0049f..1019f0b59d 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-unix.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-unix.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-sound.xml b/tests/xmconfigdat= a/test-fullvirt-sound.xml index ac9a4c3eb6..7a266248cd 100644 --- a/tests/xmconfigdata/test-fullvirt-sound.xml +++ b/tests/xmconfigdata/test-fullvirt-sound.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-usbmouse.xml b/tests/xmconfig= data/test-fullvirt-usbmouse.xml index 133fe53f41..41dde9acae 100644 --- a/tests/xmconfigdata/test-fullvirt-usbmouse.xml +++ b/tests/xmconfigdata/test-fullvirt-usbmouse.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-usbtablet.xml b/tests/xmconfi= gdata/test-fullvirt-usbtablet.xml index ce12d93f6b..54cf4a22e9 100644 --- a/tests/xmconfigdata/test-fullvirt-usbtablet.xml +++ b/tests/xmconfigdata/test-fullvirt-usbtablet.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-fullvirt-utc.xml b/tests/xmconfigdata/= test-fullvirt-utc.xml index 9e44651a4d..5d52a55184 100644 --- a/tests/xmconfigdata/test-fullvirt-utc.xml +++ b/tests/xmconfigdata/test-fullvirt-utc.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-no-source-cdrom.xml b/tests/xmconfigda= ta/test-no-source-cdrom.xml index 9d28eb5a8d..1cf3f5436a 100644 --- a/tests/xmconfigdata/test-no-source-cdrom.xml +++ b/tests/xmconfigdata/test-no-source-cdrom.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-pci-dev-syntax.xml b/tests/xmconfigdat= a/test-pci-dev-syntax.xml index 1d5d857072..fda59b7dae 100644 --- a/tests/xmconfigdata/test-pci-dev-syntax.xml +++ b/tests/xmconfigdata/test-pci-dev-syntax.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader diff --git a/tests/xmconfigdata/test-pci-devs.xml b/tests/xmconfigdata/test= -pci-devs.xml index 1d5d857072..fda59b7dae 100644 --- a/tests/xmconfigdata/test-pci-devs.xml +++ b/tests/xmconfigdata/test-pci-devs.xml @@ -6,7 +6,7 @@ 1 hvm - /usr/lib/xen/boot/hvmloader + /usr/lib/xen/boot/hvmloader --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793841536248.7412216546045; Tue, 5 Nov 2024 00:04:01 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 7C46C136D; Tue, 5 Nov 2024 03:04:00 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 5A5551185; Tue, 5 Nov 2024 02:59:02 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 84A301292; Tue, 5 Nov 2024 02:58:57 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E829C11C3 for ; Tue, 5 Nov 2024 02:58:28 -0500 (EST) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-uxpGEhZJMyGiv4soRqz4hQ-1; Tue, 05 Nov 2024 02:58:27 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 573101955EA7 for ; Tue, 5 Nov 2024 07:58:26 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 86A42300019D for ; Tue, 5 Nov 2024 07:58:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbH1VU4xxeRsFS9yn78qUivzNjA0mORchQeIAw+fGak=; b=JWheBtL19igmjzXuqSs7jWuHm7gfFVMkrAn4DLUmWWqiJZwEiPwqpwIyy5sh4ixIciwdKE mmKwGUq+csnPBsWmBrRwo909duoJJLG/lzeQkhn7lYdtdgw9YYZ6pHhkCt93mij+wzEDlt TKypm0pWy7gx/XKIg2GbmgbkH5/DLOA= X-MC-Unique: uxpGEhZJMyGiv4soRqz4hQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 09/13] qemuPrepareNVRAM: Refuse conversion of NVRAM backing file format Date: Tue, 5 Nov 2024 08:58:07 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QTEJONKKSZ6QBBBI5OOQOTLU6DXJ47VX X-Message-ID-Hash: QTEJONKKSZ6QBBBI5OOQOTLU6DXJ47VX X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793841794116600 Content-Type: text/plain; charset="utf-8" Refuse situations where the user configures a different format for a file-backed nvram than the template file has. At this point it's still required that the NVRAM and firmware share format, but that is going to be relaxed, thus we need to refuse configurations that the code can't handle. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/qemu/qemu_process.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7a40e09d47..d134de532c 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4624,6 +4624,12 @@ qemuPrepareNVRAM(virQEMUDriver *driver, return -1; } + if (loader->nvram->format !=3D loader->nvramTemplateFormat) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("conversion of the nvram template to another targ= et format is not supported")); + return -1; + } + if ((srcFD =3D virFileOpenAs(loader->nvramTemplate, O_RDONLY, 0, -1, -1, 0)) < 0) { virReportSystemError(-srcFD, --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793863216770.7052836829026; Tue, 5 Nov 2024 00:04:23 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 24C541367; Tue, 5 Nov 2024 03:04:22 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 279B312B0; Tue, 5 Nov 2024 02:59:04 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 0937711E4; Tue, 5 Nov 2024 02:58:57 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 51DD111ED for ; Tue, 5 Nov 2024 02:58:30 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-nWD76nHANGq1Eje2gaxaHw-1; Tue, 05 Nov 2024 02:58:28 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BA6B21955EA1 for ; Tue, 5 Nov 2024 07:58:27 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC087300018D for ; Tue, 5 Nov 2024 07:58:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yl1EVgDaj90lgOlASrhxbuWC5N0MmzyLTe6METMLCA8=; b=QaFDo2s9hSl5wLI9HB3XkKV6tOMiXdX9A35anxmYSAAuPw/+igSuNGYSyZIJUNwCvpyzWO ONIYzMEQFd8r0WK4T4ruauxe30tMMSW5ZOP1dqSi86zNv2VeE4gKNDSf8yWp7zF8+BxCJU hrSKkX7lpI+JEGTYWlMULCgLMR5IZTo= X-MC-Unique: nWD76nHANGq1Eje2gaxaHw-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 10/13] qemuFirmwareMatchDomain: Don't base firmware selection on nvram image format Date: Tue, 5 Nov 2024 08:58:08 +0100 Message-ID: <246da7c5b3f55d2a025b947b4aedaa878afde15b.1730793407.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CEIPHCLL4XGHBE65FIUUJCY2UMOTRTII X-Message-ID-Hash: CEIPHCLL4XGHBE65FIUUJCY2UMOTRTII X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793864004116600 Content-Type: text/plain; charset="utf-8" Basing the selection on the format of the actual NVRAM image makes no sense as user may format the image themselves. Additionally it doesn't make much sense to even limit the firmware selection based on the nvram template itself. As format of the template is given and firmware images don't really provide any choice. Remove the limitation so that autoselection can pick a template regardless of the selected format or template format. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/qemu/qemu_firmware.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index d9d21b4771..2d0ec0b4fa 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1332,13 +1332,6 @@ qemuFirmwareMatchDomain(const virDomainDef *def, flash->nvram_template.format); return false; } - if (loader && loader->nvram && loader->nvram->format && - STRNEQ(flash->nvram_template.format, virStorageFileFormatT= ypeToString(loader->nvram->format))) { - VIR_DEBUG("Discarding loader with mismatching nvram templa= te format '%s' !=3D '%s'", - flash->nvram_template.format, - virStorageFileFormatTypeToString(loader->nvram->= format)); - return false; - } } } else if (fw->mapping.device =3D=3D QEMU_FIRMWARE_DEVICE_MEMORY) { if (loader && loader->type && --=20 2.47.0 From nobody Sat Nov 23 09:31:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730793993459465.93158007297893; Tue, 5 Nov 2024 00:06:33 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 555031399; Tue, 5 Nov 2024 03:06:32 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E447F138B; Tue, 5 Nov 2024 02:59:09 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id F048E11AF; Tue, 5 Nov 2024 02:58:59 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 407D91260 for ; Tue, 5 Nov 2024 02:58:33 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-M8Brz-IOPWqH1ujJPHQNXg-1; Tue, 05 Nov 2024 02:58:29 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 020B61955F57 for ; Tue, 5 Nov 2024 07:58:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3B757300018D for ; Tue, 5 Nov 2024 07:58:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730793512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fm78hNbPsHff9K2EyC3CAM546kJAONK9TsehsOq+9R4=; b=UdKhx9xNYJk33SgM+k46FKmx7jL0wbMA/cJqq7Ns+4W9rCMFeECCjjNDDHf62vJgid87Uu PCw18551LaizmoLXr1eWGG/SMcq1wvwPN4GEUluUbM1y1a/OB405l2j4POio0A1G/u/wfy wvY14GJGIQbea1kolQHH06Y5B8Rm8co= X-MC-Unique: M8Brz-IOPWqH1ujJPHQNXg-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 11/13] conf: Remove nonsensical requirement of nvram format matching firmware format Date: Tue, 5 Nov 2024 08:58:09 +0100 Message-ID: <131f7c7eb7040b8d84d8d62034d85901dba05ced.1730793407.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 42ND2333A5D5HGGHYGGGWSCLWPMYKS6O X-Message-ID-Hash: 42ND2333A5D5HGGHYGGGWSCLWPMYKS6O X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730793994743116600 Content-Type: text/plain; charset="utf-8" The nvram image can have any supported format and there's no technical requirement of them having the same format. In fact the actual nvram image doesn't necessarily need to have the same format as the template if the user is willing to format it themselves (as libvirt is not going to convert it). Remove the nonsensical check and adjust tests. The test case required swapping around the format in order to work properly. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 10 ----- ...uto-efi-format-mismatch.x86_64-latest.args | 37 +++++++++++++++++ ...auto-efi-format-mismatch.x86_64-latest.err | 1 - ...auto-efi-format-mismatch.x86_64-latest.xml | 41 +++++++++++++++++++ .../firmware-auto-efi-format-mismatch.xml | 4 +- tests/qemuxmlconftest.c | 2 +- 6 files changed, 81 insertions(+), 14 deletions(-) create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch= .x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch= .x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch= .x86_64-latest.xml diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1439c6bdac..8acbea72f0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17270,16 +17270,6 @@ virDomainLoaderDefParseXML(virDomainLoaderDef *loa= der, loaderNode) < 0) return -1; - if (loader->nvram && - loader->format && loader->nvram->format && - loader->format !=3D loader->nvram->format) { - virReportError(VIR_ERR_XML_ERROR, - _("Format mismatch: loader.format=3D'%1$s' nvram.fo= rmat=3D'%2$s'"), - virStorageFileFormatTypeToString(loader->format), - virStorageFileFormatTypeToString(loader->nvram->for= mat)); - return -1; - } - return 0; } diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64= -latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_= 64-latest.args new file mode 100644 index 0000000000..1bdd482d71 --- /dev/null +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64-latest= .args @@ -0,0 +1,37 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-guest \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.local/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.cache \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.config \ +/usr/bin/qemu-system-x86_64 \ +-name guest=3Dguest,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ +-blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE.sec= boot.fd","node-name":"libvirt-pflash0-storage","auto-read-only":true,"disca= rd":"unmap"}' \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"raw","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.fd","node-name":"libvirt-pflash1-storage","read-only":false}' \ +-machine pc-q35-4.0,usb=3Doff,smm=3Don,dump-guest-core=3Doff,memory-backen= d=3Dpc.ram,pflash0=3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-stora= ge,acpi=3Don \ +-accel kvm \ +-cpu qemu64 \ +-global driver=3Dcfi.pflash01,property=3Dsecure,value=3Don \ +-m size=3D1048576k \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":1073741824}= ' \ +-overcommit mem-lock=3Doff \ +-smp 1,sockets=3D1,cores=3D1,threads=3D1 \ +-uuid 63840878-0deb-4095-97e6-fc444d9bc9fa \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-global ICH9-LPC.noreboot=3Doff \ +-watchdog-action reset \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64= -latest.err b/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_6= 4-latest.err deleted file mode 100644 index abfdfc4357..0000000000 --- a/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64-latest= .err +++ /dev/null @@ -1 +0,0 @@ -XML error: Format mismatch: loader.format=3D'qcow2' nvram.format=3D'raw' diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64= -latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_6= 4-latest.xml new file mode 100644 index 0000000000..79ab55751b --- /dev/null +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64-latest= .xml @@ -0,0 +1,41 @@ + + guest + 63840878-0deb-4095-97e6-fc444d9bc9fa + 1048576 + 1048576 + 1 + + hvm + + + + + /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd + /var/lib/libvirt/qemu/nvram/guest_VARS.fd + + + + + + + + qemu64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + + +
+ + + + +