[PATCH 06/13] virTypedParamsGetStringList: Ensure that returned string list is NULL-terminated

Peter Krempa posted 13 patches 6 months, 2 weeks ago
[PATCH 06/13] virTypedParamsGetStringList: Ensure that returned string list is NULL-terminated
Posted by Peter Krempa 6 months, 2 weeks ago
This can simplify callers who don't really need to know the number of
elements to check that a particular element is present.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/util/virtypedparam.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c
index 564cb81acc..f25530a735 100644
--- a/src/util/virtypedparam.c
+++ b/src/util/virtypedparam.c
@@ -439,8 +439,8 @@ virTypedParamsFilter(virTypedParameterPtr params,
  * @values: array of returned values
  *
  * Finds all parameters with desired @name within @params and
- * store their values into @values. If none of the @params are strings named
- * @name the returned @values will be NULL.
+ * store their values into a NULL-terminated string list @values. If none of
+ * the @params are strings named @name the returned @values will be NULL.
  *
  * Important: The strings in the returned string list @values are borrowed from
  * @params and thus caller must free only the pointer returned as @values, but
@@ -465,7 +465,7 @@ virTypedParamsGetStringList(virTypedParameterPtr params,
     if (nfiltered == 0)
         return 0;

-    *values = g_new0(const char *, nfiltered);
+    *values = g_new0(const char *, nfiltered + 1);

     for (i = 0; i < nfiltered; i++) {
         (*values)[i] = filtered[i]->value.s;
-- 
2.46.0