From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723671817615939.2603310532015; Wed, 14 Aug 2024 14:43:37 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 94D1F1347; Wed, 14 Aug 2024 17:43:36 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B388712A8; Wed, 14 Aug 2024 17:43:12 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id EAAD11282; Wed, 14 Aug 2024 17:43:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 76F94127F for ; Wed, 14 Aug 2024 17:43:09 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-z_SLukRaMH-zyYZd_fsHmA-1; Wed, 14 Aug 2024 17:43:07 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E104D1955F03 for ; Wed, 14 Aug 2024 21:43:06 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3C3821955E8C for ; Wed, 14 Aug 2024 21:43:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fE5xm5B6C8Nc39t12rvT8KnNXCQ814TDpWXfpMLInCs=; b=Rp+tSYTdzml+SjAaGM2UG2JIvUWtx0u5TM9XZ9NjWE3EegPApoXYC99fGTjSzxvTabkE1v cK+/Y6/7TOq9VH9IpGrpXqZdZbEv269bZ2espri1sIXJcv9s636VGiJ4hi14oIhNqFf8+G fiSVeGjlEE9UIuHW+nIsHP/xmcqNQ6M= X-MC-Unique: z_SLukRaMH-zyYZd_fsHmA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 01/20] tests: json: relax some test cases Date: Wed, 14 Aug 2024 23:40:16 +0200 Message-ID: <8d896f6289a1b7ac7d7e4e46b414156e75e1bc6d.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: D4ABEKXBOIHXWYIZIG2FRRXDZACJKQK6 X-Message-ID-Hash: D4ABEKXBOIHXWYIZIG2FRRXDZACJKQK6 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723671817944116600 Content-Type: text/plain; charset="utf-8" Some JSON parsers do not like bare types outside of objects or arrays or do validation of object key uniqueness. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- tests/virjsontest.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/virjsontest.c b/tests/virjsontest.c index 6b6a64d3d3..efcbbbab98 100644 --- a/tests/virjsontest.c +++ b/tests/virjsontest.c @@ -550,9 +550,9 @@ mymain(void) "[\"The meaning of life\"]"); DO_TEST_PARSE_FAIL("unterminated string", "[ \"The meaning of lif ]"); =20 - DO_TEST_PARSE("integer", "1", NULL); - DO_TEST_PARSE("boolean", "true", NULL); - DO_TEST_PARSE("null", "null", NULL); + DO_TEST_PARSE("integer", "[1]", NULL); + DO_TEST_PARSE("boolean", "[true]", NULL); + DO_TEST_PARSE("null", "[null]", NULL); DO_TEST_PARSE("[]", "[]", NULL); =20 DO_TEST_PARSE("escaping symbols", "[\"\\\"\\t\\n\\\\\"]", NULL); @@ -574,14 +574,11 @@ mymain(void) DO_TEST_PARSE_FAIL("array of an object with an array as a key", "[ {[\"key1\", \"key2\"]: \"value\"} ]"); DO_TEST_PARSE_FAIL("object with unterminated key", "{ \"key:7 }"); - DO_TEST_PARSE_FAIL("duplicate key", "{ \"a\": 1, \"a\": 1 }"); =20 DO_TEST_FULL("lookup on array", Lookup, "[ 1 ]", NULL, false); DO_TEST_FULL("lookup on string", Lookup, "\"str\"", NULL, false); - DO_TEST_FULL("lookup on integer", Lookup, - "1", NULL, false); DO_TEST_FULL("lookup with missing key", Lookup, "{ }", NULL, false); DO_TEST_FULL("lookup with wrong type", Lookup, --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723671940770631.3989682096077; Wed, 14 Aug 2024 14:45:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C046412BE; Wed, 14 Aug 2024 17:45:39 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C216D1464; Wed, 14 Aug 2024 17:43:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 759B312ED; Wed, 14 Aug 2024 17:43:14 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6691810F7 for ; Wed, 14 Aug 2024 17:43:10 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-bpL0bufyOlaIkAeZe216tw-1; Wed, 14 Aug 2024 17:43:08 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0AAEC19373D7 for ; Wed, 14 Aug 2024 21:43:08 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 504011955E8C for ; Wed, 14 Aug 2024 21:43:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWalN2sEKXd/XCgUSzwgHIWepHEgW8LNTQYXf2+ZWPk=; b=TdoxJEDn5DYm3YYj0jft/4PQabGuHTbyu+W0o5B0xn/m6MGA9xn356JAlSOmysz5A2b4Da 4wE/p+rOVnBdZk0kyoXCVlmLgQ7mx8kPxSUxjghLUYqjQlyhV66wdwlkz0DIozOEHlLLbL DZRWNg6pQjfFKLfPAmyOOqwa39mHU0c= X-MC-Unique: bpL0bufyOlaIkAeZe216tw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 02/20] ci: update OpenSUSE Leap to 15.6 Date: Wed, 14 Aug 2024 23:40:17 +0200 Message-ID: <596c72dcf5db3f2598f586e6d77f19932268b946.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MGKC7XJW5TEHW7LLAH535YTOUV7D6OXK X-Message-ID-Hash: MGKC7XJW5TEHW7LLAH535YTOUV7D6OXK X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723671942406116600 Content-Type: text/plain; charset="utf-8" It was released on June 12, 2024. The update means we no longer have to care about json-c 0.13 present in Leap 15.5, which solves some whitespace issues in tests. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- ci/containers/opensuse-leap-15.Dockerfile | 2 +- ci/gitlab/builds.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/containers/opensuse-leap-15.Dockerfile b/ci/containers/open= suse-leap-15.Dockerfile index bf794d6929..b152528378 100644 --- a/ci/containers/opensuse-leap-15.Dockerfile +++ b/ci/containers/opensuse-leap-15.Dockerfile @@ -4,7 +4,7 @@ # # https://gitlab.com/libvirt/libvirt-ci =20 -FROM registry.opensuse.org/opensuse/leap:15.5 +FROM registry.opensuse.org/opensuse/leap:15.6 =20 RUN zypper update -y && \ zypper install -y \ diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index a0a64c1ec1..214119b902 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -191,7 +191,7 @@ x86_64-opensuse-leap-15: CFLAGS: -Wno-missing-include-dirs NAME: opensuse-leap-15 RPM: skip - TARGET_BASE_IMAGE: registry.opensuse.org/opensuse/leap:15.5 + TARGET_BASE_IMAGE: registry.opensuse.org/opensuse/leap:15.6 =20 =20 x86_64-opensuse-tumbleweed: --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723671980599613.9062804674428; Wed, 14 Aug 2024 14:46:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9B66E12C3; Wed, 14 Aug 2024 17:46:19 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8670F1522; Wed, 14 Aug 2024 17:43:21 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0ABC512B4; Wed, 14 Aug 2024 17:43:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9E0551282 for ; Wed, 14 Aug 2024 17:43:11 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-vDXEZyjdM7WMQNCYHnUEzQ-1; Wed, 14 Aug 2024 17:43:10 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 425D01955F03 for ; Wed, 14 Aug 2024 21:43:09 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 76EA91955E8C for ; Wed, 14 Aug 2024 21:43:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ar8PjKcVZJZG3ZcnQclx8/rC9xXjnPGpqC3ZM1uOxKg=; b=CRYbbsAzCf6gP6Q2oj8woPj+KLar5I76pb82bFXcMmZ358D/xGONMa1hoaJ1QYPHWLCUem BqfHA2/r7iD6qI6QG0aU+KMNT0+7Ph5tvAhzPDHl3U2xUgL+SWizAQjihzSpFebBt3vNZT suBtag9ddgqbeRBlP7lsfD/pfffnzfA= X-MC-Unique: vDXEZyjdM7WMQNCYHnUEzQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 03/20] util: json: introduce virJSONStringPrettifyBlanks Date: Wed, 14 Aug 2024 23:40:18 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WMZ72E7JOPKZ2VTJTC4O4PMPR5X35CH7 X-Message-ID-Hash: WMZ72E7JOPKZ2VTJTC4O4PMPR5X35CH7 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723671982508116600 Content-Type: text/plain; charset="utf-8" A horribly named function for unifying formatting when pretty-printing empty JSON arrays and objects. Useful for having stable test output even if different JSON libraries format these differently. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virjson.c | 34 ++++++++++++++++++++++++++++++++++ src/util/virjson.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 0accca442a..01b332a905 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2609,6 +2609,7 @@ virISCSIScanTargets; =20 =20 # util/virjson.h +virJSONStringPrettifyBlanks; virJSONStringReformat; virJSONValueArrayAppend; virJSONValueArrayAppendString; diff --git a/src/util/virjson.c b/src/util/virjson.c index 57707350da..0edf86cd1c 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1861,6 +1861,40 @@ virJSONStringReformat(const char *jsonstr, return virJSONValueToString(json, pretty); } =20 +/** + * virJSONStringPrettifyBlanks: + * @jsonstr: string to prettify + * + * In the pretty mode of printing, various versions of JSON libraries + * format empty arrays and objects differently. + * + * Unify this to "[]" and "{}" which are used by json-c 0.17 and newer. + * https://github.com/json-c/json-c/issues/778 + * + * This format is also used by Python's 'json.dump' method. + * + * Returns the reformatted JSON string on success. + */ +char *virJSONStringPrettifyBlanks(const char *jsonstr) +{ + virBuffer buf =3D VIR_BUFFER_INITIALIZER; + const char *p; + + for (p =3D jsonstr; *p && p[1]; p++) { + virBufferAddChar(&buf, *p); + + if ((p[0] =3D=3D '{' || p[0] =3D=3D '[') && p[1] =3D=3D '\n') { + const char *q =3D p + 1; + + virSkipSpaces(&q); + + if (*q =3D=3D '}' || *q =3D=3D ']') + p =3D q - 1; + } + } + + return virBufferContentAndReset(&buf); +} =20 static virJSONValue * virJSONValueObjectDeflattenKeys(virJSONValue *json); diff --git a/src/util/virjson.h b/src/util/virjson.h index e622798fe7..d8481e5890 100644 --- a/src/util/virjson.h +++ b/src/util/virjson.h @@ -271,6 +271,8 @@ virJSONValueCopy(const virJSONValue *in); char * virJSONStringReformat(const char *jsonstr, bool pretty); +char * +virJSONStringPrettifyBlanks(const char *jsonstr); =20 virJSONValue * virJSONValueObjectDeflatten(virJSONValue *json); --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723672417143938.3550366619363; Wed, 14 Aug 2024 14:53:37 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1E67B12A3; Wed, 14 Aug 2024 17:53:36 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 84345141F; Wed, 14 Aug 2024 17:43:26 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3C4C81361; Wed, 14 Aug 2024 17:43:20 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C255512E4 for ; Wed, 14 Aug 2024 17:43:12 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-Gq9AlaM3OEaEg_lSC1NNbA-1; Wed, 14 Aug 2024 17:43:11 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3FEA91944D24 for ; Wed, 14 Aug 2024 21:43:10 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8B2C41955E8C for ; Wed, 14 Aug 2024 21:43:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YcSYL8IQH+seBqj0+yjMCk7AWeCQ/xrQk48/ZUnEkrc=; b=bNHLaSKegrtFYmQIAmEtp1iwhMFhlVIsV2yEc+qelkxxB3r5+P2z2Hfkw8B04puCc2V++o Yt3aqjqi70N25h888r4krK9ETVqD1ZQ2BvvqrwwOQZkblw30ZqtokLpOapbFSlHbvPAEzq dc0zUjCvIyNJn69ajCx85i2LoUETaCY= X-MC-Unique: Gq9AlaM3OEaEg_lSC1NNbA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 04/20] tests: switch to compact empty JSON object formatting Date: Wed, 14 Aug 2024 23:40:19 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CLHCQFJN2SU7N6GKMBNXQ5JHROYXMZFG X-Message-ID-Hash: CLHCQFJN2SU7N6GKMBNXQ5JHROYXMZFG X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723672418269116600 Content-Type: text/plain; charset="utf-8" Some earlier versions of json-c format empty elements differently. Run the tests who use the pretty formatting for readability and diffability through a function that unifies the output. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- tests/qemublocktest.c | 5 ++++- tests/qemublocktestdata/backupmerge/empty-out.json | 4 +--- tests/qemumigparamsdata/empty.json | 4 +--- tests/qemumigparamstest.c | 5 ++++- tests/virmacmaptest.c | 5 ++++- tests/virmacmaptestdata/empty.json | 4 +--- 6 files changed, 15 insertions(+), 12 deletions(-) diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index c581bd1748..6c4e735466 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -720,6 +720,7 @@ testQemuBackupIncrementalBitmapCalculate(const void *op= aque) g_autofree char *expectpath =3D NULL; g_autoptr(virStorageSource) target =3D NULL; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; + g_autofree char *actual =3D NULL; =20 expectpath =3D g_strdup_printf("%s/%s%s-out.json", abs_srcdir, backupDataPrefix, data->name); @@ -748,7 +749,9 @@ testQemuBackupIncrementalBitmapCalculate(const void *op= aque) virBufferAddLit(&buf, "NULL\n"); } =20 - return virTestCompareToFile(virBufferCurrentContent(&buf), expectpath); + actual =3D virJSONStringPrettifyBlanks(virBufferCurrentContent(&buf)); + + return virTestCompareToFile(actual, expectpath); } =20 =20 diff --git a/tests/qemublocktestdata/backupmerge/empty-out.json b/tests/qem= ublocktestdata/backupmerge/empty-out.json index 41b42e677b..fe51488c70 100644 --- a/tests/qemublocktestdata/backupmerge/empty-out.json +++ b/tests/qemublocktestdata/backupmerge/empty-out.json @@ -1,3 +1 @@ -[ - -] +[] diff --git a/tests/qemumigparamsdata/empty.json b/tests/qemumigparamsdata/e= mpty.json index 0db3279e44..0967ef424b 100644 --- a/tests/qemumigparamsdata/empty.json +++ b/tests/qemumigparamsdata/empty.json @@ -1,3 +1 @@ -{ - -} +{} diff --git a/tests/qemumigparamstest.c b/tests/qemumigparamstest.c index 5d45a9dd58..67cc14d948 100644 --- a/tests/qemumigparamstest.c +++ b/tests/qemumigparamstest.c @@ -137,6 +137,7 @@ qemuMigParamsTestJSON(const void *opaque) g_autoptr(virJSONValue) paramsIn =3D NULL; g_autoptr(virJSONValue) paramsOut =3D NULL; g_autoptr(qemuMigrationParams) migParams =3D NULL; + g_autofree char *formattedJSON =3D NULL; g_autofree char *actualJSON =3D NULL; g_auto(virBuffer) debug =3D VIR_BUFFER_INITIALIZER; =20 @@ -156,9 +157,11 @@ qemuMigParamsTestJSON(const void *opaque) return -1; =20 if (!(paramsOut =3D qemuMigrationParamsToJSON(migParams, false)) || - !(actualJSON =3D virJSONValueToString(paramsOut, true))) + !(formattedJSON =3D virJSONValueToString(paramsOut, true))) return -1; =20 + actualJSON =3D virJSONStringPrettifyBlanks(formattedJSON); + if (testQEMUSchemaValidateCommand("migrate-set-parameters", paramsOut, data->qmpschema, diff --git a/tests/virmacmaptest.c b/tests/virmacmaptest.c index 9a28c1bed0..074bc8f659 100644 --- a/tests/virmacmaptest.c +++ b/tests/virmacmaptest.c @@ -118,13 +118,16 @@ testMACFlush(const void *opaque) const struct testData *data =3D opaque; g_autofree char *file =3D NULL; g_autofree char *str =3D NULL; + g_autofree char *actual =3D NULL; =20 file =3D g_strdup_printf("%s/virmacmaptestdata/%s.json", abs_srcdir, d= ata->file); =20 if (virMacMapDumpStr(data->mgr, &str) < 0) return -1; =20 - if (virTestCompareToFile(str, file) < 0) + actual =3D virJSONStringPrettifyBlanks(str); + + if (virTestCompareToFile(actual, file) < 0) return -1; =20 return 0; diff --git a/tests/virmacmaptestdata/empty.json b/tests/virmacmaptestdata/e= mpty.json index 41b42e677b..fe51488c70 100644 --- a/tests/virmacmaptestdata/empty.json +++ b/tests/virmacmaptestdata/empty.json @@ -1,3 +1 @@ -[ - -] +[] --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723672572816701.9890126200542; Wed, 14 Aug 2024 14:56:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C59C11596; Wed, 14 Aug 2024 17:56:11 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E636212E6; Wed, 14 Aug 2024 17:43:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BADCB13D4; Wed, 14 Aug 2024 17:43:28 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 47C05140A for ; Wed, 14 Aug 2024 17:43:14 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-XiC9TvuuNuyFxpG4oPS9iA-1; Wed, 14 Aug 2024 17:43:12 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4FBC01955F4A for ; Wed, 14 Aug 2024 21:43:11 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9FA741955E8C for ; Wed, 14 Aug 2024 21:43:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PyuErt3riThffEgZyRn4o/nTaY66cHRlpJqMohvaSHA=; b=GdQajtFqV4bSSfdZn1ByaWP1zuWkgevSQgnYnFlhcNuUriCkR+dwh7Pi00aYPsaAIXjH4b 2zTY6+tTs9/r/pk4TqNt+G3Qt5ycCEHq/jQr1N4sLgwuBlZAZxgWeNGkwJ2Jt1vmj0XON5 YuDC1F3oQkpEoSqZKXBUZjSPD8otjn4= X-MC-Unique: XiC9TvuuNuyFxpG4oPS9iA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 05/20] meson: add option for building with json-c Date: Wed, 14 Aug 2024 23:40:20 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2DNYAZXARZ7LPOG7XOJKGE545OMFDILR X-Message-ID-Hash: 2DNYAZXARZ7LPOG7XOJKGE545OMFDILR X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723672575187116600 Content-Type: text/plain; charset="utf-8" Also disable it immediately for the mingw build because it's not available there. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- libvirt.spec.in | 1 + meson.build | 7 +++++++ meson_options.txt | 1 + 3 files changed, 9 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 29101e74fe..ad0f4f784f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1441,6 +1441,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Dfuse=3Ddisabled \ -Dglusterfs=3Ddisabled \ -Dhost_validate=3Ddisabled \ + -Djson_c=3Ddisabled \ -Dlibiscsi=3Ddisabled \ -Dnbdkit=3Ddisabled \ -Dnbdkit_config_default=3Ddisabled \ diff --git a/meson.build b/meson.build index f31485c395..39d6d700d3 100644 --- a/meson.build +++ b/meson.build @@ -1018,6 +1018,12 @@ glusterfs_dep =3D dependency('glusterfs-api', versio= n: '>=3D' + glusterfs_version, r gnutls_version =3D '3.6.0' gnutls_dep =3D dependency('gnutls', version: '>=3D' + gnutls_version) =20 +json_c_version =3D '0.14' +json_c_dep =3D dependency('json-c', version: '>=3D' + json_c_version, requ= ired: get_option('json_c')) +if json_c_dep.found() + conf.set('WITH_JSON_C', 1) +endif + # Check for BSD kvm (kernel memory interface) if host_machine.system() =3D=3D 'freebsd' libkvm_dep =3D cc.find_library('kvm') @@ -2342,6 +2348,7 @@ libs_summary =3D { 'dlopen': dlopen_dep.found(), 'fuse': fuse_dep.found(), 'glusterfs': glusterfs_dep.found(), + 'json-c': json_c_dep.found(), 'libiscsi': libiscsi_dep.found(), 'libkvm': libkvm_dep.found(), 'libnbd': libnbd_dep.found(), diff --git a/meson_options.txt b/meson_options.txt index 2d440c63d8..9b1610fcfe 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -28,6 +28,7 @@ option('capng', type: 'feature', value: 'auto', descripti= on: 'cap-ng support') option('curl', type: 'feature', value: 'auto', description: 'curl support') option('fuse', type: 'feature', value: 'auto', description: 'fuse support') option('glusterfs', type: 'feature', value: 'auto', description: 'glusterf= s support') +option('json_c', type: 'feature', value: 'auto', description: 'JSON-C supp= ort') option('libiscsi', type: 'feature', value: 'auto', description: 'libiscsi = support') option('libnl', type: 'feature', value: 'auto', description: 'libnl suppor= t') option('libpcap', type: 'feature', value: 'auto', description: 'libpcap su= pport') --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723673698645423.2962599609741; Wed, 14 Aug 2024 15:14:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9F457C16; Wed, 14 Aug 2024 18:14:57 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 723411571; Wed, 14 Aug 2024 17:44:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3E06F135A; Wed, 14 Aug 2024 17:44:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 736EA1426 for ; Wed, 14 Aug 2024 17:43:26 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-XkpGmP9yMcSz3ovdiYgCYw-1; Wed, 14 Aug 2024 17:43:13 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E9481953948 for ; Wed, 14 Aug 2024 21:43:12 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B454E196BE80 for ; Wed, 14 Aug 2024 21:43:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQ0/EGsRGc8lIzE1LwA9cXQlcaU/ZGw25Lp22l1mirw=; b=C/O56jxtGheNn8/g9EdjIGCt0/ozhPRr5nNnDpfdopjaZHq16xnOpmcCXihW+XkGci9IuM 0ZF2oxbCXnt3AVjGZRBXiRfhumtVdAoOa1qO5Z/2Fm66iZK8O0CqnPdg+dHYnT/5ACi6P8 TstQHf4gUTJ/SxRJWTgnMRlypvIfGUQ= X-MC-Unique: XkpGmP9yMcSz3ovdiYgCYw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 06/20] meson: link libvirt with json_c if available Date: Wed, 14 Aug 2024 23:40:21 +0200 Message-ID: <7bf0bf0a5b7441af00f8a9878f15e92e3feccb9e.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: T24GOJOSQMUSKKGWN2TMRIJKLV4ZDR5G X-Message-ID-Hash: T24GOJOSQMUSKKGWN2TMRIJKLV4ZDR5G X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723673699614116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko --- src/meson.build | 1 + src/util/meson.build | 1 + tests/meson.build | 1 + 3 files changed, 3 insertions(+) diff --git a/src/meson.build b/src/meson.build index 8cce42c7ad..b9652785dd 100644 --- a/src/meson.build +++ b/src/meson.build @@ -552,6 +552,7 @@ if conf.has('WITH_REMOTE') capng_dep, devmapper_dep, gnutls_dep, + json_c_dep, libssh2_dep, libssh_dep, sasl_dep, diff --git a/src/util/meson.build b/src/util/meson.build index 896c795150..ab6942fa81 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -193,6 +193,7 @@ virt_util_lib =3D static_library( capng_dep, devmapper_dep, gnutls_dep, + json_c_dep, intl_dep, libm_dep, libnl_dep, diff --git a/tests/meson.build b/tests/meson.build index 2f1eda1f95..d1fc122fc7 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -10,6 +10,7 @@ tests_dep =3D declare_dependency( dlopen_dep, glib_dep, gnutls_dep, + json_c_dep, libnl_dep, libxml_dep, rpc_dep, --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723672457491305.5801506216163; Wed, 14 Aug 2024 14:54:17 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 62AD8135F; Wed, 14 Aug 2024 17:54:16 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 44682157B; Wed, 14 Aug 2024 17:43:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E1F341370; Wed, 14 Aug 2024 17:43:26 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F06081441 for ; Wed, 14 Aug 2024 17:43:15 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-O58due7EMZ2xPeBbx0gqkA-1; Wed, 14 Aug 2024 17:43:14 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 83F171954B0F for ; Wed, 14 Aug 2024 21:43:13 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D223B1955E8C for ; Wed, 14 Aug 2024 21:43:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0QpdawE802YXLyERValDiMOL/VjP1MI54iaHT6+tg1Y=; b=QCZ29PsCEX4UNTfPrAE0YmrCTkEeQ5VyA59kgL3O26tVB/hEODYRSU2uGGzX1Y8PxoLvou Okqu8+EjaP6D9QhNHkgV2VI0yS0/2XwRB6gVzqlttMrbaPab29bG8RdsPXAlnTUX6oLgNM 8L2b12GGLyfWVkOOXOnMKGLfVbgLZwQ= X-MC-Unique: O58due7EMZ2xPeBbx0gqkA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 07/20] util: json: write a json-c implementation Date: Wed, 14 Aug 2024 23:40:22 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KIKAU6RLXRG75OUFXFJHWPQABGTNDCJR X-Message-ID-Hash: KIKAU6RLXRG75OUFXFJHWPQABGTNDCJR X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723672458378116600 Content-Type: text/plain; charset="utf-8" Write an alternative implementation of our virJSON functions, using json-c instead of yajl. Signed-off-by: J=C3=A1n Tomko --- src/util/virjson.c | 177 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 175 insertions(+), 2 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 0edf86cd1c..7a22c54f03 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -32,7 +32,9 @@ #include "virenum.h" #include "virbitmap.h" =20 -#if WITH_YAJL +#if WITH_JSON_C +# include +#elif WITH_YAJL # include # include =20 @@ -1389,8 +1391,179 @@ virJSONValueCopy(const virJSONValue *in) return out; } =20 +#if WITH_JSON_C +static virJSONValue * +virJSONValueFromJsonC(json_object *jobj) +{ + enum json_type type =3D json_object_get_type(jobj); + virJSONValue *ret =3D NULL; =20 -#if WITH_YAJL + switch (type) { + case json_type_null: + ret =3D virJSONValueNewNull(); + break; + case json_type_boolean: + ret =3D virJSONValueNewBoolean(json_object_get_boolean(jobj)); + break; + case json_type_double: + case json_type_int: { + ret =3D virJSONValueNewNumber(g_strdup(json_object_get_string(jobj= ))); + break; + } + case json_type_object: + ret =3D virJSONValueNewObject(); + { + json_object_object_foreach(jobj, key, val) { + virJSONValue *cur =3D virJSONValueFromJsonC(val); + + if (virJSONValueObjectAppend(ret, key, &cur) < 0) { + g_free(ret); + return NULL; + } + } + } + break; + case json_type_array: { + size_t len; + size_t i; + + ret =3D virJSONValueNewArray(); + len =3D json_object_array_length(jobj); + + for (i =3D 0; i < len; i++) { + virJSONValue *cur =3D NULL; + json_object *val =3D NULL; + + val =3D json_object_array_get_idx(jobj, i); + + cur =3D virJSONValueFromJsonC(val); + + virJSONValueArrayAppend(ret, &cur); + } + break; + } + case json_type_string: + ret =3D virJSONValueNewString(g_strdup(json_object_get_string(jobj= ))); + break; + } + + VIR_DEBUG("ret=3D%p", ret); + return ret; +} + +virJSONValue * +virJSONValueFromString(const char *jsonstring) +{ + json_object *jobj =3D NULL; + virJSONValue *ret =3D NULL; + json_tokener *tok =3D NULL; + enum json_tokener_error jerr; + int jsonflags =3D JSON_TOKENER_STRICT | JSON_TOKENER_VALIDATE_UTF8; + + VIR_DEBUG("string=3D%s", jsonstring); + + tok =3D json_tokener_new(); + json_tokener_set_flags(tok, jsonflags); + jobj =3D json_tokener_parse_ex(tok, jsonstring, strlen(jsonstring)); + jerr =3D json_tokener_get_error(tok); + if (jerr !=3D json_tokener_success) { + virReportError(VIR_ERR_INTERNAL_ERROR, + "%s", json_tokener_error_desc(jerr)); + goto cleanup; + } + ret =3D virJSONValueFromJsonC(jobj); + + cleanup: + VIR_DEBUG("result=3D%p", ret); + json_object_put(jobj); + json_tokener_free(tok); + return ret; +} + +static json_object * +virJSONValueToJsonC(virJSONValue *object) +{ + json_object *ret =3D NULL; + size_t i; + + VIR_DEBUG("object=3D%p type=3D%d", object, object->type); + + switch (object->type) { + case VIR_JSON_TYPE_OBJECT: + // constant key? + ret =3D json_object_new_object(); + for (i =3D 0; i < object->data.object.npairs; i++) { + json_object *child =3D virJSONValueToJsonC(object->data.object= .pairs[i].value); + json_object_object_add(ret, object->data.object.pairs[i].key, = child); + } + return ret; + case VIR_JSON_TYPE_ARRAY: + /* json_object_new_array_ext was introduced in json-c 0.16 */ +# if JSON_C_VERSION_NUM < ((0 << 16) | (16 << 8)) + ret =3D json_object_new_array(); +# else + ret =3D json_object_new_array_ext(object->data.array.nvalues); +# endif + for (i =3D 0; i < object->data.array.nvalues; i++) { + json_object_array_add(ret, + virJSONValueToJsonC(object->data.array.v= alues[i])); + } + return ret; + + case VIR_JSON_TYPE_STRING: + return json_object_new_string(object->data.string); + + case VIR_JSON_TYPE_NUMBER: { + /* Yes. That's a random value. We only care about the string. */ + return json_object_new_double_s(299792458, object->data.number); + } + case VIR_JSON_TYPE_BOOLEAN: + return json_object_new_boolean(object->data.boolean); + + case VIR_JSON_TYPE_NULL: + default: + return NULL; + } + return NULL; +} + + +int +virJSONValueToBuffer(virJSONValue *object, + virBuffer *buf, + bool pretty) +{ + json_object *jobj =3D NULL; + const char *str; + size_t len; + int ret =3D -1; + int jsonflags =3D JSON_C_TO_STRING_NOSLASHESCAPE; + + VIR_DEBUG("object=3D%p", object); + + if (pretty) + jsonflags |=3D JSON_C_TO_STRING_PRETTY | JSON_C_TO_STRING_SPACED; + + jobj =3D virJSONValueToJsonC(object); + if (!jobj) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("failed to convert virJSONValue to json-c data")); + goto cleanup; + } + + str =3D json_object_to_json_string_length(jobj, jsonflags, &len); + + virBufferAdd(buf, str, len); + if (pretty) + virBufferAddLit(buf, "\n"); + ret =3D 0; + + cleanup: + json_object_put(jobj); + return ret; +} + +#elif WITH_YAJL static int virJSONParserInsertValue(virJSONParser *parser, virJSONValue **value) --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723673455550382.15300478732433; Wed, 14 Aug 2024 15:10:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5A05E1546; Wed, 14 Aug 2024 18:10:54 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C6752143E; Wed, 14 Aug 2024 17:43:42 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 608A51546; Wed, 14 Aug 2024 17:43:38 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 299BB1282 for ; Wed, 14 Aug 2024 17:43:18 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-mWCjWM_cNy-ogbjo-Ux91A-1; Wed, 14 Aug 2024 17:43:15 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0BFFE1955F4A for ; Wed, 14 Aug 2024 21:43:15 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E79551955E8C for ; Wed, 14 Aug 2024 21:43:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OJ8NKODVvotEZcFx0WKzKPlGr0+rupMH+XyVX+LCdu8=; b=VNBtlUY0HkjoBcqKFkqsjKnrrOA2/Jii+c9QNx/64UujQYPvH4+cjQJSDxh6VJGrLE1BWT KQGymQKF9MIcqrNoMQhSCdR6J6rkENKWHlu6g+nn1X5g9atxU2y3VANS5kJmGNN6Is5rNC 7pPe/8dnqu8cZ5SQnT4hPne8wHdeSRg= X-MC-Unique: mWCjWM_cNy-ogbjo-Ux91A-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 08/20] ci: install json-c too Date: Wed, 14 Aug 2024 23:40:23 +0200 Message-ID: <35ae42b809f491aa0e0cedaf2e6b8fc7aa5a4daf.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WOV6IGT6ASORRL3JF56FAEGPIZ4WFFVF X-Message-ID-Hash: WOV6IGT6ASORRL3JF56FAEGPIZ4WFFVF X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723673456807116600 Content-Type: text/plain; charset="utf-8" Now that we actually have some working code using json-c, install it in our CI to demonstrate that it works. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- ci/buildenv/almalinux-9.sh | 1 + ci/buildenv/alpine-319.sh | 1 + ci/buildenv/alpine-edge.sh | 1 + ci/buildenv/centos-stream-9.sh | 1 + ci/buildenv/debian-11-cross-aarch64.sh | 1 + ci/buildenv/debian-11-cross-armv6l.sh | 1 + ci/buildenv/debian-11-cross-armv7l.sh | 1 + ci/buildenv/debian-11-cross-i686.sh | 1 + ci/buildenv/debian-11-cross-mips64el.sh | 1 + ci/buildenv/debian-11-cross-mipsel.sh | 1 + ci/buildenv/debian-11-cross-ppc64le.sh | 1 + ci/buildenv/debian-11-cross-s390x.sh | 1 + ci/buildenv/debian-11.sh | 1 + ci/buildenv/debian-12-cross-aarch64.sh | 1 + ci/buildenv/debian-12-cross-armv6l.sh | 1 + ci/buildenv/debian-12-cross-armv7l.sh | 1 + ci/buildenv/debian-12-cross-i686.sh | 1 + ci/buildenv/debian-12-cross-mips64el.sh | 1 + ci/buildenv/debian-12-cross-mipsel.sh | 1 + ci/buildenv/debian-12-cross-ppc64le.sh | 1 + ci/buildenv/debian-12-cross-s390x.sh | 1 + ci/buildenv/debian-12.sh | 1 + ci/buildenv/debian-sid-cross-aarch64.sh | 1 + ci/buildenv/debian-sid-cross-armv6l.sh | 1 + ci/buildenv/debian-sid-cross-armv7l.sh | 1 + ci/buildenv/debian-sid-cross-i686.sh | 1 + ci/buildenv/debian-sid-cross-mips64el.sh | 1 + ci/buildenv/debian-sid-cross-ppc64le.sh | 1 + ci/buildenv/debian-sid-cross-s390x.sh | 1 + ci/buildenv/debian-sid.sh | 1 + ci/buildenv/fedora-39.sh | 1 + ci/buildenv/fedora-40.sh | 1 + ci/buildenv/fedora-rawhide.sh | 1 + ci/buildenv/opensuse-leap-15.sh | 1 + ci/buildenv/opensuse-tumbleweed.sh | 1 + ci/buildenv/ubuntu-2204.sh | 1 + ci/buildenv/ubuntu-2404.sh | 1 + ci/cirrus/freebsd-13.vars | 2 +- ci/cirrus/freebsd-14.vars | 2 +- ci/cirrus/macos-13.vars | 2 +- ci/cirrus/macos-14.vars | 2 +- ci/containers/almalinux-9.Dockerfile | 1 + ci/containers/alpine-319.Dockerfile | 1 + ci/containers/alpine-edge.Dockerfile | 1 + ci/containers/centos-stream-9.Dockerfile | 1 + ci/containers/debian-11-cross-aarch64.Dockerfile | 1 + ci/containers/debian-11-cross-armv6l.Dockerfile | 1 + ci/containers/debian-11-cross-armv7l.Dockerfile | 1 + ci/containers/debian-11-cross-i686.Dockerfile | 1 + ci/containers/debian-11-cross-mips64el.Dockerfile | 1 + ci/containers/debian-11-cross-mipsel.Dockerfile | 1 + ci/containers/debian-11-cross-ppc64le.Dockerfile | 1 + ci/containers/debian-11-cross-s390x.Dockerfile | 1 + ci/containers/debian-11.Dockerfile | 1 + ci/containers/debian-12-cross-aarch64.Dockerfile | 1 + ci/containers/debian-12-cross-armv6l.Dockerfile | 1 + ci/containers/debian-12-cross-armv7l.Dockerfile | 1 + ci/containers/debian-12-cross-i686.Dockerfile | 1 + ci/containers/debian-12-cross-mips64el.Dockerfile | 1 + ci/containers/debian-12-cross-mipsel.Dockerfile | 1 + ci/containers/debian-12-cross-ppc64le.Dockerfile | 1 + ci/containers/debian-12-cross-s390x.Dockerfile | 1 + ci/containers/debian-12.Dockerfile | 1 + ci/containers/debian-sid-cross-aarch64.Dockerfile | 1 + ci/containers/debian-sid-cross-armv6l.Dockerfile | 1 + ci/containers/debian-sid-cross-armv7l.Dockerfile | 1 + ci/containers/debian-sid-cross-i686.Dockerfile | 1 + ci/containers/debian-sid-cross-mips64el.Dockerfile | 1 + ci/containers/debian-sid-cross-ppc64le.Dockerfile | 1 + ci/containers/debian-sid-cross-s390x.Dockerfile | 1 + ci/containers/debian-sid.Dockerfile | 1 + ci/containers/fedora-39.Dockerfile | 1 + ci/containers/fedora-40.Dockerfile | 1 + ci/containers/fedora-rawhide.Dockerfile | 1 + ci/containers/opensuse-leap-15.Dockerfile | 1 + ci/containers/opensuse-tumbleweed.Dockerfile | 1 + ci/containers/ubuntu-2204.Dockerfile | 1 + ci/containers/ubuntu-2404.Dockerfile | 1 + ci/lcitool/projects/libvirt.yml | 1 + 79 files changed, 79 insertions(+), 4 deletions(-) diff --git a/ci/buildenv/almalinux-9.sh b/ci/buildenv/almalinux-9.sh index 5791a73d23..6ca05b4add 100644 --- a/ci/buildenv/almalinux-9.sh +++ b/ci/buildenv/almalinux-9.sh @@ -37,6 +37,7 @@ function install_buildenv() { iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/buildenv/alpine-319.sh b/ci/buildenv/alpine-319.sh index 43fcb38a46..fe8dcf8ab7 100644 --- a/ci/buildenv/alpine-319.sh +++ b/ci/buildenv/alpine-319.sh @@ -31,6 +31,7 @@ function install_buildenv() { grep \ iproute2 \ iptables \ + json-c-dev \ kmod \ libcap-ng-dev \ libnl3-dev \ diff --git a/ci/buildenv/alpine-edge.sh b/ci/buildenv/alpine-edge.sh index 43fcb38a46..fe8dcf8ab7 100644 --- a/ci/buildenv/alpine-edge.sh +++ b/ci/buildenv/alpine-edge.sh @@ -31,6 +31,7 @@ function install_buildenv() { grep \ iproute2 \ iptables \ + json-c-dev \ kmod \ libcap-ng-dev \ libnl3-dev \ diff --git a/ci/buildenv/centos-stream-9.sh b/ci/buildenv/centos-stream-9.sh index c23c60e026..ca5bce3eb9 100644 --- a/ci/buildenv/centos-stream-9.sh +++ b/ci/buildenv/centos-stream-9.sh @@ -38,6 +38,7 @@ function install_buildenv() { iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/buildenv/debian-11-cross-aarch64.sh b/ci/buildenv/debian-11= -cross-aarch64.sh index 8540fb8d74..2d9ad9064d 100644 --- a/ci/buildenv/debian-11-cross-aarch64.sh +++ b/ci/buildenv/debian-11-cross-aarch64.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:arm64 \ libgnutls28-dev:arm64 \ libiscsi-dev:arm64 \ + libjson-c-dev:arm64 \ libnl-3-dev:arm64 \ libnl-route-3-dev:arm64 \ libnuma-dev:arm64 \ diff --git a/ci/buildenv/debian-11-cross-armv6l.sh b/ci/buildenv/debian-11-= cross-armv6l.sh index 131a7019c0..2be50a66c9 100644 --- a/ci/buildenv/debian-11-cross-armv6l.sh +++ b/ci/buildenv/debian-11-cross-armv6l.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:armel \ libgnutls28-dev:armel \ libiscsi-dev:armel \ + libjson-c-dev:armel \ libnl-3-dev:armel \ libnl-route-3-dev:armel \ libnuma-dev:armel \ diff --git a/ci/buildenv/debian-11-cross-armv7l.sh b/ci/buildenv/debian-11-= cross-armv7l.sh index ba78ffcfac..6d6ef91868 100644 --- a/ci/buildenv/debian-11-cross-armv7l.sh +++ b/ci/buildenv/debian-11-cross-armv7l.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:armhf \ libgnutls28-dev:armhf \ libiscsi-dev:armhf \ + libjson-c-dev:armhf \ libnl-3-dev:armhf \ libnl-route-3-dev:armhf \ libnuma-dev:armhf \ diff --git a/ci/buildenv/debian-11-cross-i686.sh b/ci/buildenv/debian-11-cr= oss-i686.sh index 104eb20805..b8bd49e3a8 100644 --- a/ci/buildenv/debian-11-cross-i686.sh +++ b/ci/buildenv/debian-11-cross-i686.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:i386 \ libgnutls28-dev:i386 \ libiscsi-dev:i386 \ + libjson-c-dev:i386 \ libnl-3-dev:i386 \ libnl-route-3-dev:i386 \ libnuma-dev:i386 \ diff --git a/ci/buildenv/debian-11-cross-mips64el.sh b/ci/buildenv/debian-1= 1-cross-mips64el.sh index 7b1830453c..3d5b75139c 100644 --- a/ci/buildenv/debian-11-cross-mips64el.sh +++ b/ci/buildenv/debian-11-cross-mips64el.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:mips64el \ libgnutls28-dev:mips64el \ libiscsi-dev:mips64el \ + libjson-c-dev:mips64el \ libnl-3-dev:mips64el \ libnl-route-3-dev:mips64el \ libnuma-dev:mips64el \ diff --git a/ci/buildenv/debian-11-cross-mipsel.sh b/ci/buildenv/debian-11-= cross-mipsel.sh index eef5cdbfab..20a97c165e 100644 --- a/ci/buildenv/debian-11-cross-mipsel.sh +++ b/ci/buildenv/debian-11-cross-mipsel.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:mipsel \ libgnutls28-dev:mipsel \ libiscsi-dev:mipsel \ + libjson-c-dev:mipsel \ libnl-3-dev:mipsel \ libnl-route-3-dev:mipsel \ libnuma-dev:mipsel \ diff --git a/ci/buildenv/debian-11-cross-ppc64le.sh b/ci/buildenv/debian-11= -cross-ppc64le.sh index f2c2f60623..2b5ebf360d 100644 --- a/ci/buildenv/debian-11-cross-ppc64le.sh +++ b/ci/buildenv/debian-11-cross-ppc64le.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:ppc64el \ libgnutls28-dev:ppc64el \ libiscsi-dev:ppc64el \ + libjson-c-dev:ppc64el \ libnl-3-dev:ppc64el \ libnl-route-3-dev:ppc64el \ libnuma-dev:ppc64el \ diff --git a/ci/buildenv/debian-11-cross-s390x.sh b/ci/buildenv/debian-11-c= ross-s390x.sh index 519d9c8b31..1391685e46 100644 --- a/ci/buildenv/debian-11-cross-s390x.sh +++ b/ci/buildenv/debian-11-cross-s390x.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglusterfs-dev:s390x \ libgnutls28-dev:s390x \ libiscsi-dev:s390x \ + libjson-c-dev:s390x \ libnl-3-dev:s390x \ libnl-route-3-dev:s390x \ libnuma-dev:s390x \ diff --git a/ci/buildenv/debian-11.sh b/ci/buildenv/debian-11.sh index 5986682af8..e56ea3b3ec 100644 --- a/ci/buildenv/debian-11.sh +++ b/ci/buildenv/debian-11.sh @@ -44,6 +44,7 @@ function install_buildenv() { libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnetcf-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/buildenv/debian-12-cross-aarch64.sh b/ci/buildenv/debian-12= -cross-aarch64.sh index 5fc7e8a801..4f7285e171 100644 --- a/ci/buildenv/debian-12-cross-aarch64.sh +++ b/ci/buildenv/debian-12-cross-aarch64.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:arm64 \ libgnutls28-dev:arm64 \ libiscsi-dev:arm64 \ + libjson-c-dev:arm64 \ libnl-3-dev:arm64 \ libnl-route-3-dev:arm64 \ libnuma-dev:arm64 \ diff --git a/ci/buildenv/debian-12-cross-armv6l.sh b/ci/buildenv/debian-12-= cross-armv6l.sh index 24d7d80380..6d98d1deff 100644 --- a/ci/buildenv/debian-12-cross-armv6l.sh +++ b/ci/buildenv/debian-12-cross-armv6l.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:armel \ libgnutls28-dev:armel \ libiscsi-dev:armel \ + libjson-c-dev:armel \ libnl-3-dev:armel \ libnl-route-3-dev:armel \ libnuma-dev:armel \ diff --git a/ci/buildenv/debian-12-cross-armv7l.sh b/ci/buildenv/debian-12-= cross-armv7l.sh index 35738e6bb2..39d064b659 100644 --- a/ci/buildenv/debian-12-cross-armv7l.sh +++ b/ci/buildenv/debian-12-cross-armv7l.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:armhf \ libgnutls28-dev:armhf \ libiscsi-dev:armhf \ + libjson-c-dev:armhf \ libnl-3-dev:armhf \ libnl-route-3-dev:armhf \ libnuma-dev:armhf \ diff --git a/ci/buildenv/debian-12-cross-i686.sh b/ci/buildenv/debian-12-cr= oss-i686.sh index dce90645c0..aa91d6e08a 100644 --- a/ci/buildenv/debian-12-cross-i686.sh +++ b/ci/buildenv/debian-12-cross-i686.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:i386 \ libgnutls28-dev:i386 \ libiscsi-dev:i386 \ + libjson-c-dev:i386 \ libnl-3-dev:i386 \ libnl-route-3-dev:i386 \ libnuma-dev:i386 \ diff --git a/ci/buildenv/debian-12-cross-mips64el.sh b/ci/buildenv/debian-1= 2-cross-mips64el.sh index 6d3e43aeb0..e3b92bf9db 100644 --- a/ci/buildenv/debian-12-cross-mips64el.sh +++ b/ci/buildenv/debian-12-cross-mips64el.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:mips64el \ libgnutls28-dev:mips64el \ libiscsi-dev:mips64el \ + libjson-c-dev:mips64el \ libnl-3-dev:mips64el \ libnl-route-3-dev:mips64el \ libnuma-dev:mips64el \ diff --git a/ci/buildenv/debian-12-cross-mipsel.sh b/ci/buildenv/debian-12-= cross-mipsel.sh index b3a9ba1f40..7c5de342a4 100644 --- a/ci/buildenv/debian-12-cross-mipsel.sh +++ b/ci/buildenv/debian-12-cross-mipsel.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:mipsel \ libgnutls28-dev:mipsel \ libiscsi-dev:mipsel \ + libjson-c-dev:mipsel \ libnl-3-dev:mipsel \ libnl-route-3-dev:mipsel \ libnuma-dev:mipsel \ diff --git a/ci/buildenv/debian-12-cross-ppc64le.sh b/ci/buildenv/debian-12= -cross-ppc64le.sh index 1cda4f7928..05f2a2bd54 100644 --- a/ci/buildenv/debian-12-cross-ppc64le.sh +++ b/ci/buildenv/debian-12-cross-ppc64le.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:ppc64el \ libgnutls28-dev:ppc64el \ libiscsi-dev:ppc64el \ + libjson-c-dev:ppc64el \ libnl-3-dev:ppc64el \ libnl-route-3-dev:ppc64el \ libnuma-dev:ppc64el \ diff --git a/ci/buildenv/debian-12-cross-s390x.sh b/ci/buildenv/debian-12-c= ross-s390x.sh index f0cbfad5a4..b092d59b9d 100644 --- a/ci/buildenv/debian-12-cross-s390x.sh +++ b/ci/buildenv/debian-12-cross-s390x.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:s390x \ libgnutls28-dev:s390x \ libiscsi-dev:s390x \ + libjson-c-dev:s390x \ libnl-3-dev:s390x \ libnl-route-3-dev:s390x \ libnuma-dev:s390x \ diff --git a/ci/buildenv/debian-12.sh b/ci/buildenv/debian-12.sh index 5f19ba7526..01777c2165 100644 --- a/ci/buildenv/debian-12.sh +++ b/ci/buildenv/debian-12.sh @@ -44,6 +44,7 @@ function install_buildenv() { libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/buildenv/debian-sid-cross-aarch64.sh b/ci/buildenv/debian-s= id-cross-aarch64.sh index 5fc7e8a801..4f7285e171 100644 --- a/ci/buildenv/debian-sid-cross-aarch64.sh +++ b/ci/buildenv/debian-sid-cross-aarch64.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:arm64 \ libgnutls28-dev:arm64 \ libiscsi-dev:arm64 \ + libjson-c-dev:arm64 \ libnl-3-dev:arm64 \ libnl-route-3-dev:arm64 \ libnuma-dev:arm64 \ diff --git a/ci/buildenv/debian-sid-cross-armv6l.sh b/ci/buildenv/debian-si= d-cross-armv6l.sh index 46e374ea88..c5ced00879 100644 --- a/ci/buildenv/debian-sid-cross-armv6l.sh +++ b/ci/buildenv/debian-sid-cross-armv6l.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglib2.0-dev:armel \ libgnutls28-dev:armel \ libiscsi-dev:armel \ + libjson-c-dev:armel \ libnl-3-dev:armel \ libnl-route-3-dev:armel \ libnuma-dev:armel \ diff --git a/ci/buildenv/debian-sid-cross-armv7l.sh b/ci/buildenv/debian-si= d-cross-armv7l.sh index c8bb1b9539..38c3dffe1a 100644 --- a/ci/buildenv/debian-sid-cross-armv7l.sh +++ b/ci/buildenv/debian-sid-cross-armv7l.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglib2.0-dev:armhf \ libgnutls28-dev:armhf \ libiscsi-dev:armhf \ + libjson-c-dev:armhf \ libnl-3-dev:armhf \ libnl-route-3-dev:armhf \ libnuma-dev:armhf \ diff --git a/ci/buildenv/debian-sid-cross-i686.sh b/ci/buildenv/debian-sid-= cross-i686.sh index e74b2cee73..59694cca46 100644 --- a/ci/buildenv/debian-sid-cross-i686.sh +++ b/ci/buildenv/debian-sid-cross-i686.sh @@ -70,6 +70,7 @@ function install_buildenv() { libglib2.0-dev:i386 \ libgnutls28-dev:i386 \ libiscsi-dev:i386 \ + libjson-c-dev:i386 \ libnl-3-dev:i386 \ libnl-route-3-dev:i386 \ libnuma-dev:i386 \ diff --git a/ci/buildenv/debian-sid-cross-mips64el.sh b/ci/buildenv/debian-= sid-cross-mips64el.sh index 6d3e43aeb0..e3b92bf9db 100644 --- a/ci/buildenv/debian-sid-cross-mips64el.sh +++ b/ci/buildenv/debian-sid-cross-mips64el.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:mips64el \ libgnutls28-dev:mips64el \ libiscsi-dev:mips64el \ + libjson-c-dev:mips64el \ libnl-3-dev:mips64el \ libnl-route-3-dev:mips64el \ libnuma-dev:mips64el \ diff --git a/ci/buildenv/debian-sid-cross-ppc64le.sh b/ci/buildenv/debian-s= id-cross-ppc64le.sh index 1cda4f7928..05f2a2bd54 100644 --- a/ci/buildenv/debian-sid-cross-ppc64le.sh +++ b/ci/buildenv/debian-sid-cross-ppc64le.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:ppc64el \ libgnutls28-dev:ppc64el \ libiscsi-dev:ppc64el \ + libjson-c-dev:ppc64el \ libnl-3-dev:ppc64el \ libnl-route-3-dev:ppc64el \ libnuma-dev:ppc64el \ diff --git a/ci/buildenv/debian-sid-cross-s390x.sh b/ci/buildenv/debian-sid= -cross-s390x.sh index f0cbfad5a4..b092d59b9d 100644 --- a/ci/buildenv/debian-sid-cross-s390x.sh +++ b/ci/buildenv/debian-sid-cross-s390x.sh @@ -71,6 +71,7 @@ function install_buildenv() { libglusterfs-dev:s390x \ libgnutls28-dev:s390x \ libiscsi-dev:s390x \ + libjson-c-dev:s390x \ libnl-3-dev:s390x \ libnl-route-3-dev:s390x \ libnuma-dev:s390x \ diff --git a/ci/buildenv/debian-sid.sh b/ci/buildenv/debian-sid.sh index 5f19ba7526..01777c2165 100644 --- a/ci/buildenv/debian-sid.sh +++ b/ci/buildenv/debian-sid.sh @@ -44,6 +44,7 @@ function install_buildenv() { libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/buildenv/fedora-39.sh b/ci/buildenv/fedora-39.sh index db9d88eff4..06ae3bb62d 100644 --- a/ci/buildenv/fedora-39.sh +++ b/ci/buildenv/fedora-39.sh @@ -37,6 +37,7 @@ function install_buildenv() { iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/buildenv/fedora-40.sh b/ci/buildenv/fedora-40.sh index db9d88eff4..06ae3bb62d 100644 --- a/ci/buildenv/fedora-40.sh +++ b/ci/buildenv/fedora-40.sh @@ -37,6 +37,7 @@ function install_buildenv() { iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/buildenv/fedora-rawhide.sh b/ci/buildenv/fedora-rawhide.sh index f89a87ad63..aec2d87b53 100644 --- a/ci/buildenv/fedora-rawhide.sh +++ b/ci/buildenv/fedora-rawhide.sh @@ -38,6 +38,7 @@ function install_buildenv() { iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/buildenv/opensuse-leap-15.sh b/ci/buildenv/opensuse-leap-15= .sh index a59af136ca..d462e6cdce 100644 --- a/ci/buildenv/opensuse-leap-15.sh +++ b/ci/buildenv/opensuse-leap-15.sh @@ -43,6 +43,7 @@ function install_buildenv() { libcurl-devel \ libgnutls-devel \ libiscsi-devel \ + libjson-c-devel \ libnbd-devel \ libnl3-devel \ libnuma-devel \ diff --git a/ci/buildenv/opensuse-tumbleweed.sh b/ci/buildenv/opensuse-tumb= leweed.sh index ac566d349f..2233699719 100644 --- a/ci/buildenv/opensuse-tumbleweed.sh +++ b/ci/buildenv/opensuse-tumbleweed.sh @@ -43,6 +43,7 @@ function install_buildenv() { libcurl-devel \ libgnutls-devel \ libiscsi-devel \ + libjson-c-devel \ libnbd-devel \ libnl3-devel \ libnuma-devel \ diff --git a/ci/buildenv/ubuntu-2204.sh b/ci/buildenv/ubuntu-2204.sh index c71a0b5f47..e747a6f8c2 100644 --- a/ci/buildenv/ubuntu-2204.sh +++ b/ci/buildenv/ubuntu-2204.sh @@ -44,6 +44,7 @@ function install_buildenv() { libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/buildenv/ubuntu-2404.sh b/ci/buildenv/ubuntu-2404.sh index 3eacaa6cce..c26a80d06f 100644 --- a/ci/buildenv/ubuntu-2404.sh +++ b/ci/buildenv/ubuntu-2404.sh @@ -44,6 +44,7 @@ function install_buildenv() { libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/cirrus/freebsd-13.vars b/ci/cirrus/freebsd-13.vars index f24b921300..bf82ac5176 100644 --- a/ci/cirrus/freebsd-13.vars +++ b/ci/cirrus/freebsd-13.vars @@ -11,6 +11,6 @@ MAKE=3D'/usr/local/bin/gmake' NINJA=3D'/usr/local/bin/ninja' PACKAGING_COMMAND=3D'pkg' PIP3=3D'/usr/local/bin/pip-3.8' -PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed lib= pcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 pkgconf = polkit py311-black py311-docutils py311-flake8 py311-pytest python3 qemu re= adline yajl' +PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed jso= n-c libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 p= kgconf polkit py311-black py311-docutils py311-flake8 py311-pytest python3 = qemu readline yajl' PYPI_PKGS=3D'' PYTHON=3D'/usr/local/bin/python3' diff --git a/ci/cirrus/freebsd-14.vars b/ci/cirrus/freebsd-14.vars index f24b921300..bf82ac5176 100644 --- a/ci/cirrus/freebsd-14.vars +++ b/ci/cirrus/freebsd-14.vars @@ -11,6 +11,6 @@ MAKE=3D'/usr/local/bin/gmake' NINJA=3D'/usr/local/bin/ninja' PACKAGING_COMMAND=3D'pkg' PIP3=3D'/usr/local/bin/pip-3.8' -PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed lib= pcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 pkgconf = polkit py311-black py311-docutils py311-flake8 py311-pytest python3 qemu re= adline yajl' +PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed jso= n-c libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 p= kgconf polkit py311-black py311-docutils py311-flake8 py311-pytest python3 = qemu readline yajl' PYPI_PKGS=3D'' PYTHON=3D'/usr/local/bin/python3' diff --git a/ci/cirrus/macos-13.vars b/ci/cirrus/macos-13.vars index ca4e55887c..9860033931 100644 --- a/ci/cirrus/macos-13.vars +++ b/ci/cirrus/macos-13.vars @@ -11,6 +11,6 @@ MAKE=3D'/opt/homebrew/bin/gmake' NINJA=3D'/opt/homebrew/bin/ninja' PACKAGING_COMMAND=3D'brew' PIP3=3D'/opt/homebrew/bin/pip3' -PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep libiscsi libpcap libss= h libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 qemu rea= dline yajl' +PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep json-c libiscsi libpca= p libssh libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 q= emu readline yajl' PYPI_PKGS=3D'pytest' PYTHON=3D'/opt/homebrew/bin/python3' diff --git a/ci/cirrus/macos-14.vars b/ci/cirrus/macos-14.vars index ca4e55887c..9860033931 100644 --- a/ci/cirrus/macos-14.vars +++ b/ci/cirrus/macos-14.vars @@ -11,6 +11,6 @@ MAKE=3D'/opt/homebrew/bin/gmake' NINJA=3D'/opt/homebrew/bin/ninja' PACKAGING_COMMAND=3D'brew' PIP3=3D'/opt/homebrew/bin/pip3' -PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep libiscsi libpcap libss= h libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 qemu rea= dline yajl' +PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep json-c libiscsi libpca= p libssh libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 q= emu readline yajl' PYPI_PKGS=3D'pytest' PYTHON=3D'/opt/homebrew/bin/python3' diff --git a/ci/containers/almalinux-9.Dockerfile b/ci/containers/almalinux= -9.Dockerfile index 27ac990b22..0f54cb3224 100644 --- a/ci/containers/almalinux-9.Dockerfile +++ b/ci/containers/almalinux-9.Dockerfile @@ -38,6 +38,7 @@ RUN dnf update -y && \ iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/containers/alpine-319.Dockerfile b/ci/containers/alpine-319= .Dockerfile index 2455184a87..cdd9845a19 100644 --- a/ci/containers/alpine-319.Dockerfile +++ b/ci/containers/alpine-319.Dockerfile @@ -32,6 +32,7 @@ RUN apk update && \ grep \ iproute2 \ iptables \ + json-c-dev \ kmod \ libcap-ng-dev \ libnl3-dev \ diff --git a/ci/containers/alpine-edge.Dockerfile b/ci/containers/alpine-ed= ge.Dockerfile index b28c96692c..4790d9ae8a 100644 --- a/ci/containers/alpine-edge.Dockerfile +++ b/ci/containers/alpine-edge.Dockerfile @@ -32,6 +32,7 @@ RUN apk update && \ grep \ iproute2 \ iptables \ + json-c-dev \ kmod \ libcap-ng-dev \ libnl3-dev \ diff --git a/ci/containers/centos-stream-9.Dockerfile b/ci/containers/cento= s-stream-9.Dockerfile index 93549eefad..d83ca27b93 100644 --- a/ci/containers/centos-stream-9.Dockerfile +++ b/ci/containers/centos-stream-9.Dockerfile @@ -39,6 +39,7 @@ RUN dnf distro-sync -y && \ iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/containers/debian-11-cross-aarch64.Dockerfile b/ci/containe= rs/debian-11-cross-aarch64.Dockerfile index 1cb573821f..7a7d22b766 100644 --- a/ci/containers/debian-11-cross-aarch64.Dockerfile +++ b/ci/containers/debian-11-cross-aarch64.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:arm64 \ libgnutls28-dev:arm64 \ libiscsi-dev:arm64 \ + libjson-c-dev:arm64 \ libnl-3-dev:arm64 \ libnl-route-3-dev:arm64 \ libnuma-dev:arm64 \ diff --git a/ci/containers/debian-11-cross-armv6l.Dockerfile b/ci/container= s/debian-11-cross-armv6l.Dockerfile index 6989546ebf..08737bb216 100644 --- a/ci/containers/debian-11-cross-armv6l.Dockerfile +++ b/ci/containers/debian-11-cross-armv6l.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:armel \ libgnutls28-dev:armel \ libiscsi-dev:armel \ + libjson-c-dev:armel \ libnl-3-dev:armel \ libnl-route-3-dev:armel \ libnuma-dev:armel \ diff --git a/ci/containers/debian-11-cross-armv7l.Dockerfile b/ci/container= s/debian-11-cross-armv7l.Dockerfile index fcd6a6383b..d8bb30d4a1 100644 --- a/ci/containers/debian-11-cross-armv7l.Dockerfile +++ b/ci/containers/debian-11-cross-armv7l.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:armhf \ libgnutls28-dev:armhf \ libiscsi-dev:armhf \ + libjson-c-dev:armhf \ libnl-3-dev:armhf \ libnl-route-3-dev:armhf \ libnuma-dev:armhf \ diff --git a/ci/containers/debian-11-cross-i686.Dockerfile b/ci/containers/= debian-11-cross-i686.Dockerfile index 8d79934a52..c37a7d2bfa 100644 --- a/ci/containers/debian-11-cross-i686.Dockerfile +++ b/ci/containers/debian-11-cross-i686.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:i386 \ libgnutls28-dev:i386 \ libiscsi-dev:i386 \ + libjson-c-dev:i386 \ libnl-3-dev:i386 \ libnl-route-3-dev:i386 \ libnuma-dev:i386 \ diff --git a/ci/containers/debian-11-cross-mips64el.Dockerfile b/ci/contain= ers/debian-11-cross-mips64el.Dockerfile index d80f741311..27556d7e07 100644 --- a/ci/containers/debian-11-cross-mips64el.Dockerfile +++ b/ci/containers/debian-11-cross-mips64el.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:mips64el \ libgnutls28-dev:mips64el \ libiscsi-dev:mips64el \ + libjson-c-dev:mips64el \ libnl-3-dev:mips64el \ libnl-route-3-dev:mips64el \ libnuma-dev:mips64el \ diff --git a/ci/containers/debian-11-cross-mipsel.Dockerfile b/ci/container= s/debian-11-cross-mipsel.Dockerfile index dc674150f5..be0e9e0188 100644 --- a/ci/containers/debian-11-cross-mipsel.Dockerfile +++ b/ci/containers/debian-11-cross-mipsel.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:mipsel \ libgnutls28-dev:mipsel \ libiscsi-dev:mipsel \ + libjson-c-dev:mipsel \ libnl-3-dev:mipsel \ libnl-route-3-dev:mipsel \ libnuma-dev:mipsel \ diff --git a/ci/containers/debian-11-cross-ppc64le.Dockerfile b/ci/containe= rs/debian-11-cross-ppc64le.Dockerfile index fc3a9ee157..cfbef7dcbc 100644 --- a/ci/containers/debian-11-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-11-cross-ppc64le.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:ppc64el \ libgnutls28-dev:ppc64el \ libiscsi-dev:ppc64el \ + libjson-c-dev:ppc64el \ libnl-3-dev:ppc64el \ libnl-route-3-dev:ppc64el \ libnuma-dev:ppc64el \ diff --git a/ci/containers/debian-11-cross-s390x.Dockerfile b/ci/containers= /debian-11-cross-s390x.Dockerfile index 336694b2d3..1b7cee0572 100644 --- a/ci/containers/debian-11-cross-s390x.Dockerfile +++ b/ci/containers/debian-11-cross-s390x.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:s390x \ libgnutls28-dev:s390x \ libiscsi-dev:s390x \ + libjson-c-dev:s390x \ libnl-3-dev:s390x \ libnl-route-3-dev:s390x \ libnuma-dev:s390x \ diff --git a/ci/containers/debian-11.Dockerfile b/ci/containers/debian-11.D= ockerfile index 6f08eb7448..da72d538c0 100644 --- a/ci/containers/debian-11.Dockerfile +++ b/ci/containers/debian-11.Dockerfile @@ -46,6 +46,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnetcf-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/containers/debian-12-cross-aarch64.Dockerfile b/ci/containe= rs/debian-12-cross-aarch64.Dockerfile index cc26cc2d11..1504ba0b72 100644 --- a/ci/containers/debian-12-cross-aarch64.Dockerfile +++ b/ci/containers/debian-12-cross-aarch64.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:arm64 \ libgnutls28-dev:arm64 \ libiscsi-dev:arm64 \ + libjson-c-dev:arm64 \ libnl-3-dev:arm64 \ libnl-route-3-dev:arm64 \ libnuma-dev:arm64 \ diff --git a/ci/containers/debian-12-cross-armv6l.Dockerfile b/ci/container= s/debian-12-cross-armv6l.Dockerfile index 28235d9ba1..ce2c71d466 100644 --- a/ci/containers/debian-12-cross-armv6l.Dockerfile +++ b/ci/containers/debian-12-cross-armv6l.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:armel \ libgnutls28-dev:armel \ libiscsi-dev:armel \ + libjson-c-dev:armel \ libnl-3-dev:armel \ libnl-route-3-dev:armel \ libnuma-dev:armel \ diff --git a/ci/containers/debian-12-cross-armv7l.Dockerfile b/ci/container= s/debian-12-cross-armv7l.Dockerfile index 56fbb73ebd..410f4fe15d 100644 --- a/ci/containers/debian-12-cross-armv7l.Dockerfile +++ b/ci/containers/debian-12-cross-armv7l.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:armhf \ libgnutls28-dev:armhf \ libiscsi-dev:armhf \ + libjson-c-dev:armhf \ libnl-3-dev:armhf \ libnl-route-3-dev:armhf \ libnuma-dev:armhf \ diff --git a/ci/containers/debian-12-cross-i686.Dockerfile b/ci/containers/= debian-12-cross-i686.Dockerfile index 4601cd297f..4ae974eb16 100644 --- a/ci/containers/debian-12-cross-i686.Dockerfile +++ b/ci/containers/debian-12-cross-i686.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:i386 \ libgnutls28-dev:i386 \ libiscsi-dev:i386 \ + libjson-c-dev:i386 \ libnl-3-dev:i386 \ libnl-route-3-dev:i386 \ libnuma-dev:i386 \ diff --git a/ci/containers/debian-12-cross-mips64el.Dockerfile b/ci/contain= ers/debian-12-cross-mips64el.Dockerfile index 3d3c0615fa..9664b30c14 100644 --- a/ci/containers/debian-12-cross-mips64el.Dockerfile +++ b/ci/containers/debian-12-cross-mips64el.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:mips64el \ libgnutls28-dev:mips64el \ libiscsi-dev:mips64el \ + libjson-c-dev:mips64el \ libnl-3-dev:mips64el \ libnl-route-3-dev:mips64el \ libnuma-dev:mips64el \ diff --git a/ci/containers/debian-12-cross-mipsel.Dockerfile b/ci/container= s/debian-12-cross-mipsel.Dockerfile index a1e1167f56..4692d1ce8c 100644 --- a/ci/containers/debian-12-cross-mipsel.Dockerfile +++ b/ci/containers/debian-12-cross-mipsel.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:mipsel \ libgnutls28-dev:mipsel \ libiscsi-dev:mipsel \ + libjson-c-dev:mipsel \ libnl-3-dev:mipsel \ libnl-route-3-dev:mipsel \ libnuma-dev:mipsel \ diff --git a/ci/containers/debian-12-cross-ppc64le.Dockerfile b/ci/containe= rs/debian-12-cross-ppc64le.Dockerfile index 836b1c2ec5..17beefaea6 100644 --- a/ci/containers/debian-12-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-12-cross-ppc64le.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:ppc64el \ libgnutls28-dev:ppc64el \ libiscsi-dev:ppc64el \ + libjson-c-dev:ppc64el \ libnl-3-dev:ppc64el \ libnl-route-3-dev:ppc64el \ libnuma-dev:ppc64el \ diff --git a/ci/containers/debian-12-cross-s390x.Dockerfile b/ci/containers= /debian-12-cross-s390x.Dockerfile index 000e357b97..88006f9a74 100644 --- a/ci/containers/debian-12-cross-s390x.Dockerfile +++ b/ci/containers/debian-12-cross-s390x.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:s390x \ libgnutls28-dev:s390x \ libiscsi-dev:s390x \ + libjson-c-dev:s390x \ libnl-3-dev:s390x \ libnl-route-3-dev:s390x \ libnuma-dev:s390x \ diff --git a/ci/containers/debian-12.Dockerfile b/ci/containers/debian-12.D= ockerfile index bacfd9ada4..8b34ea98fb 100644 --- a/ci/containers/debian-12.Dockerfile +++ b/ci/containers/debian-12.Dockerfile @@ -46,6 +46,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/containers/debian-sid-cross-aarch64.Dockerfile b/ci/contain= ers/debian-sid-cross-aarch64.Dockerfile index 48335d5221..cbbea29d12 100644 --- a/ci/containers/debian-sid-cross-aarch64.Dockerfile +++ b/ci/containers/debian-sid-cross-aarch64.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:arm64 \ libgnutls28-dev:arm64 \ libiscsi-dev:arm64 \ + libjson-c-dev:arm64 \ libnl-3-dev:arm64 \ libnl-route-3-dev:arm64 \ libnuma-dev:arm64 \ diff --git a/ci/containers/debian-sid-cross-armv6l.Dockerfile b/ci/containe= rs/debian-sid-cross-armv6l.Dockerfile index b9cdd95548..94d130baf8 100644 --- a/ci/containers/debian-sid-cross-armv6l.Dockerfile +++ b/ci/containers/debian-sid-cross-armv6l.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglib2.0-dev:armel \ libgnutls28-dev:armel \ libiscsi-dev:armel \ + libjson-c-dev:armel \ libnl-3-dev:armel \ libnl-route-3-dev:armel \ libnuma-dev:armel \ diff --git a/ci/containers/debian-sid-cross-armv7l.Dockerfile b/ci/containe= rs/debian-sid-cross-armv7l.Dockerfile index 4787aea1cd..b1251ffec3 100644 --- a/ci/containers/debian-sid-cross-armv7l.Dockerfile +++ b/ci/containers/debian-sid-cross-armv7l.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglib2.0-dev:armhf \ libgnutls28-dev:armhf \ libiscsi-dev:armhf \ + libjson-c-dev:armhf \ libnl-3-dev:armhf \ libnl-route-3-dev:armhf \ libnuma-dev:armhf \ diff --git a/ci/containers/debian-sid-cross-i686.Dockerfile b/ci/containers= /debian-sid-cross-i686.Dockerfile index 66d84474dc..30b1c268a2 100644 --- a/ci/containers/debian-sid-cross-i686.Dockerfile +++ b/ci/containers/debian-sid-cross-i686.Dockerfile @@ -81,6 +81,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglib2.0-dev:i386 \ libgnutls28-dev:i386 \ libiscsi-dev:i386 \ + libjson-c-dev:i386 \ libnl-3-dev:i386 \ libnl-route-3-dev:i386 \ libnuma-dev:i386 \ diff --git a/ci/containers/debian-sid-cross-mips64el.Dockerfile b/ci/contai= ners/debian-sid-cross-mips64el.Dockerfile index 4e325bf076..216dbacfa1 100644 --- a/ci/containers/debian-sid-cross-mips64el.Dockerfile +++ b/ci/containers/debian-sid-cross-mips64el.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:mips64el \ libgnutls28-dev:mips64el \ libiscsi-dev:mips64el \ + libjson-c-dev:mips64el \ libnl-3-dev:mips64el \ libnl-route-3-dev:mips64el \ libnuma-dev:mips64el \ diff --git a/ci/containers/debian-sid-cross-ppc64le.Dockerfile b/ci/contain= ers/debian-sid-cross-ppc64le.Dockerfile index 8a53dd73bd..2e93762cbf 100644 --- a/ci/containers/debian-sid-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-sid-cross-ppc64le.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:ppc64el \ libgnutls28-dev:ppc64el \ libiscsi-dev:ppc64el \ + libjson-c-dev:ppc64el \ libnl-3-dev:ppc64el \ libnl-route-3-dev:ppc64el \ libnuma-dev:ppc64el \ diff --git a/ci/containers/debian-sid-cross-s390x.Dockerfile b/ci/container= s/debian-sid-cross-s390x.Dockerfile index f9c91d56de..e106382a21 100644 --- a/ci/containers/debian-sid-cross-s390x.Dockerfile +++ b/ci/containers/debian-sid-cross-s390x.Dockerfile @@ -82,6 +82,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev:s390x \ libgnutls28-dev:s390x \ libiscsi-dev:s390x \ + libjson-c-dev:s390x \ libnl-3-dev:s390x \ libnl-route-3-dev:s390x \ libnuma-dev:s390x \ diff --git a/ci/containers/debian-sid.Dockerfile b/ci/containers/debian-sid= .Dockerfile index 0084e418d3..1bf2fa5a00 100644 --- a/ci/containers/debian-sid.Dockerfile +++ b/ci/containers/debian-sid.Dockerfile @@ -46,6 +46,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/containers/fedora-39.Dockerfile b/ci/containers/fedora-39.D= ockerfile index 91135bf15f..6a528ba71b 100644 --- a/ci/containers/fedora-39.Dockerfile +++ b/ci/containers/fedora-39.Dockerfile @@ -48,6 +48,7 @@ exec "$@"\n' > /usr/bin/nosync && \ iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/containers/fedora-40.Dockerfile b/ci/containers/fedora-40.D= ockerfile index 97e1858473..4f22956c3c 100644 --- a/ci/containers/fedora-40.Dockerfile +++ b/ci/containers/fedora-40.Dockerfile @@ -48,6 +48,7 @@ exec "$@"\n' > /usr/bin/nosync && \ iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/containers/fedora-rawhide.Dockerfile b/ci/containers/fedora= -rawhide.Dockerfile index 6f06843985..5d1cc5961c 100644 --- a/ci/containers/fedora-rawhide.Dockerfile +++ b/ci/containers/fedora-rawhide.Dockerfile @@ -49,6 +49,7 @@ exec "$@"\n' > /usr/bin/nosync && \ iproute-tc \ iptables \ iscsi-initiator-utils \ + json-c-devel \ kmod \ libacl-devel \ libattr-devel \ diff --git a/ci/containers/opensuse-leap-15.Dockerfile b/ci/containers/open= suse-leap-15.Dockerfile index b152528378..614af86f2c 100644 --- a/ci/containers/opensuse-leap-15.Dockerfile +++ b/ci/containers/opensuse-leap-15.Dockerfile @@ -44,6 +44,7 @@ RUN zypper update -y && \ libcurl-devel \ libgnutls-devel \ libiscsi-devel \ + libjson-c-devel \ libnbd-devel \ libnl3-devel \ libnuma-devel \ diff --git a/ci/containers/opensuse-tumbleweed.Dockerfile b/ci/containers/o= pensuse-tumbleweed.Dockerfile index 2b7cdb4af5..bf47571338 100644 --- a/ci/containers/opensuse-tumbleweed.Dockerfile +++ b/ci/containers/opensuse-tumbleweed.Dockerfile @@ -44,6 +44,7 @@ RUN zypper dist-upgrade -y && \ libcurl-devel \ libgnutls-devel \ libiscsi-devel \ + libjson-c-devel \ libnbd-devel \ libnl3-devel \ libnuma-devel \ diff --git a/ci/containers/ubuntu-2204.Dockerfile b/ci/containers/ubuntu-22= 04.Dockerfile index 5e8829bc2b..5de2ac6801 100644 --- a/ci/containers/ubuntu-2204.Dockerfile +++ b/ci/containers/ubuntu-2204.Dockerfile @@ -46,6 +46,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/containers/ubuntu-2404.Dockerfile b/ci/containers/ubuntu-24= 04.Dockerfile index 4a6c63b5a4..86bab63fc9 100644 --- a/ci/containers/ubuntu-2404.Dockerfile +++ b/ci/containers/ubuntu-2404.Dockerfile @@ -46,6 +46,7 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libglusterfs-dev \ libgnutls28-dev \ libiscsi-dev \ + libjson-c-dev \ libnbd-dev \ libnl-3-dev \ libnl-route-3-dev \ diff --git a/ci/lcitool/projects/libvirt.yml b/ci/lcitool/projects/libvirt.= yml index 5e0bd66958..a02fe9b8bf 100644 --- a/ci/lcitool/projects/libvirt.yml +++ b/ci/lcitool/projects/libvirt.yml @@ -30,6 +30,7 @@ packages: - ip - iptables - iscsiadm + - json-c - libacl - libattr - libaudit --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723672740074943.3861494980478; Wed, 14 Aug 2024 14:59:00 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 020ED1320; Wed, 14 Aug 2024 17:58:59 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B147B155C; Wed, 14 Aug 2024 17:43:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 641F21373; Wed, 14 Aug 2024 17:43:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BA5131497 for ; Wed, 14 Aug 2024 17:43:18 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-uPSCNfqYPoy8bdxtHPms1g-1; Wed, 14 Aug 2024 17:43:17 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35FE61944EBF for ; Wed, 14 Aug 2024 21:43:16 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 709C3196BE80 for ; Wed, 14 Aug 2024 21:43:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y1i7i1USmJDp09kTBif6RWq3dkIVLJOEVzWA/BAO1Sw=; b=Nn+/PIlEUdusuF+qjPtj4CyXS3y7zd10vIFmFKgYo0uUN1DR1YLF9rEIVswYH+rn9uwyBz 0nl7kme7gKnn4eZryZASahHGU7q9sTxC8GKJBNyC/koSXJdKFf50HzECHw5ZPXrRF6gI+g 0SRluVdKflqAlTe1tRv4HKdC0ULABXE= X-MC-Unique: uPSCNfqYPoy8bdxtHPms1g-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 09/20] meson: nss: link with json-c if available Date: Wed, 14 Aug 2024 23:40:24 +0200 Message-ID: <28024fc4083c3d06c8f7ecdeb62e8fc54e57a73c.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JTXJJSYH7YZM72O4CZP4XAUD2PLLBM54 X-Message-ID-Hash: JTXJJSYH7YZM72O4CZP4XAUD2PLLBM54 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723672741497116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko --- tools/nss/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/nss/meson.build b/tools/nss/meson.build index 85e2838fb7..1cae93ac67 100644 --- a/tools/nss/meson.build +++ b/tools/nss/meson.build @@ -28,6 +28,7 @@ nss_libvirt_impl =3D static_library( '-DLIBVIRT_NSS' ], dependencies: [ + json_c_dep, tools_dep, yajl_dep, ], @@ -44,6 +45,7 @@ nss_libvirt_guest_impl =3D static_library( '-DLIBVIRT_NSS_GUEST', ], dependencies: [ + json_c_dep, tools_dep, yajl_dep, ], --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723672617271325.1717833878648; Wed, 14 Aug 2024 14:56:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2F231135F; Wed, 14 Aug 2024 17:56:56 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 67BC01585; Wed, 14 Aug 2024 17:43:34 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2F8A91374; Wed, 14 Aug 2024 17:43:31 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E28CA135F for ; Wed, 14 Aug 2024 17:43:19 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-2WOcpNNCPE-KcyNpPKY0yA-1; Wed, 14 Aug 2024 17:43:18 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49BFA195420C for ; Wed, 14 Aug 2024 21:43:17 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 990C11955E8C for ; Wed, 14 Aug 2024 21:43:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1BMBClpTDdDrN3RLGoi6KD1k63efi+8YHYIx+5sW2z0=; b=IVNbKfoS3bj+UEPxen3JG3BBm7ToV6hrhD2BbAQNqediV2cXuIAZye5R1z2bTIdUPoAhfN x5E9DMEsS2B7KjIfPnrmgnll2i0L4milv3WzFDrWx/yaKIwYZJqGK8vvvRXVe50maJENSW lFRG2xN7Z3I8KBT7NfvhWc7BFGdnWyo= X-MC-Unique: 2WOcpNNCPE-KcyNpPKY0yA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 10/20] nss: convert findLeases to use json-c Date: Wed, 14 Aug 2024 23:40:25 +0200 Message-ID: <90992f7c718a61f4c63f20574fec457124527378.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: T4QXSQ5WHL4HH5KZVDZCAU7LKHEV6WXK X-Message-ID-Hash: T4QXSQ5WHL4HH5KZVDZCAU7LKHEV6WXK X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723672619014116600 Content-Type: text/plain; charset="utf-8" While the parsing is still done by 1K buffers, the results are no longer filtered during the parsing, but the whole JSON has to live in memory at once, which was also the case before the NSS plugin dropped its dependency on libvirt_util. Also, the new parser might be more forgiving of missing elements. Signed-off-by: J=C3=A1n Tomko --- tools/nss/libvirt_nss_leases.c | 339 ++++++++++----------------------- 1 file changed, 96 insertions(+), 243 deletions(-) diff --git a/tools/nss/libvirt_nss_leases.c b/tools/nss/libvirt_nss_leases.c index 770dae8625..86bf184ea5 100644 --- a/tools/nss/libvirt_nss_leases.c +++ b/tools/nss/libvirt_nss_leases.c @@ -26,39 +26,11 @@ #include #include =20 -#include -#include +#include =20 #include "libvirt_nss_leases.h" #include "libvirt_nss.h" =20 -enum { - FIND_LEASES_STATE_START, - FIND_LEASES_STATE_LIST, - FIND_LEASES_STATE_ENTRY, -}; - - -typedef struct { - const char *name; - char **macs; - size_t nmacs; - int state; - unsigned long long now; - int af; - bool *found; - leaseAddress **addrs; - size_t *naddrs; - - char *key; - struct { - unsigned long long expiry; - char *ipaddr; - char *macaddr; - char *hostname; - } entry; -} findLeasesParser; - =20 static int appendAddr(const char *name __attribute__((unused)), @@ -157,189 +129,102 @@ appendAddr(const char *name __attribute__((unused)), =20 =20 static int -findLeasesParserInteger(void *ctx, - long long val) +findLeaseInJSON(json_object *jobj, + const char *name, + char **macs, + size_t nmacs, + int af, + time_t now, + leaseAddress **addrs, + size_t *naddrs, + bool *found) { - findLeasesParser *parser =3D ctx; + size_t i, j; + int len; =20 - DEBUG("Parse int state=3D%d '%lld' (map key '%s')", - parser->state, val, NULLSTR(parser->key)); - if (!parser->key) - return 0; - - if (parser->state =3D=3D FIND_LEASES_STATE_ENTRY) { - if (strcmp(parser->key, "expiry-time")) - return 0; - - parser->entry.expiry =3D val; - } else { - return 0; + if (!json_object_is_type(jobj, json_type_array)) { + ERROR("parsed JSON does not contain the leases array"); + return -1; } - return 1; -} =20 + len =3D json_object_array_length(jobj); + for (i =3D 0; i < len; i++) { + json_object *lease =3D NULL; + json_object *expiry =3D NULL; + json_object *ipobj =3D NULL; + unsigned long long expiryTime; + const char *ipaddr; =20 -static int -findLeasesParserString(void *ctx, - const unsigned char *stringVal, - size_t stringLen) -{ - findLeasesParser *parser =3D ctx; + lease =3D json_object_array_get_idx(jobj, i); =20 - DEBUG("Parse string state=3D%d '%.*s' (map key '%s')", - parser->state, (int)stringLen, (const char *)stringVal, - NULLSTR(parser->key)); - if (!parser->key) - return 0; + if (macs) { + const char *macAddr; + bool match =3D false; + json_object *val; =20 - if (parser->state =3D=3D FIND_LEASES_STATE_ENTRY) { - if (!strcmp(parser->key, "ip-address")) { - if (!(parser->entry.ipaddr =3D strndup((char *)stringVal, stri= ngLen))) - return 0; - } else if (!strcmp(parser->key, "mac-address")) { - if (!(parser->entry.macaddr =3D strndup((char *)stringVal, str= ingLen))) - return 0; - } else if (!strcmp(parser->key, "hostname")) { - if (!(parser->entry.hostname =3D strndup((char *)stringVal, st= ringLen))) - return 0; + val =3D json_object_object_get(lease, "mac-address"); + if (!val) + continue; + + macAddr =3D json_object_get_string(val); + if (!macAddr) + continue; + + for (j =3D 0; j < nmacs; j++) { + if (!strcmp(macs[j], macAddr)) { + match =3D true; + break; + } + } + if (!match) + continue; } else { - return 1; - } - } else { - return 0; - } - return 1; -} - - -static int -findLeasesParserMapKey(void *ctx, - const unsigned char *stringVal, - size_t stringLen) -{ - findLeasesParser *parser =3D ctx; - - DEBUG("Parse map key state=3D%d '%.*s'", - parser->state, (int)stringLen, (const char *)stringVal); - - free(parser->key); - if (!(parser->key =3D strndup((char *)stringVal, stringLen))) - return 0; - - return 1; -} - - -static int -findLeasesParserStartMap(void *ctx) -{ - findLeasesParser *parser =3D ctx; - - DEBUG("Parse start map state=3D%d", parser->state); - - if (parser->state !=3D FIND_LEASES_STATE_LIST) - return 0; - - free(parser->key); - parser->key =3D NULL; - parser->state =3D FIND_LEASES_STATE_ENTRY; - - return 1; -} - - -static int -findLeasesParserEndMap(void *ctx) -{ - findLeasesParser *parser =3D ctx; - size_t i; - bool found =3D false; - - DEBUG("Parse end map state=3D%d", parser->state); + const char *leaseName; + json_object *val; =20 - if (parser->entry.macaddr =3D=3D NULL) - return 0; + val =3D json_object_object_get(lease, "hostname"); + if (!val) + continue; =20 - if (parser->state !=3D FIND_LEASES_STATE_ENTRY) - return 0; + leaseName =3D json_object_get_string(val); + if (!leaseName) + continue; =20 - if (parser->nmacs) { - DEBUG("Check %zu macs", parser->nmacs); - for (i =3D 0; i < parser->nmacs && !found; i++) { - DEBUG("Check mac '%s' vs '%s'", parser->macs[i], NULLSTR(parse= r->entry.macaddr)); - if (parser->entry.macaddr && !strcmp(parser->macs[i], parser->= entry.macaddr)) - found =3D true; + if (strcasecmp(leaseName, name)) + continue; } - } else { - DEBUG("Check name '%s' vs '%s'", parser->name, NULLSTR(parser->ent= ry.hostname)); - if (parser->entry.hostname && !strcasecmp(parser->name, parser->en= try.hostname)) - found =3D true; - } - DEBUG("Found %d", found); - if (parser->entry.expiry !=3D 0 && - parser->entry.expiry < parser->now) { - DEBUG("Entry expired at %llu vs now %llu", - parser->entry.expiry, parser->now); - found =3D false; - } - if (!parser->entry.ipaddr) - found =3D false; - - if (found) { - *parser->found =3D true; - - if (appendAddr(parser->name, - parser->addrs, parser->naddrs, - parser->entry.ipaddr, - parser->entry.expiry, - parser->af) < 0) - return 0; - } - - free(parser->entry.macaddr); - free(parser->entry.ipaddr); - free(parser->entry.hostname); - parser->entry.expiry =3D 0; - parser->entry.macaddr =3D NULL; - parser->entry.ipaddr =3D NULL; - parser->entry.hostname =3D NULL; =20 - parser->state =3D FIND_LEASES_STATE_LIST; - - return 1; -} + expiry =3D json_object_object_get(lease, "expiry-time"); + if (!expiry) { + ERROR("Missing expiry time for %s", name); + return -1; + } =20 + expiryTime =3D json_object_get_uint64(expiry); + if (expiryTime && expiryTime < now) { + DEBUG("Skipping expired lease for %s", name); + continue; + } =20 -static int -findLeasesParserStartArray(void *ctx) -{ - findLeasesParser *parser =3D ctx; + ipobj =3D json_object_object_get(lease, "ip-address"); + if (!ipobj) { + DEBUG("Missing IP address for %s", name); + continue; + } + ipaddr =3D json_object_get_string(ipobj); =20 - DEBUG("Parse start array state=3D%d", parser->state); + DEBUG("Found record for %s", name); + *found =3D true; =20 - if (parser->state =3D=3D FIND_LEASES_STATE_START) { - parser->state =3D FIND_LEASES_STATE_LIST; - } else { - return 0; + if (appendAddr(name, + addrs, naddrs, + ipaddr, + expiryTime, + af) < 0) + return -1; } =20 - return 1; -} - - -static int -findLeasesParserEndArray(void *ctx) -{ - findLeasesParser *parser =3D ctx; - - DEBUG("Parse end array state=3D%d", parser->state); - - if (parser->state =3D=3D FIND_LEASES_STATE_LIST) - parser->state =3D FIND_LEASES_STATE_START; - else - return 0; - - return 1; + return 0; } =20 =20 @@ -356,30 +241,10 @@ findLeases(const char *file, { int fd =3D -1; int ret =3D -1; - const yajl_callbacks parserCallbacks =3D { - NULL, /* null */ - NULL, /* bool */ - findLeasesParserInteger, - NULL, /* double */ - NULL, /* number */ - findLeasesParserString, - findLeasesParserStartMap, - findLeasesParserMapKey, - findLeasesParserEndMap, - findLeasesParserStartArray, - findLeasesParserEndArray, - }; - findLeasesParser parserState =3D { - .name =3D name, - .macs =3D macs, - .nmacs =3D nmacs, - .af =3D af, - .now =3D now, - .found =3D found, - .addrs =3D addrs, - .naddrs =3D naddrs, - }; - yajl_handle parser =3D NULL; + json_object *jobj =3D NULL; + json_tokener *tok =3D NULL; + enum json_tokener_error jerr =3D json_tokener_success; + int jsonflags =3D JSON_TOKENER_STRICT | JSON_TOKENER_VALIDATE_UTF8; char line[1024]; ssize_t nreadTotal =3D 0; int rv; @@ -389,51 +254,39 @@ findLeases(const char *file, goto cleanup; } =20 - parser =3D yajl_alloc(&parserCallbacks, NULL, &parserState); - if (!parser) { - ERROR("Unable to create JSON parser"); - goto cleanup; - } + tok =3D json_tokener_new(); + json_tokener_set_flags(tok, jsonflags); =20 - while (1) { - rv =3D read(fd, line, sizeof(line)); + while (jerr !=3D json_tokener_continue) { + rv =3D read(fd, line, sizeof(line) - 1); if (rv < 0) goto cleanup; if (rv =3D=3D 0) break; nreadTotal +=3D rv; =20 - if (yajl_parse(parser, (const unsigned char *)line, rv) !=3D - yajl_status_ok) { - unsigned char *err =3D yajl_get_error(parser, 1, - (const unsigned char*)line= , rv); - ERROR("Parse failed %s", (const char *) err); - yajl_free_error(parser, err); - goto cleanup; - } + line[rv] =3D 0; + + jobj =3D json_tokener_parse_ex(tok, line, rv); + jerr =3D json_tokener_get_error(tok); } =20 - if (nreadTotal > 0 && - yajl_complete_parse(parser) !=3D yajl_status_ok) { - ERROR("Parse failed %s", - yajl_get_error(parser, 1, NULL, 0)); + if (nreadTotal > 0 && jerr !=3D json_tokener_success) { + ERROR("Cannot parse %s: %s", file, json_tokener_error_desc(jerr)); goto cleanup; } =20 - ret =3D 0; + ret =3D findLeaseInJSON(jobj, name, macs, nmacs, af, now, + addrs, naddrs, found); =20 cleanup: + json_object_put(jobj); + json_tokener_free(tok); if (ret !=3D 0) { free(*addrs); *addrs =3D NULL; *naddrs =3D 0; } - if (parser) - yajl_free(parser); - free(parserState.entry.ipaddr); - free(parserState.entry.macaddr); - free(parserState.entry.hostname); - free(parserState.key); if (fd !=3D -1) close(fd); return ret; --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723672915996685.8037897141171; Wed, 14 Aug 2024 15:01:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 99E6C13BB; Wed, 14 Aug 2024 18:01:38 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9E13C1598; Wed, 14 Aug 2024 17:43:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7718212DF; Wed, 14 Aug 2024 17:43:35 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 020BC14AE for ; Wed, 14 Aug 2024 17:43:20 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588--pAackaKMKmDS6Yrhh-2qQ-1; Wed, 14 Aug 2024 17:43:19 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5E4B81944F06 for ; Wed, 14 Aug 2024 21:43:18 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ADC611955E8C for ; Wed, 14 Aug 2024 21:43:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w4aNuasQkvRBSodHsYg0Dw1NJi5rxCfyTv9uqbi6Gig=; b=BXaA0nhXjAPjJnmB+gmyGDS3yc57C5ZqMBEHZpZzOVIzYy8PLv8O30ZMH2HZ2wnD7kUFiW Hjl+jZIwGMUFR9WSwKR3M0N6W1Rc8RbVOZb48wFHJFS80FVyHeUgoB3r2F35ozCPVHj3Xj Fg7ovRKTShuWfN0dTJ9nSdfAOVAy+I0= X-MC-Unique: -pAackaKMKmDS6Yrhh-2qQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 11/20] nss: convert findMACs to use json-c Date: Wed, 14 Aug 2024 23:40:26 +0200 Message-ID: <29547e96bd8f4b29aeee5286da8dc7c29add8f03.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KTMEZTFWEKJRR2AU2CIISXPAXCJ7WX72 X-Message-ID-Hash: KTMEZTFWEKJRR2AU2CIISXPAXCJ7WX72 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723672916424116600 Content-Type: text/plain; charset="utf-8" While the parsing is still done by 1K buffers, the results are no longer filtered during the parsing, but the whole JSON has to live in memory at once, which was also the case before the NSS plugin dropped its dependency on libvirt_util. Also, the new parser might be more forgiving of missing elements. Signed-off-by: J=C3=A1n Tomko --- tools/nss/libvirt_nss_macs.c | 263 +++++++++-------------------------- 1 file changed, 68 insertions(+), 195 deletions(-) diff --git a/tools/nss/libvirt_nss_macs.c b/tools/nss/libvirt_nss_macs.c index f45d149793..dbc0790945 100644 --- a/tools/nss/libvirt_nss_macs.c +++ b/tools/nss/libvirt_nss_macs.c @@ -25,179 +25,78 @@ #include #include =20 -#include -#include +#include =20 #include "libvirt_nss_macs.h" #include "libvirt_nss.h" =20 -enum { - FIND_MACS_STATE_START, - FIND_MACS_STATE_LIST, - FIND_MACS_STATE_ENTRY, - FIND_MACS_STATE_ENTRY_MACS, -}; - -typedef struct { - const char *name; - char ***macs; - size_t *nmacs; - int state; - - char *key; - struct { - char *name; - char **macs; - size_t nmacs; - } entry; -} findMACsParser; - =20 static int -findMACsParserString(void *ctx, - const unsigned char *stringVal, - size_t stringLen) +findMACsFromJSON(json_object *jobj, + const char *name, + char ***macs, + size_t *nmacs) { - findMACsParser *parser =3D ctx; - - DEBUG("Parse string state=3D%d '%.*s' (map key '%s')", - parser->state, (int)stringLen, (const char *)stringVal, - NULLSTR(parser->key)); - if (!parser->key) - return 0; - - if (parser->state =3D=3D FIND_MACS_STATE_ENTRY) { - if (strcmp(parser->key, "domain")) - return 1; - - free(parser->entry.name); - if (!(parser->entry.name =3D strndup((char *)stringVal, stringLen)= )) - return 0; - } else if (parser->state =3D=3D FIND_MACS_STATE_ENTRY_MACS) { - char **macs; - if (strcmp(parser->key, "macs")) - return 1; + size_t i, j; + int len; =20 - if (!(macs =3D realloc(parser->entry.macs, - sizeof(char *) * (parser->entry.nmacs + 1)))) - return 0; - - parser->entry.macs =3D macs; - if (!(macs[parser->entry.nmacs++] =3D strndup((char *)stringVal, s= tringLen))) - return 0; - } else { - return 0; + if (!json_object_is_type(jobj, json_type_array)) { + ERROR("parsed JSON does not contain the leases array"); + return -1; } - return 1; -} - - -static int -findMACsParserMapKey(void *ctx, - const unsigned char *stringVal, - size_t stringLen) -{ - findMACsParser *parser =3D ctx; - - DEBUG("Parse map key state=3D%d '%.*s'", - parser->state, (int)stringLen, (const char *)stringVal); - - free(parser->key); - if (!(parser->key =3D strndup((char *)stringVal, stringLen))) - return 0; - - return 1; -} - - -static int -findMACsParserStartMap(void *ctx) -{ - findMACsParser *parser =3D ctx; =20 - DEBUG("Parse start map state=3D%d", parser->state); + len =3D json_object_array_length(jobj); + DEBUG("Found an array of length: %zu", len); + for (i =3D 0; i < len; i++) { + json_object *entry =3D NULL; + json_object *domain =3D NULL; + const char *domainName; + char **tmpMacs =3D NULL; + size_t newmacs =3D 0; + json_object *macsArray =3D NULL; =20 - if (parser->state !=3D FIND_MACS_STATE_LIST) - return 0; + entry =3D json_object_array_get_idx(jobj, i); + if (!entry) + return -1; =20 - free(parser->key); - parser->key =3D NULL; - parser->state =3D FIND_MACS_STATE_ENTRY; + DEBUG("Processing item %zu", i); =20 - return 1; -} + domain =3D json_object_object_get(entry, "domain"); + if (!domain) + return -1; =20 + domainName =3D json_object_get_string(domain); + if (!domainName) + return -1; =20 -static int -findMACsParserEndMap(void *ctx) -{ - findMACsParser *parser =3D ctx; - size_t i; + DEBUG("Processing domain %s", domainName); =20 - DEBUG("Parse end map state=3D%d", parser->state); + if (strcasecmp(domainName, name)) + continue; =20 - if (parser->entry.name =3D=3D NULL) - return 0; + macsArray =3D json_object_object_get(entry, "macs"); + if (!macsArray) + return -1; =20 - if (parser->state !=3D FIND_MACS_STATE_ENTRY) - return 0; + newmacs =3D json_object_array_length(macsArray); + DEBUG("Found %zu MAC addresses", newmacs); =20 - if (!strcasecmp(parser->entry.name, parser->name)) { - char **macs =3D realloc(*parser->macs, - sizeof(char *) * ((*parser->nmacs) + parser-= >entry.nmacs)); - if (!macs) + tmpMacs =3D realloc(*macs, sizeof(char *) * (*nmacs + newmacs + 1)= ); + if (!tmpMacs) return 0; =20 - *parser->macs =3D macs; - for (i =3D 0; i < parser->entry.nmacs; i++) - (*parser->macs)[(*parser->nmacs)++] =3D parser->entry.macs[i]; - } else { - for (i =3D 0; i < parser->entry.nmacs; i++) - free(parser->entry.macs[i]); - } - free(parser->entry.macs); - parser->entry.macs =3D NULL; - parser->entry.nmacs =3D 0; - - parser->state =3D FIND_MACS_STATE_LIST; - - return 1; -} - - -static int -findMACsParserStartArray(void *ctx) -{ - findMACsParser *parser =3D ctx; - - DEBUG("Parse start array state=3D%d", parser->state); - - if (parser->state =3D=3D FIND_MACS_STATE_START) - parser->state =3D FIND_MACS_STATE_LIST; - else if (parser->state =3D=3D FIND_MACS_STATE_ENTRY) - parser->state =3D FIND_MACS_STATE_ENTRY_MACS; - else - return 0; + *macs =3D tmpMacs; =20 - return 1; -} + for (j =3D 0; j < newmacs; j++) { + json_object *macobj =3D NULL; =20 + DEBUG("j: %zu", j); =20 -static int -findMACsParserEndArray(void *ctx) -{ - findMACsParser *parser =3D ctx; - - DEBUG("Parse end array state=3D%d", parser->state); - - if (parser->state =3D=3D FIND_MACS_STATE_LIST) - parser->state =3D FIND_MACS_STATE_START; - else if (parser->state =3D=3D FIND_MACS_STATE_ENTRY_MACS) - parser->state =3D FIND_MACS_STATE_ENTRY; - else - return 0; - - return 1; + macobj =3D json_object_array_get_idx(macsArray, j); + (*macs)[(*nmacs)++] =3D strdup(json_object_get_string(macobj)); + } + } + return 0; } =20 =20 @@ -209,66 +108,47 @@ findMACs(const char *file, { int fd =3D -1; int ret =3D -1; - const yajl_callbacks parserCallbacks =3D { - NULL, /* null */ - NULL, /* bool */ - NULL, /* integer */ - NULL, /* double */ - NULL, /* number */ - findMACsParserString, - findMACsParserStartMap, - findMACsParserMapKey, - findMACsParserEndMap, - findMACsParserStartArray, - findMACsParserEndArray, - }; - findMACsParser parserState =3D { - .name =3D name, - .macs =3D macs, - .nmacs =3D nmacs, - }; - yajl_handle parser =3D NULL; char line[1024]; - size_t i; + json_object *jobj =3D NULL; + json_tokener *tok =3D NULL; + enum json_tokener_error jerr =3D json_tokener_success; + int jsonflags =3D JSON_TOKENER_STRICT | JSON_TOKENER_VALIDATE_UTF8; + ssize_t nreadTotal =3D 0; int rv; + size_t i; =20 if ((fd =3D open(file, O_RDONLY)) < 0) { ERROR("Cannot open %s", file); goto cleanup; } =20 - parser =3D yajl_alloc(&parserCallbacks, NULL, &parserState); - if (!parser) { - ERROR("Unable to create JSON parser"); - goto cleanup; - } + tok =3D json_tokener_new(); + json_tokener_set_flags(tok, jsonflags); =20 - while (1) { - rv =3D read(fd, line, sizeof(line)); + while (jerr !=3D json_tokener_continue) { + rv =3D read(fd, line, sizeof(line) - 1); if (rv < 0) goto cleanup; if (rv =3D=3D 0) break; + nreadTotal +=3D rv; =20 - if (yajl_parse(parser, (const unsigned char *)line, rv) !=3D - yajl_status_ok) { - unsigned char *err =3D yajl_get_error(parser, 1, - (const unsigned char*)line= , rv); - ERROR("Parse failed %s", (const char *) err); - yajl_free_error(parser, err); - goto cleanup; - } + line[rv] =3D 0; + + jobj =3D json_tokener_parse_ex(tok, line, rv); + jerr =3D json_tokener_get_error(tok); } =20 - if (yajl_complete_parse(parser) !=3D yajl_status_ok) { - ERROR("Parse failed %s", - yajl_get_error(parser, 1, NULL, 0)); + if (nreadTotal > 0 && jerr !=3D json_tokener_success) { + ERROR("Cannot parse %s: %s", file, json_tokener_error_desc(jerr)); goto cleanup; } =20 - ret =3D 0; + ret =3D findMACsFromJSON(jobj, name, macs, nmacs); =20 cleanup: + json_object_put(jobj); + json_tokener_free(tok); if (ret !=3D 0) { for (i =3D 0; i < *nmacs; i++) { char *mac =3D (*macs)[i]; @@ -278,13 +158,6 @@ findMACs(const char *file, *macs =3D NULL; *nmacs =3D 0; } - if (parser) - yajl_free(parser); - for (i =3D 0; i < parserState.entry.nmacs; i++) - free(parserState.entry.macs[i]); - free(parserState.entry.macs); - free(parserState.entry.name); - free(parserState.key); if (fd !=3D -1) close(fd); return ret; --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 172367301169990.5928706094902; Wed, 14 Aug 2024 15:03:31 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B20FE132D; Wed, 14 Aug 2024 18:03:30 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0931B159C; Wed, 14 Aug 2024 17:43:41 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6C5521400; Wed, 14 Aug 2024 17:43:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3376B1396 for ; Wed, 14 Aug 2024 17:43:22 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-l3ubH1ESOj-FBGsLTe0UcA-1; Wed, 14 Aug 2024 17:43:20 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 731861955F4A for ; Wed, 14 Aug 2024 21:43:19 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C247C196BE80 for ; Wed, 14 Aug 2024 21:43:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ny4KFlsOacTq0CzciNVedm8lkr1nK8v1rHm8RPPT8p0=; b=KIkrNZUByBqclImSZ9TDtJe6yvr7Z2GHjIO7QTDtsdrmuEpfFwuRiabiyCMy+kCSyuwrqe Dwyo04uvh2esHmNQj5i0eA6axuoPhBLZWWkq0uPHLy1YTomFesJnHyTro35kNqE9hJlx4p yYm6YDW0CTucWtOKljVcHsXSXRiJhXU= X-MC-Unique: l3ubH1ESOj-FBGsLTe0UcA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 12/20] tests: depend on WITH_JSON_C instead of WITH_YAJL Date: Wed, 14 Aug 2024 23:40:27 +0200 Message-ID: <3fa130065ce33511c16e493554bedb60de8ed25c.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XSZKFTVF7WWSVDXN6ZYEJZHENWIS3JBZ X-Message-ID-Hash: XSZKFTVF7WWSVDXN6ZYEJZHENWIS3JBZ X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723673012741116600 Content-Type: text/plain; charset="utf-8" After the series finale, there will be no WITH_YAJL anymore. Signed-off-by: J=C3=A1n Tomko --- tests/meson.build | 6 +++--- tests/virnetdaemontest.c | 2 +- tests/virstoragetest.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index d1fc122fc7..d6e73bfba0 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -330,7 +330,7 @@ if host_machine.system() =3D=3D 'linux' { 'name': 'virscsitest' }, { 'name': 'virusbtest' }, ] - if conf.has('WITH_YAJL') + if conf.has('WITH_JSON_C') tests +=3D [ { 'name': 'virnetdevopenvswitchtest' }, ] @@ -407,7 +407,7 @@ if conf.has('WITH_NETWORK') ] endif =20 -if conf.has('WITH_NODE_DEVICES') and conf.has('WITH_YAJL') +if conf.has('WITH_NODE_DEVICES') and conf.has('WITH_JSON_C') tests +=3D [ { 'name': 'nodedevmdevctltest', 'link_with': [ node_device_driver_impl= ] }, ] @@ -556,7 +556,7 @@ if conf.has('WITH_VMX') ] endif =20 -if conf.has('WITH_YAJL') +if conf.has('WITH_JSON_C') tests +=3D [ { 'name': 'virjsontest' }, { 'name': 'virmacmaptest' }, diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c index 74c20479d4..3c00c55c72 100644 --- a/tests/virnetdaemontest.c +++ b/tests/virnetdaemontest.c @@ -26,7 +26,7 @@ =20 #define VIR_FROM_THIS VIR_FROM_RPC =20 -#if !defined(WIN32) && defined(WITH_YAJL) +#if !defined(WIN32) && defined(WITH_JSON_C) struct testClientPriv { int magic; }; diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index d07a05d04b..91c389dead 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -815,7 +815,7 @@ mymain(void) " \= n" "\n", 1); =20 -#ifdef WITH_YAJL +#ifdef WITH_JSON_C TEST_BACKING_PARSE("json:", NULL); TEST_BACKING_PARSE("json:asdgsdfg", NULL); TEST_BACKING_PARSE("json:{}", NULL); @@ -1192,7 +1192,7 @@ mymain(void) "
\n" "\n"); =20 -#endif /* WITH_YAJL */ +#endif /* WITH_JSON_C */ =20 return ret =3D=3D 0 ? EXIT_SUCCESS : EXIT_FAILURE; } --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723673121085250.8538672125968; Wed, 14 Aug 2024 15:05:21 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 04BF212E4; Wed, 14 Aug 2024 18:05:20 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 76D7F15A9; Wed, 14 Aug 2024 17:43:42 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7C88913AA; Wed, 14 Aug 2024 17:43:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 21F8513AA for ; Wed, 14 Aug 2024 17:43:23 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-XWPBAr6iMpCNFJb2jxcglg-1; Wed, 14 Aug 2024 17:43:21 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8D269195420C for ; Wed, 14 Aug 2024 21:43:20 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D650A1955E8C for ; Wed, 14 Aug 2024 21:43:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H0md0M8zbvS27+1/RXlvmHi+fvvCyTkl7yxPGySYoZ4=; b=TH4lwxRFJQUfJQHbCeAwNPjOvtsn7g5g/ddbwdk+af2fYtcgq3tpkn11f364CG/Oqww7Ut nkkbWygkcbMatNYu9tGej46i2XwC5ctO8O5rA30S2TEhXK4C6WnXRnWHsZDHKfDp3v+Qmn thiVPMQrmU1IUMwQwlc3BQmecd6DXeM= X-MC-Unique: XWPBAr6iMpCNFJb2jxcglg-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 13/20] meson: switch checks to depend on json-c instead of yajl Date: Wed, 14 Aug 2024 23:40:28 +0200 Message-ID: <616f13c3336556bf4049befc9ecd4bf2c3261aab.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4Z3VIQNKZNYT2JTEGGWZGHKQDHJEYNW7 X-Message-ID-Hash: 4Z3VIQNKZNYT2JTEGGWZGHKQDHJEYNW7 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723673121303116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko --- meson.build | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index 39d6d700d3..837b209232 100644 --- a/meson.build +++ b/meson.build @@ -1620,10 +1620,10 @@ if not get_option('driver_ch').disabled() and host_= machine.system() =3D=3D 'linux' a endif endif =20 - if not yajl_dep.found() + if not json_c_dep.found() use_ch =3D false if get_option('driver_ch').enabled() - error('YAJL 2 is required to build Cloud-Hypervisor driver') + error('json-c is required to build Cloud-Hypervisor driver') endif endif =20 @@ -1694,10 +1694,10 @@ endif if not get_option('driver_qemu').disabled() use_qemu =3D true =20 - if not yajl_dep.found() + if not json_c_dep.found() use_qemu =3D false if get_option('driver_qemu').enabled() - error('YAJL 2 is required to build QEMU driver') + error('json-c is required to build QEMU driver') endif endif =20 @@ -2027,9 +2027,9 @@ endif =20 if not get_option('nss').disabled() use_nss =3D true - if not yajl_dep.found() + if not json_c_dep.found() if get_option('nss').enabled() - error('Can\'t build nss plugin without yajl') + error('Can\'t build nss plugin without json-c') else use_nss =3D false endif --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723672788625945.4515751193301; Wed, 14 Aug 2024 14:59:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A0317AE4; Wed, 14 Aug 2024 17:59:47 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3DB931302; Wed, 14 Aug 2024 17:43:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 54FF313C8; Wed, 14 Aug 2024 17:43:35 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2623F13C8 for ; Wed, 14 Aug 2024 17:43:24 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-ZBW-Y2PQN0Gt-0r8NGettA-1; Wed, 14 Aug 2024 17:43:22 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9B7761944EBE for ; Wed, 14 Aug 2024 21:43:21 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EAF6A1955E8C for ; Wed, 14 Aug 2024 21:43:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ibSXjJ/oHF4QOxmGS9xJSN0zyF2VzETQl0g7OFyAXmQ=; b=dlDTNAd4KltLjdDb0+zVPP7UNcQf01MHaXvj8qNhPrY/nANmRcsbUfTIOp/u6dK7MQpKOr 2l2C18xaXfPPkVgWznp177zPqCQlCwM82HX1wBB6GOA46Udb/IQiIpxv6KTIF5AVyacqkw eY10Fa7u4uRwQngT9dopG1o5ZoNHnHU= X-MC-Unique: ZBW-Y2PQN0Gt-0r8NGettA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 14/20] meson-options: switch to depend on json-c instead of yajl Date: Wed, 14 Aug 2024 23:40:29 +0200 Message-ID: <91935056dcc9489ff22bad51023f2a82fdb8144d.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 634QJYYXNQV35WQ5VLDJXS73CQVFKCJJ X-Message-ID-Hash: 634QJYYXNQV35WQ5VLDJXS73CQVFKCJJ X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723672789613116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko --- meson_options.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index 9b1610fcfe..122cda0350 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -68,14 +68,14 @@ option('driver_libvirtd', type: 'feature', value: 'auto= ', description: 'libvirtd option('driver_libxl', type: 'feature', value: 'auto', description: 'libxe= nlight driver') # dep:driver_remote dep:driver_libvirtd option('driver_lxc', type: 'feature', value: 'auto', description: 'Linux C= ontainer driver') -# dep:curl dep:yajl dep:driver_remote dep:driver_libvirtd +# dep:curl dep:json_c dep:driver_remote dep:driver_libvirtd option('driver_ch', type: 'feature', value: 'auto', description: 'Cloud-Hy= pervisor driver') option('ch_user', type: 'string', value: '', description: 'username to run= Cloud-Hypervisor system instance as') option('ch_group', type: 'string', value: '', description: 'groupname to r= un Cloud-Hypervisor system instance as') # dep:driver_remote dep:driver_libvirtd option('driver_network', type: 'feature', value: 'auto', description: 'vir= tual network driver') option('driver_openvz', type: 'feature', value: 'auto', description: 'Open= VZ driver') -# dep:yajl dep:driver_remote dep:driver_libvirtd +# dep:json_c dep:driver_remote dep:driver_libvirtd option('driver_qemu', type: 'feature', value: 'auto', description: 'QEMU/K= VM driver') option('qemu_user', type: 'string', value: '', description: 'username to r= un QEMU system instance as') option('qemu_group', type: 'string', value: '', description: 'groupname to= run QEMU system instance as') @@ -123,7 +123,7 @@ option('host_validate', type: 'feature', value: 'auto',= description: 'build virt option('init_script', type: 'combo', choices: ['systemd', 'openrc', 'check= ', 'none'], value: 'check', description: 'Style of init script to install') option('loader_nvram', type: 'string', value: '', description: 'Pass list = of pairs of : paths. Both pairs and list items are separated= by a colon.') option('login_shell', type: 'feature', value: 'auto', description: 'build = virt-login-shell') -# dep:yajl dep:driver_network dep:libvirtd +# dep:json_c dep:driver_network dep:libvirtd option('nss', type: 'feature', value: 'auto', description: 'enable Name Se= rvice Switch plugin for resolving guest IP addresses') # dep:numactl option('numad', type: 'feature', value: 'auto', description: 'use numad to= manage CPU placement dynamically') --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723673598265561.083317799786; Wed, 14 Aug 2024 15:13:18 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3B67B12BE; Wed, 14 Aug 2024 18:13:17 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2D43515BB; Wed, 14 Aug 2024 17:43:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id F366912A8; Wed, 14 Aug 2024 17:43:44 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 40B6F13C2 for ; Wed, 14 Aug 2024 17:43:25 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-CTdzi67zMUWN7KSrdBnFLA-1; Wed, 14 Aug 2024 17:43:23 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D7EC41955F65 for ; Wed, 14 Aug 2024 21:43:22 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0AD121955E8C for ; Wed, 14 Aug 2024 21:43:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4M008GNqrZHR+rBaY8QIThjfZ499YWSIsVOJ0lb16AY=; b=KtiAxeh+WUvJwVL1Se30wS4lt0DqzbBqKWAp+mIS0HWs4WfUsZ4NY2IlTefs7kHA+fAbhP /8I3SphMJKps5ty44aBBcH0TvWwVdyk1hW3CbqijYyAyXsoCOoq17QGNcfNL2Vq6hTZVLn oRhdVv/dxtoGYBIzQFwJk5FI/ZiSC6g= X-MC-Unique: CTdzi67zMUWN7KSrdBnFLA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 15/20] libvirt-spec: switch to building with json-c Date: Wed, 14 Aug 2024 23:40:30 +0200 Message-ID: <682911e005ea8a60b1be2afdb82b4306dfc56ad2.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Y7YDMBRDD5HIDQDWHD5DT3EMF5S5XTXW X-Message-ID-Hash: Y7YDMBRDD5HIDQDWHD5DT3EMF5S5XTXW X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723673599282116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index ad0f4f784f..b9f9f5ed45 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -361,7 +361,7 @@ BuildRequires: libblkid-devel >=3D 2.17 BuildRequires: augeas BuildRequires: systemd-devel >=3D 185 BuildRequires: libpciaccess-devel >=3D 0.10.9 -BuildRequires: yajl-devel +BuildRequires: json-c-devel %if %{with_sanlock} BuildRequires: sanlock-devel >=3D 2.4 %endif @@ -1369,7 +1369,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Dapparmor_profiles=3Ddisabled \ -Dsecdriver_apparmor=3Ddisabled \ -Dudev=3Denabled \ - -Dyajl=3Denabled \ + -Djson_c=3Denabled \ %{?arg_sanlock} \ -Dlibpcap=3Denabled \ %{?arg_nbdkit} \ @@ -1484,7 +1484,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Dtests=3Ddisabled \ -Dudev=3Ddisabled \ -Dwireshark_dissector=3Ddisabled \ - -Dyajl=3Ddisabled \ + -Dyajl=3Ddisabled %{?enable_werror} %mingw_ninja %endif --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723673802585243.31979114647515; Wed, 14 Aug 2024 15:16:42 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9729F1364; Wed, 14 Aug 2024 18:16:41 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B32C115CE; Wed, 14 Aug 2024 17:44:17 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AF6B815C8; Wed, 14 Aug 2024 17:44:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AA0B11575 for ; Wed, 14 Aug 2024 17:43:26 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-VLjfCoXcPvazZXT_2n8J4Q-1; Wed, 14 Aug 2024 17:43:24 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12663192538D for ; Wed, 14 Aug 2024 21:43:24 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 289FC1955E8C for ; Wed, 14 Aug 2024 21:43:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RmRLj56DQej8Zjiv2bBFrz0QsjhaiaXWRVg+XO+5gBA=; b=BL/DggfVRW8OvHoXO3trI6ubMHbjBcPBGvil6CSR2B2plU9vbFNgY98Hd6r3d5+ftAp6aO SBsLhgqmAd4Wr/eRTIVZuKY61c/70KRcEkEvTGHAx7meEmCwRSWvhpYWs1JjI0MfVkAKmR +CqzKOLa1+lyGH6yScyUrEvwgJUwUCE= X-MC-Unique: VLjfCoXcPvazZXT_2n8J4Q-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 16/20] meson: do not link anything with yajl anymore Date: Wed, 14 Aug 2024 23:40:31 +0200 Message-ID: <4617c12f3c766a43de4413d2edda5fa80b8f3cfe.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: K6FIX5AYXXHEMBQI2UDCMZKV4O7ACWOR X-Message-ID-Hash: K6FIX5AYXXHEMBQI2UDCMZKV4O7ACWOR X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723673804167116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko --- src/meson.build | 1 - src/util/meson.build | 1 - tests/meson.build | 1 - tools/nss/meson.build | 2 -- 4 files changed, 5 deletions(-) diff --git a/src/meson.build b/src/meson.build index b9652785dd..b53ea2a71f 100644 --- a/src/meson.build +++ b/src/meson.build @@ -559,7 +559,6 @@ if conf.has('WITH_REMOTE') src_dep, rpc_dep, xdr_dep, - yajl_dep, ], include_directories: [ admin_inc_dir, diff --git a/src/util/meson.build b/src/util/meson.build index ab6942fa81..2998fed920 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -203,7 +203,6 @@ virt_util_lib =3D static_library( src_dep, thread_dep, win32_dep, - yajl_dep, ], ) =20 diff --git a/tests/meson.build b/tests/meson.build index d6e73bfba0..64e5780e48 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -17,7 +17,6 @@ tests_dep =3D declare_dependency( sasl_dep, selinux_dep, xdr_dep, - yajl_dep, ], include_directories: [ conf_inc_dir, diff --git a/tools/nss/meson.build b/tools/nss/meson.build index 1cae93ac67..38bba2d616 100644 --- a/tools/nss/meson.build +++ b/tools/nss/meson.build @@ -30,7 +30,6 @@ nss_libvirt_impl =3D static_library( dependencies: [ json_c_dep, tools_dep, - yajl_dep, ], ) =20 @@ -47,7 +46,6 @@ nss_libvirt_guest_impl =3D static_library( dependencies: [ json_c_dep, tools_dep, - yajl_dep, ], ) =20 --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723673927830922.1381559287099; Wed, 14 Aug 2024 15:18:47 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CDC9A998; Wed, 14 Aug 2024 18:18:46 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 036091575; Wed, 14 Aug 2024 17:44:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C6D431575; Wed, 14 Aug 2024 17:44:19 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D93BB12D2 for ; Wed, 14 Aug 2024 17:43:27 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-HxCh6tz1MLi9-n_Ew1VF1Q-1; Wed, 14 Aug 2024 17:43:26 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2AED219373D7 for ; Wed, 14 Aug 2024 21:43:25 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3CEB41955E8C for ; Wed, 14 Aug 2024 21:43:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k8XbPexa+WBHai10RbyulLZHidoQOxKgwA2hxf2YNWY=; b=b6eFJtjx3PRNxRJBL8aox9iQgxbNblxRlHM4X/RMTO6lkB5FtYyeRbrmoQ1oeI2Wc8lDWm j+y9k7hjgr0WNEO3p4IW5vqO8e+VU9eMBLAzerfy6lYjpB5QNAWY2bfMFEy9Ikdhs2pQ4C lzQ4KofB11qASCZoLhaRX/qPJEYzmyE= X-MC-Unique: HxCh6tz1MLi9-n_Ew1VF1Q-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 17/20] meson: options: drop yajl Date: Wed, 14 Aug 2024 23:40:32 +0200 Message-ID: <143c4d5c54ee6d3236b93cad76a3c8992ec9167e.1723671635.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: INELTMG2V4DLN4UN3DBPQRIBZLLWRMSY X-Message-ID-Hash: INELTMG2V4DLN4UN3DBPQRIBZLLWRMSY X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723673928646116600 Content-Type: text/plain; charset="utf-8" Drop the yajl option and all references to it. Signed-off-by: J=C3=A1n Tomko --- libvirt.spec.in | 1 - meson.build | 2 +- meson_options.txt | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b9f9f5ed45..e0c616627e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1484,7 +1484,6 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Dtests=3Ddisabled \ -Dudev=3Ddisabled \ -Dwireshark_dissector=3Ddisabled \ - -Dyajl=3Ddisabled %{?enable_werror} %mingw_ninja %endif diff --git a/meson.build b/meson.build index 837b209232..e8c19d8725 100644 --- a/meson.build +++ b/meson.build @@ -1378,7 +1378,7 @@ if wireshark_dep.found() endif =20 yajl_version =3D '2.0.3' -yajl_dep =3D dependency('yajl', version: '>=3D' + yajl_version, required: = get_option('yajl')) +yajl_dep =3D dependency('yajl', version: '>=3D' + yajl_version, required: = false) if yajl_dep.found() # Kludge for yajl include path on non-Linux # diff --git a/meson_options.txt b/meson_options.txt index 122cda0350..3dc3e8667b 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -51,7 +51,6 @@ option('udev', type: 'feature', value: 'auto', descriptio= n: 'udev support') # dep:driver_remote option('wireshark_dissector', type: 'feature', value: 'auto', description:= 'wireshark support') option('wireshark_plugindir', type: 'string', value: '', description: 'wir= eshark plugins directory for use when installing wireshark plugin') -option('yajl', type: 'feature', value: 'auto', description: 'yajl support') =20 =20 # build driver options --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723674025272209.39235105102262; Wed, 14 Aug 2024 15:20:25 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 38BC2125D; Wed, 14 Aug 2024 18:20:24 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 528E615D6; Wed, 14 Aug 2024 17:44:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 769F5158C; Wed, 14 Aug 2024 17:44:21 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9C25D138A for ; Wed, 14 Aug 2024 17:43:28 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-br8w4SWkPuebfeO9W4QknQ-1; Wed, 14 Aug 2024 17:43:26 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2145A1955F4A for ; Wed, 14 Aug 2024 21:43:26 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 511261955E8C for ; Wed, 14 Aug 2024 21:43:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S6E14Rw29zshlSAqoo5Zmml8pDDhs5HyYQ01nKG5y+Y=; b=eeUFD7JDQJ24aofdgtYNBTVTq8+Oxu5q96hkSEnk6Ajtj8oGdM9HWkIe+2hIbn1nm72Vrf XCrPP8tIkue/JXDyOSh1Je3uDYASK9WQ7H/4vvTp46Xosc/IB0wnrOZnDBV08NXz3487UB U4IJF02g7/m8IR5PlxFfbWoZUlVIfnk= X-MC-Unique: br8w4SWkPuebfeO9W4QknQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 18/20] meson: drop yajl detection Date: Wed, 14 Aug 2024 23:40:33 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5SRZN6ZEHO3GJPAANGF4FNNQLAFDTVSJ X-Message-ID-Hash: 5SRZN6ZEHO3GJPAANGF4FNNQLAFDTVSJ X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723674027003116600 Content-Type: text/plain; charset="utf-8" After this commit, WITH_YAJL can no longer be set. Signed-off-by: J=C3=A1n Tomko --- meson.build | 42 ------------------------------------------ 1 file changed, 42 deletions(-) diff --git a/meson.build b/meson.build index e8c19d8725..503b4362f7 100644 --- a/meson.build +++ b/meson.build @@ -1377,47 +1377,6 @@ if wireshark_dep.found() endif endif =20 -yajl_version =3D '2.0.3' -yajl_dep =3D dependency('yajl', version: '>=3D' + yajl_version, required: = false) -if yajl_dep.found() - # Kludge for yajl include path on non-Linux - # - # As of 2.1.0, upstream yajl.pc has -I${includedir}/yajl among - # its Cflags, which is clearly wrong. This does not affect Linux - # because ${includedir} is already part of the default include path, - # but on other platforms that's not the case and the result is that - # can't be located, causing the build to fail. - # - # Since upstream development for yajl has stopped years ago, there's - # little hope of this issue getting fixed by a new upstream release. - # Some non-Linux operating systems such as FreeBSD have elected to - # carry a small downstream patch, but in the case of Homebrew on - # macOS this approach has been rejected[1] and so we're left with no - # choice but to work around the issue ourselves. - # - # [1] https://github.com/Homebrew/homebrew-core/pull/74516 - if host_machine.system() !=3D 'linux' - yajl_includedir =3D yajl_dep.get_variable(pkgconfig : 'includedir') - if yajl_includedir.contains('include/yajl') - rc =3D run_command( - 'python3', '-c', - 'print("@0@".replace("@1@", "@2@"))'.format( - yajl_includedir, 'include/yajl', 'include', - ), - check: true, - ) - yajl_includedir =3D rc.stdout().strip() - yajl_dep =3D declare_dependency( - compile_args: [ '-I' + yajl_includedir ], - dependencies: [ yajl_dep ], - ) - endif - endif - - conf.set('WITH_YAJL', 1) -endif - - # generic build dependencies checks =20 if bash_completion_dep.found() and not readline_dep.found() @@ -2372,7 +2331,6 @@ libs_summary =3D { 'selinux': selinux_dep.found(), 'udev': udev_dep.found(), 'xdr': xdr_dep.found(), - 'yajl': yajl_dep.found(), } summary(libs_summary, section: 'Libraries', bool_yn: true) =20 --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723674072326385.1124540158395; Wed, 14 Aug 2024 15:21:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 20474B03; Wed, 14 Aug 2024 18:21:11 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AA68D15DD; Wed, 14 Aug 2024 17:44:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2827815CA; Wed, 14 Aug 2024 17:44:22 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D145212BE for ; Wed, 14 Aug 2024 17:43:29 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-2DD1S0vYM_WZPxD2YwEgYQ-1; Wed, 14 Aug 2024 17:43:28 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 528301955F03 for ; Wed, 14 Aug 2024 21:43:27 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 65B6F1955E8C for ; Wed, 14 Aug 2024 21:43:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m3shasuFL6oGSarCOedGxF+wwwkl8KSR8Ru4KZdQbM0=; b=ey/uPi+8rdn5B330XmnJezNpjWsxgRsG/VS5yJReA+qYVqZ4bwtlW4CRrtkD80eu2Hnhy2 RMzPmrZOpjtGUivvN75kkeOJt04mALIYyDdV0klOKE3eqxatI69aHFS45hVjD0lp98CxAo AgRVqM73MTd4unoo4f5XTKG5V6xua+o= X-MC-Unique: 2DD1S0vYM_WZPxD2YwEgYQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 19/20] util: drop dead code Date: Wed, 14 Aug 2024 23:40:34 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZYACKQODNRU7DWQNBEO452IQ3F4WZXDF X-Message-ID-Hash: ZYACKQODNRU7DWQNBEO452IQ3F4WZXDF X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723674073231116600 Content-Type: text/plain; charset="utf-8" Now that WITH_YAJL can never be set, we can remove some more code. Signed-off-by: J=C3=A1n Tomko --- src/util/virjson.c | 416 --------------------------------------------- 1 file changed, 416 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 7a22c54f03..98011759fb 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -34,10 +34,6 @@ =20 #if WITH_JSON_C # include -#elif WITH_YAJL -# include -# include - #endif =20 /* XXX fixme */ @@ -1563,418 +1559,6 @@ virJSONValueToBuffer(virJSONValue *object, return ret; } =20 -#elif WITH_YAJL -static int -virJSONParserInsertValue(virJSONParser *parser, - virJSONValue **value) -{ - if (!parser->head) { - parser->head =3D g_steal_pointer(value); - } else { - virJSONParserState *state; - if (!parser->nstate) { - VIR_DEBUG("got a value to insert without a container"); - return -1; - } - - state =3D &parser->state[parser->nstate-1]; - - switch (state->value->type) { - case VIR_JSON_TYPE_OBJECT: { - if (!state->key) { - VIR_DEBUG("missing key when inserting object value"); - return -1; - } - - if (virJSONValueObjectAppend(state->value, - state->key, - value) < 0) - return -1; - - VIR_FREE(state->key); - } break; - - case VIR_JSON_TYPE_ARRAY: { - if (state->key) { - VIR_DEBUG("unexpected key when inserting array value"); - return -1; - } - - if (virJSONValueArrayAppend(state->value, - value) < 0) - return -1; - } break; - - default: - VIR_DEBUG("unexpected value type, not a container"); - return -1; - } - } - - return 0; -} - - -static int -virJSONParserHandleNull(void *ctx) -{ - virJSONParser *parser =3D ctx; - g_autoptr(virJSONValue) value =3D virJSONValueNewNull(); - - VIR_DEBUG("parser=3D%p", parser); - - if (virJSONParserInsertValue(parser, &value) < 0) - return 0; - - return 1; -} - - -static int -virJSONParserHandleBoolean(void *ctx, - int boolean_) -{ - virJSONParser *parser =3D ctx; - g_autoptr(virJSONValue) value =3D virJSONValueNewBoolean(boolean_); - - VIR_DEBUG("parser=3D%p boolean=3D%d", parser, boolean_); - - if (virJSONParserInsertValue(parser, &value) < 0) - return 0; - - return 1; -} - - -static int -virJSONParserHandleNumber(void *ctx, - const char *s, - size_t l) -{ - virJSONParser *parser =3D ctx; - g_autoptr(virJSONValue) value =3D virJSONValueNewNumber(g_strndup(s, l= )); - - VIR_DEBUG("parser=3D%p str=3D%s", parser, value->data.number); - - if (virJSONParserInsertValue(parser, &value) < 0) - return 0; - - return 1; -} - - -static int -virJSONParserHandleString(void *ctx, - const unsigned char *stringVal, - size_t stringLen) -{ - virJSONParser *parser =3D ctx; - g_autoptr(virJSONValue) value =3D virJSONValueNewString(g_strndup((con= st char *)stringVal, stringLen)); - - VIR_DEBUG("parser=3D%p str=3D%p", parser, (const char *)stringVal); - - if (virJSONParserInsertValue(parser, &value) < 0) - return 0; - - return 1; -} - - -static int -virJSONParserHandleMapKey(void *ctx, - const unsigned char *stringVal, - size_t stringLen) -{ - virJSONParser *parser =3D ctx; - virJSONParserState *state; - - VIR_DEBUG("parser=3D%p key=3D%p", parser, (const char *)stringVal); - - if (!parser->nstate) - return 0; - - state =3D &parser->state[parser->nstate-1]; - if (state->key) - return 0; - state->key =3D g_strndup((const char *)stringVal, stringLen); - return 1; -} - - -static int -virJSONParserHandleStartMap(void *ctx) -{ - virJSONParser *parser =3D ctx; - g_autoptr(virJSONValue) value =3D virJSONValueNewObject(); - virJSONValue *tmp =3D value; - - VIR_DEBUG("parser=3D%p", parser); - - if (virJSONParserInsertValue(parser, &value) < 0) - return 0; - - VIR_REALLOC_N(parser->state, parser->nstate + 1); - - parser->state[parser->nstate].value =3D tmp; - parser->state[parser->nstate].key =3D NULL; - parser->nstate++; - - return 1; -} - - -static int -virJSONParserHandleEndMap(void *ctx) -{ - virJSONParser *parser =3D ctx; - virJSONParserState *state; - - VIR_DEBUG("parser=3D%p", parser); - - if (!parser->nstate) - return 0; - - state =3D &(parser->state[parser->nstate-1]); - if (state->key) { - VIR_FREE(state->key); - return 0; - } - - VIR_DELETE_ELEMENT(parser->state, parser->nstate - 1, parser->nstate); - - return 1; -} - - -static int -virJSONParserHandleStartArray(void *ctx) -{ - virJSONParser *parser =3D ctx; - g_autoptr(virJSONValue) value =3D virJSONValueNewArray(); - virJSONValue *tmp =3D value; - - VIR_DEBUG("parser=3D%p", parser); - - if (virJSONParserInsertValue(parser, &value) < 0) - return 0; - - VIR_REALLOC_N(parser->state, parser->nstate + 1); - - parser->state[parser->nstate].value =3D tmp; - parser->state[parser->nstate].key =3D NULL; - parser->nstate++; - - return 1; -} - - -static int -virJSONParserHandleEndArray(void *ctx) -{ - virJSONParser *parser =3D ctx; - virJSONParserState *state; - - VIR_DEBUG("parser=3D%p", parser); - - if (!(parser->nstate - parser->wrap)) - return 0; - - state =3D &(parser->state[parser->nstate-1]); - if (state->key) { - VIR_FREE(state->key); - return 0; - } - - VIR_DELETE_ELEMENT(parser->state, parser->nstate - 1, parser->nstate); - - return 1; -} - - -static const yajl_callbacks parserCallbacks =3D { - virJSONParserHandleNull, - virJSONParserHandleBoolean, - NULL, - NULL, - virJSONParserHandleNumber, - virJSONParserHandleString, - virJSONParserHandleStartMap, - virJSONParserHandleMapKey, - virJSONParserHandleEndMap, - virJSONParserHandleStartArray, - virJSONParserHandleEndArray -}; - - -/* XXX add an incremental streaming parser - yajl trivially supports it */ -virJSONValue * -virJSONValueFromString(const char *jsonstring) -{ - yajl_handle hand; - virJSONParser parser =3D { NULL, NULL, 0, 0 }; - virJSONValue *ret =3D NULL; - int rc; - size_t len =3D strlen(jsonstring); - - VIR_DEBUG("string=3D%s", jsonstring); - - hand =3D yajl_alloc(&parserCallbacks, NULL, &parser); - if (!hand) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to create JSON parser")); - return NULL; - } - - /* Yajl 2 is nice enough to default to rejecting trailing garbage. */ - rc =3D yajl_parse(hand, (const unsigned char *)jsonstring, len); - if (rc !=3D yajl_status_ok || - yajl_complete_parse(hand) !=3D yajl_status_ok) { - unsigned char *errstr =3D yajl_get_error(hand, 1, - (const unsigned char*)jsons= tring, - strlen(jsonstring)); - - virReportError(VIR_ERR_INTERNAL_ERROR, - _("cannot parse json %1$s: %2$s"), - jsonstring, (const char*) errstr); - yajl_free_error(hand, errstr); - virJSONValueFree(parser.head); - goto cleanup; - } - - if (parser.nstate !=3D 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("cannot parse json %1$s: unterminated string/map/= array"), - jsonstring); - virJSONValueFree(parser.head); - } else { - ret =3D parser.head; - } - - cleanup: - yajl_free(hand); - - if (parser.nstate) { - size_t i; - for (i =3D 0; i < parser.nstate; i++) - VIR_FREE(parser.state[i].key); - VIR_FREE(parser.state); - } - - VIR_DEBUG("result=3D%p", ret); - - return ret; -} - - -static int -virJSONValueToStringOne(virJSONValue *object, - yajl_gen g) -{ - size_t i; - - VIR_DEBUG("object=3D%p type=3D%d gen=3D%p", object, object->type, g); - - switch (object->type) { - case VIR_JSON_TYPE_OBJECT: - if (yajl_gen_map_open(g) !=3D yajl_gen_status_ok) - return -1; - for (i =3D 0; i < object->data.object.npairs; i++) { - if (yajl_gen_string(g, - (unsigned char *)object->data.object.pairs= [i].key, - strlen(object->data.object.pairs[i].key)) - !=3D yajl_gen_status_ok) - return -1; - if (virJSONValueToStringOne(object->data.object.pairs[i].value= , g) < 0) - return -1; - } - if (yajl_gen_map_close(g) !=3D yajl_gen_status_ok) - return -1; - break; - case VIR_JSON_TYPE_ARRAY: - if (yajl_gen_array_open(g) !=3D yajl_gen_status_ok) - return -1; - for (i =3D 0; i < object->data.array.nvalues; i++) { - if (virJSONValueToStringOne(object->data.array.values[i], g) <= 0) - return -1; - } - if (yajl_gen_array_close(g) !=3D yajl_gen_status_ok) - return -1; - break; - - case VIR_JSON_TYPE_STRING: - if (yajl_gen_string(g, (unsigned char *)object->data.string, - strlen(object->data.string)) !=3D yajl_gen_sta= tus_ok) - return -1; - break; - - case VIR_JSON_TYPE_NUMBER: - if (yajl_gen_number(g, object->data.number, - strlen(object->data.number)) !=3D yajl_gen_sta= tus_ok) - return -1; - break; - - case VIR_JSON_TYPE_BOOLEAN: - if (yajl_gen_bool(g, object->data.boolean) !=3D yajl_gen_status_ok) - return -1; - break; - - case VIR_JSON_TYPE_NULL: - if (yajl_gen_null(g) !=3D yajl_gen_status_ok) - return -1; - break; - - default: - return -1; - } - - return 0; -} - - -int -virJSONValueToBuffer(virJSONValue *object, - virBuffer *buf, - bool pretty) -{ - yajl_gen g; - const unsigned char *str; - size_t len; - int ret =3D -1; - - VIR_DEBUG("object=3D%p", object); - - g =3D yajl_gen_alloc(NULL); - if (!g) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to create JSON formatter")); - goto cleanup; - } - yajl_gen_config(g, yajl_gen_beautify, pretty ? 1 : 0); - yajl_gen_config(g, yajl_gen_indent_string, pretty ? " " : " "); - yajl_gen_config(g, yajl_gen_validate_utf8, 1); - - if (virJSONValueToStringOne(object, g) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("failed to convert virJSONValue to yajl data")); - goto cleanup; - } - - if (yajl_gen_get_buf(g, &str, &len) !=3D yajl_gen_status_ok) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("failed to format JSON")); - goto cleanup; - } - - virBufferAdd(buf, (const char *) str, len); - ret =3D 0; - - cleanup: - yajl_gen_free(g); - - return ret; -} - - #else virJSONValue * virJSONValueFromString(const char *jsonstring G_GNUC_UNUSED) --=20 2.45.2 From nobody Sat Nov 23 13:59:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1723674385052497.1711550160619; Wed, 14 Aug 2024 15:26:25 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DB10A12DF; Wed, 14 Aug 2024 18:26:23 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 200DD13D4; Wed, 14 Aug 2024 17:44:52 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A37111305; Wed, 14 Aug 2024 17:44:49 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6EFE1138F for ; Wed, 14 Aug 2024 17:43:32 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-7eU496sLMc-LAkARTPAKPw-1; Wed, 14 Aug 2024 17:43:29 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 61E7618EB22C for ; Wed, 14 Aug 2024 21:43:28 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7C25A1955E8C for ; Wed, 14 Aug 2024 21:43:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723671812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7TRICAb28rr5CpftypX91qL7Bt25M96v0Uw7IcKoRco=; b=QSUt34MxCnSsMCIobJcqWBsToirnymQd66SjjJjaGH3TlAAabiQAng5Y+j6oi0b9RNDyoW pCQmkSNvN2KSi/MF6VDuMQnnPyua4U54tXjm67X2r6eMC9vRC4bkPeWDe/yBkWItoFYE+8 BuxQdEJ3bEAqgcvDeMHxboPPMozhm6k= X-MC-Unique: 7eU496sLMc-LAkARTPAKPw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 20/20] ci: drop yajl completely Date: Wed, 14 Aug 2024 23:40:35 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BNW7COTJSZPPQAJZKPVE4J34JF35MVTG X-Message-ID-Hash: BNW7COTJSZPPQAJZKPVE4J34JF35MVTG X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1723674386525116600 Content-Type: text/plain; charset="utf-8" It is no longer used by libvirt so it's pointless to install it. Signed-off-by: J=C3=A1n Tomko --- ci/buildenv/almalinux-9.sh | 3 +-- ci/buildenv/alpine-319.sh | 3 +-- ci/buildenv/alpine-edge.sh | 3 +-- ci/buildenv/centos-stream-9.sh | 3 +-- ci/buildenv/debian-11-cross-aarch64.sh | 1 - ci/buildenv/debian-11-cross-armv6l.sh | 1 - ci/buildenv/debian-11-cross-armv7l.sh | 1 - ci/buildenv/debian-11-cross-i686.sh | 1 - ci/buildenv/debian-11-cross-mips64el.sh | 1 - ci/buildenv/debian-11-cross-mipsel.sh | 1 - ci/buildenv/debian-11-cross-ppc64le.sh | 1 - ci/buildenv/debian-11-cross-s390x.sh | 1 - ci/buildenv/debian-11.sh | 1 - ci/buildenv/debian-12-cross-aarch64.sh | 1 - ci/buildenv/debian-12-cross-armv6l.sh | 1 - ci/buildenv/debian-12-cross-armv7l.sh | 1 - ci/buildenv/debian-12-cross-i686.sh | 1 - ci/buildenv/debian-12-cross-mips64el.sh | 1 - ci/buildenv/debian-12-cross-mipsel.sh | 1 - ci/buildenv/debian-12-cross-ppc64le.sh | 1 - ci/buildenv/debian-12-cross-s390x.sh | 1 - ci/buildenv/debian-12.sh | 1 - ci/buildenv/debian-sid-cross-aarch64.sh | 1 - ci/buildenv/debian-sid-cross-armv6l.sh | 1 - ci/buildenv/debian-sid-cross-armv7l.sh | 1 - ci/buildenv/debian-sid-cross-i686.sh | 1 - ci/buildenv/debian-sid-cross-mips64el.sh | 1 - ci/buildenv/debian-sid-cross-ppc64le.sh | 1 - ci/buildenv/debian-sid-cross-s390x.sh | 1 - ci/buildenv/debian-sid.sh | 1 - ci/buildenv/fedora-39.sh | 3 +-- ci/buildenv/fedora-40.sh | 3 +-- ci/buildenv/fedora-rawhide.sh | 3 +-- ci/buildenv/opensuse-leap-15.sh | 1 - ci/buildenv/opensuse-tumbleweed.sh | 1 - ci/buildenv/ubuntu-2204.sh | 1 - ci/buildenv/ubuntu-2404.sh | 1 - ci/cirrus/freebsd-13.vars | 2 +- ci/cirrus/freebsd-14.vars | 2 +- ci/cirrus/macos-13.vars | 2 +- ci/cirrus/macos-14.vars | 2 +- ci/containers/almalinux-9.Dockerfile | 3 +-- ci/containers/alpine-319.Dockerfile | 3 +-- ci/containers/alpine-edge.Dockerfile | 3 +-- ci/containers/centos-stream-9.Dockerfile | 3 +-- ci/containers/debian-11-cross-aarch64.Dockerfile | 1 - ci/containers/debian-11-cross-armv6l.Dockerfile | 1 - ci/containers/debian-11-cross-armv7l.Dockerfile | 1 - ci/containers/debian-11-cross-i686.Dockerfile | 1 - ci/containers/debian-11-cross-mips64el.Dockerfile | 1 - ci/containers/debian-11-cross-mipsel.Dockerfile | 1 - ci/containers/debian-11-cross-ppc64le.Dockerfile | 1 - ci/containers/debian-11-cross-s390x.Dockerfile | 1 - ci/containers/debian-11.Dockerfile | 1 - ci/containers/debian-12-cross-aarch64.Dockerfile | 1 - ci/containers/debian-12-cross-armv6l.Dockerfile | 1 - ci/containers/debian-12-cross-armv7l.Dockerfile | 1 - ci/containers/debian-12-cross-i686.Dockerfile | 1 - ci/containers/debian-12-cross-mips64el.Dockerfile | 1 - ci/containers/debian-12-cross-mipsel.Dockerfile | 1 - ci/containers/debian-12-cross-ppc64le.Dockerfile | 1 - ci/containers/debian-12-cross-s390x.Dockerfile | 1 - ci/containers/debian-12.Dockerfile | 1 - ci/containers/debian-sid-cross-aarch64.Dockerfile | 1 - ci/containers/debian-sid-cross-armv6l.Dockerfile | 1 - ci/containers/debian-sid-cross-armv7l.Dockerfile | 1 - ci/containers/debian-sid-cross-i686.Dockerfile | 1 - ci/containers/debian-sid-cross-mips64el.Dockerfile | 1 - ci/containers/debian-sid-cross-ppc64le.Dockerfile | 1 - ci/containers/debian-sid-cross-s390x.Dockerfile | 1 - ci/containers/debian-sid.Dockerfile | 1 - ci/containers/fedora-39.Dockerfile | 3 +-- ci/containers/fedora-40.Dockerfile | 3 +-- ci/containers/fedora-rawhide.Dockerfile | 3 +-- ci/containers/opensuse-leap-15.Dockerfile | 1 - ci/containers/opensuse-tumbleweed.Dockerfile | 1 - ci/containers/ubuntu-2204.Dockerfile | 1 - ci/containers/ubuntu-2404.Dockerfile | 1 - ci/lcitool/projects/libvirt.yml | 1 - 79 files changed, 18 insertions(+), 93 deletions(-) diff --git a/ci/buildenv/almalinux-9.sh b/ci/buildenv/almalinux-9.sh index 6ca05b4add..3f3993229e 100644 --- a/ci/buildenv/almalinux-9.sh +++ b/ci/buildenv/almalinux-9.sh @@ -84,8 +84,7 @@ function install_buildenv() { systemd-devel \ systemd-rpm-macros \ systemtap-sdt-devel \ - wireshark-devel \ - yajl-devel + wireshark-devel rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED rpm -qa | sort > /packages.txt mkdir -p /usr/libexec/ccache-wrappers diff --git a/ci/buildenv/alpine-319.sh b/ci/buildenv/alpine-319.sh index fe8dcf8ab7..d2149a6def 100644 --- a/ci/buildenv/alpine-319.sh +++ b/ci/buildenv/alpine-319.sh @@ -67,8 +67,7 @@ function install_buildenv() { sed \ util-linux-dev \ wireshark-dev \ - xen-dev \ - yajl-dev + xen-dev rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED apk list --installed | sort > /packages.txt mkdir -p /usr/libexec/ccache-wrappers diff --git a/ci/buildenv/alpine-edge.sh b/ci/buildenv/alpine-edge.sh index fe8dcf8ab7..d2149a6def 100644 --- a/ci/buildenv/alpine-edge.sh +++ b/ci/buildenv/alpine-edge.sh @@ -67,8 +67,7 @@ function install_buildenv() { sed \ util-linux-dev \ wireshark-dev \ - xen-dev \ - yajl-dev + xen-dev rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED apk list --installed | sort > /packages.txt mkdir -p /usr/libexec/ccache-wrappers diff --git a/ci/buildenv/centos-stream-9.sh b/ci/buildenv/centos-stream-9.sh index ca5bce3eb9..cb67c3cdcc 100644 --- a/ci/buildenv/centos-stream-9.sh +++ b/ci/buildenv/centos-stream-9.sh @@ -85,8 +85,7 @@ function install_buildenv() { systemd-devel \ systemd-rpm-macros \ systemtap-sdt-devel \ - wireshark-devel \ - yajl-devel + wireshark-devel rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED rpm -qa | sort > /packages.txt mkdir -p /usr/libexec/ccache-wrappers diff --git a/ci/buildenv/debian-11-cross-aarch64.sh b/ci/buildenv/debian-11= -cross-aarch64.sh index 2d9ad9064d..6600b73e74 100644 --- a/ci/buildenv/debian-11-cross-aarch64.sh +++ b/ci/buildenv/debian-11-cross-aarch64.sh @@ -88,7 +88,6 @@ function install_buildenv() { libudev-dev:arm64 \ libxen-dev:arm64 \ libxml2-dev:arm64 \ - libyajl-dev:arm64 \ systemtap-sdt-dev:arm64 mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11-cross-armv6l.sh b/ci/buildenv/debian-11-= cross-armv6l.sh index 2be50a66c9..761d813df0 100644 --- a/ci/buildenv/debian-11-cross-armv6l.sh +++ b/ci/buildenv/debian-11-cross-armv6l.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:armel \ libudev-dev:armel \ libxml2-dev:armel \ - libyajl-dev:armel \ systemtap-sdt-dev:armel mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11-cross-armv7l.sh b/ci/buildenv/debian-11-= cross-armv7l.sh index 6d6ef91868..6c016bd90b 100644 --- a/ci/buildenv/debian-11-cross-armv7l.sh +++ b/ci/buildenv/debian-11-cross-armv7l.sh @@ -88,7 +88,6 @@ function install_buildenv() { libudev-dev:armhf \ libxen-dev:armhf \ libxml2-dev:armhf \ - libyajl-dev:armhf \ systemtap-sdt-dev:armhf mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11-cross-i686.sh b/ci/buildenv/debian-11-cr= oss-i686.sh index b8bd49e3a8..b9705f1c3c 100644 --- a/ci/buildenv/debian-11-cross-i686.sh +++ b/ci/buildenv/debian-11-cross-i686.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:i386 \ libudev-dev:i386 \ libxml2-dev:i386 \ - libyajl-dev:i386 \ systemtap-sdt-dev:i386 mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11-cross-mips64el.sh b/ci/buildenv/debian-1= 1-cross-mips64el.sh index 3d5b75139c..065c61ba57 100644 --- a/ci/buildenv/debian-11-cross-mips64el.sh +++ b/ci/buildenv/debian-11-cross-mips64el.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:mips64el \ libudev-dev:mips64el \ libxml2-dev:mips64el \ - libyajl-dev:mips64el \ systemtap-sdt-dev:mips64el mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11-cross-mipsel.sh b/ci/buildenv/debian-11-= cross-mipsel.sh index 20a97c165e..89a0a8904b 100644 --- a/ci/buildenv/debian-11-cross-mipsel.sh +++ b/ci/buildenv/debian-11-cross-mipsel.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:mipsel \ libudev-dev:mipsel \ libxml2-dev:mipsel \ - libyajl-dev:mipsel \ systemtap-sdt-dev:mipsel mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11-cross-ppc64le.sh b/ci/buildenv/debian-11= -cross-ppc64le.sh index 2b5ebf360d..c898939f09 100644 --- a/ci/buildenv/debian-11-cross-ppc64le.sh +++ b/ci/buildenv/debian-11-cross-ppc64le.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:ppc64el \ libudev-dev:ppc64el \ libxml2-dev:ppc64el \ - libyajl-dev:ppc64el \ systemtap-sdt-dev:ppc64el mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11-cross-s390x.sh b/ci/buildenv/debian-11-c= ross-s390x.sh index 1391685e46..f1b94ac872 100644 --- a/ci/buildenv/debian-11-cross-s390x.sh +++ b/ci/buildenv/debian-11-cross-s390x.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:s390x \ libudev-dev:s390x \ libxml2-dev:s390x \ - libyajl-dev:s390x \ systemtap-sdt-dev:s390x mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-11.sh b/ci/buildenv/debian-11.sh index e56ea3b3ec..9ba9e80183 100644 --- a/ci/buildenv/debian-11.sh +++ b/ci/buildenv/debian-11.sh @@ -64,7 +64,6 @@ function install_buildenv() { libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/buildenv/debian-12-cross-aarch64.sh b/ci/buildenv/debian-12= -cross-aarch64.sh index 4f7285e171..93288ae46f 100644 --- a/ci/buildenv/debian-12-cross-aarch64.sh +++ b/ci/buildenv/debian-12-cross-aarch64.sh @@ -89,7 +89,6 @@ function install_buildenv() { libudev-dev:arm64 \ libxen-dev:arm64 \ libxml2-dev:arm64 \ - libyajl-dev:arm64 \ systemtap-sdt-dev:arm64 mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12-cross-armv6l.sh b/ci/buildenv/debian-12-= cross-armv6l.sh index 6d98d1deff..37e743478d 100644 --- a/ci/buildenv/debian-12-cross-armv6l.sh +++ b/ci/buildenv/debian-12-cross-armv6l.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:armel \ libudev-dev:armel \ libxml2-dev:armel \ - libyajl-dev:armel \ systemtap-sdt-dev:armel mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12-cross-armv7l.sh b/ci/buildenv/debian-12-= cross-armv7l.sh index 39d064b659..1b8e4f7019 100644 --- a/ci/buildenv/debian-12-cross-armv7l.sh +++ b/ci/buildenv/debian-12-cross-armv7l.sh @@ -89,7 +89,6 @@ function install_buildenv() { libudev-dev:armhf \ libxen-dev:armhf \ libxml2-dev:armhf \ - libyajl-dev:armhf \ systemtap-sdt-dev:armhf mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12-cross-i686.sh b/ci/buildenv/debian-12-cr= oss-i686.sh index aa91d6e08a..060b6ea75e 100644 --- a/ci/buildenv/debian-12-cross-i686.sh +++ b/ci/buildenv/debian-12-cross-i686.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:i386 \ libudev-dev:i386 \ libxml2-dev:i386 \ - libyajl-dev:i386 \ systemtap-sdt-dev:i386 mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12-cross-mips64el.sh b/ci/buildenv/debian-1= 2-cross-mips64el.sh index e3b92bf9db..6da5920d1d 100644 --- a/ci/buildenv/debian-12-cross-mips64el.sh +++ b/ci/buildenv/debian-12-cross-mips64el.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:mips64el \ libudev-dev:mips64el \ libxml2-dev:mips64el \ - libyajl-dev:mips64el \ systemtap-sdt-dev:mips64el mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12-cross-mipsel.sh b/ci/buildenv/debian-12-= cross-mipsel.sh index 7c5de342a4..5ad809c625 100644 --- a/ci/buildenv/debian-12-cross-mipsel.sh +++ b/ci/buildenv/debian-12-cross-mipsel.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:mipsel \ libudev-dev:mipsel \ libxml2-dev:mipsel \ - libyajl-dev:mipsel \ systemtap-sdt-dev:mipsel mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12-cross-ppc64le.sh b/ci/buildenv/debian-12= -cross-ppc64le.sh index 05f2a2bd54..eca66706fc 100644 --- a/ci/buildenv/debian-12-cross-ppc64le.sh +++ b/ci/buildenv/debian-12-cross-ppc64le.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:ppc64el \ libudev-dev:ppc64el \ libxml2-dev:ppc64el \ - libyajl-dev:ppc64el \ systemtap-sdt-dev:ppc64el mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12-cross-s390x.sh b/ci/buildenv/debian-12-c= ross-s390x.sh index b092d59b9d..65dc4ce545 100644 --- a/ci/buildenv/debian-12-cross-s390x.sh +++ b/ci/buildenv/debian-12-cross-s390x.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:s390x \ libudev-dev:s390x \ libxml2-dev:s390x \ - libyajl-dev:s390x \ systemtap-sdt-dev:s390x mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-12.sh b/ci/buildenv/debian-12.sh index 01777c2165..d06f33af12 100644 --- a/ci/buildenv/debian-12.sh +++ b/ci/buildenv/debian-12.sh @@ -64,7 +64,6 @@ function install_buildenv() { libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/buildenv/debian-sid-cross-aarch64.sh b/ci/buildenv/debian-s= id-cross-aarch64.sh index 4f7285e171..93288ae46f 100644 --- a/ci/buildenv/debian-sid-cross-aarch64.sh +++ b/ci/buildenv/debian-sid-cross-aarch64.sh @@ -89,7 +89,6 @@ function install_buildenv() { libudev-dev:arm64 \ libxen-dev:arm64 \ libxml2-dev:arm64 \ - libyajl-dev:arm64 \ systemtap-sdt-dev:arm64 mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-sid-cross-armv6l.sh b/ci/buildenv/debian-si= d-cross-armv6l.sh index c5ced00879..f19ec82093 100644 --- a/ci/buildenv/debian-sid-cross-armv6l.sh +++ b/ci/buildenv/debian-sid-cross-armv6l.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:armel \ libudev-dev:armel \ libxml2-dev:armel \ - libyajl-dev:armel \ systemtap-sdt-dev:armel mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-sid-cross-armv7l.sh b/ci/buildenv/debian-si= d-cross-armv7l.sh index 38c3dffe1a..4ebf3126e3 100644 --- a/ci/buildenv/debian-sid-cross-armv7l.sh +++ b/ci/buildenv/debian-sid-cross-armv7l.sh @@ -88,7 +88,6 @@ function install_buildenv() { libudev-dev:armhf \ libxen-dev:armhf \ libxml2-dev:armhf \ - libyajl-dev:armhf \ systemtap-sdt-dev:armhf mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-sid-cross-i686.sh b/ci/buildenv/debian-sid-= cross-i686.sh index 59694cca46..43c02e784e 100644 --- a/ci/buildenv/debian-sid-cross-i686.sh +++ b/ci/buildenv/debian-sid-cross-i686.sh @@ -87,7 +87,6 @@ function install_buildenv() { libtirpc-dev:i386 \ libudev-dev:i386 \ libxml2-dev:i386 \ - libyajl-dev:i386 \ systemtap-sdt-dev:i386 mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-sid-cross-mips64el.sh b/ci/buildenv/debian-= sid-cross-mips64el.sh index e3b92bf9db..6da5920d1d 100644 --- a/ci/buildenv/debian-sid-cross-mips64el.sh +++ b/ci/buildenv/debian-sid-cross-mips64el.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:mips64el \ libudev-dev:mips64el \ libxml2-dev:mips64el \ - libyajl-dev:mips64el \ systemtap-sdt-dev:mips64el mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-sid-cross-ppc64le.sh b/ci/buildenv/debian-s= id-cross-ppc64le.sh index 05f2a2bd54..eca66706fc 100644 --- a/ci/buildenv/debian-sid-cross-ppc64le.sh +++ b/ci/buildenv/debian-sid-cross-ppc64le.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:ppc64el \ libudev-dev:ppc64el \ libxml2-dev:ppc64el \ - libyajl-dev:ppc64el \ systemtap-sdt-dev:ppc64el mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-sid-cross-s390x.sh b/ci/buildenv/debian-sid= -cross-s390x.sh index b092d59b9d..65dc4ce545 100644 --- a/ci/buildenv/debian-sid-cross-s390x.sh +++ b/ci/buildenv/debian-sid-cross-s390x.sh @@ -88,7 +88,6 @@ function install_buildenv() { libtirpc-dev:s390x \ libudev-dev:s390x \ libxml2-dev:s390x \ - libyajl-dev:s390x \ systemtap-sdt-dev:s390x mkdir -p /usr/local/share/meson/cross printf "[binaries]\n\ diff --git a/ci/buildenv/debian-sid.sh b/ci/buildenv/debian-sid.sh index 01777c2165..d06f33af12 100644 --- a/ci/buildenv/debian-sid.sh +++ b/ci/buildenv/debian-sid.sh @@ -64,7 +64,6 @@ function install_buildenv() { libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/buildenv/fedora-39.sh b/ci/buildenv/fedora-39.sh index 06ae3bb62d..e45ac2230f 100644 --- a/ci/buildenv/fedora-39.sh +++ b/ci/buildenv/fedora-39.sh @@ -83,8 +83,7 @@ function install_buildenv() { systemd-rpm-macros \ systemtap-sdt-devel \ wireshark-devel \ - xen-devel \ - yajl-devel + xen-devel rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED rpm -qa | sort > /packages.txt mkdir -p /usr/libexec/ccache-wrappers diff --git a/ci/buildenv/fedora-40.sh b/ci/buildenv/fedora-40.sh index 06ae3bb62d..e45ac2230f 100644 --- a/ci/buildenv/fedora-40.sh +++ b/ci/buildenv/fedora-40.sh @@ -83,8 +83,7 @@ function install_buildenv() { systemd-rpm-macros \ systemtap-sdt-devel \ wireshark-devel \ - xen-devel \ - yajl-devel + xen-devel rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED rpm -qa | sort > /packages.txt mkdir -p /usr/libexec/ccache-wrappers diff --git a/ci/buildenv/fedora-rawhide.sh b/ci/buildenv/fedora-rawhide.sh index aec2d87b53..cbfeb71c92 100644 --- a/ci/buildenv/fedora-rawhide.sh +++ b/ci/buildenv/fedora-rawhide.sh @@ -84,8 +84,7 @@ function install_buildenv() { systemd-rpm-macros \ systemtap-sdt-devel \ wireshark-devel \ - xen-devel \ - yajl-devel + xen-devel rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED rpm -qa | sort > /packages.txt mkdir -p /usr/libexec/ccache-wrappers diff --git a/ci/buildenv/opensuse-leap-15.sh b/ci/buildenv/opensuse-leap-15= .sh index d462e6cdce..2a1c1e2314 100644 --- a/ci/buildenv/opensuse-leap-15.sh +++ b/ci/buildenv/opensuse-leap-15.sh @@ -59,7 +59,6 @@ function install_buildenv() { libxml2 \ libxml2-devel \ libxslt \ - libyajl-devel \ lvm2 \ make \ meson \ diff --git a/ci/buildenv/opensuse-tumbleweed.sh b/ci/buildenv/opensuse-tumb= leweed.sh index 2233699719..4e0f812622 100644 --- a/ci/buildenv/opensuse-tumbleweed.sh +++ b/ci/buildenv/opensuse-tumbleweed.sh @@ -59,7 +59,6 @@ function install_buildenv() { libxml2 \ libxml2-devel \ libxslt \ - libyajl-devel \ lvm2 \ make \ meson \ diff --git a/ci/buildenv/ubuntu-2204.sh b/ci/buildenv/ubuntu-2204.sh index e747a6f8c2..95762d663c 100644 --- a/ci/buildenv/ubuntu-2204.sh +++ b/ci/buildenv/ubuntu-2204.sh @@ -65,7 +65,6 @@ function install_buildenv() { libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/buildenv/ubuntu-2404.sh b/ci/buildenv/ubuntu-2404.sh index c26a80d06f..5ce8e74a91 100644 --- a/ci/buildenv/ubuntu-2404.sh +++ b/ci/buildenv/ubuntu-2404.sh @@ -65,7 +65,6 @@ function install_buildenv() { libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/cirrus/freebsd-13.vars b/ci/cirrus/freebsd-13.vars index bf82ac5176..fbcd613095 100644 --- a/ci/cirrus/freebsd-13.vars +++ b/ci/cirrus/freebsd-13.vars @@ -11,6 +11,6 @@ MAKE=3D'/usr/local/bin/gmake' NINJA=3D'/usr/local/bin/ninja' PACKAGING_COMMAND=3D'pkg' PIP3=3D'/usr/local/bin/pip-3.8' -PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed jso= n-c libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 p= kgconf polkit py311-black py311-docutils py311-flake8 py311-pytest python3 = qemu readline yajl' +PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed jso= n-c libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 p= kgconf polkit py311-black py311-docutils py311-flake8 py311-pytest python3 = qemu readline' PYPI_PKGS=3D'' PYTHON=3D'/usr/local/bin/python3' diff --git a/ci/cirrus/freebsd-14.vars b/ci/cirrus/freebsd-14.vars index bf82ac5176..fbcd613095 100644 --- a/ci/cirrus/freebsd-14.vars +++ b/ci/cirrus/freebsd-14.vars @@ -11,6 +11,6 @@ MAKE=3D'/usr/local/bin/gmake' NINJA=3D'/usr/local/bin/ninja' PACKAGING_COMMAND=3D'pkg' PIP3=3D'/usr/local/bin/pip-3.8' -PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed jso= n-c libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 p= kgconf polkit py311-black py311-docutils py311-flake8 py311-pytest python3 = qemu readline yajl' +PKGS=3D'augeas bash-completion ca_root_nss ccache codespell cppi curl cyru= s-sasl diffutils fusefs-libs gettext git glib gmake gnugrep gnutls gsed jso= n-c libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 p= kgconf polkit py311-black py311-docutils py311-flake8 py311-pytest python3 = qemu readline' PYPI_PKGS=3D'' PYTHON=3D'/usr/local/bin/python3' diff --git a/ci/cirrus/macos-13.vars b/ci/cirrus/macos-13.vars index 9860033931..d23fe3cd47 100644 --- a/ci/cirrus/macos-13.vars +++ b/ci/cirrus/macos-13.vars @@ -11,6 +11,6 @@ MAKE=3D'/opt/homebrew/bin/gmake' NINJA=3D'/opt/homebrew/bin/ninja' PACKAGING_COMMAND=3D'brew' PIP3=3D'/opt/homebrew/bin/pip3' -PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep json-c libiscsi libpca= p libssh libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 q= emu readline yajl' +PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep json-c libiscsi libpca= p libssh libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 q= emu readline' PYPI_PKGS=3D'pytest' PYTHON=3D'/opt/homebrew/bin/python3' diff --git a/ci/cirrus/macos-14.vars b/ci/cirrus/macos-14.vars index 9860033931..d23fe3cd47 100644 --- a/ci/cirrus/macos-14.vars +++ b/ci/cirrus/macos-14.vars @@ -11,6 +11,6 @@ MAKE=3D'/opt/homebrew/bin/gmake' NINJA=3D'/opt/homebrew/bin/ninja' PACKAGING_COMMAND=3D'brew' PIP3=3D'/opt/homebrew/bin/pip3' -PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep json-c libiscsi libpca= p libssh libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 q= emu readline yajl' +PKGS=3D'augeas bash-completion black ccache codespell cppi curl diffutils = docutils flake8 gettext git glib gnu-sed gnutls grep json-c libiscsi libpca= p libssh libssh2 libxml2 libxslt make meson ninja perl pkg-config python3 q= emu readline' PYPI_PKGS=3D'pytest' PYTHON=3D'/opt/homebrew/bin/python3' diff --git a/ci/containers/almalinux-9.Dockerfile b/ci/containers/almalinux= -9.Dockerfile index 0f54cb3224..576119542d 100644 --- a/ci/containers/almalinux-9.Dockerfile +++ b/ci/containers/almalinux-9.Dockerfile @@ -85,8 +85,7 @@ RUN dnf update -y && \ systemd-devel \ systemd-rpm-macros \ systemtap-sdt-devel \ - wireshark-devel \ - yajl-devel && \ + wireshark-devel && \ dnf autoremove -y && \ dnf clean all -y && \ rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ diff --git a/ci/containers/alpine-319.Dockerfile b/ci/containers/alpine-319= .Dockerfile index cdd9845a19..2e4842ef3e 100644 --- a/ci/containers/alpine-319.Dockerfile +++ b/ci/containers/alpine-319.Dockerfile @@ -68,8 +68,7 @@ RUN apk update && \ sed \ util-linux-dev \ wireshark-dev \ - xen-dev \ - yajl-dev && \ + xen-dev && \ rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ apk list --installed | sort > /packages.txt && \ mkdir -p /usr/libexec/ccache-wrappers && \ diff --git a/ci/containers/alpine-edge.Dockerfile b/ci/containers/alpine-ed= ge.Dockerfile index 4790d9ae8a..83f160257f 100644 --- a/ci/containers/alpine-edge.Dockerfile +++ b/ci/containers/alpine-edge.Dockerfile @@ -68,8 +68,7 @@ RUN apk update && \ sed \ util-linux-dev \ wireshark-dev \ - xen-dev \ - yajl-dev && \ + xen-dev && \ rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ apk list --installed | sort > /packages.txt && \ mkdir -p /usr/libexec/ccache-wrappers && \ diff --git a/ci/containers/centos-stream-9.Dockerfile b/ci/containers/cento= s-stream-9.Dockerfile index d83ca27b93..1b21f9ea75 100644 --- a/ci/containers/centos-stream-9.Dockerfile +++ b/ci/containers/centos-stream-9.Dockerfile @@ -86,8 +86,7 @@ RUN dnf distro-sync -y && \ systemd-devel \ systemd-rpm-macros \ systemtap-sdt-devel \ - wireshark-devel \ - yajl-devel && \ + wireshark-devel && \ dnf autoremove -y && \ dnf clean all -y && \ rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ diff --git a/ci/containers/debian-11-cross-aarch64.Dockerfile b/ci/containe= rs/debian-11-cross-aarch64.Dockerfile index 7a7d22b766..f8d4ea8ed2 100644 --- a/ci/containers/debian-11-cross-aarch64.Dockerfile +++ b/ci/containers/debian-11-cross-aarch64.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libudev-dev:arm64 \ libxen-dev:arm64 \ libxml2-dev:arm64 \ - libyajl-dev:arm64 \ systemtap-sdt-dev:arm64 && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11-cross-armv6l.Dockerfile b/ci/container= s/debian-11-cross-armv6l.Dockerfile index 08737bb216..f974163000 100644 --- a/ci/containers/debian-11-cross-armv6l.Dockerfile +++ b/ci/containers/debian-11-cross-armv6l.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:armel \ libudev-dev:armel \ libxml2-dev:armel \ - libyajl-dev:armel \ systemtap-sdt-dev:armel && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11-cross-armv7l.Dockerfile b/ci/container= s/debian-11-cross-armv7l.Dockerfile index d8bb30d4a1..ced175c7c0 100644 --- a/ci/containers/debian-11-cross-armv7l.Dockerfile +++ b/ci/containers/debian-11-cross-armv7l.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libudev-dev:armhf \ libxen-dev:armhf \ libxml2-dev:armhf \ - libyajl-dev:armhf \ systemtap-sdt-dev:armhf && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11-cross-i686.Dockerfile b/ci/containers/= debian-11-cross-i686.Dockerfile index c37a7d2bfa..c1ee60f3b6 100644 --- a/ci/containers/debian-11-cross-i686.Dockerfile +++ b/ci/containers/debian-11-cross-i686.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:i386 \ libudev-dev:i386 \ libxml2-dev:i386 \ - libyajl-dev:i386 \ systemtap-sdt-dev:i386 && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11-cross-mips64el.Dockerfile b/ci/contain= ers/debian-11-cross-mips64el.Dockerfile index 27556d7e07..98c40beef4 100644 --- a/ci/containers/debian-11-cross-mips64el.Dockerfile +++ b/ci/containers/debian-11-cross-mips64el.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:mips64el \ libudev-dev:mips64el \ libxml2-dev:mips64el \ - libyajl-dev:mips64el \ systemtap-sdt-dev:mips64el && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11-cross-mipsel.Dockerfile b/ci/container= s/debian-11-cross-mipsel.Dockerfile index be0e9e0188..e3531a9fac 100644 --- a/ci/containers/debian-11-cross-mipsel.Dockerfile +++ b/ci/containers/debian-11-cross-mipsel.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:mipsel \ libudev-dev:mipsel \ libxml2-dev:mipsel \ - libyajl-dev:mipsel \ systemtap-sdt-dev:mipsel && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11-cross-ppc64le.Dockerfile b/ci/containe= rs/debian-11-cross-ppc64le.Dockerfile index cfbef7dcbc..8f9f729909 100644 --- a/ci/containers/debian-11-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-11-cross-ppc64le.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:ppc64el \ libudev-dev:ppc64el \ libxml2-dev:ppc64el \ - libyajl-dev:ppc64el \ systemtap-sdt-dev:ppc64el && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11-cross-s390x.Dockerfile b/ci/containers= /debian-11-cross-s390x.Dockerfile index 1b7cee0572..b09076b148 100644 --- a/ci/containers/debian-11-cross-s390x.Dockerfile +++ b/ci/containers/debian-11-cross-s390x.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:s390x \ libudev-dev:s390x \ libxml2-dev:s390x \ - libyajl-dev:s390x \ systemtap-sdt-dev:s390x && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-11.Dockerfile b/ci/containers/debian-11.D= ockerfile index da72d538c0..1660bd9c52 100644 --- a/ci/containers/debian-11.Dockerfile +++ b/ci/containers/debian-11.Dockerfile @@ -66,7 +66,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/containers/debian-12-cross-aarch64.Dockerfile b/ci/containe= rs/debian-12-cross-aarch64.Dockerfile index 1504ba0b72..e57cbffaec 100644 --- a/ci/containers/debian-12-cross-aarch64.Dockerfile +++ b/ci/containers/debian-12-cross-aarch64.Dockerfile @@ -100,7 +100,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libudev-dev:arm64 \ libxen-dev:arm64 \ libxml2-dev:arm64 \ - libyajl-dev:arm64 \ systemtap-sdt-dev:arm64 && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12-cross-armv6l.Dockerfile b/ci/container= s/debian-12-cross-armv6l.Dockerfile index ce2c71d466..9572f4d28f 100644 --- a/ci/containers/debian-12-cross-armv6l.Dockerfile +++ b/ci/containers/debian-12-cross-armv6l.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:armel \ libudev-dev:armel \ libxml2-dev:armel \ - libyajl-dev:armel \ systemtap-sdt-dev:armel && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12-cross-armv7l.Dockerfile b/ci/container= s/debian-12-cross-armv7l.Dockerfile index 410f4fe15d..e29eea8a6b 100644 --- a/ci/containers/debian-12-cross-armv7l.Dockerfile +++ b/ci/containers/debian-12-cross-armv7l.Dockerfile @@ -100,7 +100,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libudev-dev:armhf \ libxen-dev:armhf \ libxml2-dev:armhf \ - libyajl-dev:armhf \ systemtap-sdt-dev:armhf && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12-cross-i686.Dockerfile b/ci/containers/= debian-12-cross-i686.Dockerfile index 4ae974eb16..39f5e9ef8d 100644 --- a/ci/containers/debian-12-cross-i686.Dockerfile +++ b/ci/containers/debian-12-cross-i686.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:i386 \ libudev-dev:i386 \ libxml2-dev:i386 \ - libyajl-dev:i386 \ systemtap-sdt-dev:i386 && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12-cross-mips64el.Dockerfile b/ci/contain= ers/debian-12-cross-mips64el.Dockerfile index 9664b30c14..af15c9c76a 100644 --- a/ci/containers/debian-12-cross-mips64el.Dockerfile +++ b/ci/containers/debian-12-cross-mips64el.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:mips64el \ libudev-dev:mips64el \ libxml2-dev:mips64el \ - libyajl-dev:mips64el \ systemtap-sdt-dev:mips64el && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12-cross-mipsel.Dockerfile b/ci/container= s/debian-12-cross-mipsel.Dockerfile index 4692d1ce8c..63caa15b20 100644 --- a/ci/containers/debian-12-cross-mipsel.Dockerfile +++ b/ci/containers/debian-12-cross-mipsel.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:mipsel \ libudev-dev:mipsel \ libxml2-dev:mipsel \ - libyajl-dev:mipsel \ systemtap-sdt-dev:mipsel && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12-cross-ppc64le.Dockerfile b/ci/containe= rs/debian-12-cross-ppc64le.Dockerfile index 17beefaea6..6c6e747120 100644 --- a/ci/containers/debian-12-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-12-cross-ppc64le.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:ppc64el \ libudev-dev:ppc64el \ libxml2-dev:ppc64el \ - libyajl-dev:ppc64el \ systemtap-sdt-dev:ppc64el && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12-cross-s390x.Dockerfile b/ci/containers= /debian-12-cross-s390x.Dockerfile index 88006f9a74..4e124ca26a 100644 --- a/ci/containers/debian-12-cross-s390x.Dockerfile +++ b/ci/containers/debian-12-cross-s390x.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:s390x \ libudev-dev:s390x \ libxml2-dev:s390x \ - libyajl-dev:s390x \ systemtap-sdt-dev:s390x && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-12.Dockerfile b/ci/containers/debian-12.D= ockerfile index 8b34ea98fb..682f8217f4 100644 --- a/ci/containers/debian-12.Dockerfile +++ b/ci/containers/debian-12.Dockerfile @@ -66,7 +66,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/containers/debian-sid-cross-aarch64.Dockerfile b/ci/contain= ers/debian-sid-cross-aarch64.Dockerfile index cbbea29d12..1932a7cfbe 100644 --- a/ci/containers/debian-sid-cross-aarch64.Dockerfile +++ b/ci/containers/debian-sid-cross-aarch64.Dockerfile @@ -100,7 +100,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libudev-dev:arm64 \ libxen-dev:arm64 \ libxml2-dev:arm64 \ - libyajl-dev:arm64 \ systemtap-sdt-dev:arm64 && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-sid-cross-armv6l.Dockerfile b/ci/containe= rs/debian-sid-cross-armv6l.Dockerfile index 94d130baf8..bd7b1a12a3 100644 --- a/ci/containers/debian-sid-cross-armv6l.Dockerfile +++ b/ci/containers/debian-sid-cross-armv6l.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:armel \ libudev-dev:armel \ libxml2-dev:armel \ - libyajl-dev:armel \ systemtap-sdt-dev:armel && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-sid-cross-armv7l.Dockerfile b/ci/containe= rs/debian-sid-cross-armv7l.Dockerfile index b1251ffec3..a0ee83d25b 100644 --- a/ci/containers/debian-sid-cross-armv7l.Dockerfile +++ b/ci/containers/debian-sid-cross-armv7l.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libudev-dev:armhf \ libxen-dev:armhf \ libxml2-dev:armhf \ - libyajl-dev:armhf \ systemtap-sdt-dev:armhf && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-sid-cross-i686.Dockerfile b/ci/containers= /debian-sid-cross-i686.Dockerfile index 30b1c268a2..b2f96a6c03 100644 --- a/ci/containers/debian-sid-cross-i686.Dockerfile +++ b/ci/containers/debian-sid-cross-i686.Dockerfile @@ -98,7 +98,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:i386 \ libudev-dev:i386 \ libxml2-dev:i386 \ - libyajl-dev:i386 \ systemtap-sdt-dev:i386 && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-sid-cross-mips64el.Dockerfile b/ci/contai= ners/debian-sid-cross-mips64el.Dockerfile index 216dbacfa1..bcb24e13ff 100644 --- a/ci/containers/debian-sid-cross-mips64el.Dockerfile +++ b/ci/containers/debian-sid-cross-mips64el.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:mips64el \ libudev-dev:mips64el \ libxml2-dev:mips64el \ - libyajl-dev:mips64el \ systemtap-sdt-dev:mips64el && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-sid-cross-ppc64le.Dockerfile b/ci/contain= ers/debian-sid-cross-ppc64le.Dockerfile index 2e93762cbf..66180dcb1e 100644 --- a/ci/containers/debian-sid-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-sid-cross-ppc64le.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:ppc64el \ libudev-dev:ppc64el \ libxml2-dev:ppc64el \ - libyajl-dev:ppc64el \ systemtap-sdt-dev:ppc64el && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-sid-cross-s390x.Dockerfile b/ci/container= s/debian-sid-cross-s390x.Dockerfile index e106382a21..5f9fbc8ffd 100644 --- a/ci/containers/debian-sid-cross-s390x.Dockerfile +++ b/ci/containers/debian-sid-cross-s390x.Dockerfile @@ -99,7 +99,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libtirpc-dev:s390x \ libudev-dev:s390x \ libxml2-dev:s390x \ - libyajl-dev:s390x \ systemtap-sdt-dev:s390x && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ diff --git a/ci/containers/debian-sid.Dockerfile b/ci/containers/debian-sid= .Dockerfile index 1bf2fa5a00..87aee59bbd 100644 --- a/ci/containers/debian-sid.Dockerfile +++ b/ci/containers/debian-sid.Dockerfile @@ -66,7 +66,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/containers/fedora-39.Dockerfile b/ci/containers/fedora-39.D= ockerfile index 6a528ba71b..2e35ca426d 100644 --- a/ci/containers/fedora-39.Dockerfile +++ b/ci/containers/fedora-39.Dockerfile @@ -94,8 +94,7 @@ exec "$@"\n' > /usr/bin/nosync && \ systemd-rpm-macros \ systemtap-sdt-devel \ wireshark-devel \ - xen-devel \ - yajl-devel && \ + xen-devel && \ nosync dnf autoremove -y && \ nosync dnf clean all -y && \ rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ diff --git a/ci/containers/fedora-40.Dockerfile b/ci/containers/fedora-40.D= ockerfile index 4f22956c3c..b82a975bdb 100644 --- a/ci/containers/fedora-40.Dockerfile +++ b/ci/containers/fedora-40.Dockerfile @@ -94,8 +94,7 @@ exec "$@"\n' > /usr/bin/nosync && \ systemd-rpm-macros \ systemtap-sdt-devel \ wireshark-devel \ - xen-devel \ - yajl-devel && \ + xen-devel && \ nosync dnf autoremove -y && \ nosync dnf clean all -y && \ rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ diff --git a/ci/containers/fedora-rawhide.Dockerfile b/ci/containers/fedora= -rawhide.Dockerfile index 5d1cc5961c..a673f82b4b 100644 --- a/ci/containers/fedora-rawhide.Dockerfile +++ b/ci/containers/fedora-rawhide.Dockerfile @@ -95,8 +95,7 @@ exec "$@"\n' > /usr/bin/nosync && \ systemd-rpm-macros \ systemtap-sdt-devel \ wireshark-devel \ - xen-devel \ - yajl-devel && \ + xen-devel && \ nosync dnf autoremove -y && \ nosync dnf clean all -y && \ rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ diff --git a/ci/containers/opensuse-leap-15.Dockerfile b/ci/containers/open= suse-leap-15.Dockerfile index 614af86f2c..38160bf7dc 100644 --- a/ci/containers/opensuse-leap-15.Dockerfile +++ b/ci/containers/opensuse-leap-15.Dockerfile @@ -60,7 +60,6 @@ RUN zypper update -y && \ libxml2 \ libxml2-devel \ libxslt \ - libyajl-devel \ lvm2 \ make \ meson \ diff --git a/ci/containers/opensuse-tumbleweed.Dockerfile b/ci/containers/o= pensuse-tumbleweed.Dockerfile index bf47571338..82b6aee142 100644 --- a/ci/containers/opensuse-tumbleweed.Dockerfile +++ b/ci/containers/opensuse-tumbleweed.Dockerfile @@ -60,7 +60,6 @@ RUN zypper dist-upgrade -y && \ libxml2 \ libxml2-devel \ libxslt \ - libyajl-devel \ lvm2 \ make \ meson \ diff --git a/ci/containers/ubuntu-2204.Dockerfile b/ci/containers/ubuntu-22= 04.Dockerfile index 5de2ac6801..18555693d1 100644 --- a/ci/containers/ubuntu-2204.Dockerfile +++ b/ci/containers/ubuntu-2204.Dockerfile @@ -67,7 +67,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/containers/ubuntu-2404.Dockerfile b/ci/containers/ubuntu-24= 04.Dockerfile index 86bab63fc9..b2f461b629 100644 --- a/ci/containers/ubuntu-2404.Dockerfile +++ b/ci/containers/ubuntu-2404.Dockerfile @@ -67,7 +67,6 @@ RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ locales \ lvm2 \ make \ diff --git a/ci/lcitool/projects/libvirt.yml b/ci/lcitool/projects/libvirt.= yml index a02fe9b8bf..b29fe227bb 100644 --- a/ci/lcitool/projects/libvirt.yml +++ b/ci/lcitool/projects/libvirt.yml @@ -81,4 +81,3 @@ packages: - xen - xmllint - xsltproc - - yajl --=20 2.45.2