From nobody Fri May 10 00:49:45 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1708335827902811.3433458308202; Mon, 19 Feb 2024 01:43:47 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id A1F0E1CDB; Mon, 19 Feb 2024 04:43:46 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id BFFCE1CA8; Mon, 19 Feb 2024 04:42:35 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 298241BF8; Mon, 19 Feb 2024 04:42:33 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8C9241999 for ; Mon, 19 Feb 2024 04:42:32 -0500 (EST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-U1KlGs6YOsq16lOdg3XadQ-1; Mon, 19 Feb 2024 04:42:29 -0500 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a3d114fe9b6so102203166b.3 for ; Mon, 19 Feb 2024 01:42:29 -0800 (PST) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id jv14-20020a05600c570e00b0040fe3147babsm10946932wmb.0.2024.02.19.01.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 01:35:14 -0800 (PST) Received: from wheatley.pinto-pinecone.ts.net (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 874FC194D499E for ; Mon, 19 Feb 2024 10:35:14 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: U1KlGs6YOsq16lOdg3XadQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708335748; x=1708940548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1jkGRON5QBDj7HJ7COgMVHgDE1LseEEndW2m62jBGxk=; b=sMP7Y9FOsJu8f9PSZQ+LkChhVR1WaBN+2oh0i3+VWmSK+/3xYcUFBHDYm4Z5RSMJCg 60NKKV8bq/aEE/nnnA4xwftN8A71TrK1ThknpbLEOQCB4UuHXb/4+DBxUGy7yAlp5YlU R6bgvr/zPmLhEBZPpuhnQaaF3YqW3wx83kc+HKSXwuaKXkInJxM9GHxBTbCoozJKePri NVGzd7/lFNKTcS5pBCQ7adp454CFVrzFmd6G6vbNFf+14PthR5xvtMgXLsMPO1MREDzJ 8I798eTY3KkzK74FJSoTpYn57wTAH5pXV6eJbY46cwGCGjav9rYONJvBU+HE8hgpDmwn HwWA== X-Gm-Message-State: AOJu0YyrjGurZ/6wwgGZ+6tZf+UnhTBJiCQoCKXg2+UICteVSHEYJsHF QISNaXkFjV1P1l7lVQhOERikF13Y3SAmnJ9QEhIH/e49+z8HwhokheVZ+Fa5+RoB2mGJHiXVqCm 787g6J/K7LUT44LLv/cZo7PUvC620S3CqAgezX/F/CBfiXZIk0Q6/CEh0ZUvIUXURAj5CQd1Ldo HftWMfys6ImInH3phfEBK0Kdvodiydx1ouGNaAlyg= X-Received: by 2002:a05:600c:45d3:b0:410:2d72:63b3 with SMTP id s19-20020a05600c45d300b004102d7263b3mr8262164wmo.23.1708335315707; Mon, 19 Feb 2024 01:35:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGky+Ymvjzg3KSN07axO9Wet52gQafFNrJ0zBGo3HHi/jooL40oMmGjqmBXzXva5N5z8teB5A== X-Received: by 2002:a05:600c:45d3:b0:410:2d72:63b3 with SMTP id s19-20020a05600c45d300b004102d7263b3mr8262145wmo.23.1708335315303; Mon, 19 Feb 2024 01:35:15 -0800 (PST) From: Martin Kletzander To: devel@lists.libvirt.org Subject: [PATCH 1/2] build: Split optional programs into test and rest Date: Mon, 19 Feb 2024 10:35:13 +0100 Message-ID: <71c71cefe1cabcae4d21d595509168d44d2625ae.1708335297.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.43.1 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: QL2NTZ2CGZ5PETY7CUZSRFKO4G4L2JGL X-Message-ID-Hash: QL2NTZ2CGZ5PETY7CUZSRFKO4G4L2JGL X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1708335829159100001 To be used in the following commit. Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik --- meson.build | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/meson.build b/meson.build index dbd9cad6df5a..2f3d73b93085 100644 --- a/meson.build +++ b/meson.build @@ -795,12 +795,17 @@ endforeach =20 # optional programs =20 -optional_programs =3D [ +optional_test_programs =3D [ 'augparse', 'black', + 'flake8', + 'pdwtags', + 'pytest', +] + +optional_programs =3D [ 'dmidecode', 'ebtables', - 'flake8', 'ip', 'ip6tables', 'iptables', @@ -809,11 +814,9 @@ optional_programs =3D [ 'mm-ctl', 'modprobe', 'ovs-vsctl', - 'pdwtags', - 'pytest', 'rmmod', 'tc', -] +] + optional_test_programs =20 foreach name : optional_programs prog =3D find_program(name, required: false, dirs: libvirt_sbin_path) --=20 2.43.1 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Fri May 10 00:49:45 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1708335987586665.7495037521302; Mon, 19 Feb 2024 01:46:27 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8C1CC1CE3; Mon, 19 Feb 2024 04:46:26 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 54FFC1DC1; Mon, 19 Feb 2024 04:44:05 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id DA4531BF8; Mon, 19 Feb 2024 04:43:53 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3C1931CB9 for ; Mon, 19 Feb 2024 04:43:31 -0500 (EST) Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-YDuWsq8ON0SdoWhIzlmgpw-1; Mon, 19 Feb 2024 04:43:28 -0500 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-512a00a2651so2015441e87.1 for ; Mon, 19 Feb 2024 01:43:28 -0800 (PST) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id bv9-20020a0560001f0900b0033b1277e95dsm10069896wrb.77.2024.02.19.01.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 01:35:15 -0800 (PST) Received: from wheatley.pinto-pinecone.ts.net (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 92B8E194D499F for ; Mon, 19 Feb 2024 10:35:14 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: YDuWsq8ON0SdoWhIzlmgpw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708335807; x=1708940607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+yBrFiwEqc0n6k85faKNHHrCg6TyqRg8uT7w+258VAU=; b=KCkopMXDVWWKqftilgyX6/I+DLZ6d4Zh97UhHEFEJx7H0cOzCCBp6oxOAA+88nJ2o8 uQcgUFo/i5a94dHN/0rBVR4fFYmryUxBK8E1A0lTjJ55OsSEtZ4YmdpaTWuehBwaiCGN wAcmpnpldFzRIGHHUqIORrGSsW69NnxzU/BF+H6CGiiRK/j/7z5vIJZphP/hB5Z8Qpt0 yqocfxTLxbsCcSCMUc7tMSef+H/D9juA+JGoKOxW/tXUXL4p+q+5ygGQ3uVW3jzQCoZM 4Kav08+VGh/pbGvHDvDwlx6b8ux4Fmbp3NxjHDeYKGPXVFxLybTA43w3ZE4QJrIpZCFr fNHQ== X-Gm-Message-State: AOJu0YweRNVr6+8d26GwGhhvudNXRWcN+kkvNMjuIZ+As+vmjXG9VW+z Lb3BiMOEj2BadmUesVYl8pmG0lLyGOQWeUZeCEJf7VbREkOTvIXJodkHaQ5CXO2Wozuj80iOkjN TuJkemhG50cw9FDA6D4mMLzA6PpTv8SMDd9WXLOnlmcdZSljITAUB7NSuzq+pTvx4YD0FY8vz6H KxJFbeGyNdhV+97pwaDlLJ6aNdDqQaMgjCcn4YCXI= X-Received: by 2002:a5d:5f47:0:b0:33d:5d4f:a45a with SMTP id cm7-20020a5d5f47000000b0033d5d4fa45amr794287wrb.22.1708335315795; Mon, 19 Feb 2024 01:35:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4becCgTyYSuD+d4ksmVs10rmgxKu5W0lSx36GLXfK+gcq3rWX9Xf7tBFHdfTHIdoCaYswpA== X-Received: by 2002:a5d:5f47:0:b0:33d:5d4f:a45a with SMTP id cm7-20020a5d5f47000000b0033d5d4fa45amr794276wrb.22.1708335315519; Mon, 19 Feb 2024 01:35:15 -0800 (PST) From: Martin Kletzander To: devel@lists.libvirt.org Subject: [PATCH 2/2] build: Let users know not all tests might run Date: Mon, 19 Feb 2024 10:35:14 +0100 Message-ID: <3899af31d41ed14a083ba278d092693f8eeeefd9.1708335297.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.43.1 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 2LAFRK424YJAMCCMVEGBL45CAX2A4RZQ X-Message-ID-Hash: 2LAFRK424YJAMCCMVEGBL45CAX2A4RZQ X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1708335989633100001 We warned users before the meson times, so do like an S Club 7 and bring it all back. Add the information into the 'Miscellaneous' section of the summary, because even though using `warning()` looks better, it scrolls on by once the summary is printed. Signed-off-by: Martin Kletzander Reviewed-by: Martin Kletzander Reviewed-by: Michal Privoznik --- meson.build | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/meson.build b/meson.build index 2f3d73b93085..6482493d7136 100644 --- a/meson.build +++ b/meson.build @@ -818,6 +818,7 @@ optional_programs =3D [ 'tc', ] + optional_test_programs =20 +missing_optional_programs =3D [] foreach name : optional_programs prog =3D find_program(name, required: false, dirs: libvirt_sbin_path) varname =3D name.underscorify() @@ -825,6 +826,9 @@ foreach name : optional_programs prog_path =3D prog.full_path() else prog_path =3D name + if name in optional_test_programs + missing_optional_programs +=3D [ name ] + endif endif =20 conf.set_quoted(varname.to_upper(), prog_path) @@ -2330,6 +2334,10 @@ misc_summary =3D { 'sysctl config': conf.has('WITH_SYSCTL'), 'userfaultfd sysctl': conf.has('WITH_USERFAULTFD_SYSCTL'), } +if missing_optional_programs.length() > 0 + misc_summary +=3D {'Some programs are missing, not all tests will be exe= cuted': + missing_optional_programs} +endif summary(misc_summary, section: 'Miscellaneous', bool_yn: true, list_sep: '= ') =20 devtools_summary =3D { --=20 2.43.1 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org