[libvirt PATCH 1/6] qemu: Document qemuMigrationParamsFlagMapItem fields

Jiri Denemark posted 6 patches 9 months, 1 week ago
[libvirt PATCH 1/6] qemu: Document qemuMigrationParamsFlagMapItem fields
Posted by Jiri Denemark 9 months, 1 week ago
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/qemu/qemu_migration_params.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 79fe6e97c8..9de6c08021 100644
--- a/src/qemu/qemu_migration_params.c
+++ b/src/qemu/qemu_migration_params.c
@@ -131,10 +131,20 @@ struct _qemuMigrationParamsAlwaysOnItem {
 
 typedef struct _qemuMigrationParamsFlagMapItem qemuMigrationParamsFlagMapItem;
 struct _qemuMigrationParamsFlagMapItem {
+    /* Describes what to do with the capability if @flag is found.
+     * When se to QEMU_MIGRATION_FLAG_REQUIRED, the capability will be
+     * enabled iff the specified migration flag is enabled. On the other hand
+     * QEMU_MIGRATION_FLAG_FORBIDDEN will enable the capability as long as
+     * the specified migration flag is not enabled. */
     qemuMigrationFlagMatch match;
+    /* Migration flag to check. */
     virDomainMigrateFlags flag;
+    /* Migration capability to be enabled or disabled based on the flag. */
     qemuMigrationCapability cap;
-    int party; /* bit-wise OR of qemuMigrationParty */
+    /* Bit-wise OR of qemuMigrationParty. Determines whether the capability has
+     * to be enabled on the source, on the destination, or on both sides of
+     * migration. */
+    int party;
 };
 
 typedef struct _qemuMigrationParamsTPMapItem qemuMigrationParamsTPMapItem;
-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [libvirt PATCH 1/6] qemu: Document qemuMigrationParamsFlagMapItem fields
Posted by Peter Krempa 9 months, 1 week ago
On Mon, Jan 08, 2024 at 18:06:37 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/qemu/qemu_migration_params.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org