From nobody Tue May 21 06:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695843269; cv=none; d=zohomail.com; s=zohoarc; b=jcYxTF27oUFf8uAex+lE+hca8lEQki+sF5i+qr1/OKhObwhdbnFoOI8P0xfbefY57PPXM0aCTwdr/8Q43o4dlHR1T6I7vNBDRVdcvclsbCZY4JWfwbkRot8KZovebaeqTODf7zLzs/oQU11OXk+5gm2eSGnvxLJD2bHokzEm1MY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695843269; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HHCE9MvWYaAdHpoRUNDJxdFJY1DNR3BLtpWr9/DjSj0=; b=EhOcBXr7l06huQEqI/WC9xpJ1RJ/28+R5AR8fNAkYgH5OtGkmVYWYtw6p+liRxHJDEX3Wsh0W7WwNOQT2Oz0YNqnthIGvAy+w3cRUb/0JmbzSzC1/xrdQMJTgaGXBv68oHG3i+/8398QsEGdLZT5GtxwZntAHcoQIPv/wUSVdSo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1695843269395369.2242239684773; Wed, 27 Sep 2023 12:34:29 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-YqKTDILKNYeYzqWDo2wXWw-1; Wed, 27 Sep 2023 15:34:24 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9CA9101A59B; Wed, 27 Sep 2023 19:34:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3A7714027B9; Wed, 27 Sep 2023 19:34:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 94E8519466E9; Wed, 27 Sep 2023 19:34:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0FBE01946587 for ; Wed, 27 Sep 2023 18:53:56 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EDE9D40C6E76; Wed, 27 Sep 2023 18:53:50 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.224.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75F2540C6EA8; Wed, 27 Sep 2023 18:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695843268; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HHCE9MvWYaAdHpoRUNDJxdFJY1DNR3BLtpWr9/DjSj0=; b=Qqp3Q5Z3B3bFZJ+BD63fxFkYamAxQVkuszn91x14k8CI9MLnQrQkIBoMPHalay2ESOnEMz Th8BGsKpAmBXCNQEmLKGo8jKTXB00yj7ze4y81iGDsdaB6ucKswWArbtas6mJ7ZULEhol5 0ms7rEcODdGRixCaaQAEjvD+dFunnm4= X-MC-Unique: YqKTDILKNYeYzqWDo2wXWw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 1/7] docs: ci-runners: Add a note on a new runner registration process Date: Wed, 27 Sep 2023 20:53:42 +0200 Message-ID: <4796fba20149973d91132237e7ba2687a5381716.1695840821.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695843270399100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The documented process should be updated to reflect the new process once GitLab transitions to it completely and drops the old process involving registration tokens as hinted by the note. Signed-off-by: Erik Skultety Reviewed-by: Pavel Hrdina --- docs/ci-runners.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/ci-runners.rst b/docs/ci-runners.rst index fd5fdd121a..4a93f0e872 100644 --- a/docs/ci-runners.rst +++ b/docs/ci-runners.rst @@ -54,6 +54,16 @@ configurations on the GitLab UI. Navigate to: * *Runners activated for this project*, then * Click on the *Edit* icon (next to the *Lock* Icon) =20 +*Note: GitLab has changed the runner registration process deprecating the = use of +registration tokens in future versions, so while the above process is still +applicable (though the settings are now a bit more hidden) at the time of = writing +this note (09/2023), GitLab v18.0+ is planned to completely switch to a new +process (see the links below), deleting the use of registration tokens.* + + * https://gitlab.com/gitlab-org/gitlab/-/issues/380872 + * https://docs.gitlab.com/ee/ci/runners/new_creation_workflow.html + * https://docs.gitlab.com/ee/ci/runners/runners_scope.html#create-a-share= d-runner-with-a-runner-authentication-token + Don't forget to add a tag to your runner as these are used to route specif= ic jobs to specific runners, e.g. if a job in ``ci/integration.yml`` looked l= ike this :: --=20 2.41.0 From nobody Tue May 21 06:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695844927; cv=none; d=zohomail.com; s=zohoarc; b=UOcmzP5qX073NoXc93vXMbqH6t5Wi4D4ZXmCexvs6dV2nQ42+E1kycpKQY8tmC1xk0NG1frH3KxrZxcC2yvjr9kQmjUl0hAMQJFU2w7iM2BfYFD9j/qK4f0bYfXDmuU68/Tj9U7IWuSkYBClyIjXvb4Lhbl4y5fw0rgeQLo4Utg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695844927; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GjUIyB5Q+j41Vvm49ShuYDKBbu3qXYXI+gBFkEb4mns=; b=lKfpz2vIQCGLh0ZDVMjxQr1P7hEc6JR+w7W5zuyUIttj+/GDoUNKVkNG3Vu+Gu9IN/FfkruVfDk5LvSZu/Q0pZfT5rPJpexUMJqTSBn4+HNS2MuSX5J6fnDxHlrlpsSaOBUrsoLvNN71eXypU5xUPoWQCyqYkAubrLYOP7JatEw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 169584492790650.473844819132296; Wed, 27 Sep 2023 13:02:07 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-290-qEe0ePLaMEihmsWRw8JnTQ-1; Wed, 27 Sep 2023 16:01:59 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 295E31C008A3; Wed, 27 Sep 2023 20:01:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4078940C2064; Wed, 27 Sep 2023 20:01:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BCAFD1946594; Wed, 27 Sep 2023 20:01:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B87F41946587 for ; Wed, 27 Sep 2023 18:53:51 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id AAC7740C6E78; Wed, 27 Sep 2023 18:53:51 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.224.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 32FB640C6EA8; Wed, 27 Sep 2023 18:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695844926; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GjUIyB5Q+j41Vvm49ShuYDKBbu3qXYXI+gBFkEb4mns=; b=QpeQjPFbPgqBAzZaQSWd2M+RrPJ4mcmxrlSvH1y/JQDPp641qtSuTmi7WEsXNFdt9zfUZz jVMXX+88XGLuGzoDWYLKp41ts48MdfaaOzt6O5jHcsMiZogtnRb47xWmLXgp7RJGKMRQ01 YOd7at5AnPSwTz9WZeJRgwqzWMlImfg= X-MC-Unique: qEe0ePLaMEihmsWRw8JnTQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 2/7] docs: ci: Update the description on the integration CI GitLab variables Date: Wed, 27 Sep 2023 20:53:43 +0200 Message-ID: <17628d74eb4bc0c11a40b5588f80ada9d39808b4.1695840821.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695844929005100001 Content-Type: text/plain; charset="utf-8"; x-default="true" This patch mainly fixes an unfinished sentence that was supposed to describe the LIBVIRT_CI_INTEGRATION_RUNNER_TAG variable, but took the opportunity to update the description of the other variable too. Signed-off-by: Erik Skultety Reviewed-by: Pavel Hrdina --- docs/ci.rst | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/ci.rst b/docs/ci.rst index ee85018c49..f3911d84ca 100644 --- a/docs/ci.rst +++ b/docs/ci.rst @@ -31,8 +31,12 @@ see below. GitLab CI variables ------------------- =20 -* ``LIBVIRT_CI_INTEGRATION`` - enables integration test runs manually or i= n forks -* ``LIBVIRT_CI_INTEGRATION_RUNNER_TAG`` - overrides the upstream runner ta= g on the +* ``LIBVIRT_CI_INTEGRATION`` - enables integration test suite execution as= part + of the pipeline (works in forks too if there's a registered shared run= ner) +* ``LIBVIRT_CI_INTEGRATION_RUNNER_TAG`` - overrides the gitlab-runner tag = for + the pipeline; this is needed in forks because the default tag only mat= ches + upstream shared runners which may be (and will be) different from the = tags + defined on shared runners in forks =20 Retrieving test logs -------------------- --=20 2.41.0 From nobody Tue May 21 06:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695845548; cv=none; d=zohomail.com; s=zohoarc; b=FNo10pHRuE4EoRZ8xISN887SePP73Vq8xFJG5oace4RQVrx6ubh1pIocFlMcryR9mVNgPuWb8rWGl0w4nKpYVM+qxsq3fTPI3ZtEKBnFBdzWM0/oaic6WLbyDejjM8w7f61jeL1dLVKxIZ+XosXCZ2wbAjOLlOoGTi0TqGBGTIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695845548; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iBee4aCfZLuQI7qDZ6RDcaYbaSks7rpf1Smqe9SdOkE=; b=BHO3+pUKjbeNmEb4aQn6g2vCyu1UdGL5iQ/LVQkB7A2LSsdKhHzakS5mgReAg5fWEEJqyOb5bNhZFr1BK6EQThU2+Jsav2/cp6lvVTqUo8aU1BHZ6qtAVsEPJNKiwp+eYQy7VjOTaO/VCUQHcGF3Gfn/Myq3KIJX5WwibVHA6rI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16958455487096.0259953053507616; Wed, 27 Sep 2023 13:12:28 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-402-No1Rq9A2OwWJTayRAfZnkQ-1; Wed, 27 Sep 2023 16:12:22 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CA01C3C0F23C; Wed, 27 Sep 2023 20:12:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B569040C6E77; Wed, 27 Sep 2023 20:12:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 03CF819466E7; Wed, 27 Sep 2023 20:12:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 769051946587 for ; Wed, 27 Sep 2023 18:53:52 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 68ECE40C6E78; Wed, 27 Sep 2023 18:53:52 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.224.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3F7140C6EA8; Wed, 27 Sep 2023 18:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695845547; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=iBee4aCfZLuQI7qDZ6RDcaYbaSks7rpf1Smqe9SdOkE=; b=Izt+1ElTr9TZDg87JFBa7Ls8MYltk4jWOC5/g8yFZJiHg4W7XGUf7djVf7NQrBvb1kbAbo cSd78CgqgfsafNhm6tQZT1r1sSufFx5vpTRKMKhEDV5LLmCRomlae9Y96WksaF6WQEZdNK uX+uby8O9rQH5ncrvkLAPO0JxMtHxJw= X-MC-Unique: No1Rq9A2OwWJTayRAfZnkQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 3/7] docs: testtck: Tweak the Avocado command to run TCK test suite Date: Wed, 27 Sep 2023 20:53:44 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695845548924100001 Content-Type: text/plain; charset="utf-8"; x-default="true" While we may have needed to run TCK through Avocado by explicitly using the '--tap' option (still possible), we can get a nice output from Avocado by default leaving the option out which is exactly what we do inside GitLab CI environment. Signed-off-by: Erik Skultety Reviewed-by: Pavel Hrdina --- docs/testtck.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/testtck.rst b/docs/testtck.rst index 100a278acd..d7f5483b5f 100644 --- a/docs/testtck.rst +++ b/docs/testtck.rst @@ -78,7 +78,7 @@ as root the test suite as root (when running with Avocado= ): =20 :: =20 - # avocado --config avocado.config run --tap - ./scripts/ + # avocado --config avocado.config run =20 from the TCK's git root. =20 --=20 2.41.0 From nobody Tue May 21 06:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695843473; cv=none; d=zohomail.com; s=zohoarc; b=EQdXnSqVKym/+kv1HlXYa6DrfUKZLLRJiYpRotQJ5CLI3KQ+33+pqNbwGpRRc4ldrqE3QflNm/YBGPCuPMvvOacB09O3uNtKOXw6N/KGzro+WvM4TN1EOOt9PYR3VtkLTcv9r3VSDc8NdChcsvZ4qsBwxB1Q9kh4vt2h9hKyhJI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695843473; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rl4b7yQf5iKtp/835B4SSMTFfkP94cEleX7KretOFwM=; b=NBCU/xjmsLosfv1ho5xLMR1OzSxaMqV4hD3+jSGXySnd4sTm9miCJkrke5hupFyxlb0uFFNlhtPugBJQfeLp0gXuja3qLFAN/F0IuSkQDCYn59qqeZYpqvnCFA2oavNp507Q6SuXeKMtpsDRkFqycX2TGW5gFrJfuwmNmLxw3mU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 169584347364493.81587249464246; Wed, 27 Sep 2023 12:37:53 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-zf7upZn0Py-S5xqE1Sdjlw-1; Wed, 27 Sep 2023 15:37:49 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47425858F1B; Wed, 27 Sep 2023 19:37:47 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAAB8176C3; Wed, 27 Sep 2023 19:37:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9794C1946588; Wed, 27 Sep 2023 19:37:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 28C311946587 for ; Wed, 27 Sep 2023 18:53:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 24EFB40C6E79; Wed, 27 Sep 2023 18:53:53 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.224.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id A13C240C6EA8; Wed, 27 Sep 2023 18:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695843472; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rl4b7yQf5iKtp/835B4SSMTFfkP94cEleX7KretOFwM=; b=hlJkArI7WNqFCca619oViV18jnEZ7Es5fscHauzT4yaG1wOlBaTANcKk4tFQ0ATKOZo6fr cHPwO17K/jPA5IY313f0HDitNGJkShidBfUX1GGtal3pQJE0osR9cXZpRHkiEOvLtCksM/ sXPqm/35VBwp8sWTOmKjaP67gcoR67k= X-MC-Unique: zf7upZn0Py-S5xqE1Sdjlw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 4/7] docs: testtck: Improve the documentation on how to get a VM from lcitool Date: Wed, 27 Sep 2023 20:53:45 +0200 Message-ID: <2df19a6bdb79b039a23abedab6f125c49b8ed46f.1695840821.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695843475681100001 Content-Type: text/plain; charset="utf-8"; x-default="true" While wording is still correct to this day, we have already added more features to lcitool and documented it properly in its repo. Make sure that we refer the users to lcitool's doc material for further details on how VMs can be installed locally. Use the opportunity to bump the OS distro target from Fedora 36 -> 38. Signed-off-by: Erik Skultety Reviewed-by: Pavel Hrdina --- docs/testtck.rst | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/docs/testtck.rst b/docs/testtck.rst index d7f5483b5f..89760e3f63 100644 --- a/docs/testtck.rst +++ b/docs/testtck.rst @@ -48,20 +48,31 @@ available through the system package manager and some w= ill likely need to be installed from CPAN (Perl's equivalent of Python's PyPI). Here's where `libvirt-ci's `__ lcitool can h= elp with preparing a test environment in a fresh VM, taking care of the -dependencies along the way: +dependencies along the way. A simple example of getting a machine from lci= tool +would be: =20 :: =20 - $ lcitool install --target fedora-36 tck-fedora36 --wait + $ lcitool install --target fedora-38 tck-fedora38 --wait =20 -would get you a new Fedora 36 VM named ``tck-fedora36``. Then +would get you a new Fedora 38 VM named ``tck-fedora38``. There are differe= nt +ways of getting a fresh local VM with ``lcitool``, so please refer to +`Installing local VMs `__ +for further details, especially to utilize vendor cloud images for this +purpose. + +Once you have a fresh virtual machine, you need to pre-install it with all +necessary build dependencies to be able to build libvirt, libvirt Perl bin= dings +and run the TCK test suite inside it. You'd do that by running =20 :: =20 - $ lcitool update tck-fedora36 libvirt,libvirt-perl,libvirt-tck+runtime + $ lcitool update tck-fedora38 libvirt,libvirt-perl,libvirt-tck+runtime + +Again, for further details on how to update ``lcitool`` virtual machines, +please refer to +`Updating VMs with a given project dependencies `__ =20 -will install all the necessary dependencies to build libvirt, the correspo= nding -Perl bindings and all TCK runtime dependencies to be able to execute the t= ests. We also recommend executing TCK using the Avocado framework as the test ha= rness engine which means that you'll have to install Avocado in the test environ= ment as well. You can get it either from --=20 2.41.0 From nobody Tue May 21 06:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695843263; cv=none; d=zohomail.com; s=zohoarc; b=WpDr+fwtAVeyRwcpB1udwNoFoj91i5rfJt/2UzUwBiM6jJokBPgyvp5BfwJzVstEHXSarA1Z9dn5q7dmKb7FtDoHcqQ9twWcVzbBdHBt8Aj2hH7J5dfz6g/ZP6D2xX5YPYTc4psEcQK1DOduXR4xC5TaLbQNZOya1eNWkuxCJuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695843263; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MBZCIj0eDNuH9qjJO7b4NtId7efXTm6rWzp1cO2w9oc=; b=iNQKVlsw0badSvLPTP/nJNGc8WC+wlmsR5cUBoh76U2rG6/qypvEEpbXHrJyWMhPctPWK9J5xZkL1ziVZ3R+Uy1c0vyZ3a7f66Se00rlFK/P6id2vFDJrdHyr4UzsSpbKJyhzlapLMm8iDdt4zYh0V4o6xrLkeRWtAEGHQMNQkY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1695843263463517.2255705913321; Wed, 27 Sep 2023 12:34:23 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-679-WKc_RvD1Mw6S-OVY570aWw-1; Wed, 27 Sep 2023 15:34:19 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A99E38125B7; Wed, 27 Sep 2023 19:34:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44D001004145; Wed, 27 Sep 2023 19:34:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1465D1946594; Wed, 27 Sep 2023 19:34:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DB5C21946587 for ; Wed, 27 Sep 2023 18:53:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id D729140C6E77; Wed, 27 Sep 2023 18:53:53 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.224.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5EA2A40C6EA8; Wed, 27 Sep 2023 18:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695843262; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MBZCIj0eDNuH9qjJO7b4NtId7efXTm6rWzp1cO2w9oc=; b=UuxEzrjS0XJSR1ftdncY6qI6hTZYibzlU0Hh8EMsPOKTnEph7Xxi39zPF8BBGKbvHoGzuc PhLYjbjSeQ9sRp+Z3kY1zWXKxPsphTuOW6F53dSNB5dEQjulXmXzAv8UHbPUzjKiN3kcZ1 Pr8rJw7x1SLEd7vk29YenFmxwC3BHGI= X-MC-Unique: WKc_RvD1Mw6S-OVY570aWw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 5/7] docs: testing: Adjust the docs on how to run container workloads locally Date: Wed, 27 Sep 2023 20:53:46 +0200 Message-ID: <64644d07295fc7c2eb32fc89679ca23e6558b329.1695840821.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695843263884100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The fact that we need ci/helper script to run the workloads remains true, but the invocation has changed as of commit eb41e456 . We also extracted GitLab job specs into a standalone ci/jobs.sh script which allows execution of any container job we run in upstream CI locally, unlike the original functionality which only allowed builds, tests and shell (although important to say it could be adjusted with the right meson/ninja args). lcitool also became mandatory as it enables the container execution which replaced a Makefile we used to have for this purpose. Signed-off-by: Erik Skultety Reviewed-by: Pavel Hrdina --- docs/testing.rst | 37 +++++++++++++++++++++++++++++-------- 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/docs/testing.rst b/docs/testing.rst index a597c3ed07..9ca47072ba 100644 --- a/docs/testing.rst +++ b/docs/testing.rst @@ -48,11 +48,17 @@ Running container builds with GitLab CI As long as your GitLab account has CI minutes available, pipelines will run automatically on every branch push to your fork. =20 -Running container builds locally -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Running container jobs locally +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ =20 -In order to run container builds locally, we have a ``helper`` script insi= de -the ``ci`` directory that can pull, build, and test (if applicable) change= s on +GitLab CI configuration file is the only source of truth when it comes to +various job specifications we execute as part of the upstream pipeline. +Luckily, all "script" (i.e. Bash scripts) were extracted to standalone She= ll +functions in ``ci/jobs.sh``. This allows users to run any of the container +GitLab job specifications locally by just referencing the job name. + +When it comes to actually running the GitLab jobs locally, we have a +``ci/helper`` script can pull, build, and test (if applicable) changes on your current local branch. It supports both the Docker and Podman runtimes with an automatic selection of whichever runtime is configured on your sys= tem. In case neither has been enabled/configured, please go through the followi= ng @@ -130,12 +136,27 @@ the default libvirt registry: fedora-rawhide-cross-mingw64 ... =20 -Now let's say one would want to build their local libvirt changes on Alpine -Edge using their own GitLab's registry container. They'd then proceed with +Now, let's say one would want to run the ``website`` job from GitLab on De= bian +11. This is how a GitLab job specification can be referenced on ``ci/helpe= r``'s +command line: =20 :: =20 - $ ci/helper build --image-prefix registry.gitlab.com//libvirt/ci= - alpine-edge + $ ci/helper run --job website debian-10 + +What if you want to run an rpmbuild of libvirt on an RPM distro? + +:: + + $ ci/helper run --job rpmbuild fedora-38 + +Want to use your own, say alpine-edge, container image from your GitLab +container registry? +Proceed with the following: + +:: + + $ ci/helper run --job build --image-prefix registry.gitlab.com//= libvirt/ci- alpine-edge =20 Finally, it would be nice if one could get an interactive shell inside the test environment to debug potential build issues. This can be achieved wit= h the @@ -143,7 +164,7 @@ following: =20 :: =20 - $ ci/helper shell alpine-edge + $ ci/helper run --job shell alpine-edge =20 =20 Integration tests --=20 2.41.0 From nobody Tue May 21 06:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695843259; cv=none; d=zohomail.com; s=zohoarc; b=PKk5vC8lU2prHVTzdmjkk0Bec9I5h0jwaDNRsKcWctO8gf/lXgwORZClz1KRRpQSU4L5ZMWne4Cy5c/OKPfzoSXQzTcZ1mhxxQ2l5nqQfxNiEAlHZMQwmsT4fdtrqWR+4+mhgxlbvV3pSh859UTndlnXbSaF0JVH4HvnBvxhKjU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695843259; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bVZtQ3fgfydD5BixCT/PI91r4nRxygtLNnvIRJN5D5A=; b=Vbvjnlq4EyUG9pwY0A2xV6X6JwqgWMCX7EGge74CcTYcfXhxqK6HgU3CVnjrcZBmTa/T98cES5BHTiki0Szi4sIfnxYC2L9wZnKtuuFCy2u83UIF6/F9GC6R6JKmxj3a8G3cnKrWPAQK4AmmUZ0hY5fzKxPt/KPo1/c+WGu1q/A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 169584325916983.11882862243033; Wed, 27 Sep 2023 12:34:19 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-655-kMJf50RVOfKrKzBQdfF18Q-1; Wed, 27 Sep 2023 15:34:15 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73C1E280D58E; Wed, 27 Sep 2023 19:34:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B50B840C2064; Wed, 27 Sep 2023 19:34:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1C5D11946589; Wed, 27 Sep 2023 19:34:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 97FBF1946587 for ; Wed, 27 Sep 2023 18:53:54 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 93E9240C6E78; Wed, 27 Sep 2023 18:53:54 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.224.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BDA540C6EA8; Wed, 27 Sep 2023 18:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695843258; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bVZtQ3fgfydD5BixCT/PI91r4nRxygtLNnvIRJN5D5A=; b=IQwVWiir0RzXWr4JuBnGnQVoQ5Mwl/wbSTmendYA/JJ71OIxNoTKXvfw/8N2CnbrkVhaE4 dun4LAxB9mmBxoNU/SKolFtL5pD9zZ0R0f7RekBFTW/ScVE0zKAe2WfMfCNZPPxWzcOfYr aNyLEBM9sRdN+nqCsaru72O0qOOblME= X-MC-Unique: kMJf50RVOfKrKzBQdfF18Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 6/7] docs: testtck: Add a clear note on libvirt + Perl bindings dependency Date: Wed, 27 Sep 2023 20:53:47 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695843260335100001 Content-Type: text/plain; charset="utf-8"; x-default="true" It's mentioned in an earlier paragraph that Perl bindings in correct version are needed, but there's no note about libvirt even though it should be obvious. So make a clear note on that and while at it, do mention the possibility to get upstream libvirt RPMs from GitLab CI artifacts if users don't feel like building everything on their own. Signed-off-by: Erik Skultety Reviewed-by: Pavel Hrdina --- docs/testtck.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/testtck.rst b/docs/testtck.rst index 89760e3f63..f57af61aa8 100644 --- a/docs/testtck.rst +++ b/docs/testtck.rst @@ -73,6 +73,12 @@ Again, for further details on how to update ``lcitool`` = virtual machines, please refer to `Updating VMs with a given project dependencies `__ =20 +Note that lcitool only installs build dependencies, so as mentioned above = you'll +need both libvirt **and** libvirt Perl bindings installed in order to be a= ble +to run TCK. You can (depending on use case) either build both inside the V= M and +install manually or install the corresponding RPMs from GitLab CI build +artifacts. + We also recommend executing TCK using the Avocado framework as the test ha= rness engine which means that you'll have to install Avocado in the test environ= ment as well. You can get it either from --=20 2.41.0 From nobody Tue May 21 06:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695845533; cv=none; d=zohomail.com; s=zohoarc; b=YTAJZ/+U17lxyW65rRJ8dmNJvccgMv5fBOcBIFRibBYmuo2dxGzVMbsaEmEjiRfjLWUL+mHn2k2a5vP4WIsGdg7QXfncizNT7GaFzRYGj8FJo2grIFBV2L9JzL51K2FYfrV9EhxO0El7gArQB5TFEN1juDatGlOQ3aIlyYkVoDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695845533; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jw0p63usHTa/pH4cpwWi0KisdvEuzbzl3WEpL1NbuiA=; b=QPGvidnN08eU481dcqLl8kxfXgsOGFischQIlMFCaW/42ka6dxodEgUhLtZnDMpvxt9YfXSn1j+09MlDd3WOfHTGOIcHTIFXuqqyxlWZMHBk+e9g9yAqVqTY07Sw2Vw6RTtXXTNo+jJra6MUHuar1MS5Y3IognFw/+8Bg2N0bPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1695845533684800.3545521301891; Wed, 27 Sep 2023 13:12:13 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-281-iRE6d3dGOKyN8pYTEIJ5LA-1; Wed, 27 Sep 2023 16:12:10 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C04D23C0E449; Wed, 27 Sep 2023 20:12:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 844CE176C3; Wed, 27 Sep 2023 20:12:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 519AF1946588; Wed, 27 Sep 2023 20:12:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5620B1946587 for ; Wed, 27 Sep 2023 18:53:55 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 51C2540C6EA8; Wed, 27 Sep 2023 18:53:55 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.224.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE8F640C6E78; Wed, 27 Sep 2023 18:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695845532; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jw0p63usHTa/pH4cpwWi0KisdvEuzbzl3WEpL1NbuiA=; b=jEZ3NEkQkVTwuu6h2L/mPx3EDJQvdQio5RJTOPRSKOdlWuam0WnCpsRrOBf5x/Ndrgroa5 mJPJNfQ64J/5ORVpVbaxOrY6ByvDsqrApSq6Z7Xys1y7Y0FuZXQJhSHUCC9zPEG/DphsWL QaB/aMRVpG0zeGXs+DVTJqFVYsZnIBs= X-MC-Unique: iRE6d3dGOKyN8pYTEIJ5LA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 7/7] docs: testtck: Expand the 'Run TCK' section on making use of ci/jobs.sh Date: Wed, 27 Sep 2023 20:53:48 +0200 Message-ID: <2ab9260aa3999f460745737421061b1ad632728b.1695840821.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695845535222100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Ever since commit 6e9bd600 added a new GitLab job description function handling the integration test suite process to ci/jobs.sh it should be mentioned in the docs. This patch splits the 'Run TCK' section in two, giving user the option to run the integration test suite in their VM environment the same way as we do in GitLab CI or execute everything manually. This patch takes the opportunity to also link to the virtiofs kbase article to give users a different option to get the local libvirt repositories to be used in testing inside a VM. Signed-off-by: Erik Skultety Reviewed-by: Pavel Hrdina --- docs/testtck.rst | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/docs/testtck.rst b/docs/testtck.rst index f57af61aa8..568899dcdd 100644 --- a/docs/testtck.rst +++ b/docs/testtck.rst @@ -90,8 +90,33 @@ in the future we plan on making the TCK internal couplin= g with Avocado tighter. Running TCK ~~~~~~~~~~~ =20 -Once you have all the dependencies installed, you can then proceed with ru= nning -as root the test suite as root (when running with Avocado): +Once you have all the dependencies installed, you can then proceed with ei= ther +of the following procedures to execute the test suite as root. + +Replicating upstream CI test suite execution locally +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +Similarly to how local container builds utilize the standalone ``ci/jobs.s= h`` +script containing functions describing GitLab job definitions it can be +utilized to run integration test suite as well. In this case, one needs to +get a copy of their libvirt repository containing the changes to be tested +inside the VM (either by cloning it manually or sharing the repo e.g. via +`virtiofs `__). Make sure that the +user which is going to execute the following has passwordless "sudo" permi= ssions +(lcitool's default "test" user does). Then it's just a matter of running + +:: + + $ source ci/jobs.sh + $ run_integration + +Manual invocation +^^^^^^^^^^^^^^^^^ + +If you want to have more control over the whole procedure or simply don't = want +to run the exact same steps as libvirt's upstream CI pipeline does in cont= ext +of integration tests then start by cloning the +`TCK `__ repository and run =20 :: =20 --=20 2.41.0