From nobody Sat Feb 7 15:10:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1686321088; cv=none; d=zohomail.com; s=zohoarc; b=m9rgasJ16P/KJUjK/1NE8MK+BTSn8ZCOyAE0DzrOPlm32xKTgHpjmI7mIRHQuYynty6XEygQqg4kHobeqbjF/nc+aLSAhrZp08f6q/NN+AuJ5wSVumZuWYW3Ef0UPCST3T0DH+NjatmooYQALeRp2Pha0PIBmMH/czQ2DwOVSlA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686321088; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jLiKrTcw4YaT56yKqBJmGVtq40MOVKGhh46btw5xVSw=; b=byIVMwT+XfmwuxhYLB7N/Mxb7H+EzFGGKFLso1cNW7HY66H5kTLivri8RlIQgL126aKm2reF407vwaSm7vyGT5wenlCzuZvj6QUN0uDiuy4/FwsEPoS3dnLgtIAAxYZQ9YiSoRyYjpNaKkFcWeBBqfYg1Xld0A1dmhrd0KRJAE0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1686321088429356.3010323353616; Fri, 9 Jun 2023 07:31:28 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-169-GGpi631OP1WaxqNqxXuJ3A-1; Fri, 09 Jun 2023 10:31:24 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E35228EA6F3; Fri, 9 Jun 2023 14:31:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 37026140E957; Fri, 9 Jun 2023 14:31:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 36D8D19451C2; Fri, 9 Jun 2023 14:31:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 34D2A19451CC for ; Fri, 9 Jun 2023 14:31:13 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 23A57140E957; Fri, 9 Jun 2023 14:31:13 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D668140E954 for ; Fri, 9 Jun 2023 14:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686321087; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jLiKrTcw4YaT56yKqBJmGVtq40MOVKGhh46btw5xVSw=; b=Gsw8fy+c4JnTzRR4wCtrwijhfWMMt72FWfyWxtxbe4ypqcXkAYEF1yE7D+2DVgx6H1Yl2o wrR94flq7U+jKtgFIsrSpNOcTSCDEbMrPukx16p6mwgjOetW0Ds2tGA6ZVDJzUnLRsklB0 9fNdhUo1lQ/pnpWAqFNFRPZPkdTsxpA= X-MC-Unique: GGpi631OP1WaxqNqxXuJ3A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/2] tests: qemucapabilitiesdata: Update data for qemu-8.1 dev cycle Date: Fri, 9 Jun 2023 16:31:09 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1686321090217100003 Content-Type: text/plain; charset="utf-8" Update to v8.0.0-1739-g5f9dd6a8ce and build on a newer kernel and with newer libblkio. Notable changes: - 'fdset' feature is supported for the vdpa block backend provided by libblkio - 'xsaves' feature is optional for EPYC-Rome - 'cryptodev-backend-lkcf' and 'PIIX3-xen' devices removed Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 5 +- .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 - tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 5 +- .../caps_8.1.0_x86_64.replies | 82 +++++++++++-------- .../caps_8.1.0_x86_64.xml | 43 ++++++++-- .../cpu-host-model.x86_64-latest.args | 2 +- 6 files changed, 89 insertions(+), 49 deletions(-) diff --git a/tests/domaincapsdata/qemu_8.1.0-q35.x86_64.xml b/tests/domainc= apsdata/qemu_8.1.0-q35.x86_64.xml index f4a9c43340..da900d488c 100644 --- a/tests/domaincapsdata/qemu_8.1.0-q35.x86_64.xml +++ b/tests/domaincapsdata/qemu_8.1.0-q35.x86_64.xml @@ -51,7 +51,6 @@ - @@ -70,6 +69,7 @@ + qemu64 @@ -112,7 +112,7 @@ Haswell-noTSX Haswell-IBRS Haswell - EPYC-Rome + EPYC-Rome EPYC-Milan EPYC-IBPB EPYC @@ -252,7 +252,6 @@ builtin - lkcf diff --git a/tests/domaincapsdata/qemu_8.1.0-tcg.x86_64.xml b/tests/domainc= apsdata/qemu_8.1.0-tcg.x86_64.xml index 15ecb729a4..c36bac3fd2 100644 --- a/tests/domaincapsdata/qemu_8.1.0-tcg.x86_64.xml +++ b/tests/domaincapsdata/qemu_8.1.0-tcg.x86_64.xml @@ -253,7 +253,6 @@ builtin - lkcf diff --git a/tests/domaincapsdata/qemu_8.1.0.x86_64.xml b/tests/domaincapsd= ata/qemu_8.1.0.x86_64.xml index 89f7ff5250..9183b7c937 100644 --- a/tests/domaincapsdata/qemu_8.1.0.x86_64.xml +++ b/tests/domaincapsdata/qemu_8.1.0.x86_64.xml @@ -50,7 +50,6 @@ - @@ -69,6 +68,7 @@ + qemu64 @@ -111,7 +111,7 @@ Haswell-noTSX Haswell-IBRS Haswell - EPYC-Rome + EPYC-Rome EPYC-Milan EPYC-IBPB EPYC @@ -252,7 +252,6 @@ builtin - lkcf diff --git a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies b/tests/q= emucapabilitiesdata/caps_8.1.0_x86_64.replies index cf59957e98..21ce2566d3 100644 --- a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies @@ -21,7 +21,7 @@ "minor": 0, "major": 8 }, - "package": "v8.0.0-1619-g369081c455" + "package": "v8.0.0-1739-g5f9dd6a8ce" }, "id": "libvirt-2" } @@ -10879,6 +10879,7 @@ ], "meta-type": "object", "features": [ + "fdset" ] }, { @@ -23993,16 +23994,16 @@ "parent": "chardev-ringbuf" }, { - "name": "Haswell-v3-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "i82557a", + "parent": "pci-device" }, { "name": "vhost-user-scsi-pci-non-transitional", "parent": "vhost-user-scsi-pci-base" }, { - "name": "i82557a", - "parent": "pci-device" + "name": "vmmouse", + "parent": "isa-device" }, { "name": "chardev-udp", @@ -24021,8 +24022,8 @@ "parent": "virtio-scsi-pci-base" }, { - "name": "vmmouse", - "parent": "isa-device" + "name": "Haswell-v3-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "migration", @@ -24560,10 +24561,6 @@ "name": "Conroe-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "cryptodev-backend-lkcf", - "parent": "cryptodev-backend" - }, { "name": "apic", "parent": "apic-common" @@ -24657,11 +24654,11 @@ "parent": "usb-device" }, { - "name": "IvyBridge-x86_64-cpu", + "name": "SandyBridge-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "SandyBridge-v1-x86_64-cpu", + "name": "IvyBridge-x86_64-cpu", "parent": "x86_64-cpu" }, { @@ -25284,14 +25281,14 @@ "name": "KnightsMill-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "virtio-mmio", - "parent": "sys-bus-device" - }, { "name": "pentium2-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "virtio-mmio", + "parent": "sys-bus-device" + }, { "name": "Broadwell-v1-x86_64-cpu", "parent": "x86_64-cpu" @@ -25652,10 +25649,6 @@ "name": "i440FX-pcihost", "parent": "pci-host-bridge" }, - { - "name": "virtio-iommu-device", - "parent": "virtio-device" - }, { "name": "isa-debugcon", "parent": "isa-device" @@ -25689,8 +25682,8 @@ "parent": "ivshmem-common" }, { - "name": "PIIX3-xen", - "parent": "pci-piix3" + "name": "virtio-iommu-device", + "parent": "virtio-device" }, { "name": "virtio-net-pci", @@ -33543,7 +33536,8 @@ "cldemote", "movdiri", "movdir64b", - "spec-ctrl" + "spec-ctrl", + "xsaves" ], "static": false, "migration-safe": true, @@ -33560,6 +33554,7 @@ "movdir64b", "spec-ctrl", "core-capability", + "xsaves", "split-lock-detect" ], "static": false, @@ -33638,6 +33633,7 @@ "avx512vl", "pku", "spec-ctrl", + "xsaves", "avx512f", "avx512f", "avx512f", @@ -33824,7 +33820,8 @@ "pcid", "erms", "invpcid", - "spec-ctrl" + "spec-ctrl", + "xsaves" ], "static": false, "migration-safe": true, @@ -33956,6 +33953,7 @@ "fzrm", "fsrs", "fsrc", + "xsaves", "xfd", "avx512f", "avx512f", @@ -34009,6 +34007,7 @@ "fzrm", "fsrs", "fsrc", + "xsaves", "xfd", "avx512f", "avx512f", @@ -34340,6 +34339,7 @@ "la57", "fsrm", "spec-ctrl", + "xsaves", "avx512f", "avx512f", "avx512f", @@ -34376,6 +34376,7 @@ "la57", "fsrm", "spec-ctrl", + "xsaves", "avx512f", "avx512f", "avx512f", @@ -34707,6 +34708,7 @@ "name": "EPYC-v4", "typename": "EPYC-v4-x86_64-cpu", "unavailable-features": [ + "xsaves" ], "static": false, "migration-safe": true, @@ -34716,6 +34718,7 @@ "name": "EPYC-v3", "typename": "EPYC-v3-x86_64-cpu", "unavailable-features": [ + "xsaves" ], "static": false, "migration-safe": true, @@ -34753,7 +34756,8 @@ "name": "EPYC-Rome-v3", "typename": "EPYC-Rome-v3-x86_64-cpu", "unavailable-features": [ - "ibrs" + "ibrs", + "xsaves" ], "static": false, "migration-safe": true, @@ -34763,7 +34767,8 @@ "name": "EPYC-Rome-v2", "typename": "EPYC-Rome-v2-x86_64-cpu", "unavailable-features": [ - "ibrs" + "ibrs", + "xsaves" ], "static": false, "migration-safe": true, @@ -34773,6 +34778,7 @@ "name": "EPYC-Rome-v1", "typename": "EPYC-Rome-v1-x86_64-cpu", "unavailable-features": [ + "xsaves" ], "static": false, "migration-safe": true, @@ -34782,6 +34788,7 @@ "name": "EPYC-Rome", "typename": "EPYC-Rome-x86_64-cpu", "unavailable-features": [ + "xsaves" ], "alias-of": "EPYC-Rome-v1", "static": false, @@ -34803,6 +34810,7 @@ "stibp-always-on", "amd-psfd", "no-nested-data-bp", + "xsaves", "pku" ], "static": false, @@ -34819,6 +34827,7 @@ "pku", "fsrm", "ibrs", + "xsaves", "pku" ], "static": false, @@ -34835,6 +34844,7 @@ "pku", "fsrm", "ibrs", + "xsaves", "pku" ], "alias-of": "EPYC-Milan-v1", @@ -34882,6 +34892,7 @@ "amd-psfd", "no-nested-data-bp", "auto-ibrs", + "xsaves", "avx512f", "avx512f", "avx512f", @@ -34921,6 +34932,7 @@ "amd-psfd", "no-nested-data-bp", "auto-ibrs", + "xsaves", "avx512f", "avx512f", "avx512f", @@ -34945,6 +34957,7 @@ "name": "Dhyana-v2", "typename": "Dhyana-v2-x86_64-cpu", "unavailable-features": [ + "xsaves" ], "static": false, "migration-safe": true, @@ -34974,7 +34987,8 @@ "typename": "Denverton-v3-x86_64-cpu", "unavailable-features": [ "erms", - "spec-ctrl" + "spec-ctrl", + "xsaves" ], "static": false, "migration-safe": true, @@ -35038,6 +35052,7 @@ "avx512vnni", "spec-ctrl", "avx512-bf16", + "xsaves", "avx512f", "avx512f", "avx512f", @@ -35142,6 +35157,7 @@ "pku", "avx512vnni", "spec-ctrl", + "xsaves", "avx512f", "avx512f", "avx512f", @@ -37337,7 +37353,7 @@ "vaes": false, "serialize": false, "movdir64b": false, - "xsaves": true, + "xsaves": false, "vmx-shadow-vmcs": false, "lm": true, "vmx-exit-save-preemption-timer": false, @@ -37709,7 +37725,7 @@ "vaes": false, "serialize": false, "movdir64b": false, - "xsaves": true, + "xsaves": false, "vmx-shadow-vmcs": false, "lm": true, "vmx-exit-save-preemption-timer": false, @@ -38050,7 +38066,7 @@ "sgx-tokenkey": false, "cldemote": false, "vmx-ept": false, - "hv-tlbflush-direct": false, + "hv-tlbflush-direct": true, "xfd": false, "hv-reenlightenment": true, "kvm-mmu": false, @@ -38163,7 +38179,7 @@ "popcnt": true, "vaes": false, "serialize": false, - "xsaves": true, + "xsaves": false, "movdir64b": false, "vmx-shadow-vmcs": false, "tcg-cpuid": true, @@ -38264,7 +38280,7 @@ "vmx-entry-load-efer": false, "level-func7": 0, "vmx-mtf": false, - "hv-tlbflush-ext": false, + "hv-tlbflush-ext": true, "pause_filter": true, "model-id": "AMD Ryzen 9 3900X 12-Core Processor ", "sha-ni": true, diff --git a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml b/tests/qemuc= apabilitiesdata/caps_8.1.0_x86_64.xml index 50ed122fa4..224270d8e5 100644 --- a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml @@ -200,7 +200,6 @@ - @@ -208,7 +207,7 @@ 8000050 43100245 - v8.0.0-1619-g369081c455 + v8.0.0-1739-g5f9dd6a8ce x86_64 @@ -471,7 +470,7 @@ - + @@ -625,6 +624,7 @@ + @@ -634,6 +634,7 @@ + @@ -683,6 +684,7 @@ + @@ -811,6 +813,7 @@ + @@ -890,6 +893,7 @@ + @@ -936,6 +940,7 @@ + @@ -1052,6 +1057,7 @@ + @@ -1081,6 +1087,7 @@ + @@ -1300,8 +1307,12 @@ - - + + + + + + @@ -1309,12 +1320,18 @@ + + + + + + + + - - @@ -1327,6 +1344,7 @@ + @@ -1336,6 +1354,7 @@ + @@ -1345,6 +1364,7 @@ + @@ -1375,6 +1395,7 @@ + @@ -1407,18 +1428,22 @@ + - + + + + @@ -1453,6 +1478,7 @@ + @@ -1518,6 +1544,7 @@ + diff --git a/tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args b/tes= ts/qemuxml2argvdata/cpu-host-model.x86_64-latest.args index 92c260c0e6..3afc39af56 100644 --- a/tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args +++ b/tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine q35,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Doff \ -accel kvm \ --cpu EPYC-Rome,x2apic=3Don,tsc-deadline=3Don,hypervisor=3Don,tsc-adjust=3D= on,stibp=3Don,arch-capabilities=3Don,ssbd=3Don,xsaves=3Don,cmp-legacy=3Don,= amd-ssbd=3Don,virt-ssbd=3Don,lbrv=3Don,tsc-scale=3Don,vmcb-clean=3Don,pause= -filter=3Don,pfthreshold=3Don,v-vmsave-vmload=3Don,vgif=3Don,svme-addr-chk= =3Don,lfence-always-serializing=3Don,null-sel-clr-base=3Don,rdctl-no=3Don,s= kip-l1dfl-vmentry=3Don,mds-no=3Don,pschange-mc-no=3Don \ +-cpu EPYC-Rome,x2apic=3Don,tsc-deadline=3Don,hypervisor=3Don,tsc-adjust=3D= on,stibp=3Don,arch-capabilities=3Don,ssbd=3Don,cmp-legacy=3Don,amd-ssbd=3Do= n,virt-ssbd=3Don,lbrv=3Don,tsc-scale=3Don,vmcb-clean=3Don,pause-filter=3Don= ,pfthreshold=3Don,v-vmsave-vmload=3Don,vgif=3Don,svme-addr-chk=3Don,lfence-= always-serializing=3Don,null-sel-clr-base=3Don,rdctl-no=3Don,skip-l1dfl-vme= ntry=3Don,mds-no=3Don,pschange-mc-no=3Don,xsaves=3Doff \ -m 214 \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ -overcommit mem-lock=3Doff \ --=20 2.40.1 From nobody Sat Feb 7 15:10:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1686321091; cv=none; d=zohomail.com; s=zohoarc; b=R24S6AIWOyXEspJbbvUTS0lE+2Nl8R+tC+bWEllBYZV9Fs5bn2mrOLbCY+ZN/6R93DDrrYCh6jXOob56ORLGM1x6I0SLlS1gk6y9WLGE8Mcoz38+q5dzstlVK/Zt8PsRyc5dtnC7Q+6xCwDk958wEwx8IXqANGY6bvruzngVLuw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686321091; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Jdc+QO3cavN+Kfka7pdxD5OKMzAgDXmI9WCCu+s2JZo=; b=TtdMko3Bj5NdDW/mqQ0GO4Nb/ZKQsKchWN++r3XvK8+nFBhdZB/FpXF5leFNPnzDAUgIPcWufHx9iff7CO9d+n78d1E6DVrc/1MG35Hxh30tixZForAHI4eJTtQsNpQlHmpE0+3MXqqtuhYF/WkK2ANLn5cfdG0FAisfCqW3mhU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1686321091233483.2823263250365; Fri, 9 Jun 2023 07:31:31 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-670-LcYuG_9fP3K97-tPhpESkw-1; Fri, 09 Jun 2023 10:31:28 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B168A801585; Fri, 9 Jun 2023 14:31:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 99D1C2166B25; Fri, 9 Jun 2023 14:31:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4B1EC19451CC; Fri, 9 Jun 2023 14:31:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 10618194658C for ; Fri, 9 Jun 2023 14:31:14 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E56F7140E958; Fri, 9 Jun 2023 14:31:13 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D9E2140E957 for ; Fri, 9 Jun 2023 14:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686321090; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Jdc+QO3cavN+Kfka7pdxD5OKMzAgDXmI9WCCu+s2JZo=; b=S/WmnfsbQJw9sArG3kJRPytLMFd7znn21mDjghy6zcxU5smaCAfqX8CApDgAl4rU0ezDt1 tkT8UP9HKknBX8R9Tp8vyby6D2IYb8k9Zdamv3o2eVjHsBLf0g4bbNozne/EFIpY2gsvyU ODkxvXfcr3ohCHFgga/uPGPHYT9k7Yo= X-MC-Unique: LcYuG_9fP3K97-tPhpESkw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/2] Explicitly reject unsupported storage types for legacy config generators Date: Fri, 9 Jun 2023 16:31:10 +0200 Message-Id: <6bc53fe6149116476bd56ed064fc691388c0a980.1686320977.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1686321092262100005 Content-Type: text/plain; charset="utf-8" New storage types are not implemented in generators for -drive and the xen config. Explicitly reject them in case of a programming error. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libxl/xen_xl.c | 4 +++- src/qemu/qemu_command.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 77f9f112f0..1cc42fa59f 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -1525,7 +1525,9 @@ xenFormatXLDiskSrc(virStorageSource *src, char **srcs= tr) case VIR_STORAGE_TYPE_VHOST_USER: case VIR_STORAGE_TYPE_NONE: case VIR_STORAGE_TYPE_LAST: - break; + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("unsupported storage type for this code path")); + return -1; } return 0; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a19902988c..8f5bc02459 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1638,10 +1638,11 @@ qemuBuildDriveSourceStr(virDomainDiskDef *disk, case VIR_STORAGE_TYPE_VHOST_USER: case VIR_STORAGE_TYPE_NONE: case VIR_STORAGE_TYPE_LAST: - break; + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("unsupported storage type for this code path")); + return -1; } - virBufferAddLit(buf, ","); if (encinfo) { --=20 2.40.1