[PATCH 1/2] util: include virfirewall.h in virfirewalld.h

Michal Privoznik posted 2 patches 4 months, 3 weeks ago
[PATCH 1/2] util: include virfirewall.h in virfirewalld.h
Posted by Michal Privoznik 4 months, 3 weeks ago
The virfirewalld.h file provides a declaration for
virFirewallDApplyRule() which accepts an argument of type
virFirewallLayer. But the typedef lives in virfirewall.h and thus
including just virfirewalld.h is not sufficient.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/util/virfirewalld.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/util/virfirewalld.h b/src/util/virfirewalld.h
index 004d10ec29..0e94d3507b 100644
--- a/src/util/virfirewalld.h
+++ b/src/util/virfirewalld.h
@@ -20,6 +20,8 @@
 
 #pragma once
 
+#include "virfirewall.h"
+
 #define VIR_FIREWALL_FIREWALLD_SERVICE "org.fedoraproject.FirewallD1"
 
 typedef enum {
-- 
2.39.2
Re: [PATCH 1/2] util: include virfirewall.h in virfirewalld.h
Posted by Martin Kletzander 4 months, 2 weeks ago
On Wed, May 03, 2023 at 11:00:54AM +0200, Michal Privoznik wrote:
>The virfirewalld.h file provides a declaration for
>virFirewallDApplyRule() which accepts an argument of type
>virFirewallLayer. But the typedef lives in virfirewall.h and thus
>including just virfirewalld.h is not sufficient.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>---
> src/util/virfirewalld.h | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/src/util/virfirewalld.h b/src/util/virfirewalld.h
>index 004d10ec29..0e94d3507b 100644
>--- a/src/util/virfirewalld.h
>+++ b/src/util/virfirewalld.h
>@@ -20,6 +20,8 @@
>
> #pragma once
>
>+#include "virfirewall.h"
>+
> #define VIR_FIREWALL_FIREWALLD_SERVICE "org.fedoraproject.FirewallD1"
>
> typedef enum {
>-- 
>2.39.2
>