From nobody Mon Feb 9 01:44:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681733355; cv=none; d=zohomail.com; s=zohoarc; b=WkMa0AQIKup6H5FIb0l5MQVjTnZYB0lk6M92r53MDHcY2BglTAMXBa77dt0PWTcFKaYeMOxbRLI/gCAgULamfCzHJQdLzcqdTQF7BvwoMZcWxIRpYgWK08W8gWU4AWnANPtN17/yUoEBMnYcHDx4lsoQdcb0l4rlauafEfTzKQo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681733355; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zq1BJxruwXYdaRiU9gqPRtdBdlIi7bJkAesESHg6IJM=; b=UtDpSdL5LbdwZwYQhff5imrbf+zmgW/+RSK3b035sorbHVFkJEjdhzTLnByZ2l+Zrayni8iY8SRvthKUWYgygEfUHdOgd1IxuBXs7QNitojQo+vCJqNsb5YT2wuMk0vKcs8gVhauV62JYUYoX+YaoLaZMtBeLmV4//x5VaGoteI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1681733355280141.56012581972266; Mon, 17 Apr 2023 05:09:15 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-bg-RaXkqMXi2wlvBWdqvMQ-1; Mon, 17 Apr 2023 08:09:10 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7560D299E760; Mon, 17 Apr 2023 12:09:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62BD2492B0F; Mon, 17 Apr 2023 12:09:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4E3A2194658D; Mon, 17 Apr 2023 12:09:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5DCF01946A40 for ; Mon, 17 Apr 2023 12:09:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4FA85492B0F; Mon, 17 Apr 2023 12:09:05 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id E917D492B03 for ; Mon, 17 Apr 2023 12:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681733354; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zq1BJxruwXYdaRiU9gqPRtdBdlIi7bJkAesESHg6IJM=; b=i0UmXMESeHem2Sho6DIcBLNXjn8n83DGv3BzJWBLxKDTTob/U3CKdT9XS0G7JtUHTym5z0 /fqATxQ4fyZ9R/zhpbqp/W2gjdLp2G2LpVy9D92S+X7FY8J2Yeu9Vq2hOg58s53eMb1GK2 ahsB5RUSoYc7WEoWpYTCDHeCEgc25iQ= X-MC-Unique: bg-RaXkqMXi2wlvBWdqvMQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/3] networkUpdateState: do not assume dnsmasq_caps Date: Mon, 17 Apr 2023 14:09:01 +0200 Message-Id: <3bfea37519a0acb0f9ebd91e13631266ff6e0338.1681733319.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681733356193100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Assume there's a dnsmasq running (because there's an active virtual network that spawned it). Now, shut down the daemon, remove the dnsmasq binary and start the daemon again. At this point, networkUpdateState() is called, but dnsmasq_caps is NULL (because networkStateInitialize() called earlier failed to set them, rightfully though). Now, the networkUpdateState() tries to read the dnsmasq's PID file using virPidFileReadIfAlive() which takes a path to the corresponding binary as one of its arguments. To provide that path, dnsmasqCapsGetBinaryPath() is called, but since dnsmasq_caps is NULL, it dereferences it and thus causes a crash. It's true that virPidFileReadIfAlive() can deal with a removed binary (well virPidFileReadPathIfAlive() which it calls can), but iff the binary path is provided in its absolute form. Otherwise, virFileResolveAllLinks() fails to canonicalize the path (expected, the path doesn't exist anyway). Therefore, reading dnsmasq's PID file didn't work before v8.1.0-rc1~401 which introduced this crash. It was always set to -1. But passing NULL as binary path instead, makes virPidFileReadIfAlive() return early, right after the PID file is read and it's confirmed the PID exists. Yes, this may yield wrong results, as the PID might be of a completely different binary. But this problem is preexistent and until we start locking PID files, there's nothing we can do about it. IOW, it would require rework of dnsmasq PID file handling. Fixes: 4b68c982e283471575bacbf87302495864da46fe Resolves: https://gitlab.com/libvirt/libvirt/-/issues/456 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/network/bridge_driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 97e099880b..7f2298a15e 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -493,15 +493,19 @@ networkUpdateState(virNetworkObj *obj, =20 /* Try and read dnsmasq pids of active networks */ if (virNetworkObjIsActive(obj) && def->ips && (def->nips > 0)) { + const char *binpath =3D NULL; pid_t dnsmasqPid; =20 if (networkSetMacMap(cfg, obj) < 0) return -1; =20 + if (dnsmasq_caps) + binpath =3D dnsmasqCapsGetBinaryPath(dnsmasq_caps); + ignore_value(virPidFileReadIfAlive(cfg->pidDir, def->name, &dnsmasqPid, - dnsmasqCapsGetBinaryPath(dnsmas= q_caps))); + binpath)); virNetworkObjSetDnsmasqPid(obj, dnsmasqPid); } =20 --=20 2.39.2 From nobody Mon Feb 9 01:44:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681733356; cv=none; d=zohomail.com; s=zohoarc; b=REJUij1HYSxEev/WgPzlG37hK/CABodKFgordVlxvKd6cUCFAgeC8XobmilzoBJWvSF5W/UtLToQ2ADRwacVj93GA0q4QH3lJHAbcUFBxJRKo9VQ8cRrbXE7yluKyGY2xV0DJeubPIwLZC/DBhk/LahciqMFNQ7rrpkmwk3ylrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681733356; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/L7+JagJbAnJPhmNW+ecW7tmoHFrIPoMMQMnSWYvSnM=; b=I/WwI7NRq++R80Q6/6iulH1qPiC9UGicxHuOLIWnKz79onJ3HszvgRW2PdhYs+MDh+M9UBFPmCr1819SmvKPuG/vD0x5GRYAX7mkzn+xk9oFwrzrP/ORnP/VQNp945Gad4LUssNQwOmYVF21JDqN6O2RLYGEFJgHBCrZ1/V+sIo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1681733356622136.49470842875485; Mon, 17 Apr 2023 05:09:16 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-191-pQ7UrmhiP4ecPE6NSUR_0g-1; Mon, 17 Apr 2023 08:09:11 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E42CE299E76E; Mon, 17 Apr 2023 12:09:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB19C2027063; Mon, 17 Apr 2023 12:09:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8191B1946A40; Mon, 17 Apr 2023 12:09:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F28C2194658C for ; Mon, 17 Apr 2023 12:09:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E4AFE492B10; Mon, 17 Apr 2023 12:09:05 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89EA2492B03 for ; Mon, 17 Apr 2023 12:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681733355; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/L7+JagJbAnJPhmNW+ecW7tmoHFrIPoMMQMnSWYvSnM=; b=CO/s8wZiV5IjGNOhOldTaLHFXB1avWAtPHS1ds6EE4rXz34VClpN/3h6BZRUZ5Zh+z3aCS pkPmD+GDZkuk0eK63sI89uj/JxUqo0CPPhhiupJ8yhjPe3okMduOF9o5Do7rF97nnE7s65 AaiPETWkPSzFF+jkHmhhQDl7Z0LVbok= X-MC-Unique: pQ7UrmhiP4ecPE6NSUR_0g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/3] conf: Initialize _virNetworkObj::dnsmasqPid to -1 in virNetworkObjNew() Date: Mon, 17 Apr 2023 14:09:02 +0200 Message-Id: <6a76e09cbd290bb63bb36dd2a333e87a5a629494.1681733319.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681733357130100003 Content-Type: text/plain; charset="utf-8"; x-default="true" Throughout all of our network driver code we assume that dnsmasqPid of value -1 means the network has no dnsmasq process running. There are plenty of calls to: virNetworkObjSetDnsmasqPid(obj, -1); or: pid_t dnsmasqPid =3D virNetworkObjGetDnsmasqPid(obj); if (dnsmasqPid > 0) ...; Now, a virNetworkObj is created via virNetworkObjNew() which might as well set this de-facto default value. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/conf/virnetworkobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 1726fc381f..b8b86da06f 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -117,6 +117,7 @@ virNetworkObjNew(void) ignore_value(virBitmapSetBit(obj->classIdMap, 2)); =20 obj->ports =3D virHashNew(virNetworkObjPortFree); + obj->dnsmasqPid =3D (pid_t)-1; =20 virObjectLock(obj); =20 --=20 2.39.2 From nobody Mon Feb 9 01:44:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681733356; cv=none; d=zohomail.com; s=zohoarc; b=AMVzrIHTJDPArrwC04Naz3iDnXDP1TTWlGCdI4KrwkbdLdSLsUPIeA/BOK88VV0u43y+gCDvjKSe6yJjx1Y4zfjtTs7VV1H9NvfaAyVJESzPwij/nD4euLIjPYU0dT9JhzOKvgWthuhDV33XMKgcyTGmxn8NNfee2hOXCw8viwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681733356; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=evkfEd/f/RKFwfqrAeYRfYJ0YydynKpRfKjUXzsF6lk=; b=AHsI6BSt2Yjk3vhSHHUb8AB5x0pusB7hGdDe7BYRqVChA4uXUwOtH+6yPC5uVgY16dZvE1fEvQ87mMjLKPuRThOA8rp/nSYuXkeDQbBMFQ7ZixuWeJcheqEdnjbGP0bQJ3vBgCRTAe7iiqSRYpF2cZizBTpv12IpxeWsrCmLn/A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1681733356780532.8275514481495; Mon, 17 Apr 2023 05:09:16 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201--eHnJdf9Ni-7Fr0fn25-kw-1; Mon, 17 Apr 2023 08:09:11 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8B2CF3C1069A; Mon, 17 Apr 2023 12:09:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74B2C40CE2D4; Mon, 17 Apr 2023 12:09:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 594A3194658D; Mon, 17 Apr 2023 12:09:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9A3C0194658C for ; Mon, 17 Apr 2023 12:09:06 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7FA91492B03; Mon, 17 Apr 2023 12:09:06 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27121492B10 for ; Mon, 17 Apr 2023 12:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681733355; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=evkfEd/f/RKFwfqrAeYRfYJ0YydynKpRfKjUXzsF6lk=; b=U0+3issQfSfjtDSq0u29Rgjfaiyb87sYbjYnXYmsq/zhA85fHHOxOJajdv+zSFyS0H7GDe LaS36ifaUomHVUTfzqlYk1Nl/8u2piAjnMYkcHJ3QZJKpYcYuVDp7j6PtSRVY6clvtxSRl 95Hn/G+itt7vtU+fok/LXeO4LRAKGQ4= X-MC-Unique: -eHnJdf9Ni-7Fr0fn25-kw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/3] networkRefreshDhcpDaemon: Get dnsmasq's PID once Date: Mon, 17 Apr 2023 14:09:03 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681733358200100005 Content-Type: text/plain; charset="utf-8"; x-default="true" This is a relict of v3.7.0-rc1~132 when getter/setter APIs for dnsmasq's PID were introduced. Previously, obj->dnsmasqPid was accessed directly. But the aforementioned commit introduced two calls to virNetworkObjGetDnsmasqPid() even though the result of the first call is stored in a variable. Remove the second call as it's unnecessary. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/network/bridge_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 7f2298a15e..9eb543a0a3 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1599,7 +1599,6 @@ networkRefreshDhcpDaemon(virNetworkDriverState *drive= r, if (dnsmasqSave(dctx) < 0) return -1; =20 - dnsmasqPid =3D virNetworkObjGetDnsmasqPid(obj); return kill(dnsmasqPid, SIGHUP); =20 } --=20 2.39.2