From nobody Mon Feb 9 16:18:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680264047; cv=none; d=zohomail.com; s=zohoarc; b=HuHg0ywVpArhV6b3zDuDfON+CqZlBbOdxVhvoC7OXQn6LFiwCptKbvSsDqjtip9lg79DiekDaqlB3067tYosO/n3eGgHp3ynW0xqWzi129WWUZaDTlMNR7o9uSoojy6IWqoJ2uhWdGLeL6NAQwe/Qln471uWDuZXOQmTK5kNKJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680264047; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2o+/KDZenV/pQCeyLd5feJHI8y0F5TojryTZTqvkgco=; b=e70vkFR2TEjVyMUaqvf7XBlahar7QOyM1yoyL4ZuqNuQkrdhQjw8AXZI7A9DmdowXZ8hhONYFM8UQcd6mKjVVFk3wpOUmYdndB/nCowXNQm3xLyyO7kOhYLqZpvHAM6lWWAFObW2bPLcayDVDuTQEhHwXiWJ0MjfRwzdZeZrO7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1680264047343305.64786757046863; Fri, 31 Mar 2023 05:00:47 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-210-iQc9F2weNci7CHFgeSv-fw-1; Fri, 31 Mar 2023 08:00:42 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A7D1E858289; Fri, 31 Mar 2023 12:00:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9354FC15BA0; Fri, 31 Mar 2023 12:00:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6708C1946A40; Fri, 31 Mar 2023 12:00:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 566E81946A4C for ; Fri, 31 Mar 2023 12:00:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2D14351FF; Fri, 31 Mar 2023 12:00:37 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64039440D8 for ; Fri, 31 Mar 2023 12:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680264046; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2o+/KDZenV/pQCeyLd5feJHI8y0F5TojryTZTqvkgco=; b=Ye7rH33e3o/ipAWkL2+JCyOnqqAKBIdXCf0SmbsZQPnK+UPQNyhpQqT1PODabUV1BHuABZ lUOebX8ZAWX/lBqm4SpgRAUFnTsDFFKasYkEJaLhhGbyfXWKRwcdzlgIqoThtkMe3Jj1mP JXjBQhXoECAmWCEMefPXrTXCfrOxcfo= X-MC-Unique: iQc9F2weNci7CHFgeSv-fw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/3] conf: Store the iothread 'poll' settings in the XML Date: Fri, 31 Mar 2023 14:00:32 +0200 Message-Id: <516109df56e39bacbd3f32582a2e134b280ec58e.1680262381.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680264048996100003 Content-Type: text/plain; charset="utf-8" Currently we allow configuring the 'poll-max-ns', 'poll-grow', and 'poll-shrink' parameters of qemu iothreads only during runtime and they are not persisted. Add XML machinery to persist them. Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander --- docs/formatdomain.rst | 11 ++++- src/conf/domain_conf.c | 41 ++++++++++++++++++- src/conf/domain_conf.h | 7 ++++ src/conf/schemas/domaincommon.rng | 19 +++++++++ .../iothreads-ids-pool-sizes.xml | 12 ++++-- 5 files changed, 85 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 27f83e254d..e3ebf1c718 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -740,7 +740,9 @@ host/guest with many LUNs. :since:`Since 1.2.8 (QEMU on= ly)` - + + + ... @@ -766,6 +768,13 @@ host/guest with many LUNs. :since:`Since 1.2.8 (QEMU o= nly)` ``thread_pool_max`` which allow setting lower and upper boundary for nu= mber of worker threads for given IOThread. While the former can be value of = zero, the latter can't. :since:`Since 8.5.0` + :since:`Since 9.1.0` an optional sub-element ``poll`` with can be used = to + override the hypervisor-default interval of polling for the iothread be= fore + it switches back to events. The optional attribute ``max`` sets the max= imum + time polling should be used in nanoseconds. Setting ``max`` to ``0`` di= sables + polling. Attributes ``grow`` and ``shrink`` override (or disable when s= et to + ``0`` the default steps for increasing/decreasing the polling interval = if + the set interval is deemed insufficient or extensive. ``defaultiothread`` This element represents the default event loop within hypervisor, where= I/O requests from devices not assigned to a specific IOThread are processed. diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 08527964d1..060ab7b41f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15787,6 +15787,7 @@ static virDomainIOThreadIDDef * virDomainIOThreadIDDefParseXML(xmlNodePtr node) { g_autoptr(virDomainIOThreadIDDef) iothrid =3D virDomainIOThreadIDDefNe= w(); + xmlNodePtr pollNode; if (virXMLPropUInt(node, "id", 10, VIR_XML_PROP_REQUIRED | VIR_XML_PROP_NONZERO, @@ -15803,6 +15804,28 @@ virDomainIOThreadIDDefParseXML(xmlNodePtr node) &iothrid->thread_pool_max, -1) < 0) return NULL; + if ((pollNode =3D virXMLNodeGetSubelement(node, "poll"))) { + int rc; + + if ((rc =3D virXMLPropULongLong(pollNode, "max", 10, VIR_XML_PROP_= NONE, + &iothrid->poll_max_ns)) < 0) + return NULL; + + iothrid->set_poll_max_ns =3D rc =3D=3D 1; + + if ((rc =3D virXMLPropUInt(pollNode, "grow", 10, VIR_XML_PROP_NONE, + &iothrid->poll_grow)) < 0) + return NULL; + + iothrid->set_poll_grow =3D rc =3D=3D 1; + + if ((rc =3D virXMLPropUInt(pollNode, "shrink", 10, VIR_XML_PROP_NO= NE, + &iothrid->poll_shrink)) < 0) + return NULL; + + iothrid->set_poll_shrink =3D rc =3D=3D 1; + } + return g_steal_pointer(&iothrid); } @@ -26735,6 +26758,9 @@ virDomainDefIothreadShouldFormat(const virDomainDef= *def) for (i =3D 0; i < def->niothreadids; i++) { if (!def->iothreadids[i]->autofill || + def->iothreadids[i]->set_poll_max_ns || + def->iothreadids[i]->set_poll_grow || + def->iothreadids[i]->set_poll_shrink || def->iothreadids[i]->thread_pool_min >=3D 0 || def->iothreadids[i]->thread_pool_max >=3D 0) return true; @@ -26783,6 +26809,8 @@ virDomainDefIOThreadsFormat(virBuffer *buf, for (i =3D 0; i < def->niothreadids; i++) { virDomainIOThreadIDDef *iothread =3D def->iothreadids[i]; g_auto(virBuffer) attrBuf =3D VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) iothreadChildBuf =3D VIR_BUFFER_INIT_CHILD(&= childrenBuf); + g_auto(virBuffer) pollAttrBuf =3D VIR_BUFFER_INITIALIZER; virBufferAsprintf(&attrBuf, " id=3D'%u'", iothread->iothread_id); @@ -26797,7 +26825,18 @@ virDomainDefIOThreadsFormat(virBuffer *buf, iothread->thread_pool_max); } - virXMLFormatElement(&childrenBuf, "iothread", &attrBuf, NULL); + if (iothread->set_poll_max_ns) + virBufferAsprintf(&pollAttrBuf, " max=3D'%llu'", iothread-= >poll_max_ns); + + if (iothread->set_poll_grow) + virBufferAsprintf(&pollAttrBuf, " grow=3D'%u'", iothread->= poll_grow); + + if (iothread->set_poll_shrink) + virBufferAsprintf(&pollAttrBuf, " shrink=3D'%u'", iothread= ->poll_shrink); + + virXMLFormatElement(&iothreadChildBuf, "poll", &pollAttrBuf, N= ULL); + + virXMLFormatElement(&childrenBuf, "iothread", &attrBuf, &iothr= eadChildBuf); } virXMLFormatElement(buf, "iothreadids", NULL, &childrenBuf); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 5a2c70f012..8ac76f25d3 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2713,6 +2713,13 @@ struct _virDomainIOThreadIDDef { virDomainThreadSchedParam sched; + unsigned long long poll_max_ns; + bool set_poll_max_ns; + unsigned int poll_grow; + bool set_poll_grow; + unsigned int poll_shrink; + bool set_poll_shrink; + int thread_pool_min; int thread_pool_max; }; diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 6158ed79ac..57fb4a5e33 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -885,6 +885,25 @@ + + + + + + + + + + + + + + + + + + + diff --git a/tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml b/tests/qe= muxml2argvdata/iothreads-ids-pool-sizes.xml index df4b291a7a..63fb4a52f6 100644 --- a/tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml +++ b/tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml @@ -7,9 +7,15 @@ 5 - - - + + + + + + + + + --=20 2.39.2 From nobody Mon Feb 9 16:18:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680264049; cv=none; d=zohomail.com; s=zohoarc; b=CiEPWj1ELqNrsdwab+WRWbufqT0ISi2XbImCL+MKEId/Kh37jStzUveRV4M+udpj/xSly1eTzWt8j5AW/4WUYcKxMy4H4QnXbwp/3bxQuDlx6ylNBaPQoCx76lRFP0PfXWNYuc+d8Kow11Vn4A4bxJMbBuF1C97scOL8RUwmLcE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680264049; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NjEsBXKlEvtGFV7xG7M6GqcwFKnHfakxXDKy1+NwWkQ=; b=etNeF5cyCorU1Xmug590K7h/MA2sekEVOKnFcunHihbREDmVHHT51y5gG98AJXag24+ujEHpEYJg4ucr/agpmpBpPJ8hQTqcyCJpXp6KPjFzUz1Ov2gKjr9IZOoDQwWlIhew7F2fMvmE9s5kxxCKXZ3n51y6RQW2f4bh5S1b7Qk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1680264049210264.3675896396895; Fri, 31 Mar 2023 05:00:49 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-Y36Qr-jlNsaQrzoGfwUCGw-1; Fri, 31 Mar 2023 08:00:45 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 180B62807D6F; Fri, 31 Mar 2023 12:00:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 031AC2166B35; Fri, 31 Mar 2023 12:00:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AF7461946A4F; Fri, 31 Mar 2023 12:00:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1B55D19466DF for ; Fri, 31 Mar 2023 12:00:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0DF22440D8; Fri, 31 Mar 2023 12:00:38 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7677851FF for ; Fri, 31 Mar 2023 12:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680264048; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NjEsBXKlEvtGFV7xG7M6GqcwFKnHfakxXDKy1+NwWkQ=; b=LFtyLsixlZcRo6elcva4/CLpi22Lkm1pdFlfHGF1ei1KYVGwj5QXT+n/pCFbHQe6ToJd95 NrNGGCfwiB4JppHoshfN7ItkYe/co6QqCNDty08Ws6w0Hi4iH35zX+r2DLyj7pzOTMf9Xz M8DP9E0l6/YiYNA3VYi20rR8/QGY8Mo= X-MC-Unique: Y36Qr-jlNsaQrzoGfwUCGw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/3] qemu: Use configured iothread poll parameters on startup Date: Fri, 31 Mar 2023 14:00:33 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680264051056100006 Content-Type: text/plain; charset="utf-8" Implement the support for the persisted poll parameters and remove restrictions on saving config when modifying them during runtime. Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander --- src/qemu/qemu_command.c | 18 +++++++++++ src/qemu/qemu_driver.c | 30 ++++++++++--------- ...othreads-ids-pool-sizes.x86_64-latest.args | 6 ++-- 3 files changed, 37 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 7e75354902..0693369faa 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7300,6 +7300,24 @@ qemuBuildIOThreadCommandLine(virCommand *cmd, NULL) < 0) return -1; + if (iothread->set_poll_max_ns && + virJSONValueObjectAdd(&props, + "U:poll-max-ns", iothread->poll_max_ns, + NULL) < 0) + return -1; + + if (iothread->set_poll_grow && + virJSONValueObjectAdd(&props, + "u:poll-grow", iothread->poll_grow, + NULL) < 0) + return -1; + + if (iothread->set_poll_shrink && + virJSONValueObjectAdd(&props, + "U:poll-shrink", iothread->poll_shrink, + NULL) < 0) + return -1; + if (qemuBuildObjectCommandlineFromJSON(cmd, props, qemuCaps) < 0) return -1; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 09ae893daf..3412c5d6f2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5071,23 +5071,30 @@ qemuDomainHotplugModIOThread(virDomainObj *vm, } -static int +static void qemuDomainHotplugModIOThreadIDDef(virDomainIOThreadIDDef *def, qemuMonitorIOThreadInfo mondef) { - /* These have no representation in domain XML */ - if (mondef.set_poll_grow || - mondef.set_poll_max_ns || - mondef.set_poll_shrink) - return -1; + if (mondef.set_poll_max_ns) { + def->poll_max_ns =3D mondef.poll_max_ns; + def->set_poll_max_ns =3D true; + } + + if (mondef.set_poll_grow) { + def->poll_grow =3D mondef.poll_grow; + def->set_poll_grow =3D true; + } + + if (mondef.set_poll_shrink) { + def->poll_shrink =3D mondef.poll_shrink; + def->set_poll_shrink =3D true; + } if (mondef.set_thread_pool_min) def->thread_pool_min =3D mondef.thread_pool_min; if (mondef.set_thread_pool_max) def->thread_pool_max =3D mondef.thread_pool_max; - - return 0; } @@ -5406,12 +5413,7 @@ qemuDomainChgIOThread(virQEMUDriver *driver, if (qemuDomainIOThreadValidate(iothreaddef, iothread, false) <= 0) goto endjob; - if (qemuDomainHotplugModIOThreadIDDef(iothreaddef, iothread) <= 0) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("configuring persistent polling values is= not supported")); - goto endjob; - } - + qemuDomainHotplugModIOThreadIDDef(iothreaddef, iothread); break; } } diff --git a/tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.= args b/tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args index 4f5a11aab1..1422e94e35 100644 --- a/tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args +++ b/tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args @@ -18,9 +18,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -overcommit mem-lock=3Doff \ -smp 6,sockets=3D6,cores=3D1,threads=3D1 \ -object '{"qom-type":"iothread","id":"iothread2","thread-pool-min":0,"thre= ad-pool-max":60}' \ --object '{"qom-type":"iothread","id":"iothread4","thread-pool-min":1,"thre= ad-pool-max":1}' \ --object '{"qom-type":"iothread","id":"iothread1"}' \ --object '{"qom-type":"iothread","id":"iothread3"}' \ +-object '{"qom-type":"iothread","id":"iothread4","thread-pool-min":1,"thre= ad-pool-max":1,"poll-max-ns":123}' \ +-object '{"qom-type":"iothread","id":"iothread1","poll-grow":456,"poll-shr= ink":789}' \ +-object '{"qom-type":"iothread","id":"iothread3","poll-max-ns":123000,"pol= l-grow":456,"poll-shrink":789}' \ -object '{"qom-type":"iothread","id":"iothread5"}' \ -object '{"qom-type":"main-loop","id":"main-loop","thread-pool-min":8,"thr= ead-pool-max":16}' \ -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --=20 2.39.2 From nobody Mon Feb 9 16:18:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680264050; cv=none; d=zohomail.com; s=zohoarc; b=PNUeCoXGeufRON+UvjerQCNvX0sRJhaBGcg/1SO29alquDE+u5uttLFadgC1JFFsBslxkvBdIMLtqKUOjlbwx/08Esv8BOOqTqrPg02i+XWKPJZxNbucUnz84w4SHGZ/01ItQZ/ezXzdg7IA6p5g8I39UCLNuH0Azns1OlArijo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680264050; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cMOI7Oa89t4jImIw1oJfxdBMtvYSe22Ffv/wG/DXoEk=; b=WShM+pBCRRUHJ6ELC6IOsVCO8aaKClIkxEARlnCvPtMlXYqL2s9x8dhIFkdDjfB04wiSMHoIJ2fkBBuCzIPqUGY1ppTjq7PE1Yxea6c8USFp8MQWldr+SAM9k4ujArkeMyviL2vUSMtERIxREiuHo3SWKINkDMbMMQmdtiQrKfk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1680264050221786.379310355786; Fri, 31 Mar 2023 05:00:50 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-68-4osGTvdoNHOZlwPw6EXzlQ-1; Fri, 31 Mar 2023 08:00:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A765D3C0F386; Fri, 31 Mar 2023 12:00:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9370D51FF; Fri, 31 Mar 2023 12:00:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8330F19465BD; Fri, 31 Mar 2023 12:00:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 03DCA19465BC for ; Fri, 31 Mar 2023 12:00:39 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id DBED651FF; Fri, 31 Mar 2023 12:00:38 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FCDB18EC7 for ; Fri, 31 Mar 2023 12:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680264049; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cMOI7Oa89t4jImIw1oJfxdBMtvYSe22Ffv/wG/DXoEk=; b=Ugc1K2HfcwXtRR9eNk4Uz22oTVIJuVYp1o8uC3HllX0KKmot36Lz+dGXIbFrU+gM1oCt6L 3zNfS/c2qPdiKKNzV2TA70V2thoXbOvVUajyOhQ9T8TFjCcEQkKfUF3ELBi4vYgeQx30Ws VXb9oMtNFsqjZI/hJwNlt54z0VUZhLA= X-MC-Unique: 4osGTvdoNHOZlwPw6EXzlQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/3] docs: formatdomain: Properly indent example XML for setting 'metadata_cache' Date: Fri, 31 Mar 2023 14:00:34 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680264051053100005 Content-Type: text/plain; charset="utf-8" Indent the example XML block so that it belongs to the paragraph talking about it. Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander --- docs/formatdomain.rst | 42 ++++++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index e3ebf1c718..dcc5844b7b 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3275,28 +3275,26 @@ paravirtualized driver is specified via the ``disk`= ` element. to the ``qemu`` `qcow2 cache docs `__ - **Example:** - -:: - - - - - 1234 - - - - - - - 1234 - - - - - - - + **Example**:: + + + + + 1234 + + + + + + + 1234 + + + + + + + ``backenddomain`` The optional ``backenddomain`` element allows specifying a backend doma= in --=20 2.39.2