From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146720; cv=none; d=zohomail.com; s=zohoarc; b=SgMz71xKa1Q3CuIXJIUVm7GTf2ER0xmvZ2miuDv408DkXjFg2zvXaEAAQ7t+7zO6MZG1aMuisvbY85BBicE6wp1EC7IVxY3S+CbzF48x6M+jrhwi4h1SBqVtDaU24cSqpeKm6jWFh8mxkWwqArfudypWh2/hkehpum1ko4r6Fas= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146720; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f9SXKZB3eJQps5+D3Mg3h9dDVOb7Q6aowR/Quevd4Ew=; b=ZOMKix0DX5qWjXKaeo4uEjB45r1uvhsZLZUW8R44N83maWxda95Gjjfv8b83SWi/W0noz+zlngpnotR3c+0nhjvyuQCzoXdGPlOtJH7qERrv1tTzj/6yiX7K8tOjme9G7kLP+iqLtvUhJ+wk2X8HI5LJtWlJCPMZ+mkL97KgqOU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1679146720816567.3103539601314; Sat, 18 Mar 2023 06:38:40 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-175-58FT9T55OGWguTxVTwhjew-1; Sat, 18 Mar 2023 09:38:34 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 626DB8030A0; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C1DA1121318; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C18341946A4D; Sat, 18 Mar 2023 13:38:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E93F01946595 for ; Sat, 18 Mar 2023 13:38:28 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CCDCF406AA67; Sat, 18 Mar 2023 13:38:28 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35C35406AA66 for ; Sat, 18 Mar 2023 13:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146719; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=f9SXKZB3eJQps5+D3Mg3h9dDVOb7Q6aowR/Quevd4Ew=; b=Vcl7p/9gOIrh80rBb0OVJqr+JPE5cPG5cU2uKoogk/lzdb1ruint1r760oEqynEpKO1HhC RucC5wMsueX8yj5mOMXEnsEf8bo+kAyEX0vz01s5dkXsZJVhxxwQB8QeKFWmqI/NYfzzfU wsdBYgPY1HDSquEw8L7sHa3RdP9oZmE= X-MC-Unique: 58FT9T55OGWguTxVTwhjew-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/8] bhyve: fix typo in error message Date: Sat, 18 Mar 2023 14:38:20 +0100 Message-Id: <800d9d1fab9b2372ba051472b7c32d5eaba98057.1679146695.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146722508100003 Use the same string as in qemu_process. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/bhyve/bhyve_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index eee0c4bf1d..f8f072ff03 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -145,7 +145,7 @@ virBhyveProcessStartImpl(struct _bhyveConn *driver, if (unlink(driver->pidfile) < 0 && errno !=3D ENOENT) { virReportSystemError(errno, - _("Cannot remove state PID file %s"), + _("Cannot remove stale PID file %s"), driver->pidfile); goto cleanup; } --=20 2.39.2 From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146743; cv=none; d=zohomail.com; s=zohoarc; b=WSBc408yWdz+dPwW8eTyPk0QiUu77B0mVZBAQrCF57DoOYQef0kmsQ5dmbJXiRW4kPC/6YaIQewvK1qILF+N9zy3ytgt4Ih3qam5rfK4K8U4dJLRLDtGHiGbxjaYqUAqhsQe7x+78kSWNJHMz1QaFJXV/QRFDLdyaUFQFnXlNaM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146743; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=p9i0BKQMR8vnptG893C6FKXF9MeHW7mwP/0NwKtD/oE=; b=W9pkStR2qBQJxYN+IogmeFJfxjdgt6tyuTD0gHHD1R+EF6RNrNsHJd2Ef8rXNkwl4rMRYHn9MW8kkVVUe+1QTR0T0xlZcmKj4YrcduVTokO2aKT41hhSvr/M351hXWzcuAN6krQug+p+3ndNVgweTholoIrUuP6HJGWPM02TQDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679146743069949.8046849492264; Sat, 18 Mar 2023 06:39:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-635-RZO0hYJkM6KW9SwHSl5BAQ-1; Sat, 18 Mar 2023 09:38:36 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 87F342A5956F; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 733AC1410F1B; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 00CF51946A6B; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AE3C01946A67 for ; Sat, 18 Mar 2023 13:38:29 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A1582406AA67; Sat, 18 Mar 2023 13:38:29 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22729406AA66 for ; Sat, 18 Mar 2023 13:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146742; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=p9i0BKQMR8vnptG893C6FKXF9MeHW7mwP/0NwKtD/oE=; b=MaysAFuxegk3um8LWMopCms/j8Xl8BMnNRJch3INU/Ef6ewcqU+hBxwBt6thxdboACBzaR nNmZNZrZpLLputm8ZcO0ptEvABkdaBfKyhj60RDQELL59ZexwpQD2yfXV29+N6mO/Vz2U9 DK9MuGGzDGtV3E+X4GvzF7rggd0UMIw= X-MC-Unique: RZO0hYJkM6KW9SwHSl5BAQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/8] src: unify symlink creation error message Date: Sat, 18 Mar 2023 14:38:21 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146744500100002 In some places, one quote got dropped by accident. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/libxl/libxl_driver.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/qemu/qemu_driver.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 04e74086e6..07dcfcdc05 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -4651,7 +4651,7 @@ libxlDomainSetAutostart(virDomainPtr dom, int autosta= rt) =20 if (symlink(configFile, autostartLink) < 0) { virReportSystemError(errno, - _("Failed to create symlink '%s to '%= s'"), + _("Failed to create symlink '%s' to '= %s'"), autostartLink, configFile); goto endjob; } diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index b1d53659d7..d581372b00 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -2481,7 +2481,7 @@ static int lxcDomainSetAutostart(virDomainPtr dom, =20 if (symlink(configFile, autostartLink) < 0) { virReportSystemError(errno, - _("Failed to create symlink '%s to '%s'"), + _("Failed to create symlink '%s' to '%s'"= ), autostartLink, configFile); goto endjob; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 891f630e27..09ae893daf 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8232,7 +8232,7 @@ static int qemuDomainSetAutostart(virDomainPtr dom, =20 if (symlink(configFile, autostartLink) < 0) { virReportSystemError(errno, - _("Failed to create symlink '%s to '%= s'"), + _("Failed to create symlink '%s' to '= %s'"), autostartLink, configFile); goto endjob; } @@ -18964,7 +18964,7 @@ qemuDomainRenameCallback(virDomainObj *vm, =20 if (symlink(new_dom_cfg_file, new_dom_autostart_link) < 0) { virReportSystemError(errno, - _("Failed to create symlink '%s to '%s'"), + _("Failed to create symlink '%s' to '%s'"= ), new_dom_autostart_link, new_dom_cfg_file); return -1; } --=20 2.39.2 From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146721; cv=none; d=zohomail.com; s=zohoarc; b=L/V6AveewYEQc2Ti2bfyVgAHsJe91mUoLurGqFCrVETgCp1iYSICU8fb0QVx2UP0t0MKQl6aXkToly3fXZxsohZwSgAa+82tpPTWVp46ACa++dzvOkl+pSOwbhJvDy95IcxA2OwuB8aaKrqBIZbVZRv6fGVmAbm5ElBstGy10+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146721; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VI3Pcj+43ScuZlvpBC9ghasm+BKs8ADogZjl25J2/9M=; b=ffieNO5zKCglUQL2zFNCUwF3wW51+FmhzS+e1CXJ9BVvqPwmn50hvqWT38DYMlxv87SlK5QFTj6CozUk96H7TC/S9nI2gWXiG/wufcLjnnqamqdabWlm+ZYv9PCI135x7FUlO4XqE0JW/1f5OpQCoGxwPdlSa79p2KUoMdpGR10= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1679146721129572.186113631846; Sat, 18 Mar 2023 06:38:41 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-235-m64fmHL5ORSEPgq3d3VVPQ-1; Sat, 18 Mar 2023 09:38:35 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E110685A5A3; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC62F18EC6; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9C56D1946A4B; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 848691946595 for ; Sat, 18 Mar 2023 13:38:30 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 74DBB406AA67; Sat, 18 Mar 2023 13:38:30 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8E0D406AA66 for ; Sat, 18 Mar 2023 13:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146720; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VI3Pcj+43ScuZlvpBC9ghasm+BKs8ADogZjl25J2/9M=; b=hKssFYyUHpYNe+k7UKoZtDjF5Me6/Go9jXUeDtZItCikLjBAnn9ysXAq1rxnTr6XbrSo/a X4cZJbs7SThEgRvswOUAieK1en3Ey9/7upzUPR1Ydrxe3m3axyKE4qINZpjlSEQKv+fZ8L +V54WPWIoHU7Z23y7boFdRcbFuCW9ps= X-MC-Unique: m64fmHL5ORSEPgq3d3VVPQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/8] bhyve: unify error message for UUID generation Date: Sat, 18 Mar 2023 14:38:22 +0100 Message-Id: <290531c61e79e9d21ebab35a6d3325a1e0a7ab63.1679146695.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146722388100001 All the other places spell UUID in all caps. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/bhyve/bhyve_parse_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_comman= d.c index 2a5959ba1d..4b0aaab056 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -947,7 +947,7 @@ bhyveParseCommandLineString(const char* nativeConfig, def->virtType =3D VIR_DOMAIN_VIRT_BHYVE; if (virUUIDGenerate(def->uuid) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Failed to generate uuid")); + _("Failed to generate UUID")); return NULL; } def->id =3D -1; --=20 2.39.2 From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146742; cv=none; d=zohomail.com; s=zohoarc; b=K+UD2kSwtXFmS5UJI6AYegbZ4Yns5n7F7vymxZYKHOPGGaUpNJC+PiU3VZNp7FnWgO5kytosROOXVGkrguFPIJiQd2bt8VDkFlRvvkG2ORO5jXueiPmMvqPZNBNXbWNhoIhHT7VuQEscq4vZR9guPfuhjZsZ84wZiVkv5P0GPiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146742; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JIlaPEP5YiaGXNEDvtPxtiQkhFIhy/ZJMi4KDMPpszI=; b=kieYCEibdVDm9a096fTKRpM/SwYhJuDehe3/jcHqdI+iOblIgh6OtsOK7Mpjz0yV95RgtoaRQ202LqIO3Tjaj5aOnngs4pPKNgIc4l3A3jFvGyZdr1t0D1+2yg2JbNiEiFacm8KTYs0sNoL/oVVP7e5pdOl/3zj/J8sEXEZ8oSQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679146742858429.9225399678934; Sat, 18 Mar 2023 06:39:02 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-53-gm5UGSMDPfiEScgOt9_Ssw-1; Sat, 18 Mar 2023 09:38:38 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E54578030D7; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D307F40C6E67; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 399471946A77; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A4E5B1946A51 for ; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7AA46406AA68; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7585406AA66 for ; Sat, 18 Mar 2023 13:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146741; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JIlaPEP5YiaGXNEDvtPxtiQkhFIhy/ZJMi4KDMPpszI=; b=YbDC+hdHJ69FNYmI4wzeH5CTQfbtq86JyBjptO5RVA4By81U6Z9yInW7c1OMeZow2XxyKo Ydbli7o2lbg7WPRWl5aG6O/txDIp/YKXLxWL2Skoyd83AH+6i1yd94J43e6Z17sgVfYNoJ 0MgKx3L45CV/Goqe+LFNl6dgGwut8lI= X-MC-Unique: gm5UGSMDPfiEScgOt9_Ssw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/8] vbox: remove unreachable error in virVBoxSnapshotConfLoadVboxFile Date: Sat, 18 Mar 2023 14:38:23 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146744494100001 Both callers in the VirtualBox driver error out if the path can't be fetched via VirtualBox APIs and abort on coversion error from UTF-16 to UTF-8. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/vbox/vbox_snapshot_conf.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c index 2f3f48d688..a6e5fad4d2 100644 --- a/src/vbox/vbox_snapshot_conf.c +++ b/src/vbox/vbox_snapshot_conf.c @@ -576,12 +576,6 @@ virVBoxSnapshotConfLoadVboxFile(const char *filePath, ssize_t searchResultSize =3D 0; char *currentSnapshotAttribute =3D NULL; =20 - if (filePath =3D=3D NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Filepath is Null")); - goto cleanup; - } - machineDescription =3D g_new0(virVBoxSnapshotConfMachine, 1); =20 xml =3D virXMLParse(filePath, NULL, NULL, NULL, &xPathContext, NULL, f= alse); --=20 2.39.2 From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146745; cv=none; d=zohomail.com; s=zohoarc; b=kN6wNZzxXM5cob4T9CGKZdaBlXpTu75NFCPGGdARk5LU2MVp82JCa77uZVeeImDX+ofO8lf4rIe/+3za2kEa9Y+IAWt+crDzj/PH/KBg6phg1d1eWhlemg4bBilZXoQN5iaAzaZFIjke+pvOMTosOgVLMZQn7ywWAEPOeBeqTKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146745; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BaWEkE/BWcJXk8ia5UrTlYXw6SxjcgLpdtcGjmfmg0s=; b=DpC/zT3sQkLa0UNTGzUA6v2xasDo7T6Th63UPPB9pWe4KO1Mg9QF+p3CPdQpjEnCXaTpe45ltBMp52Lu5mjZTPXhazcou+cJoFS9fFn1uPQMEWG9DrHmCoPF+RW+PwV8gHPgnCBu0o8W4QODcQ7tyRBw9FHA1OsCZpoFNiLckLw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679146745628547.410220884202; Sat, 18 Mar 2023 06:39:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-592-b06ddqYbP2S7MwJVFIAOsQ-1; Sat, 18 Mar 2023 09:38:36 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B376101A551; Sat, 18 Mar 2023 13:38:34 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED81340C6E67; Sat, 18 Mar 2023 13:38:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D6EE31946A4B; Sat, 18 Mar 2023 13:38:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 74B331946595 for ; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 66FE2406AA68; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD2DD406AA66 for ; Sat, 18 Mar 2023 13:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BaWEkE/BWcJXk8ia5UrTlYXw6SxjcgLpdtcGjmfmg0s=; b=FAFxMqVeSVJejrA3Br/y7yFHktQA2/dD+c0w5hpcncdzvEXK4TUjfA8DRJTthQ6l4uoMzu YN5Vs7rqB+i+ZDogVJ4gNZfK7Xi6N5HTVA3SNOAMIgRA1wth6y1M1F7XzBbLjLhcJMlAkT u/uxd9rpMhfD/ZKs5pisw19zAi2P4wg= X-MC-Unique: b06ddqYbP2S7MwJVFIAOsQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 5/8] vbox: remove unreachable error in virVBoxSnapshotConfSaveVboxFile Date: Sat, 18 Mar 2023 14:38:24 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146746481100005 Both callers in the VirtualBox driver handle the error and only call this function with a non-NULL argument. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/vbox/vbox_snapshot_conf.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c index a6e5fad4d2..78fb360e1e 100644 --- a/src/vbox/vbox_snapshot_conf.c +++ b/src/vbox/vbox_snapshot_conf.c @@ -952,11 +952,6 @@ virVBoxSnapshotConfSaveVboxFile(virVBoxSnapshotConfMac= hine *machine, _("Machine is null")); goto cleanup; } - if (filePath =3D=3D NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Filepath is null")); - goto cleanup; - } xml =3D xmlNewDoc(BAD_CAST "1.0"); if (!xml) abort(); --=20 2.39.2 From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146745; cv=none; d=zohomail.com; s=zohoarc; b=Tq6i0Bc2C99d5V7DrNo4VhC4uKirAfzBr5IiiWXpj+At1XVDhRG2IVsj8+TanFT2BzHUqAnuCvAXSBsoG3P2Ka7duExv8Uv0no2YqLSfATHKrsgSjVLZ7kHxO/DsnQQ4mWwppJGLq5ZbdPQRjFsEDy1Je2VOdk8K9YLhTQvVM+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146745; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=t8EzCb/8v11L7HA5EZC8JqQqmhAYMzzuaTGEUmK71Xw=; b=NDcrs4UEukmSbTEVhRDEIvke1qMl7CN8xiA3EShaNE3STSCcA4tkvP0AVaS3utH/VzM+0anJJTM7/6aKwQHycQBFW8+q8k+tvJNCoZa8ceutKpnRInYj9RgmCGeBXKbV6xJtvrWCyKWbkf45o7tgk04K4X7OdjQtybFp9sef5hY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679146745949370.5955938686775; Sat, 18 Mar 2023 06:39:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251-gA78xaQrNjaC87G6QHyTmQ-1; Sat, 18 Mar 2023 09:38:39 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90B862A59552; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F27C406AA66; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6D5CD1946A4B; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 89EEE1946595 for ; Sat, 18 Mar 2023 13:38:33 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6D8AB406AA66; Sat, 18 Mar 2023 13:38:33 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9DED406AA67 for ; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146745; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=t8EzCb/8v11L7HA5EZC8JqQqmhAYMzzuaTGEUmK71Xw=; b=JLoWTqoMnqvsHqqx8RamvlS+g7l7Vfybk2OB7d9z+ia93jvfAcvC7+QejWFtIv5avSG3/y rrj4WDF1OVGKcg9eDjpNyUPCDJArX162MbAGOMMYPbYSXg0kyJ6ba25kBxz26ZngXpQVNP R81NjQPuqH1Ainv+vxE6Q5ZC8RZWokE= X-MC-Unique: gA78xaQrNjaC87G6QHyTmQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 6/8] util: xml: remove function names from error messages Date: Sat, 18 Mar 2023 14:38:25 +0100 Message-Id: <109b5adb1fcbad238b912cfede1c7e9fc0b5b154.1679146695.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146746483100006 The function name is already logged, and these can happen only as a result of a programmer error. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/util/virxml.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index c0789c062c..a84048e14a 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -864,7 +864,7 @@ virXPathBoolean(const char *xpath, =20 if ((ctxt =3D=3D NULL) || (xpath =3D=3D NULL)) { virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Invalid parameter to virXPathBoolean()")); + "%s", _("Invalid parameter")); return -1; } obj =3D xmlXPathEval(BAD_CAST xpath, ctxt); @@ -917,7 +917,7 @@ virXPathNode(const char *xpath, =20 if ((ctxt =3D=3D NULL) || (xpath =3D=3D NULL)) { virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Invalid parameter to virXPathNode()")); + "%s", _("Invalid parameter")); return NULL; } obj =3D xmlXPathEval(BAD_CAST xpath, ctxt); @@ -952,7 +952,7 @@ virXPathNodeSet(const char *xpath, =20 if ((ctxt =3D=3D NULL) || (xpath =3D=3D NULL)) { virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Invalid parameter to virXPathNodeSet()")); + "%s", _("Invalid parameter")); return -1; } =20 --=20 2.39.2 From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146727; cv=none; d=zohomail.com; s=zohoarc; b=GhCpOeZu2QhmzyNoIp/G7aMWiWjIIKzD9/hc36Vd0c7xdYFQGSNul9r+virV1gx0YSGvqdLcVBgIsv9Q2U7KgonVreDd7tNIeNsPlPEqL9VW1iyX1c4DVPSbR3m78Gz/cSu50Up0aAh0uLAzuVvE2zdWC/PNI7WzFdEPtPlkP7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146727; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ED5XQRpajtgMJI73vbTf322TI/JLsa34wHF72Vjsrec=; b=lS+yEjd1rZhndzpvWkpRdSKR5qnqfUorF5NNS9X9zIFq62/a+2yI5ohlNNiAgq7IQhzmvDXe7XYkmUYBzqVS6wIMPL8+COw5F5/ElI3t7nhbVsroXpbzdrRDNzmXxIf5QUSXPalV6XvOTurhLRUOIW0+GxPUra2J0p3SroMed+o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1679146727249130.6333263605444; Sat, 18 Mar 2023 06:38:47 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-99-vMMSfut0MFyybcxjoIJuzw-1; Sat, 18 Mar 2023 09:38:40 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4344B3813F54; Sat, 18 Mar 2023 13:38:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EBDB20267FB; Sat, 18 Mar 2023 13:38:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 183311946A50; Sat, 18 Mar 2023 13:38:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7C3521946A4B for ; Sat, 18 Mar 2023 13:38:34 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7320A406AA67; Sat, 18 Mar 2023 13:38:34 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id D09FF406AA66 for ; Sat, 18 Mar 2023 13:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146726; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ED5XQRpajtgMJI73vbTf322TI/JLsa34wHF72Vjsrec=; b=WPTMoQi4YZuaK8KjmoqO0kizfznWLLrdbcbCAbseAioz6b5936PcoBraXMPYSK3FaIXKIQ xs7GWNb9V9fb+M00/Mkgf/c57VEJOTBlhsVy2HNQq5kCIwG65rmEV+NK86xk2TvB7W1tx+ /eylPvRX+hcWieLMqsFvhDTVP0jF78k= X-MC-Unique: vMMSfut0MFyybcxjoIJuzw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 7/8] Unify error message when namespaces are unsupported Date: Sat, 18 Mar 2023 14:38:26 +0100 Message-Id: <71de74d00393076acd93cb5527c22c81347fc62a.1679146695.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146728475100001 Some helpers used a period at the end, others did not. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/qemu/qemu_namespace.c | 2 +- src/util/virprocess.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c index 89d631ee5a..ab50f47821 100644 --- a/src/qemu/qemu_namespace.c +++ b/src/qemu/qemu_namespace.c @@ -1392,7 +1392,7 @@ qemuNamespaceMknodPaths(virDomainObj *vm G_GNUC_UNUSE= D, bool *created G_GNUC_UNUSED) { virReportSystemError(ENOSYS, "%s", - _("Namespaces are not supported on this platform.= ")); + _("Namespaces are not supported on this platform"= )); return -1; } =20 diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 39ca5de811..9143edc868 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -708,7 +708,7 @@ int virProcessSetNamespaces(size_t nfdlist G_GNUC_UNUSE= D, int *fdlist G_GNUC_UNUSED) { virReportSystemError(ENOSYS, "%s", - _("Namespaces are not supported on this platform.= ")); + _("Namespaces are not supported on this platform"= )); return -1; } #endif @@ -1491,7 +1491,7 @@ int virProcessSetupPrivateMountNS(void) { virReportSystemError(ENOSYS, "%s", - _("Namespaces are not supported on this platform.= ")); + _("Namespaces are not supported on this platform"= )); return -1; } =20 @@ -1499,7 +1499,7 @@ int virProcessNamespaceAvailable(unsigned int ns G_GNUC_UNUSED) { virReportSystemError(ENOSYS, "%s", - _("Namespaces are not supported on this platform.= ")); + _("Namespaces are not supported on this platform"= )); return -1; } =20 --=20 2.39.2 From nobody Mon Dec 15 11:50:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146750; cv=none; d=zohomail.com; s=zohoarc; b=ceDscd6hd0gFafNR8wPQCTJI+nf2AIo8ZmMYOs7KbFRpddt5bGNIIQzJIvb0Mg9Mmg6tWT4lyrneYlfuPRTZ6tYwUYzPkkDgj7gCSJIcsb/85/1mlXwcjwlIRK8Jh/bJHlSEv2yau0QK+vE3zhBQbX/sU3wQ/APUnUk2hiEBius= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146750; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jKZKzRDdsmR/BAv1mZ3ijQHB62quW2b/5rEOxXPQmHI=; b=B8vg76ddImMSO7eItZcMS0R4hK4YlCqDNuTy43LasdhCkij+4nyVLYmwyhkvzWQi9Mrwby1gwKplO4p70DZXxbbapKqKDGnYqjSzkvtaB1w49eIam6vIu1rU/y3018C/ftzGTIR9lbWLCpq0Jb8eGgNA7f/MUuinPMomA+yER7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679146750629654.058748850603; Sat, 18 Mar 2023 06:39:10 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-85-lwCzaleHMGCaTmcmCfonyg-1; Sat, 18 Mar 2023 09:38:40 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3F4F1C075BB; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC4F540D1C9; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A19951946A66; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 610BE1946595 for ; Sat, 18 Mar 2023 13:38:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 46F65406AA67; Sat, 18 Mar 2023 13:38:35 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id D61DE406AA66 for ; Sat, 18 Mar 2023 13:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146749; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jKZKzRDdsmR/BAv1mZ3ijQHB62quW2b/5rEOxXPQmHI=; b=fAOZuEmVu+uXZxmEw/4Qgep38mL7VKzDdUjjo/RsnZZ9SXqP5UdUfHkqa3dZDRBDRigA2z pQ5MKEfwpvjT270jwEyT3TazAVmUA4147wD5mAwcYmJNITfbgvv7OHlGQhpnjutCV2HVCc uv9nDPC4jCOM1kFR/qUhFEkGyjT45bE= X-MC-Unique: lwCzaleHMGCaTmcmCfonyg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 8/8] vbox: unify "unable to get hard disk id" message Date: Sat, 18 Mar 2023 14:38:27 +0100 Message-Id: <37711f03caba818ad7b8b03c020fb077c80bd992.1679146695.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146752509100001 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/vbox/vbox_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 7aed421390..4a4b635fe2 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -5220,7 +5220,7 @@ vboxSnapshotRedefine(virDomainPtr dom, rc =3D gVBoxAPI.UIMedium.GetId(medium, &parentiid); if (NS_FAILED(rc)) { vboxReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to get hardDisk Id")); + _("Unable to get hard disk id")); goto cleanup; } gVBoxAPI.UIID.vboxIIDToUtf8(data, &parentiid, &parentUuid); @@ -6946,7 +6946,7 @@ vboxDomainSnapshotDeleteMetadataOnly(virDomainSnapsho= tPtr snapshot) rc =3D gVBoxAPI.UIMedium.GetId(medium, &parentiid); if (NS_FAILED(rc)) { vboxReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to get hardDisk Id")); + _("Unable to get hard disk id")); goto cleanup; } gVBoxAPI.UIID.vboxIIDToUtf8(data, &parentiid, &parentUuid); --=20 2.39.2