[libvirt PATCH 02/20] snapshot_conf: export virDomainSnapshotDiskDefClear

Pavel Hrdina posted 20 patches 1 year, 4 months ago
There is a newer version of this series
[libvirt PATCH 02/20] snapshot_conf: export virDomainSnapshotDiskDefClear
Posted by Pavel Hrdina 1 year, 4 months ago
We will need to call this function from qemu_snapshot when introducing
external snapshot revert support.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/conf/snapshot_conf.c | 2 +-
 src/conf/snapshot_conf.h | 3 +++
 src/libvirt_private.syms | 1 +
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index 9bf3c78353..1329292293 100644
--- a/src/conf/snapshot_conf.c
+++ b/src/conf/snapshot_conf.c
@@ -74,7 +74,7 @@ VIR_ENUM_IMPL(virDomainSnapshotState,
 );
 
 /* Snapshot Def functions */
-static void
+void
 virDomainSnapshotDiskDefClear(virDomainSnapshotDiskDef *disk)
 {
     VIR_FREE(disk->name);
diff --git a/src/conf/snapshot_conf.h b/src/conf/snapshot_conf.h
index 96c77ef42b..ad49990a1e 100644
--- a/src/conf/snapshot_conf.h
+++ b/src/conf/snapshot_conf.h
@@ -59,6 +59,9 @@ struct _virDomainSnapshotDiskDef {
     virStorageSource *src;
 };
 
+void
+virDomainSnapshotDiskDefClear(virDomainSnapshotDiskDef *disk);
+
 void
 virDomainSnapshotDiskDefFree(virDomainSnapshotDiskDef *disk);
 
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 245f258df4..dd752ba55c 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1039,6 +1039,7 @@ virDomainSnapshotDefFormat;
 virDomainSnapshotDefIsExternal;
 virDomainSnapshotDefNew;
 virDomainSnapshotDefParseString;
+virDomainSnapshotDiskDefClear;
 virDomainSnapshotDiskDefFree;
 virDomainSnapshotDiskDefParseXML;
 virDomainSnapshotFormatConvertXMLFlags;
-- 
2.39.2
Re: [libvirt PATCH 02/20] snapshot_conf: export virDomainSnapshotDiskDefClear
Posted by Peter Krempa 1 year, 3 months ago
On Mon, Mar 13, 2023 at 16:42:03 +0100, Pavel Hrdina wrote:
> We will need to call this function from qemu_snapshot when introducing
> external snapshot revert support.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/conf/snapshot_conf.c | 2 +-
>  src/conf/snapshot_conf.h | 3 +++
>  src/libvirt_private.syms | 1 +
>  3 files changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>