From nobody Sat Apr 27 22:53:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1678098128; cv=none; d=zohomail.com; s=zohoarc; b=P+cETgL0BjbUelIShvrkmUNWCgDB54R73VqCOMp+vZ+NJuI0H5YIEVb4XHhMz9/t82HXAAY6nAr5sowzOZEcO6ZBrF9H5+zQGyzGNRhfUYnh4xq93Z5UBQaeJV7Em4ODgrIXgskeesJ3gpvGSLi7nKMaqQb6ZUGenDiDMPqx5kM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678098128; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xOwbTs0qhD6fU3W3Icafp7c/ZW5rhQfvzxyg7LOF1JY=; b=cNWbkpIauP42Aq0y6H+y7wL4h6IsuMbzsJqsZBN8TCi4qJl4hakqcY7HuGuR/LeUzuJqaVDGzMal8maX6uWbk2qhV5KMORZrlcrYP3sUW1uvhU23UJQDyPRj34MBskU4+JmPZKIalu8KFDWAwo7Y6R5EXXlY1jaNQ95uARz+gzY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1678098128420484.527107124759; Mon, 6 Mar 2023 02:22:08 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-QwaE1cJhNuyKQUKzRXmJDw-1; Mon, 06 Mar 2023 05:22:02 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6547F185A7A4; Mon, 6 Mar 2023 10:21:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F039492B01; Mon, 6 Mar 2023 10:21:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B02AA19465B5; Mon, 6 Mar 2023 10:21:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3F27C1946586 for ; Mon, 6 Mar 2023 10:21:57 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 22D2314171C4; Mon, 6 Mar 2023 10:21:57 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B70414171C3 for ; Mon, 6 Mar 2023 10:21:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678098127; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xOwbTs0qhD6fU3W3Icafp7c/ZW5rhQfvzxyg7LOF1JY=; b=Sgcny0Ba5Fyq9GsjpaGh8FEZCp1mHRNl4iPx4jtYmzegWgjzJAK3l6bOh4qL4OWdCjnYpG oEGJkhSXV82uzRkAYzuw198uZsRTMdhjWnXfEidqOYuxFPGVvsaA4rNN6um4Gz7YssjyBf IRcngcMNYr5uWWx7N5hsqQzJgcb351U= X-MC-Unique: QwaE1cJhNuyKQUKzRXmJDw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/2] examples: systemtap: Warn users to properly update 'amd-sev-es-vmsa.stp' Date: Mon, 6 Mar 2023 11:21:53 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1678098128971100001 Content-Type: text/plain; charset="utf-8" The script references a very specific line in the kernel source code and thus may need to be updated to work properly. Add a warning into the comment and also print it to warn users. Signed-off-by: Peter Krempa --- examples/systemtap/amd-sev-es-vmsa.stp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/examples/systemtap/amd-sev-es-vmsa.stp b/examples/systemtap/am= d-sev-es-vmsa.stp index 551ed739b7..14bfb01c10 100644 --- a/examples/systemtap/amd-sev-es-vmsa.stp +++ b/examples/systemtap/amd-sev-es-vmsa.stp @@ -19,6 +19,9 @@ # A script that captures the VMSA blob for the boot vCPU and # first additional vCPU, when a KVM guest is booted with SEV-ES # +# NOTE: This directly references specific structures and places in the +# kernel source code. If the code changes this example will break. +# # The captured VMSA will be printed to the console in hex format, # and can be converted to the required binary format by feeding # it through @@ -27,6 +30,7 @@ # probe begin { + printf("WARNING: Make sure this script is updated according to your kern= el source!\n") printf("Running\n") } --=20 2.39.2 From nobody Sat Apr 27 22:53:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1678098192; cv=none; d=zohomail.com; s=zohoarc; b=AkfQo6IMdHUQHvaJytl1r9fHgKt6zhD/oSjtzmpeoIU6qSGGGRztz1sJCsHvq7XtNuvjsVFWBHY0bXIInN9P+NoB4R1l+gFvDqKGe/ZyaVl9ue5QSdPfUb5THcLHb1Y4BT4J8LPaeopRGW+RckZepu4KoYUqlMkvAqIvRUNDp2A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678098192; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hD9X//7n+hufXwd6bocS7zw+H6XB3DLdiMcnrD/BB/s=; b=TPO62sxQEUKmfA+NDKa3xwH7r9ILNp/awdzt7BaDEPKkYwp9Dd2NS5wTGtxjGG1D3V0LfgAka1JDKqmw+bTA0yVQCVnS1GzF61atRn971/n3CVUgyr/AnkK+reO5902Ms3BPSPiZeFZZY628/+AlW/QUEqMe275otPcRAS4eswA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1678098192108501.501190776208; Mon, 6 Mar 2023 02:23:12 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-OKGSNGDTPUK8rcE4-K6nhg-1; Mon, 06 Mar 2023 05:22:03 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 11F0729AA3B2; Mon, 6 Mar 2023 10:22:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFC921121314; Mon, 6 Mar 2023 10:22:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E6771194658C; Mon, 6 Mar 2023 10:22:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1E2131946586 for ; Mon, 6 Mar 2023 10:21:58 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0106A1400B19; Mon, 6 Mar 2023 10:21:58 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 786E114171C3 for ; Mon, 6 Mar 2023 10:21:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678098190; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hD9X//7n+hufXwd6bocS7zw+H6XB3DLdiMcnrD/BB/s=; b=D7UfDhUpdujEao3jiSEJ/5sR2SW7GCCOJlKco9CkunXiznoK7CyGlRucjRl1NS0zaJMaMV wT2pwJkX/69648TDRVyjKL9gk2fUX3raZ6w+m+GPczp2qVnmjWf/6Wqw7lah20i82wZec/ LGR+gci7kyy5yqfyVVUVxn/OA9ldpPI= X-MC-Unique: OKGSNGDTPUK8rcE4-K6nhg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/2] examples: systemtap: Update to linux-6.3 Date: Mon, 6 Mar 2023 11:21:54 +0100 Message-Id: <509dd70a7cacdccb430387e423e35b6b64515db2.1678098056.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1678098193377100001 Content-Type: text/plain; charset="utf-8" The 'vmsa' struct was moved out of 'struct vcpu_svm' in linux commit: commit b67a4cc35c9f726999fa29880713ce72d4e39e8d Author: Peter Gonda Date: Thu Oct 21 10:42:59 2021 -0700 KVM: SEV: Refactor out sev_es_state struct Move SEV-ES vCPU metadata into new sev_es_state struct from vcpu_svm. Also update the line reference for linux-6.3. NB: I strongly considered removing the example as it's impossible to keep in sync. With the warning added by previous commit I think we can give it one more chance. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2175598 Signed-off-by: Peter Krempa --- examples/systemtap/amd-sev-es-vmsa.stp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/systemtap/amd-sev-es-vmsa.stp b/examples/systemtap/am= d-sev-es-vmsa.stp index 14bfb01c10..ab2f202681 100644 --- a/examples/systemtap/amd-sev-es-vmsa.stp +++ b/examples/systemtap/amd-sev-es-vmsa.stp @@ -46,7 +46,7 @@ function dump_vmsa(addr:long) { # is the one beween the call to clflush_cache_range(...) and the # call to sev_issue_cmd(kvm, SEV_CMD_LAUNCH_UPDATE...). # -# Line 632 is correct for Linux v6.0 -probe module("kvm_amd").statement("__sev_launch_update_vmsa@arch/x86/kvm/s= vm/sev.c:632") { - dump_vmsa($svm->vmsa) +# Line 635 is correct for Linux v6.3 +probe module("kvm_amd").statement("__sev_launch_update_vmsa@arch/x86/kvm/s= vm/sev.c:635") { + dump_vmsa($svm->sev_es->vmsa) } --=20 2.39.2