[PATCH 0/6] qemuBuildHostNetProps: Properly handle unsupported netdevs and remove virJSONValueObjectAppendStringPrintf

Peter Krempa posted 6 patches 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1678094352.git.pkrempa@redhat.com
src/libvirt_private.syms |   1 -
src/qemu/qemu_command.c  | 113 +++++++++++++++++++++++++--------------
src/util/virjson.c       |  17 ------
src/util/virjson.h       |   6 ---
4 files changed, 74 insertions(+), 63 deletions(-)
[PATCH 0/6] qemuBuildHostNetProps: Properly handle unsupported netdevs and remove virJSONValueObjectAppendStringPrintf
Posted by Peter Krempa 1 year ago
First patch fixes a crasher if unsupported network device is used and
subsequently virJSONValueObjectAppendStringPrintf is removed.

Peter Krempa (6):
  qemuBuildHostNetProps: Report proper errors for unhandled interface
    types
  qemuBuildHostNetProps: Don't use virJSONValueObjectAppendStringPrintf
    to format address
  qemuBuildChannelGuestfwdNetdevProps: Don't use
    virJSONValueObjectAppendStringPrintf
  qemuBuildHostNetProps: Append ipv6 address using virJSONValueObjectAdd
  qemuBuildHostNetProps: Append aliases without
    virJSONValueObjectAppendStringPrintf
  util: json: Remove unused virJSONValueObjectAppendStringPrintf

 src/libvirt_private.syms |   1 -
 src/qemu/qemu_command.c  | 113 +++++++++++++++++++++++++--------------
 src/util/virjson.c       |  17 ------
 src/util/virjson.h       |   6 ---
 4 files changed, 74 insertions(+), 63 deletions(-)

-- 
2.39.2
Re: [PATCH 0/6] qemuBuildHostNetProps: Properly handle unsupported netdevs and remove virJSONValueObjectAppendStringPrintf
Posted by Ján Tomko 1 year ago
On a Monday in 2023, Peter Krempa wrote:
>First patch fixes a crasher if unsupported network device is used and
>subsequently virJSONValueObjectAppendStringPrintf is removed.
>
>Peter Krempa (6):
>  qemuBuildHostNetProps: Report proper errors for unhandled interface
>    types
>  qemuBuildHostNetProps: Don't use virJSONValueObjectAppendStringPrintf
>    to format address
>  qemuBuildChannelGuestfwdNetdevProps: Don't use
>    virJSONValueObjectAppendStringPrintf
>  qemuBuildHostNetProps: Append ipv6 address using virJSONValueObjectAdd
>  qemuBuildHostNetProps: Append aliases without
>    virJSONValueObjectAppendStringPrintf
>  util: json: Remove unused virJSONValueObjectAppendStringPrintf
>
> src/libvirt_private.syms |   1 -
> src/qemu/qemu_command.c  | 113 +++++++++++++++++++++++++--------------
> src/util/virjson.c       |  17 ------
> src/util/virjson.h       |   6 ---
> 4 files changed, 74 insertions(+), 63 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano