From nobody Thu May 2 21:38:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677767914; cv=none; d=zohomail.com; s=zohoarc; b=OptDU69BHH/MuME95OCF7C00aZ1NXqi56RxJhhZCDfjj5dpdEaLJ/fyIlUCMCBu0W1BQ9b273pZAALWZazTcoefBYaZnmHu1GT4MXLKcoIE01taMDU4bCWNUxZHkGQxrxTJKL1KkyKu8V95OHYCxLWn1sJQle6aBYt4xE5hlFnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677767914; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b1Qn4FArWmV/RMLWp2+jwAIIZfQjwO1tNw67OyyO4Bg=; b=kaMI6b33uhIO9ufvTgJB9TdHwZgZUdzt3+nTL6abEe/XCFZppWHfzQVLqh5nZgNniVg0U3hdkvqkYa0GdL5lbJG5Cb4FSTuErE+BSkBqz5yplkK/Ndvpr5UVRq2pHAV8BwEC0y7uWEWcvwTpFCFoF/A1kTjdMYFPDos5Vg3xF24= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1677767914263769.9444406496165; Thu, 2 Mar 2023 06:38:34 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-370-nWaSCyBcPw6hqzQXRhGgIQ-1; Thu, 02 Mar 2023 09:38:25 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B092D802DD4; Thu, 2 Mar 2023 14:38:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E71B492B00; Thu, 2 Mar 2023 14:38:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8D9F219452D0; Thu, 2 Mar 2023 14:38:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 533E719452CD for ; Thu, 2 Mar 2023 14:38:07 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 38EE214171FF; Thu, 2 Mar 2023 14:38:07 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DB77140EBF6 for ; Thu, 2 Mar 2023 14:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677767913; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=b1Qn4FArWmV/RMLWp2+jwAIIZfQjwO1tNw67OyyO4Bg=; b=N4bVwi/FUT9RQ2d5+qD9YckAnI5KB3B00J5oIcjv8ynzup6Snc+x4N2fAtNymnN3p+akTA LgJCqmssMUV5DKnPC1cOaK6bCxGnQ8R0I6Eq9aEvyHR9Cmsuf7z87WPz1M+qfY/GxEFtmc YYRDRUp4v2oL8BclCACrDZ618NyCJkw= X-MC-Unique: nWaSCyBcPw6hqzQXRhGgIQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/21] conf: virDomainDiskDefDriverParseXML: Drop unused XPath infrastructure Date: Thu, 2 Mar 2023 15:37:43 +0100 Message-Id: <9e1eaa33521cb7d388dc74379a8578c30602c0af.1677767499.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677767915259100001 Content-Type: text/plain; charset="utf-8" The function doesn't use XPath at all. Don't pass the context to it. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 39ddfb7db0..ad2b44b610 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7743,13 +7743,8 @@ virDomainDiskDefGeometryParse(virDomainDiskDef *def, static int virDomainDiskDefDriverParseXML(virDomainDiskDef *def, - xmlNodePtr cur, - xmlXPathContextPtr ctxt) + xmlNodePtr cur) { - VIR_XPATH_NODE_AUTORESTORE(ctxt) - - ctxt->node =3D cur; - def->driverName =3D virXMLPropString(cur, "name"); if (virXMLPropEnum(cur, "cache", virDomainDiskCacheTypeFromString, @@ -8037,7 +8032,7 @@ virDomainDiskDefParseXML(virDomainXMLOption *xmlopt, if (virDomainVirtioOptionsParseXML(driverNode, &def->virtio) < 0) return NULL; - if (virDomainDiskDefDriverParseXML(def, driverNode, ctxt) < 0) + if (virDomainDiskDefDriverParseXML(def, driverNode) < 0) return NULL; if (virDomainDiskDefDriverSourceParseXML(def->src, driverNode, ctx= t) < 0) --=20 2.39.2 From nobody Thu May 2 21:38:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677767899; cv=none; d=zohomail.com; s=zohoarc; b=hkZjUnOxVjGfjb/fje15yhWSPjg25WC8hgb6tvKZPOjOM8jWjvjb4AvfB0kahB7iFYkxod2nUNSoYxdGOj9/AQtq2sijkCQCsrNAycHx6LZvKGGsJFJhTck1/mmlYOSDRqEuaW/xeoosF3P2rtp8uRE1JUo6+ycuOVluIHYuN+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677767899; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MQq7ohm0MkfTsVUIyEw/gsl28fASVCqagvRBqy6GQEU=; b=h0+LdQNTkAuqWct1FU3KI1JRz9A+d8Aya1Sn5o3d1f2ZeLuuUlLUKXNLLgzWEBG4Xi2N4Iaj+KjlWeONCW2k4DYH5JyNBbpMK3c1Qar4knaqqUht/FG2mg1TyvWCmMcDE0AlNMWTp8e7c+s8DJps9353fC2IhKEFFuYyiRnw0sM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1677767899453955.2067157355451; Thu, 2 Mar 2023 06:38:19 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-S8C0jP6XPEWqe63SSt0yNw-1; Thu, 02 Mar 2023 09:38:14 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C21563C218B7; Thu, 2 Mar 2023 14:38:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD7C740C83B6; Thu, 2 Mar 2023 14:38:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 98B8419452CE; Thu, 2 Mar 2023 14:38:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4785D19452CE for ; Thu, 2 Mar 2023 14:38:08 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 39E9614171FF; Thu, 2 Mar 2023 14:38:08 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1440140EBF6 for ; Thu, 2 Mar 2023 14:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677767898; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MQq7ohm0MkfTsVUIyEw/gsl28fASVCqagvRBqy6GQEU=; b=XUuWIy3j4B2nj9aCURnuq3Sl+LXTSLZMLLiIBklEOT2H6oAQvTdAVhG6SxhWZXp2OfNLn6 SfJ7EDMV8PPHC2VGNbfS6fSYzNeJVPnNiaZIEk956ByHpjkRsK++f96wVKNwNirIIyxL4u MUYCc00yqcjxq4l8Smq9PyNl3XbwZjU= X-MC-Unique: S8C0jP6XPEWqe63SSt0yNw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 02/21] qemuxml2argvtest: Remove 'iothreads-nocap' Date: Thu, 2 Mar 2023 15:37:44 +0100 Message-Id: <995b0077752ac98e21e1f7b09c5771bf5c355644.1677767499.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677767901161100002 Content-Type: text/plain; charset="utf-8" All supported QEMU versions now support iothreads thus upcoming patches will be removing the capability checks. Remove the 'iothreads-nocap' case which will become invalid. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/iothreads-nocap.err | 1 - tests/qemuxml2argvdata/iothreads-nocap.xml | 37 ---------------------- tests/qemuxml2argvtest.c | 1 - 3 files changed, 39 deletions(-) delete mode 100644 tests/qemuxml2argvdata/iothreads-nocap.err delete mode 100644 tests/qemuxml2argvdata/iothreads-nocap.xml diff --git a/tests/qemuxml2argvdata/iothreads-nocap.err b/tests/qemuxml2arg= vdata/iothreads-nocap.err deleted file mode 100644 index ed2f47ecd5..0000000000 --- a/tests/qemuxml2argvdata/iothreads-nocap.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: IOThreads not supported for this QEMU diff --git a/tests/qemuxml2argvdata/iothreads-nocap.xml b/tests/qemuxml2arg= vdata/iothreads-nocap.xml deleted file mode 100644 index fa04d735cd..0000000000 --- a/tests/qemuxml2argvdata/iothreads-nocap.xml +++ /dev/null @@ -1,37 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 2 - 4 - - - - - - - - - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu-system-i386 - - - - -
- - - - - - - diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 5a33c336c8..1956e6da08 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1887,7 +1887,6 @@ mymain(void) DO_TEST("iothreads-ids", QEMU_CAPS_OBJECT_IOTHREAD); DO_TEST("iothreads-ids-partial", QEMU_CAPS_OBJECT_IOTHREAD); DO_TEST_CAPS_LATEST("iothreads-ids-pool-sizes"); - DO_TEST_FAILURE_NOCAPS("iothreads-nocap"); DO_TEST("iothreads-disk", QEMU_CAPS_OBJECT_IOTHREAD); DO_TEST_CAPS_ARCH_VER("iothreads-disk-virtio-ccw", "s390x", "4.2.0"); DO_TEST_CAPS_VER("iothreads-virtio-scsi-pci", "5.2.0"); --=20 2.39.2 From nobody Thu May 2 21:38:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677768156; cv=none; d=zohomail.com; s=zohoarc; b=f0o7ffNNvkiY+k84akBwKxc4240nZ3miNfSc/i8rjbjtGZViYEdYMMNtOMSTAWAZfM5MY08opvyEDHNRUMXvel6/jyH5vuM41cLR1uPNm23PBSQ7CIS9IILjG+DzgdIOkYefrYWTwTD1jIt97QHo09elcsQge0upPpAj0Q9fKxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677768156; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=K0VnVXXWNIKGgklEnUqs/qctAbbX0+Xc5ZUd6O5OqSI=; b=idfjvF1CWVBnrw9fOaTwQYfRPrWjznf0xnKETVeZJVWnvHXKy04BmILjaze0m6/0rB3iHX3O+ZYw5T0zhROWOyZoKbBO2O+FP6FEXP2dWO1t/v975QlcNOI8pynQq8udKJMUQTMoQ0PPyzbQGHKdr7nC6QRNKRLdvkNs08tj+pA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1677768156367330.2008938878988; Thu, 2 Mar 2023 06:42:36 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-PPfO-_OcPZCQZRhyy0xKEw-1; Thu, 02 Mar 2023 09:41:58 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 280F6100F909; Thu, 2 Mar 2023 14:38:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1445851FF; Thu, 2 Mar 2023 14:38:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CC82619452CE; Thu, 2 Mar 2023 14:38:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5FC0F19452CD for ; Thu, 2 Mar 2023 14:38:09 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 45CC61417203; Thu, 2 Mar 2023 14:38:09 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D38D14171FF for ; Thu, 2 Mar 2023 14:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677768154; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=K0VnVXXWNIKGgklEnUqs/qctAbbX0+Xc5ZUd6O5OqSI=; b=dP8uZdouIRL5EWc6z3VzDCuNP48ib7RsMZdVxKM1bXDRplrFMmHEiOFrcZERT5eMJk+Ssh PxdcEY+vH7TN/lW0v0HN7gzTWBKw+R4wZSMgvGTm4/IyLJt4XYY6zsjSe4gstkOFP9x8gb 60k9wcpfdvaedUt0tTGFBfq5DBAp/20= X-MC-Unique: PPfO-_OcPZCQZRhyy0xKEw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 03/21] qemuxml2(argv|xml)test: Remove 'iothreads' case Date: Thu, 2 Mar 2023 15:37:45 +0100 Message-Id: <789c4a7f4e2ffba568ef934b8230e81341bf9cb6.1677767499.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677768156707100001 Content-Type: text/plain; charset="utf-8" 'iothreads-disk' covers everything that 'iothreads' did in addition to actually using the iothread. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/iothreads.args | 35 ------------------------- tests/qemuxml2argvdata/iothreads.xml | 31 ---------------------- tests/qemuxml2argvtest.c | 1 - tests/qemuxml2xmloutdata/iothreads.xml | 36 -------------------------- tests/qemuxml2xmltest.c | 1 - 5 files changed, 104 deletions(-) delete mode 100644 tests/qemuxml2argvdata/iothreads.args delete mode 100644 tests/qemuxml2argvdata/iothreads.xml delete mode 100644 tests/qemuxml2xmloutdata/iothreads.xml diff --git a/tests/qemuxml2argvdata/iothreads.args b/tests/qemuxml2argvdata= /iothreads.args deleted file mode 100644 index 88e6fa4906..0000000000 --- a/tests/qemuxml2argvdata/iothreads.args +++ /dev/null @@ -1,35 +0,0 @@ -LC_ALL=3DC \ -PATH=3D/bin \ -HOME=3D/tmp/lib/domain--1-QEMUGuest1 \ -USER=3Dtest \ -LOGNAME=3Dtest \ -XDG_DATA_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.local/share \ -XDG_CACHE_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.cache \ -XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.config \ -/usr/bin/qemu-system-i386 \ --name guest=3DQEMUGuest1,debug-threads=3Don \ --S \ --object secret,id=3DmasterKey0,format=3Draw,file=3D/tmp/lib/domain--1-QEMU= Guest1/master-key.aes \ --machine pc,usb=3Doff,dump-guest-core=3Doff \ --accel tcg \ --m 214 \ --overcommit mem-lock=3Doff \ --smp 2,sockets=3D2,cores=3D1,threads=3D1 \ --object iothread,id=3Diothread1 \ --object iothread,id=3Diothread2 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --display none \ --no-user-config \ --nodefaults \ --chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ --mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ --rtc base=3Dutc \ --no-shutdown \ --no-acpi \ --boot strict=3Don \ --usb \ --blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","no= de-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"raw= ","file":"libvirt-1-storage"}' \ --device ide-hd,bus=3Dide.0,unit=3D0,drive=3Dlibvirt-1-format,id=3Dide0-0-0= ,bootindex=3D1 \ --audiodev '{"id":"audio1","driver":"none"}' \ --msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/iothreads.xml b/tests/qemuxml2argvdata/= iothreads.xml deleted file mode 100644 index 1c860ddd25..0000000000 --- a/tests/qemuxml2argvdata/iothreads.xml +++ /dev/null @@ -1,31 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 2 - 2 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu-system-i386 - - - - -
- - - - - - - - - diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 1956e6da08..5db882a142 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1883,7 +1883,6 @@ mymain(void) DO_TEST_NOCAPS("smp"); DO_TEST("smp-dies", QEMU_CAPS_SMP_DIES); - DO_TEST("iothreads", QEMU_CAPS_OBJECT_IOTHREAD); DO_TEST("iothreads-ids", QEMU_CAPS_OBJECT_IOTHREAD); DO_TEST("iothreads-ids-partial", QEMU_CAPS_OBJECT_IOTHREAD); DO_TEST_CAPS_LATEST("iothreads-ids-pool-sizes"); diff --git a/tests/qemuxml2xmloutdata/iothreads.xml b/tests/qemuxml2xmloutd= ata/iothreads.xml deleted file mode 100644 index 17e5f8bce1..0000000000 --- a/tests/qemuxml2xmloutdata/iothreads.xml +++ /dev/null @@ -1,36 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 2 - 2 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu-system-i386 - - - - -
- - -
- - -
- - - - -