From nobody Fri Apr 26 00:47:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669278127; cv=none; d=zohomail.com; s=zohoarc; b=TsGhMvuZ/9l3JMdkqKUdHKHH/uDHNs9PuHPjwQl5d9+uIaLQrwtN4jE+QAtwPMxRjBA24T9K0GhdkUqn+n6Cb8CHgUyziMTWHqRxNtra9l6iWMsX95Vj+HVhRrzOe86wiNazexD1ZYIXNT2WY2vVQz4wFgygRDb4j5pwYqOpqR0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669278127; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/zKfkgEn98WSeUAoyfZl7lkB9bEgTm6m4QWkFv1EqjU=; b=AZ/pKh79kH/VacUBJAE2DtgyXV7/oXH83LpT7WBr6f9sLwEiEObHFHtDJcXfXauGi5szkxQyvEMx4zreUOctD517bMu4442K2UZ72PvOWnlBHvJns2xWhYrqmLgmSHdVVaSAU47yjnWu2gA0Gc09FeVr/7mBDcqdh89mpgLnF84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1669278127196478.875860758827; Thu, 24 Nov 2022 00:22:07 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-J7elqkDVPPWGd8pCa-6HQw-1; Thu, 24 Nov 2022 03:21:19 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 243432833B1C; Thu, 24 Nov 2022 08:21:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F8F04A9254; Thu, 24 Nov 2022 08:21:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7A25A1946A41; Thu, 24 Nov 2022 08:21:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 70A6F1946587 for ; Thu, 24 Nov 2022 08:21:12 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 55FC0111E3F8; Thu, 24 Nov 2022 08:21:12 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE0AD111E3EB for ; Thu, 24 Nov 2022 08:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669278126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/zKfkgEn98WSeUAoyfZl7lkB9bEgTm6m4QWkFv1EqjU=; b=c2su0+eZAvy5AGyuhm32rLRiTi5P4mWt2TDDhP2LQpTsdevBvc+CZRInT7iIaNqs5rAY9u e7JrtUer9xRNvDm8585WakgnRzO/FKGiiQK/gnALLtlf8T6dtMiKSzgcv47VJs2b9g7c0k mKvFyuGB/YhDKTzmVIyocMs0YFnTLjM= X-MC-Unique: J7elqkDVPPWGd8pCa-6HQw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/2] virsh: Format -V output properly Date: Thu, 24 Nov 2022 09:21:08 +0100 Message-Id: <119effe9362d09cc157b7b4a22829108983fe004.1669278033.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669278128767100001 Content-Type: text/plain; charset="utf-8"; x-default="true" When displaying long version (virsh -V), the 'Virtuozzo Storage' substring lacks leading space and thus produces awful output. Signed-off-by: Michal Privoznik Reviewed-by: Jiri Denemark --- tools/virsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.c b/tools/virsh.c index 5696941550..ad11f4a9ac 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -586,7 +586,7 @@ virshShowVersion(vshControl *ctl G_GNUC_UNUSED) vshPrint(ctl, " ZFS"); #endif #ifdef WITH_STORAGE_VSTORAGE - vshPrint(ctl, "Virtuozzo Storage"); + vshPrint(ctl, " Virtuozzo Storage"); #endif vshPrint(ctl, "\n"); =20 --=20 2.37.4 From nobody Fri Apr 26 00:47:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669278085; cv=none; d=zohomail.com; s=zohoarc; b=nIGzubDliOqIZcJCXAiHAXHF1nNPd2wJNmBrnsvO+NpiBE/4wUZIs8lVdpaBQeIBtG16td6uD5qVwMR/D9x543358Xb6jrct9x6lFO2DB7JP1n8wXVPNYkLTNF35a2hSx4AJNYzles1swi3mtikuWA9w2AnZLOj0ffZObjLC1sw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669278085; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8g/qw4aKrQ9ndD9lCd5pPj8hey2LOIVlpfHJ8b1gDZs=; b=i/pZ+a+7ZbL1m5WpPwaw1mAJ6EJXAwGyIdJ2eCLKKeJ5uzJBHzGcdvl/nVPNX/vBZAM/yE8fvVC5N/3rRZycF6y6pU2g756x6uPEP5euytPRI986B2u4H3/GZSfIIMu2ZY5Ou8h+mLVeVYIJV3CFi35KHwuxACQ7xvoazzrYWTc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1669278085042171.61847456387602; Thu, 24 Nov 2022 00:21:25 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-y7cjk93SOn-ve6v8c9qj8A-1; Thu, 24 Nov 2022 03:21:18 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2454C857FB0; Thu, 24 Nov 2022 08:21:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 17E8940C83DD; Thu, 24 Nov 2022 08:21:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EC3CA1946595; Thu, 24 Nov 2022 08:21:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 02F621946587 for ; Thu, 24 Nov 2022 08:21:13 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EA592111E3EB; Thu, 24 Nov 2022 08:21:12 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F31D111E3F8 for ; Thu, 24 Nov 2022 08:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669278083; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8g/qw4aKrQ9ndD9lCd5pPj8hey2LOIVlpfHJ8b1gDZs=; b=LzYz247ntNIbh9mDPgT3OJdjUbOJfj2FqMxaz68xVxc6D89UmKTS1bhKkCRMRpnvOGKlN2 9rX/TR9D+K5s+U+xEXEJbV2RP8PzAWOr7zztiAY3yc2SaPi+3x+yu+RnTEBuRmQox65PIA 5MBa5I9pzNHbyaHbh6YBSC/xrj/7wGA= X-MC-Unique: y7cjk93SOn-ve6v8c9qj8A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/2] virsh: Report iSCSI-direct backend in long version Date: Thu, 24 Nov 2022 09:21:09 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669278086639100001 Content-Type: text/plain; charset="utf-8"; x-default="true" We already report whether iSCSI backend was enabled at compile time, but we don't do the same with iSCSI-direct backend. Signed-off-by: Michal Privoznik Reviewed-by: Jiri Denemark --- tools/virsh.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index ad11f4a9ac..8de85f2516 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -573,6 +573,9 @@ virshShowVersion(vshControl *ctl G_GNUC_UNUSED) #ifdef WITH_STORAGE_ISCSI vshPrint(ctl, " iSCSI"); #endif +#ifdef WITH_STORAGE_ISCSI_DIRECT + vshPrint(ctl, " iSCSI-direct"); +#endif #ifdef WITH_STORAGE_LVM vshPrint(ctl, " LVM"); #endif --=20 2.37.4