[PATCH 0/7] Couple of miscellaneous cleanups

Michal Privoznik posted 7 patches 2 weeks, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1668589451.git.mprivozn@redhat.com
docs/coding-style.rst  | 42 ++++++++++++++++++++++++++++--------
src/conf/domain_conf.c | 48 ++++++++++++++++++++++++------------------
src/conf/domain_conf.h |  2 ++
src/internal.h         |  2 ++
src/vmx/vmx.c          | 11 +++++-----
5 files changed, 71 insertions(+), 34 deletions(-)
[PATCH 0/7] Couple of miscellaneous cleanups
Posted by Michal Privoznik 2 weeks, 4 days ago
There's this request for us to parse NVDIMMs from .vmx files. Well,
we're not there yet - firstly we'd need to deduce NUMA configuration so
that we know to which guest NUMA node is the NVDIMM attached. But that
is very dynamic and in fact computed on virtual machine startup [1].

Nevertheless, I've accumulated couple of cleanups that are independent
of the feature and can be merged separately.

1: https://frankdenneman.nl/2016/08/22/numa-deep-dive-part-5-esxi-vmkernel-numa-constructs/

Michal Prívozník (7):
  coding-style: Follow our own recommendation wrt spacing around commas
  docs: Fill missing docs on STRCASEPREFIX() and STRSKIP()
  internal: Introduce STRCASESKIP()
  vmx: Convert virVMXConfigScanResultsCollector() to use STRCASESKIP()
  vmx: Rework virVMXConfigScanResultsCollector slightly
  conf: Introduce virDomainMemoryDefNew()
  conf: Declare and use autoptr for virDomainMemoryDef

 docs/coding-style.rst  | 42 ++++++++++++++++++++++++++++--------
 src/conf/domain_conf.c | 48 ++++++++++++++++++++++++------------------
 src/conf/domain_conf.h |  2 ++
 src/internal.h         |  2 ++
 src/vmx/vmx.c          | 11 +++++-----
 5 files changed, 71 insertions(+), 34 deletions(-)

-- 
2.37.4

Re: [PATCH 0/7] Couple of miscellaneous cleanups
Posted by Tim Wiederhake 2 weeks, 4 days ago
On Wed, 2022-11-16 at 10:11 +0100, Michal Privoznik wrote:
> There's this request for us to parse NVDIMMs from .vmx files. Well,
> we're not there yet - firstly we'd need to deduce NUMA configuration
> so
> that we know to which guest NUMA node is the NVDIMM attached. But
> that
> is very dynamic and in fact computed on virtual machine startup [1].
> 
> Nevertheless, I've accumulated couple of cleanups that are
> independent
> of the feature and can be merged separately.
> 
> 1:
> https://frankdenneman.nl/2016/08/22/numa-deep-dive-part-5-esxi-vmkernel-numa-constructs/
> 
> Michal Prívozník (7):
>   coding-style: Follow our own recommendation wrt spacing around
> commas
>   docs: Fill missing docs on STRCASEPREFIX() and STRSKIP()
>   internal: Introduce STRCASESKIP()
>   vmx: Convert virVMXConfigScanResultsCollector() to use
> STRCASESKIP()
>   vmx: Rework virVMXConfigScanResultsCollector slightly
>   conf: Introduce virDomainMemoryDefNew()
>   conf: Declare and use autoptr for virDomainMemoryDef
> 
>  docs/coding-style.rst  | 42 ++++++++++++++++++++++++++++--------
>  src/conf/domain_conf.c | 48 ++++++++++++++++++++++++----------------
> --
>  src/conf/domain_conf.h |  2 ++
>  src/internal.h         |  2 ++
>  src/vmx/vmx.c          | 11 +++++-----
>  5 files changed, 71 insertions(+), 34 deletions(-)
> 

Reviewed-by: Tim Wiederhake <twiederh@redhat.com>