From nobody Tue Apr 30 17:01:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665746937; cv=none; d=zohomail.com; s=zohoarc; b=c/kNyyozKfGWjk9vKu1+PxKEeGPgy3acCXEPGhjX61lfOUpokQSQ0XZ1KAfU0kVWfLgD7w+nZjls/e94D2TMFb8/fs0xbxNeXAfHrnVNpNJqJXTu5+VokVIcqofHIfIy+wxt+PPm06cPDUbBf6hafzWlQl4ymTkzBF32Bz7jT2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665746937; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/A3oDWUhAPFv0dzHDAFanFmG4+76Rb4CDZVfsj77qkU=; b=Txafa9gUp2UJdrnLdTUKSgfVX7XvYfp4J7ml0bBT+aMo6eOD9YWbwFDlU97c6mKJeY23MUBCkwfeQj6OgHLNqEU01slsMKhAUmtFKIlfBH4TnLDLa7coKtOHO9lizGVtW1b7ZvbshWtoE+f2DzsEvdF2M4PimGnkXzPePS6qcTQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1665746937495555.3390668905416; Fri, 14 Oct 2022 04:28:57 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-425-rLYAn1LnMZC57jplDTYETw-1; Fri, 14 Oct 2022 07:28:51 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44134382F1A0; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2FF861402158; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 200301946589; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 497931946588 for ; Fri, 14 Oct 2022 11:28:47 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 1F3A1208DDBC; Fri, 14 Oct 2022 11:28:47 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C488207B31A; Fri, 14 Oct 2022 11:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665746935; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/A3oDWUhAPFv0dzHDAFanFmG4+76Rb4CDZVfsj77qkU=; b=bGj5hKzcgDonEzSPOOaRItQTog3TQbCLF6UzMHu8wPsXaRyx1nZVJAz7JPYFA6+a8uFgVY L++2GjW7wZmWsja2tz/Ox23c69GR0UydlpDB4miK3bejeSj40AmNXw9xSgO4Pti7pnE5Qi mgtjlGiAPDUcP4/uI5libEphqStefYY= X-MC-Unique: rLYAn1LnMZC57jplDTYETw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 1/7] ci: integration: Add virtnetworkd to the list of restarted services Date: Fri, 14 Oct 2022 13:28:39 +0200 Message-Id: <6ac12b36a9ac0d3457b5eca6b8a03ab53c29d31e.1665746914.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665746939381100003 Content-Type: text/plain; charset="utf-8"; x-default="true" It was missing from the set. While at it, order the daemon set alphabetically. Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration-template.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index acb51a0b27..4ca8a0bb24 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -39,9 +39,9 @@ - if test "$ID" =3D "centos" && test "$VERSION_ID" -lt 9 || test "$ID" =3D "fedora" && test "$VERSION_ID" -lt 35; then - DAEMONS=3D"libvirtd virtlogd virtlockd"; + DAEMONS=3D"libvirtd virtlockd virtlogd"; else - DAEMONS=3D"virtproxyd virtqemud virtinterfaced virtsecretd virtstora= ged virtnwfilterd virtnodedevd virtlogd virtlockd"; + DAEMONS=3D"virtinterfaced virtlockd virtlogd virtnetworkd virtnodede= vd virtnwfilterd virtproxyd virtqemud virtsecretd virtstoraged"; fi - for daemon in $DAEMONS; do --=20 2.37.3 From nobody Tue Apr 30 17:01:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665746944; cv=none; d=zohomail.com; s=zohoarc; b=I7EPSOYzq/QDs9si3Lhekkoy51+VEpCeq8xAtP+kgcL02/hCOEq5oM7fOVXyXxydm4pBF+Qawcr4P4RNw62pY5CoDINKMeR2iVgYvWC1vbr7dCegPN4U+vWgcOel2HK1uecX0st8EN7Mx1xaZQCTT96eC5Kw0Pxsg+7NN9nV72I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665746944; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0YDCo8uOpCkWx9YICJMAVei+TmaqDiT4Kw99Cnvz5AQ=; b=hg6kCuFu9IldlTaONkz0K8ublcQNNixsSjwe4JAHo6QZ5FV13GnojuZBMofLyl3lorFeDHFYuLe4x+VvEDuFtICPfbOwTLdTnhd+G/y11xKuoMBPxDrxQZeBcH3xxF9N+2fg4OxTOag2wmZAUyjfk2qS9Xy8KOlH7SUPSBiAzl4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1665746944535161.64928063350362; Fri, 14 Oct 2022 04:29:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-7erukIzCMP6ZXCrd4bVTmg-1; Fri, 14 Oct 2022 07:28:52 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B6E4E88B7BC; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CC1D2144B44; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5D3BC19465B7; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E0FB819465A2 for ; Fri, 14 Oct 2022 11:28:47 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CEB00208DDBC; Fri, 14 Oct 2022 11:28:47 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 584D7207B31A; Fri, 14 Oct 2022 11:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665746943; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0YDCo8uOpCkWx9YICJMAVei+TmaqDiT4Kw99Cnvz5AQ=; b=ZTE7nRcm58gC9RKQo3NfnJcP7MwUVdUl5xMSqkJI9xh5c4TQHFWrdl5JadVvmxJvlTWOpn obD2DNaFWJIA4d6pz1rh0tGwF2rN9Dy4DJRCAPb4tXMDfKgAhTHii87prG3TN521gmnF7W VaQSbOzHR8Da+tvtkWJrrN1ERQibS1Q= X-MC-Unique: 7erukIzCMP6ZXCrd4bVTmg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 2/7] ci: integration: Add an extra level of quoting for augeas set options Date: Fri, 14 Oct 2022 13:28:40 +0200 Message-Id: <0f959c2fdc1f8f0bb38a947fa6a2362a7992bfce.1665746914.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665746945449100002 Content-Type: text/plain; charset="utf-8"; x-default="true" Both log filters and log outputs expect string values, however, augeas apparently requires an extra level of quotes apart from the ones we pass via shell (see comment [1]) to work properly, otherwise augeas ignores the value and returns 0. Without this fix we don't set libvirt's log level to debug, we don't set logging to a file and hence we don't include the logs in CI artifacts in case the test suite fails. [1] https://github.com/hercules-team/augeas/issues/301#issuecomment-1436998= 80 Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration-template.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index 4ca8a0bb24..bb8969da19 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -47,8 +47,8 @@ do LOG_OUTPUTS=3D"1:file:/var/log/libvirt/${daemon}.log"; LOG_FILTERS=3D"3:remote 4:event 3:util.json 3:util.object 3:util.dbu= s 3:util.netlink 3:node_device 3:rpc 3:access 1:*"; - sudo augtool set /files/etc/libvirt/${daemon}.conf/log_filters "$LOG= _FILTERS" &>/dev/null; - sudo augtool set /files/etc/libvirt/${daemon}.conf/log_outputs "$LOG= _OUTPUTS" &>/dev/null; + sudo augtool set /files/etc/libvirt/${daemon}.conf/log_filters "'$LO= G_FILTERS'" &>/dev/null; + sudo augtool set /files/etc/libvirt/${daemon}.conf/log_outputs "'$LO= G_OUTPUTS'" &>/dev/null; sudo systemctl --quiet stop ${daemon}.service; sudo systemctl restart ${daemon}.socket; done --=20 2.37.3 From nobody Tue Apr 30 17:01:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665746939; cv=none; d=zohomail.com; s=zohoarc; b=HejwHX5dTk4hr9ETNzyiuFXhlb8POU3CnxEAv7xslil+2vWMQhkaIRvtICxUowXjh2FdMez/rjKMoMt3aVq68Swq/XYArNRf4V1N+Yq+saVjaumSQSyEiMkFDeDwsY4IWehVD6Z51aYWbVHCW/lsl/q7jGzyefSy00wP2sID97c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665746939; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=d2rrhw1FS1SMIx6/yA3FpHrbM6X0crdJbgfqicMVxLQ=; b=N2mDy0TjCyi7DMjldT6b0Jd83ha3tF1t9uV9ftSsXzhxubGif7UCLJeQoBPAm95U82PFVDLSRANiG7gARL1nQj43dSmsuXem3JS101R35Il7vZPAr1uGZs53TWouu6sgsYfZwt8kVyaz8UcEjwnoUu+n6IH+PznATt7oA+oCv4s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 166574693980978.46064729859631; Fri, 14 Oct 2022 04:28:59 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-313-YBhsYejaPtewuMAUG9XvuQ-1; Fri, 14 Oct 2022 07:28:53 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF4F38853BA; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCDF41111A44; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A344C19465B2; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9802A1946588 for ; Fri, 14 Oct 2022 11:28:48 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8AADF208DDB6; Fri, 14 Oct 2022 11:28:48 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13BED208DDBD; Fri, 14 Oct 2022 11:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665746938; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=d2rrhw1FS1SMIx6/yA3FpHrbM6X0crdJbgfqicMVxLQ=; b=i7X2NFURA7qCkEmi5G5Vg/BHIMm2MYtGp55Usd+JIzwXCG6dLdqhzjXtyVelFg38crEe1k Flf5mbJoOyoWpG3wCjRjoFGQTi7k5QRvuaV3FUTiSAH6EpswR3xJPV2zsIYvbujKOxJ1D1 xCOUegHBLBYHDW0H6emKf+Mch4H7f2Y= X-MC-Unique: YBhsYejaPtewuMAUG9XvuQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 3/7] ci: integration: Fix the test on avocado directory existence Date: Fri, 14 Oct 2022 13:28:41 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665746941371100007 Content-Type: text/plain; charset="utf-8"; x-default="true" It's a directory, so -d should be used with 'test'. Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration-template.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index bb8969da19..2e7802dbe0 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -56,7 +56,7 @@ =20 .collect-logs: &collect-logs - mkdir logs - - test -e "$SCRATCH_DIR"/avocado && sudo mv "$SCRATCH_DIR"/avocado/lates= t/test-results logs/avocado; + - test -d "$SCRATCH_DIR"/avocado && sudo mv "$SCRATCH_DIR"/avocado/lates= t/test-results logs/avocado; - sudo coredumpctl info --no-pager > logs/coredumpctl.txt - sudo mv /var/log/libvirt logs/libvirt - sudo chown -R $(whoami):$(whoami) logs --=20 2.37.3 From nobody Tue Apr 30 17:01:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665746937; cv=none; d=zohomail.com; s=zohoarc; b=ZLvR8VDH74nBt3vL4Slhw9W9fH4kL0iK4+jvYzWA/MhpfF+XjjXGqR5MbtSbK5vjm34ymKQSAQN8rTns+/zdM/e2/qRg6T3aayPZ/51I1GmgYSrpXTwRIxBADFlzb9iyvXreDMVjuf/Ht0FjrmmSwe+P16r3JkgFpV0+qFpy82Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665746937; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/xHBB1w6IkreiuJNUaKYbHbPS5wvAT50F6+FHfkT3QE=; b=c9Qd7o9VOW/ZaaLEGpL8V/umJJAoNeVDDkyk47K+ouMm+gW3TakWVl3Yew3yx6xECga6C7vmyg2VZaeV9EWrvjqjHZYJqw7Kl1jccH7UBRpq/HB7/vZ/i1bFoY0KkSgN6+OfVtB7SzIEpsDDYEcJRWpl9yB13o7phTPa7FNz28Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1665746937692704.5753171859114; Fri, 14 Oct 2022 04:28:57 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-66-1kZkuE-uMXq9jCOEnhygeg-1; Fri, 14 Oct 2022 07:28:53 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1EBB21C0A10F; Fri, 14 Oct 2022 11:28:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C4CD85795; Fri, 14 Oct 2022 11:28:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EDA731946589; Fri, 14 Oct 2022 11:28:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6FBAD1946A42 for ; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4722E208DDBE; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id C43B9207B31A; Fri, 14 Oct 2022 11:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665746936; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/xHBB1w6IkreiuJNUaKYbHbPS5wvAT50F6+FHfkT3QE=; b=cdVddRci1z0y80DE59n/zPAGUoEdnI2zDOf2Mr4HgG6rnbx8mqwCNWpXMz3uTlnxMSJNjz KhuEgXpAhTBX2XgUXMh7uuSqs1jskDTPgT+Fhw7EVOOQpiUGDLid3cBxbJ07eZko/NwT0r QDj9P2dACqN8ssqeN+/hxZy2ZBWnGqM= X-MC-Unique: 1kZkuE-uMXq9jCOEnhygeg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 4/7] ci: integration: Only create a coredump log when a core exists Date: Fri, 14 Oct 2022 13:28:42 +0200 Message-Id: <67ed4c9999243145dd08b5b42afe02e48594d89e.1665746914.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665746939384100004 Content-Type: text/plain; charset="utf-8"; x-default="true" It could be quite confusing looking at the job log artifacts and having an empty coredump log in there, IOW it doesn't really give much confidence that the reporting mechanism actually works. Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration-template.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index 2e7802dbe0..4321f0d29e 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -57,7 +57,7 @@ .collect-logs: &collect-logs - mkdir logs - test -d "$SCRATCH_DIR"/avocado && sudo mv "$SCRATCH_DIR"/avocado/lates= t/test-results logs/avocado; - - sudo coredumpctl info --no-pager > logs/coredumpctl.txt + - sudo coredumpctl &>/dev/null && sudo coredumpctl info --no-pager > log= s/coredumpctl.txt - sudo mv /var/log/libvirt logs/libvirt - sudo chown -R $(whoami):$(whoami) logs # rename all Avocado stderr/stdout logs to *.log so that GitLab's web = UI doesn't mangle the MIME type --=20 2.37.3 From nobody Tue Apr 30 17:01:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665746946; cv=none; d=zohomail.com; s=zohoarc; b=TRrPrO/j6ymZMqvXRz5g6zdcMKPuOby7f+Xa5TdDFsMq3eJCCWC6rBTMEtoPFNd3XKIbULJHWzxqN9ijfuRR9PcC7lDil63zW5sL4CUnSoVyglc+Xnkm6fzoigcmzwAwMH/eYqieNpM6b/7pTsNKfGo12l1xPvGP0e/VkPT6b1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665746946; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=F43JeP5POccaN/HTVNBezRiByX2a5EqzOrVBlHqdAFw=; b=nBZEgbUlM8Y3abXn0tmWprl2EywXh+a6wCnaomCUPBl2tjW08FOa7W/5uJJlgW+c/NWBjvcmMTUJLniSjjkV+Uv35HDQL6BpOoR3lzzUFCFVcF3dsN0oAol1nmz8x3NgEC6DxzRlNsSxlSdTDlLdisZkgyQyonPfUjlwHeMYWHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1665746946269122.09668198274517; Fri, 14 Oct 2022 04:29:06 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-287-d9l4TFeuO-ClhiBEhflHsQ-1; Fri, 14 Oct 2022 07:28:55 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A099F2A59541; Fri, 14 Oct 2022 11:28:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D216207B31A; Fri, 14 Oct 2022 11:28:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 618211946589; Fri, 14 Oct 2022 11:28:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 11BED1946588 for ; Fri, 14 Oct 2022 11:28:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 03408208DDBC; Fri, 14 Oct 2022 11:28:50 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 803F4207B31A; Fri, 14 Oct 2022 11:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665746944; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=F43JeP5POccaN/HTVNBezRiByX2a5EqzOrVBlHqdAFw=; b=f3GGrR/NlBU2mM7HY+dTorkHclkqJMbVvqEXj3lxAWxpZj9d7/CXRiiYog/iEa0TFet4IU EQ8QTmsmCMZDjglVmRWt5ATHsmCilCm25uExvGpJLzwoPNxUO5Ph0LOTqL6riMFyKEeNuX zLn8jkXTCSv+OWnznO8PGUqzfXSS7Ms= X-MC-Unique: d9l4TFeuO-ClhiBEhflHsQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 5/7] ci: integration: Use 'set +e' in the log collecting job Date: Fri, 14 Oct 2022 13:28:43 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665746947416100005 Content-Type: text/plain; charset="utf-8"; x-default="true" All 'script' blocks are defined as 'set -e' and so a single failed return value means we won't collect some of the logs. Because of the nature of the original job's failure some of the log sources might not be available, but that's fine, however, the gitlab after_script job cannot finish prematurely. Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration-template.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index 4321f0d29e..67982c5167 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -55,6 +55,7 @@ =20 =20 .collect-logs: &collect-logs + - set +e - mkdir logs - test -d "$SCRATCH_DIR"/avocado && sudo mv "$SCRATCH_DIR"/avocado/lates= t/test-results logs/avocado; - sudo coredumpctl &>/dev/null && sudo coredumpctl info --no-pager > log= s/coredumpctl.txt --=20 2.37.3 From nobody Tue Apr 30 17:01:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665746943; cv=none; d=zohomail.com; s=zohoarc; b=lTd+iQG/WENzocZGI/6rAMBLeICJJmhXqnhKJU9Accmup7h/dhOVoXsgGF/R0qXoUzbT0EZwEKvoPRGPmWhw799EewW8U5/KaDsfiYNLOzeO9fKDwdfCq9kzsjNGPF2O/5S9/eefBLTlLwC92MmcwTamlISr66L5xb5Szl2/5DQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665746943; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IY1gRzHBx2U4Etycg1OGu+uxT1R/KtDGD6GiDPTXMSs=; b=Ry6wfNz7XuxgHu+Je7R3rHyT6yI9fru6i2GS0ON0Cjq1NqnHLwYPGp9zkVVWy8bvJiu0t4j591La1IP4X11VG/kFMQGhmX8VhSEcu6jAZEgQSJxd8Lfk2pakEQ1SrQtv3nzaQRFqLzO9D03q8qNVTnWNueKWeYCcRJqy6btzpqA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1665746943728886.6250704289761; Fri, 14 Oct 2022 04:29:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-264-o0GbMnlnN7miY2dGqgaTYg-1; Fri, 14 Oct 2022 07:28:55 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58ECE2A5954E; Fri, 14 Oct 2022 11:28:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4298C2144B2D; Fri, 14 Oct 2022 11:28:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 359E01946589; Fri, 14 Oct 2022 11:28:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CB89F1946588 for ; Fri, 14 Oct 2022 11:28:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B1C7E208DDB6; Fri, 14 Oct 2022 11:28:50 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BE42207B31A; Fri, 14 Oct 2022 11:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665746942; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IY1gRzHBx2U4Etycg1OGu+uxT1R/KtDGD6GiDPTXMSs=; b=P71gTBV7dmjNtd0i5bKelDk0ZH6ji58T8qOg0braZZAPsCXTD2/BOthQo2VI10pP98eeNO A1Ucu14XGQ0BT5iDeTNA0v3vYmXau/OHPUPRYhR1Wd1n9KA279cmjSyq2WUME0r1N2PUNJ tSjJ8qFlzuRck/Sa8X0B2R5aMnN7liI= X-MC-Unique: o0GbMnlnN7miY2dGqgaTYg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 6/7] ci: integration: Create the avocado logs artifact dir conditionally Date: Fri, 14 Oct 2022 13:28:44 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665746945447100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Don't create an avocado directory in the resulting log artifacts if Avocado didn't even run (e.g. libvirt errored out on service restart). Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration-template.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index 67982c5167..48e71e2dd9 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -57,7 +57,7 @@ .collect-logs: &collect-logs - set +e - mkdir logs - - test -d "$SCRATCH_DIR"/avocado && sudo mv "$SCRATCH_DIR"/avocado/lates= t/test-results logs/avocado; + - test -d "$SCRATCH_DIR"/avocado && mkdir logs/avocado - sudo coredumpctl &>/dev/null && sudo coredumpctl info --no-pager > log= s/coredumpctl.txt - sudo mv /var/log/libvirt logs/libvirt - sudo chown -R $(whoami):$(whoami) logs --=20 2.37.3 From nobody Tue Apr 30 17:01:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665747015; cv=none; d=zohomail.com; s=zohoarc; b=Xku5LnGwHOq2xv3i7enUYJjRLxwR0jRVEd9fONyKdcvIOujCkn3w1em+h0R1L3BjIcojwGFQdyOM5zU54VkP4NeE4Uq4D3D4mOyccfyVHHU1tdG2i0yCIsBYiyEfFDp9/xoc7+YZ5JdIT5UlXN3aJuUc/H8qoYi+t6sQP5E6R9k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665747015; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oojmzOsYjXto9SDgBX838o9vzJwGyXGpKpgAT0uPdhU=; b=ihYsDaWpKZ+X7o5kpCJyE7TZiTOGNvh5i4wwIQIqKmmUbemz/xK2y5Y2gtfTD5e27pE2mBc7UeciKRToUJvNZdEgHBVwW8xFy40iI0k3DeVs/5I1kxzmOis+CU0GxelUmhqMaUvXIvB+x0nXLNdonqCKGLYsLLNKRGznzaiLr7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 16657470156341020.0464027853892; Fri, 14 Oct 2022 04:30:15 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547-mdHyg_MCMEm5SxoTitB4KA-1; Fri, 14 Oct 2022 07:28:56 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A3568185A7A3; Fri, 14 Oct 2022 11:28:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8AB0940974DF; Fri, 14 Oct 2022 11:28:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 807BD19465A0; Fri, 14 Oct 2022 11:28:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 88977194658F for ; Fri, 14 Oct 2022 11:28:51 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6D14B208DDB6; Fri, 14 Oct 2022 11:28:51 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id EAF06207B31A; Fri, 14 Oct 2022 11:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665747013; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oojmzOsYjXto9SDgBX838o9vzJwGyXGpKpgAT0uPdhU=; b=fBV7zFGtN/VzEqcMs9XnhcfRZgBXLcZC2BGxJwOxVt/37GaQJuZti1OZD7ocJKoKUz11KA E7ody15k704Hqg+mPI7gm2NQRw0zaeyeD70BVmZ6Sz0TDkqKjQCmspOpThPFArEQKKdcyf 0khL69DATuNSzrp3qyAg75l1zHiBFzg= X-MC-Unique: mdHyg_MCMEm5SxoTitB4KA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 7/7] ci: integration: Bundle only failed Avocado test results Date: Fri, 14 Oct 2022 13:28:45 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665747016048100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Latest versions of Avocado create 'by-status' symlink shortcuts to test results, IOW: # this is the main test results directory containing all data $ ls /avocado/job-results/latest/test-results/ 01-scripts_networks_050-transient-lifecycle.t 02-scripts_networks_051-transient-autostart.t ... 22-scripts_networks_400-guest-bandwidth.t by_status/ # list only the failed tests $ ls -l /avocado/job-results/latest/test-results/by-status/FAIL 19-scripts_networks_360-guest-network-vepa.t -> /avocado/job-results/latest/test-results/19-scripts_networks_360-= guest-network-vepa.t Therefore, let's bundle only the failed ones, it's going to make the log artifacts more obvious when looking for libvirt errors. Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration-template.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index 48e71e2dd9..f01de7845d 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -56,10 +56,16 @@ =20 .collect-logs: &collect-logs - set +e + - shopt -s nullglob - mkdir logs - test -d "$SCRATCH_DIR"/avocado && mkdir logs/avocado - sudo coredumpctl &>/dev/null && sudo coredumpctl info --no-pager > log= s/coredumpctl.txt - sudo mv /var/log/libvirt logs/libvirt + # filter only the failed tests, omitting successful job logs + - for test_log in "$SCRATCH_DIR"/avocado/latest/test-results/by-status/{= ERROR,FAIL}/*; + do + sudo mv "$(realpath $test_log)" logs/avocado; + done; - sudo chown -R $(whoami):$(whoami) logs # rename all Avocado stderr/stdout logs to *.log so that GitLab's web = UI doesn't mangle the MIME type - find logs/avocado/ -type f ! -name "*.log" -exec --=20 2.37.3