From nobody Wed May 15 21:59:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1660226524; cv=none; d=zohomail.com; s=zohoarc; b=YyFiE7b7nDWZbE3icEMNqbR4pdU5JkbX9EbOsfE92A2oZYssP50s5xIBk4H/GMYzO21huWfXMHd41VqBAFXEF+7+/GhYrciwgWU5Tdk3tD8q4MUDTZH/UG3G/IZCWr/Z1jygGc/OYWNiDUnCBs7GE0/1RJ6aJ/c6g4sQ2XYU2qo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660226524; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RqvAQT2gmJyaonUKPQl4Gxr0JyVFeT//MatUc0ZCQjk=; b=AlpAyVG2VGbtuQAQDgi1LR+SLxjcJQfOJgbJST7lrsRCQQEEW94UbYY8nS+W8bNMSYDxWmNXHlGdaAYQopDh3IXyqf2lHnXEOe2pDI969iJ/pRWlnLq+A+vWU9JAQ1UfT2/ltoSKQGsuui1cn+EJ7Wcbg8HvBvdYFPL045NgkIE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1660226524946515.8925004389628; Thu, 11 Aug 2022 07:02:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-v_hTf0UNNHWsB2el1q3Edg-1; Thu, 11 Aug 2022 10:01:57 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3CB3885A59A; Thu, 11 Aug 2022 14:01:47 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id A43589458A; Thu, 11 Aug 2022 14:01:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 487321946A42; Thu, 11 Aug 2022 14:01:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EB5A11946A41 for ; Thu, 11 Aug 2022 14:01:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id D715C2026D07; Thu, 11 Aug 2022 14:01:45 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82C9B2026D64 for ; Thu, 11 Aug 2022 14:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660226523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RqvAQT2gmJyaonUKPQl4Gxr0JyVFeT//MatUc0ZCQjk=; b=fD2Yn+oZrkke+QeiEQ7yVXPjmOEnq5Rrsg7UGVZO+H85NLKKb7UNp6+KuIpA4Ezj24g1uT 2rqEz1/FB7I3P4pcCIyMdDw0mIkbkJcjiFtkEMDrriO4wHqp+phz20uosnD/5xGDYe1HSa STgDzDpC78x0LZ7bHV+J4r/V/h87V2A= X-MC-Unique: v_hTf0UNNHWsB2el1q3Edg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] tests: qemuxml2xmltest: remove interface from disk test Date: Thu, 11 Aug 2022 16:01:41 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660226526009100004 There is no need to specify an interface for a disk test. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Jonathon Jongsma --- .../qemuxml2argvdata/disk-copy_on_read.x86_64-latest.args | 4 +--- tests/qemuxml2argvdata/disk-copy_on_read.xml | 5 ----- tests/qemuxml2xmloutdata/disk-copy_on_read.xml | 8 +------- tests/qemuxml2xmltest.c | 2 +- 4 files changed, 3 insertions(+), 16 deletions(-) diff --git a/tests/qemuxml2argvdata/disk-copy_on_read.x86_64-latest.args b/= tests/qemuxml2argvdata/disk-copy_on_read.x86_64-latest.args index 9041eda95a..98ddf685e2 100644 --- a/tests/qemuxml2argvdata/disk-copy_on_read.x86_64-latest.args +++ b/tests/qemuxml2argvdata/disk-copy_on_read.x86_64-latest.args @@ -36,9 +36,7 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-test/.config \ -blockdev '{"driver":"file","filename":"/var/lib/libvirt/Fedora-14-x86_64-= Live-KDE.iso","node-name":"libvirt-1-storage","auto-read-only":true,"discar= d":"unmap"}' \ -blockdev '{"node-name":"libvirt-1-format","read-only":true,"driver":"raw"= ,"file":"libvirt-1-storage"}' \ -device '{"driver":"ide-cd","bus":"ide.1","unit":0,"drive":"libvirt-1-form= at","id":"ide0-1-0","bootindex":1}' \ --netdev user,id=3Dhostnet0 \ --device '{"driver":"virtio-net-pci","tx":"bh","netdev":"hostnet0","id":"ne= t0","mac":"52:54:00:e5:48:58","bus":"pci.0","addr":"0x2"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","add= r":"0x3"}' \ +-device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","add= r":"0x2"}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/disk-copy_on_read.xml b/tests/qemuxml2a= rgvdata/disk-copy_on_read.xml index 95f4715bbd..10f56a8a64 100644 --- a/tests/qemuxml2argvdata/disk-copy_on_read.xml +++ b/tests/qemuxml2argvdata/disk-copy_on_read.xml @@ -35,11 +35,6 @@ - - - - - diff --git a/tests/qemuxml2xmloutdata/disk-copy_on_read.xml b/tests/qemuxml= 2xmloutdata/disk-copy_on_read.xml index b2581450e9..ae76cbafad 100644 --- a/tests/qemuxml2xmloutdata/disk-copy_on_read.xml +++ b/tests/qemuxml2xmloutdata/disk-copy_on_read.xml @@ -39,17 +39,11 @@
- - - - -
-