[PATCH 0/5] qemu: Migration code (ternary operator) cleanups

Peter Krempa posted 5 patches 1 year, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1658753062.git.pkrempa@redhat.com
src/qemu/qemu_migration.c | 37 +++++++++++++++++++++++--------------
src/qemu/qemu_monitor.c   | 35 ++++++++++++++++++++++++++---------
2 files changed, 49 insertions(+), 23 deletions(-)
[PATCH 0/5] qemu: Migration code (ternary operator) cleanups
Posted by Peter Krempa 1 year, 8 months ago
I've noticed few things that could be improved during review of Jirka's
post copy migration changes but didn't want to interfer with the series
at that point.

Peter Krempa (5):
  qemuMigrationDstFinishFresh: Avoid multi-line ternary operator in
    function call
  qemuMigrationDstPersist: Avoid multi-line ternary operator in function
    call
  qemu: migration: Overwrite 'dname' only when NULL
  qemuMigrationSrcIOFunc: Avoid unnecessary string construction
  qemu: monitor: Split up enum strings definitions

 src/qemu/qemu_migration.c | 37 +++++++++++++++++++++++--------------
 src/qemu/qemu_monitor.c   | 35 ++++++++++++++++++++++++++---------
 2 files changed, 49 insertions(+), 23 deletions(-)

-- 
2.36.1
Re: [PATCH 0/5] qemu: Migration code (ternary operator) cleanups
Posted by Michal Prívozník 1 year, 8 months ago
On 7/25/22 14:45, Peter Krempa wrote:
> I've noticed few things that could be improved during review of Jirka's
> post copy migration changes but didn't want to interfer with the series
> at that point.
> 
> Peter Krempa (5):
>   qemuMigrationDstFinishFresh: Avoid multi-line ternary operator in
>     function call
>   qemuMigrationDstPersist: Avoid multi-line ternary operator in function
>     call
>   qemu: migration: Overwrite 'dname' only when NULL
>   qemuMigrationSrcIOFunc: Avoid unnecessary string construction
>   qemu: monitor: Split up enum strings definitions
> 
>  src/qemu/qemu_migration.c | 37 +++++++++++++++++++++++--------------
>  src/qemu/qemu_monitor.c   | 35 ++++++++++++++++++++++++++---------
>  2 files changed, 49 insertions(+), 23 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

But see my comment to 1/5 before pushing. There's one typo that needs
fixing.

Michal