From nobody Sat May 4 20:29:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652882493; cv=none; d=zohomail.com; s=zohoarc; b=MhJ9NiXmWbvByKUqklgTh0imlBsRTHMuqJeOASPOTHl3Gfpr2dd2YjA+ejTOqHADCxtHOT2NosjS18C/hnncsNCJaYE+1b0NhvG3SHm9qdF+B7Y5kzhy7xDVvdhLfK+V8HJF7+ed6EJxpyYjlfbkJq5qilTIFK7Xw87E55/96+c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652882493; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cphqlkZ/sl878IdDgmqo095qpqsePod8IVetus2oBSs=; b=c6ZAcbayXLPwRV0iTVth8prx2l7fi3GYPSKXvZySQx2u/PGV8wpor7I5/6zt2aI2V4bpd56ovD0RCuGuWPFX4gVzxQt60+wM6gqlBR8xXcMkzpSDYrEw/5pmzYXXz3fzKoBy2Ar1Fo2XYBWuXKD1DwtorGzOEZtPSVk74cXvA5c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1652882493695479.70703379044164; Wed, 18 May 2022 07:01:33 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-572-uOQ6XFE3MVy5bjyEq1VdCg-1; Wed, 18 May 2022 10:01:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8A5C1294EDC7; Wed, 18 May 2022 14:01:12 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E1DD1415102; Wed, 18 May 2022 14:01:12 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 52A6E1947B91; Wed, 18 May 2022 14:01:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0BE221947B8F for ; Wed, 18 May 2022 14:01:03 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B58DF492CA2; Wed, 18 May 2022 14:01:02 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D51B492C3B for ; Wed, 18 May 2022 14:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652882492; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cphqlkZ/sl878IdDgmqo095qpqsePod8IVetus2oBSs=; b=CR5i+7r8pQsJX8ruLlb8cp3ARsQzkBmBplBOyfoI6xvPhgjJPW87QuEDp/QbT9R3EWmmaG JMAvr+1Z4m9A6g4kCs+Or7GExrh2FScDRGdmqWnokzmQ69WkdpxR51j/jmmK0q2Epk5olL otNCUt7iIWkd/GacQq/aRzaiY0u3ihI= X-MC-Unique: uOQ6XFE3MVy5bjyEq1VdCg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/5] Do not check if unsigned vars are less than zero Date: Wed, 18 May 2022 16:00:56 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652882495248100004 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/esx/esx_stream.c | 2 +- src/libvirt-qemu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_stream.c b/src/esx/esx_stream.c index b356fbed70..51c96ff0e0 100644 --- a/src/esx/esx_stream.c +++ b/src/esx/esx_stream.c @@ -287,7 +287,7 @@ esxStreamRecvFlags(virStreamPtr stream, if (esxStreamTransfer(priv, false) < 0) return -1; =20 - if (priv->buffer_used <=3D 0) + if (priv->buffer_used =3D=3D 0) return -2; } else /* blocking */ { do { diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index 3cd8c8f745..5020b5dc1b 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -233,7 +233,7 @@ virDomainQemuAttach(virConnectPtr conn, virResetLastError(); =20 virCheckConnectReturn(conn, NULL); - virCheckPositiveArgGoto(pid_value, error); + virCheckNonZeroArgGoto(pid_value, error); if (pid !=3D pid_value) { virReportInvalidArg(pid_value, _("pid_value in %s is too large"), --=20 2.34.1 From nobody Sat May 4 20:29:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652882532; cv=none; d=zohomail.com; s=zohoarc; b=XFCHhmPnPB97214q55It9z5iC88tOgOUS0yk3eEt0pcG6+Hep+GFPQMaXDD9c+d1xM5y817S9xYf8eVTXHS5E6u3d2cFmI0fbkiMiyaOS3I3Yx/oW1ATZkuv+X2P1N/zm8wa0D2MYvFWTY0SN+vwjzACcCHyP1j95s7gdfi2j9o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652882532; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jPISToqsEgp7hiE5cFpfksUAC6Ngk/JnezebiJWBRa4=; b=TWj03OJOflIDSN/tUYCze0AdKQvHgw1FGZeZfWzgmthIBUO/Vs+p+i8doApi7C36maL7LF6WYFoq1V5ZdeELcPKhB48rPW95Cd3ksmzaiCxgcDV0x90XY/tyL3RxGKAH+fXDho0hFeKWo/dwYOR5/PCJOXpsBVSihIQDiViM4Hg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1652882532991663.5654128464181; Wed, 18 May 2022 07:02:12 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-287-3aUoTTTBMYKToWBYNxvOoQ-1; Wed, 18 May 2022 10:01:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0A50F29AB442; Wed, 18 May 2022 14:01:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E95351410F36; Wed, 18 May 2022 14:01:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9D66E1947B91; Wed, 18 May 2022 14:01:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 61B021947B8F for ; Wed, 18 May 2022 14:01:03 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 53B6F492CA2; Wed, 18 May 2022 14:01:03 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEB5C492C3B for ; Wed, 18 May 2022 14:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652882532; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jPISToqsEgp7hiE5cFpfksUAC6Ngk/JnezebiJWBRa4=; b=LvWT1P6ud28uxpYwfpjcxaJhh6OHL4NZQlWksoWqxwWkk+EvN1KrHA2q2gkrZTTccRAxeI xO61yfhhHCfMyW+oiS5cXJDCIT2ZrK+tW+YL4pwY30I7ZHOLNVO8nogaAmiuYZh+kFe4MA k80EFk0XuPHysz3TE/HIZIgIS6Yccwk= X-MC-Unique: 3aUoTTTBMYKToWBYNxvOoQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/5] src: QemuMonitorCommandWithFiles: report error when fd passing is unsupported Date: Wed, 18 May 2022 16:00:57 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652882534421100001 The result of the <=3D 0 comparison was assigned to 'rc', rendering the if (rc =3D=3D 0) condition dead code. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/libvirt-qemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index 5020b5dc1b..ace91e8ada 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -161,7 +161,7 @@ virDomainQemuMonitorCommandWithFiles(virDomainPtr domai= n, if (ninfiles > 0 || outfiles) { int rc; if ((rc =3D VIR_DRV_SUPPORTS_FEATURE(conn->driver, conn, - VIR_DRV_FEATURE_FD_PASSING) <= =3D 0)) { + VIR_DRV_FEATURE_FD_PASSING)) <= =3D 0) { if (rc =3D=3D 0) virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("fd passing is not supported by this conn= ection")); --=20 2.34.1 From nobody Sat May 4 20:29:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652882553; cv=none; d=zohomail.com; s=zohoarc; b=YGnNTCr91FUAh5D/mmE3kNPSeHp2p23kpmz5npF53IxbVy5yEpW1wIBLHqvWG+IcGVGwGpqgPmIPtYPuneOjID6jma5/08hli50irczc5U75ayjdMrkKctysoZJkJzWkSmZohUxL+lmkXGjJ+M1+iOOFWGpwhxZP00gmyP7HN24= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652882553; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4MUZyULRcUMbUEsZCYTVfK6ClaXKHA5gGyR05gN2F3A=; b=dTeD05GS3vuCUmKP9Fngd2A3TCQu+kygibY6WfB+U5As4NhGNuH8JhFzjbmvWIYI98/UT2MCnaOrMw6KBqJzaBT/szoqZiRsDjaADw9bUm4PhwT6bNXh0St3ESZA0bAeKpl8QbVUMB9jGE4IzeRx9yfWA1IDjN8Iw7FHGruoyCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1652882553273673.2063818746035; Wed, 18 May 2022 07:02:33 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-543-d3G69AitPwOXS6WVIfLzAQ-1; Wed, 18 May 2022 10:01:28 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F2F03AF42A8; Wed, 18 May 2022 14:01:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46A9C492C14; Wed, 18 May 2022 14:01:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 355311947B91; Wed, 18 May 2022 14:01:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1102C194975B for ; Wed, 18 May 2022 14:01:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EA3D6492CA3; Wed, 18 May 2022 14:01:03 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91671492C3B for ; Wed, 18 May 2022 14:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652882551; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4MUZyULRcUMbUEsZCYTVfK6ClaXKHA5gGyR05gN2F3A=; b=YP1AzebuUFFLdg5OVrb2w76ciALiGmdD5JNVcUa22xOYGefmz9jytO6K6L9frjxeZ1bm15 TXXEqIIwzFNHLYRF+Op1xW5NCYuy4wXNKdgNFAxLCpZSf4quKnlJquvPN60+VP0wKx05TL +6SldHmpjNBXfIL19jREeNnuRfdsvQU= X-MC-Unique: d3G69AitPwOXS6WVIfLzAQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/5] apparmor: report error when removing profile failed Date: Wed, 18 May 2022 16:00:58 +0200 Message-Id: <963b53ec19be3a54ac88e614e134aef1345f64bc.1652882416.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652882554600100001 Assign the return value to 'rc' before comparing it. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 1f1cce8b3d..5dc941f79a 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1497,7 +1497,7 @@ main(int argc, char **argv) size =3D virFileLength(profile, -1); if (size =3D=3D 0) { vah_warning(_("Profile of 0 size detected, will at= tempt to remove it")); - if ((rc =3D parserRemove(ctl->uuid) !=3D 0)) + if ((rc =3D parserRemove(ctl->uuid)) !=3D 0) vah_error(ctl, 1, _("could not remove prof= ile")); unlink(profile); purged =3D true; --=20 2.34.1 From nobody Sat May 4 20:29:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652882494; cv=none; d=zohomail.com; s=zohoarc; b=KFRzMTY04A7B8cQ2amaaPbLJ5TiGamquiVx/0xA++wBtcLCjfv6l9pbkH1RLrcpyO9AL1jI+AyrR4qANPpa3V64W90rEY+baCWa1WWqnQ2zgtflR1XO6GS4lc172F8Nyx8b3J4IK/FLSNXXvsw0csHnB4qinhdI1MNQj+A377oE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652882494; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D1/X3gbeaWtDVJ7p8SwLuVHi5j/f4dvWtqEaRXn7Ly4=; b=ObIhDWG/BN+x6aV6yAxk8DQQvqi6YnAhBC7PgSWGirTcqW+XtzXnR+1U5l3cX4DNDypPAFtJ97qvVn4k71JpYcVomcpY1fIh/eW45nw+ScciB8XwwgiJXToqkhDZLKaPMX5ieDndZ6k/aR05RMw7uGBL8oN0/70rRYo3v/bwyyQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1652882494647681.4231223858429; Wed, 18 May 2022 07:01:34 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-8GWVcT-jOXSm9RVmytG-uw-1; Wed, 18 May 2022 10:01:28 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5402881F46B; Wed, 18 May 2022 14:01:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CAA4C15D58; Wed, 18 May 2022 14:01:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8BDF41926218; Wed, 18 May 2022 14:01:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A37251947B90 for ; Wed, 18 May 2022 14:01:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 86DF7492CA6; Wed, 18 May 2022 14:01:04 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EFD8492C3B for ; Wed, 18 May 2022 14:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652882493; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=D1/X3gbeaWtDVJ7p8SwLuVHi5j/f4dvWtqEaRXn7Ly4=; b=jSaIe/DSkylbXzvmo07JVTd3kOwsSDuTMbH4WXXnbZXW8ZED/CdI0ZtYMYpsO+ze8FFnZ+ Dk7dWQ/pYgqhfM/f62wWknYxDu2GW++dST9We6r9TFv7EMFbaky6yLqPr9cdhn8LaXRSwj riZT1zdSVca8V5kSbpA4VmZ/CgWgVOc= X-MC-Unique: 8GWVcT-jOXSm9RVmytG-uw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/5] vbox: SnapshotConfAllChildren: reduce scope of tempSize Date: Wed, 18 May 2022 16:00:59 +0200 Message-Id: <6fa906a69b73743ea45d71d6823586b3bfa66660.1652882416.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652882495244100003 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/vbox/vbox_snapshot_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c index 6b47893b5e..90afac179e 100644 --- a/src/vbox/vbox_snapshot_conf.c +++ b/src/vbox/vbox_snapshot_conf.c @@ -454,7 +454,6 @@ virVBoxSnapshotConfAllChildren(virVBoxSnapshotConfHardD= isk *disk, virVBoxSnapshotConfHardDisk ***list) { size_t returnSize =3D 0; - size_t tempSize =3D 0; virVBoxSnapshotConfHardDisk **ret =3D NULL; virVBoxSnapshotConfHardDisk **tempList =3D NULL; size_t i =3D 0; @@ -463,7 +462,7 @@ virVBoxSnapshotConfAllChildren(virVBoxSnapshotConfHardD= isk *disk, ret =3D g_new0(virVBoxSnapshotConfHardDisk *, 0); =20 for (i =3D 0; i < disk->nchildren; i++) { - tempSize =3D virVBoxSnapshotConfAllChildren(disk->children[i], &te= mpList); + size_t tempSize =3D virVBoxSnapshotConfAllChildren(disk->children[= i], &tempList); VIR_EXPAND_N(ret, returnSize, tempSize); =20 for (j =3D 0; j < tempSize; j++) --=20 2.34.1 From nobody Sat May 4 20:29:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652882492; cv=none; d=zohomail.com; s=zohoarc; b=l/rFczn6qUq0UI1WTQWSpTELQS2QdN0pHVW6G2P+UVYDU6G3BQYw9LZw+559XSbk8JM7pkV5uYyWA0tlFKcc/BS8YelfcKzQh+n5WJplBs404DZC+YLcOtumIBl3Pr2N5mgwk1SaRukUpeWRHsq+/jSVKpszevFw35TDH/P9aeM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652882492; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DMw2Kg4K/HAivo1aguk3W1Ws2dYR4T5DRIWbTssSPms=; b=O/SgaDciMF1eJQc1WrKCHk9aKXOEB1vFmRAlhPP6L9EVW+S+pv1d2FbIfSCw8GASEnYqhbhOlH393hJy6setRl63okCKSwFJHi9BnnENtAjIagztuUrOkdEziSSg+Sij1lfTfyX3RM1XC6VIAoALSF4ThKtt5bQdJZlmH8QBx+Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1652882492643218.50952570376296; Wed, 18 May 2022 07:01:32 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-acFaBIr6MUyxKZf4NVZwEA-1; Wed, 18 May 2022 10:01:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 389611066542; Wed, 18 May 2022 14:01:12 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 224E82166B41; Wed, 18 May 2022 14:01:12 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E47301926218; Wed, 18 May 2022 14:01:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3A1831947B90 for ; Wed, 18 May 2022 14:01:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 24579492CA2; Wed, 18 May 2022 14:01:05 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id C008F492C3B for ; Wed, 18 May 2022 14:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652882491; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DMw2Kg4K/HAivo1aguk3W1Ws2dYR4T5DRIWbTssSPms=; b=hEMZrxbNS3QjETOXpGcutYXs7HQXUxMcIUT2zhX+78u+NRNP8KvYXakpBU/IiXJZqrTyNX VEbCurlrmWtqDbUfUaa7VZBw+ptQfiZiuro3U/cNCPne4WSBWExGf5dcRTcXM1GjlLck5t WZMV8K0CEXxTVUtFhxwNKgOdgOADiI8= X-MC-Unique: acFaBIr6MUyxKZf4NVZwEA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 5/5] storagefile: set size field of ploop to 8 Date: Wed, 18 May 2022 16:01:00 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652882493259100001 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/storage_file/storage_file_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage_file/storage_file_probe.c b/src/storage_file/stora= ge_file_probe.c index 54e095ffd3..9465af5d96 100644 --- a/src/storage_file/storage_file_probe.c +++ b/src/storage_file/storage_file_probe.c @@ -296,7 +296,7 @@ static struct FileTypeInfo const fileTypeInfo[] =3D { [VIR_STORAGE_FILE_VHD] =3D { 0, NULL, LV_LITTLE_ENDIAN, -1, 0, {0}, 0, 0, 0, NULL, NULL, NULL, NULL= }, [VIR_STORAGE_FILE_PLOOP] =3D { 0, "WithouFreSpacExt", LV_LITTLE_ENDIAN, - -2, 0, {0}, PLOOP_IMAGE_SIZE_OFFSET, 0, + -2, 0, {0}, PLOOP_IMAGE_SIZE_OFFSET, 8, PLOOP_SIZE_MULTIPLIER, NULL, NULL, NULL, = NULL }, =20 /* All formats with a backing store probe below here */ --=20 2.34.1