From nobody Mon May 6 16:33:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643189379; cv=none; d=zohomail.com; s=zohoarc; b=A2rAPAZrbeqnLhm9ZjpqfwVTJSSHhR26reoTpslUR6OO9D85BDsjyINQpsfwSFErViQA60mG5iY3LesAsBnhQyjXdckY6IzxK0fNit294nccGD6WHYn72awd2yiSbPtufb+P0rVoeaTnzpzafOiAHbLxxfScPka4/six6i7d7g4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643189379; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vQFwmzp2fBXZovRJktpn3YqOEW3eLOtAOrZiqH79mz8=; b=kYrr6dxIopsQaCjSQ8nZgyy2rQqrBMic+ptQj44UBrISPv1rVb8v4vyUJA1QE4+VANYT2SlbTpiwT9+z0bEwmWFRXq85cT4XnWoTWW+i2KQX8RSp9Ln7ROtOTrYudkzbhgzcg3XFyv/T0pFToIwBegmq9/1300nMxAZMyrFRmrs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1643189379254243.54404661317244; Wed, 26 Jan 2022 01:29:39 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-FhHNqwq8P06c6ddCbG6f7Q-1; Wed, 26 Jan 2022 04:29:35 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F12F446877; Wed, 26 Jan 2022 09:29:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E57444EC7D; Wed, 26 Jan 2022 09:29:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 64D561809CB9; Wed, 26 Jan 2022 09:29:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20Q9TNTY018778 for ; Wed, 26 Jan 2022 04:29:23 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5298C62D7C; Wed, 26 Jan 2022 09:29:23 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id D066762D7B for ; Wed, 26 Jan 2022 09:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643189378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vQFwmzp2fBXZovRJktpn3YqOEW3eLOtAOrZiqH79mz8=; b=IfMorRDxQr0YlyNTXcbiw9wdFUhk5KBbznJvsfL7QPDTX+3ZiDBfSMlq46SljhzYolNr0R 2BCe3rRJzjXeDuU80TKaX5nYutITDgzajNllPTeIymq3QQGPdbrJmDuAxtFmpFK4zvJwFp RzTewxkKilFeisoIq0RA3eyEeG41kHQ= X-MC-Unique: FhHNqwq8P06c6ddCbG6f7Q-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 1/3] domain_validate: Refuse VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED Date: Wed, 26 Jan 2022 10:29:08 +0100 Message-Id: <8842fd4e633d4893c88f296ced1f0d4afe4c3c04.1643189237.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643189380653100001 We document that
can be used only for -s. However, corresponding validation rule is missing. Let's put the rule into hypervisor agnostic part of validation process so that all drivers can benefit. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_validate.c | 45 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index e9baf1d41a..d5e74db243 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2257,10 +2257,55 @@ virDomainGraphicsDefValidate(const virDomainDef *de= f, return 0; } =20 +static int +virDomainDeviceInfoValidate(const virDomainDeviceDef *dev) +{ + virDomainDeviceInfo *info; + + if (!(info =3D virDomainDeviceGetInfo(dev))) + return 0; + + switch ((virDomainDeviceAddressType) info->type) { + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCID: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_ISA: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DIMM: + /* No validation for these address types yet */ + break; + + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED: + if (dev->type !=3D VIR_DOMAIN_DEVICE_HOSTDEV) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("address of type '%s' is supported only for h= ostdevs"), + virDomainDeviceAddressTypeToString(info->type)); + return -1; + } + break; + + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_LAST: + default: + virReportEnumRangeError(virDomainDeviceAddressType, info->type); + return -1; + } + + return 0; +} + static int virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, const virDomainDef *def) { + if (virDomainDeviceInfoValidate(dev) < 0) + return -1; + switch ((virDomainDeviceType) dev->type) { case VIR_DOMAIN_DEVICE_DISK: return virDomainDiskDefValidate(def, dev->data.disk); --=20 2.34.1 From nobody Mon May 6 16:33:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643189392; cv=none; d=zohomail.com; s=zohoarc; b=WF+9Zl9tAQHTjzCAHlOqANcD5ZgJ9esr4LAKpOBLDbg8YK4l2xP7BGHOHgYWODuPu+qzNUyCSyouyxpB3IZV1htucR2RKfX3DeCd4XVWlQyyc/wFa5r25VecoOSnOG2wFSYlnhJ9nSL8Ju72buSph9HQESTEWRAou39nHOfhtDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643189392; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WnXvZSmPxyprJuy10lh29Z+kFLxlAeS7j1ufdyFoEzc=; b=bGkjY1qEYImM5cuxzfQQ8gyJApz3BtAfeVxqKeO/TbCcTG1UikxtJgyGqn/A3FFRc2cWTMZsLe1XJxDUmBxczJp7x9GgG+oo8yiT5bZpiNjIEgC+MhSh1d1KXjjex2spbUUjEcMJB7BRzQLOPwT5MQ9zYwdtjZOVUTzqj8izGTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1643189392854765.7219420995084; Wed, 26 Jan 2022 01:29:52 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-XeYmDRYQOuS5p7GToPyhwQ-1; Wed, 26 Jan 2022 04:29:50 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AFC6C1006AA8; Wed, 26 Jan 2022 09:29:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E70A6A901; Wed, 26 Jan 2022 09:29:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5AC804A7CA; Wed, 26 Jan 2022 09:29:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20Q9TOdZ018783 for ; Wed, 26 Jan 2022 04:29:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 211A962D7C; Wed, 26 Jan 2022 09:29:24 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E8CF62D7B for ; Wed, 26 Jan 2022 09:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643189392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=WnXvZSmPxyprJuy10lh29Z+kFLxlAeS7j1ufdyFoEzc=; b=Db+/k1CG7B5hDcdy0PBvX8yXwGMNnQqefI8aaPNdiYPLBKN+dNN2g9h5Md90N50TOkwJy2 SDww0fSzQ57dsIrWFlKJg8EMaOFXlspJpXug2lFLeUQP28rgVTk1/vzLDCmjSRkkNtL61u omoczcFSMhRbsIyQVzBugV4e0Em0BAQ= X-MC-Unique: XeYmDRYQOuS5p7GToPyhwQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 2/3] qemuDomainAttachHostPCIDevice: Handle hostevs with unassigned type of address Date: Wed, 26 Jan 2022 10:29:09 +0100 Message-Id: <71d692a726897f114f1263d0c46dc598a8c03ed5.1643189237.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643189394560100001 A can have
which means libvirt manages the device detach from/reattach to the host but the device is never exposed to the guest. This means that we have to take a shortcut during hotplug, similar to the one we are taking when constructing the command line (see qemuBuildHostdevCommandLine()). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2040548 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_hotplug.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index f36de2385a..b998b51f5a 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1668,6 +1668,12 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, qemuDomainFillDeviceIsolationGroup(vm->def, &dev); } =20 + if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED) { + /* Unassigned devices are not exposed to QEMU. Our job is done her= e. */ + ret =3D 0; + goto done; + } + if (qemuDomainEnsurePCIAddress(vm, &dev) < 0) goto error; releaseaddr =3D true; @@ -1692,6 +1698,7 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, exit_monitor: qemuDomainObjExitMonitor(driver, vm); =20 + done: virDomainAuditHostdev(vm, hostdev, "attach", ret =3D=3D 0); if (ret < 0) goto error; --=20 2.34.1 From nobody Mon May 6 16:33:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643189394; cv=none; d=zohomail.com; s=zohoarc; b=AZVl4KCjuNwA+CwPy+wM9MHTaZatIOqAvdQ/E9x35lBsxWIfQFC2f6aXM4akbR6bfPX7OB67kR/pL1/ATwk6nWNo01Lo1DmFW7TyH3QpYMX6zAKODxJRlA7Z/Ui765Qy5ySBzFqqsC7NhLxdJ4dpvqQ35K2To76TdMSNraSTHM0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643189394; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uv6nzqac+ZUfpuWhrbBynlWiIHVJdpQ+qgdGALR130A=; b=oCn7PIZCvjQZh/rYOc6fRqhli0vGeHudIbEAoXNfEa9b32sAHpnov/7Niy45muw3eeVE+neAOGCnhy66oWA12Ou6KDWACU2AZdnsgBo/bxXxHolGVvutiX8lEU28LQVLOuNMq8LsDl4lCFhlX5J4c+mIjdD1fCtsnyO+0mt3A6s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1643189394257796.8055372957963; Wed, 26 Jan 2022 01:29:54 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-169-m_zS-ZbEMmeBU6OLOGXrFw-1; Wed, 26 Jan 2022 04:29:50 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AF4D1083F69; Wed, 26 Jan 2022 09:29:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5035105915F; Wed, 26 Jan 2022 09:29:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A7B154A7C9; Wed, 26 Jan 2022 09:29:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20Q9TOcp018793 for ; Wed, 26 Jan 2022 04:29:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id E317862D7C; Wed, 26 Jan 2022 09:29:24 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CFC662D7B for ; Wed, 26 Jan 2022 09:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643189393; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uv6nzqac+ZUfpuWhrbBynlWiIHVJdpQ+qgdGALR130A=; b=EWeoQzQ3caVK99R+wsmkZsvT52BLG0FLB2ql0Ro5g+rvuyC3ehVppaFFWj9kThsyd+j7uU yaUHiJGW/lLLeSFPog79p4KGwp0HQG3AveMQMDe4Gooss5a0CulZnUjOER+xDAEFmI1nI+ ElcX0pF2ZF7YhRCQljlh9dnVDEoEwMM= X-MC-Unique: m_zS-ZbEMmeBU6OLOGXrFw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 3/3] qemuDomainDetachDeviceLive: Handle hostevs with unassigned type of address Date: Wed, 26 Jan 2022 10:29:10 +0100 Message-Id: <44f307c8d147674854ad13ef20c5a351e64a62bf.1643189237.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643189396858100001 Content-Type: text/plain; charset="utf-8" A can have
which means libvirt manages the device detach from/reattach to the host but the device is never exposed to the guest. This means that we have to take a shortcut during hotunplug (e.g. never ask QEMU on the monitor to detach the device, or never wait for DEVICE_DELETED event). Signed-off-by: Michal Privoznik --- src/qemu/qemu_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b998b51f5a..31141cf7df 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -6219,6 +6219,10 @@ qemuDomainDetachDeviceLive(virDomainObj *vm, info->addr.pci.slot, info->addr.pci.function); return -1; } + } else if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED= ) { + /* Unassigned devices are not exposed to QEMU, so remove the device + * explicitly, just like if we received DEVICE_DELETED event.*/ + return qemuDomainRemoveDevice(driver, vm, &detach); } =20 /* --=20 2.34.1