[PATCH 00/11] conf: Misc cleanups & reworks

Michal Privoznik posted 11 patches 2 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1643018556.git.mprivozn@redhat.com
src/conf/domain_conf.c     | 296 ++++++++++++++-----------------------
src/conf/domain_conf.h     |  22 +--
src/conf/domain_validate.c |  67 ++++++++-
src/libxl/libxl_conf.c     |   2 +-
src/libxl/xen_common.c     |  23 +--
src/lxc/lxc_cgroup.c       |   2 +-
src/lxc/lxc_controller.c   |   2 +-
src/qemu/qemu_command.c    |  28 ++--
src/qemu/qemu_process.c    |   5 +-
src/qemu/qemu_validate.c   |  14 +-
10 files changed, 226 insertions(+), 235 deletions(-)
[PATCH 00/11] conf: Misc cleanups & reworks
Posted by Michal Privoznik 2 years, 2 months ago
As I was going through domain_conf.c trying to change the code to use
virXMLPropEnum() more I had to write couple of clean ups first.

Patches can be also found here:

https://gitlab.com/MichalPrivoznik/libvirt/-/commits/virxmlprop/

but on the branch, there are also said virXMLPropEnum() patches so look
only at the first 11 patches on the branch.

Michal Prívozník (11):
  virDomainInputDefParseXML: Move validation into validator
  virDomainChrSourceDefCopy: Copy more struct members
  virDomainChrSourceDefCopy: Don't check arguments against NULL
  virDomainChrSourceDefCopy: return void
  conf: Fix type of @present in _virDomainTimerDef struct
  conf: Fix @tickpolicy member of _virDomainTimerDef struct
  conf: Fix @track member of _virDomainTimerDef struct
  conf: Fix @mode member of _virDomainTimerDef struct
  conf: Rework virDomainTimerDefFormat()
  virDomainTimerDefFormat: return void
  conf: Separate out virDomainClockDef formatting

 src/conf/domain_conf.c     | 296 ++++++++++++++-----------------------
 src/conf/domain_conf.h     |  22 +--
 src/conf/domain_validate.c |  67 ++++++++-
 src/libxl/libxl_conf.c     |   2 +-
 src/libxl/xen_common.c     |  23 +--
 src/lxc/lxc_cgroup.c       |   2 +-
 src/lxc/lxc_controller.c   |   2 +-
 src/qemu/qemu_command.c    |  28 ++--
 src/qemu/qemu_process.c    |   5 +-
 src/qemu/qemu_validate.c   |  14 +-
 10 files changed, 226 insertions(+), 235 deletions(-)

-- 
2.34.1

Re: [PATCH 00/11] conf: Misc cleanups & reworks
Posted by Ján Tomko 2 years, 2 months ago
On a Monday in 2022, Michal Privoznik wrote:
>As I was going through domain_conf.c trying to change the code to use
>virXMLPropEnum() more I had to write couple of clean ups first.
>
>Patches can be also found here:
>
>https://gitlab.com/MichalPrivoznik/libvirt/-/commits/virxmlprop/
>
>but on the branch, there are also said virXMLPropEnum() patches so look
>only at the first 11 patches on the branch.
>
>Michal Prívozník (11):
>  virDomainInputDefParseXML: Move validation into validator
>  virDomainChrSourceDefCopy: Copy more struct members
>  virDomainChrSourceDefCopy: Don't check arguments against NULL
>  virDomainChrSourceDefCopy: return void
>  conf: Fix type of @present in _virDomainTimerDef struct
>  conf: Fix @tickpolicy member of _virDomainTimerDef struct
>  conf: Fix @track member of _virDomainTimerDef struct
>  conf: Fix @mode member of _virDomainTimerDef struct
>  conf: Rework virDomainTimerDefFormat()
>  virDomainTimerDefFormat: return void
>  conf: Separate out virDomainClockDef formatting
>
> src/conf/domain_conf.c     | 296 ++++++++++++++-----------------------
> src/conf/domain_conf.h     |  22 +--
> src/conf/domain_validate.c |  67 ++++++++-
> src/libxl/libxl_conf.c     |   2 +-
> src/libxl/xen_common.c     |  23 +--
> src/lxc/lxc_cgroup.c       |   2 +-
> src/lxc/lxc_controller.c   |   2 +-
> src/qemu/qemu_command.c    |  28 ++--
> src/qemu/qemu_process.c    |   5 +-
> src/qemu/qemu_validate.c   |  14 +-
> 10 files changed, 226 insertions(+), 235 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano