[libvirt PATCH 0/6] util: virnetdev: use g_auto for virCommand

Ján Tomko posted 6 patches 2 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1642438847.git.jtomko@redhat.com
src/util/virnetdevbandwidth.c | 128 +++++++++++++---------------------
src/util/virnetdevmidonet.c   |  20 ++----
2 files changed, 53 insertions(+), 95 deletions(-)
[libvirt PATCH 0/6] util: virnetdev: use g_auto for virCommand
Posted by Ján Tomko 2 years, 2 months ago
Refactor some functions to remove more manual virCommand freeing.

virNetDevBandwidthSet is left untouched.

Ján Tomko (6):
  util: midonet: use g_auto for virCommand
  util: virNetDevBandwidthUpdateRate: refactor
  util: virNetDevBandwidthManipulateFilter: use g_auto
  util: virNetDevBandwidthClear: use g_auto
  util: refactor virNetDevBandwidthPlug
  util: refactor virNetDevBandwidthUnplug

 src/util/virnetdevbandwidth.c | 128 +++++++++++++---------------------
 src/util/virnetdevmidonet.c   |  20 ++----
 2 files changed, 53 insertions(+), 95 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/6] util: virnetdev: use g_auto for virCommand
Posted by Michal Prívozník 2 years, 2 months ago
On 1/17/22 18:02, Ján Tomko wrote:
> Refactor some functions to remove more manual virCommand freeing.
> 
> virNetDevBandwidthSet is left untouched.
> 
> Ján Tomko (6):
>   util: midonet: use g_auto for virCommand
>   util: virNetDevBandwidthUpdateRate: refactor
>   util: virNetDevBandwidthManipulateFilter: use g_auto
>   util: virNetDevBandwidthClear: use g_auto
>   util: refactor virNetDevBandwidthPlug
>   util: refactor virNetDevBandwidthUnplug
> 
>  src/util/virnetdevbandwidth.c | 128 +++++++++++++---------------------
>  src/util/virnetdevmidonet.c   |  20 ++----
>  2 files changed, 53 insertions(+), 95 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal