[PATCH 0/5] tests: Tool for programatic modification of qemucapabilitiesdata/*.replies

Peter Krempa posted 5 patches 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1640182750.git.pkrempa@redhat.com
src/libvirt_private.syms          |   1 +
src/util/virjson.c                |  20 +++
src/util/virjson.h                |   6 +
tests/domaincapstest.c            |   3 +-
tests/meson.build                 |   1 +
tests/qemucapabilitiesnumbering.c | 242 ++++++++++++++++++++++++++++++
tests/qemucapabilitiestest.c      |   4 +-
tests/qemucapsfixreplies          |  26 ----
tests/qemumonitortestutils.c      | 123 ++++++++++-----
tests/qemumonitortestutils.h      | 149 +++++++++++-------
10 files changed, 453 insertions(+), 122 deletions(-)
create mode 100644 tests/qemucapabilitiesnumbering.c
delete mode 100755 tests/qemucapsfixreplies
[PATCH 0/5] tests: Tool for programatic modification of qemucapabilitiesdata/*.replies
Posted by Peter Krempa 2 years, 3 months ago
I was asked multiple times how to automate modification of the qemu
capability dumps. I wrote a tool [1] that allowed doing that.
Unfortunately as it wasn't in the repo it was not avalilable.

Now I've finally set out to finish it. It masquerades as a test in
default mode checking the ordering and numbering of the caps dump files
as in the past there were few cases where manual edits broke it.

In update mode it allows modification of the replies and gives few
examples to do so. There's a lot of possible things users would want to
do so there's no way around actually writing some code but it should be
easier this way.

Since this now does also numbering, the AWK/shell script
'qemucapsfixreplies' can be removed.




[1]: Okay, okay. Copy&paste'd few bits from various places into one
messy C file and didn't bother with memory cleanup. But it worked.


Peter Krempa (5):
  util: json: Introduce virJSONValueObjectReplaceValue
  tests: qemumonitortestutils.h: Reformat header file
  qemumonitortestutils: Extract parser for the monitor conversation dump
    file
  tests: Tool for programatic modification of
    qemucapabilitiesdata/*.replies
  tests: Remove 'qemucapsfixreplies'

 src/libvirt_private.syms          |   1 +
 src/util/virjson.c                |  20 +++
 src/util/virjson.h                |   6 +
 tests/domaincapstest.c            |   3 +-
 tests/meson.build                 |   1 +
 tests/qemucapabilitiesnumbering.c | 242 ++++++++++++++++++++++++++++++
 tests/qemucapabilitiestest.c      |   4 +-
 tests/qemucapsfixreplies          |  26 ----
 tests/qemumonitortestutils.c      | 123 ++++++++++-----
 tests/qemumonitortestutils.h      | 149 +++++++++++-------
 10 files changed, 453 insertions(+), 122 deletions(-)
 create mode 100644 tests/qemucapabilitiesnumbering.c
 delete mode 100755 tests/qemucapsfixreplies

-- 
2.31.1

Re: [PATCH 0/5] tests: Tool for programatic modification of qemucapabilitiesdata/*.replies
Posted by Ján Tomko 2 years, 3 months ago
On a Wednesday in 2021, Peter Krempa wrote:
>I was asked multiple times how to automate modification of the qemu
>capability dumps. I wrote a tool [1] that allowed doing that.
>Unfortunately as it wasn't in the repo it was not avalilable.
>
>Now I've finally set out to finish it. It masquerades as a test in
>default mode checking the ordering and numbering of the caps dump files
>as in the past there were few cases where manual edits broke it.
>
>In update mode it allows modification of the replies and gives few
>examples to do so. There's a lot of possible things users would want to
>do so there's no way around actually writing some code but it should be
>easier this way.
>
>Since this now does also numbering, the AWK/shell script
>'qemucapsfixreplies' can be removed.
>
>
>
>
>[1]: Okay, okay. Copy&paste'd few bits from various places into one
>messy C file and didn't bother with memory cleanup. But it worked.
>
>
>Peter Krempa (5):
>  util: json: Introduce virJSONValueObjectReplaceValue
>  tests: qemumonitortestutils.h: Reformat header file
>  qemumonitortestutils: Extract parser for the monitor conversation dump
>    file
>  tests: Tool for programatic modification of
>    qemucapabilitiesdata/*.replies
>  tests: Remove 'qemucapsfixreplies'
>
> src/libvirt_private.syms          |   1 +
> src/util/virjson.c                |  20 +++
> src/util/virjson.h                |   6 +
> tests/domaincapstest.c            |   3 +-
> tests/meson.build                 |   1 +
> tests/qemucapabilitiesnumbering.c | 242 ++++++++++++++++++++++++++++++
> tests/qemucapabilitiestest.c      |   4 +-
> tests/qemucapsfixreplies          |  26 ----
> tests/qemumonitortestutils.c      | 123 ++++++++++-----
> tests/qemumonitortestutils.h      | 149 +++++++++++-------
> 10 files changed, 453 insertions(+), 122 deletions(-)
> create mode 100644 tests/qemucapabilitiesnumbering.c
> delete mode 100755 tests/qemucapsfixreplies
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano