[PATCH 0/6] json helper cleanups

Peter Krempa posted 6 patches 2 years, 3 months ago
Failed in applying to current master (apply log)
src/libvirt_private.syms |   3 -
src/qemu/qemu_agent.c    |   4 +-
src/qemu/qemu_block.c    |  10 +-
src/util/virjson.c       |  57 +------
src/util/virjson.h       | 315 +++++++++++++++++++++++++++------------
src/util/virmacmap.c     |   4 +-
tests/virjsontest.c      |   4 +-
7 files changed, 231 insertions(+), 166 deletions(-)
[PATCH 0/6] json helper cleanups
Posted by Peter Krempa 2 years, 3 months ago
Peter Krempa (6):
  qemuBlockStorageSourceGetRBDProps: Simplify generation of auth modes
  Replace open coded virJSONValueArrayAppendString
  util: json: Don't copy string in virJSONValueNewString
  util: json: Open-code only call of virJSONValueNewStringLen
  util: json: Remove virJSONValueIsNull/virJSONValueObjectIsNull
  util: virjson.h: Reformat headers to conform with new style

 src/libvirt_private.syms |   3 -
 src/qemu/qemu_agent.c    |   4 +-
 src/qemu/qemu_block.c    |  10 +-
 src/util/virjson.c       |  57 +------
 src/util/virjson.h       | 315 +++++++++++++++++++++++++++------------
 src/util/virmacmap.c     |   4 +-
 tests/virjsontest.c      |   4 +-
 7 files changed, 231 insertions(+), 166 deletions(-)

-- 
2.31.1

Re: [PATCH 0/6] json helper cleanups
Posted by Tim Wiederhake 2 years, 3 months ago
On Wed, 2021-12-22 at 13:02 +0100, Peter Krempa wrote:
> Peter Krempa (6):
>   qemuBlockStorageSourceGetRBDProps: Simplify generation of auth
> modes
>   Replace open coded virJSONValueArrayAppendString
>   util: json: Don't copy string in virJSONValueNewString
>   util: json: Open-code only call of virJSONValueNewStringLen
>   util: json: Remove virJSONValueIsNull/virJSONValueObjectIsNull
>   util: virjson.h: Reformat headers to conform with new style
> 
>  src/libvirt_private.syms |   3 -
>  src/qemu/qemu_agent.c    |   4 +-
>  src/qemu/qemu_block.c    |  10 +-
>  src/util/virjson.c       |  57 +------
>  src/util/virjson.h       | 315 +++++++++++++++++++++++++++----------
> --
>  src/util/virmacmap.c     |   4 +-
>  tests/virjsontest.c      |   4 +-
>  7 files changed, 231 insertions(+), 166 deletions(-)
> 
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>

Re: [PATCH 0/6] json helper cleanups
Posted by Ján Tomko 2 years, 3 months ago
On a Wednesday in 2021, Peter Krempa wrote:
>Peter Krempa (6):
>  qemuBlockStorageSourceGetRBDProps: Simplify generation of auth modes
>  Replace open coded virJSONValueArrayAppendString
>  util: json: Don't copy string in virJSONValueNewString
>  util: json: Open-code only call of virJSONValueNewStringLen
>  util: json: Remove virJSONValueIsNull/virJSONValueObjectIsNull
>  util: virjson.h: Reformat headers to conform with new style
>
> src/libvirt_private.syms |   3 -
> src/qemu/qemu_agent.c    |   4 +-
> src/qemu/qemu_block.c    |  10 +-
> src/util/virjson.c       |  57 +------
> src/util/virjson.h       | 315 +++++++++++++++++++++++++++------------
> src/util/virmacmap.c     |   4 +-
> tests/virjsontest.c      |   4 +-
> 7 files changed, 231 insertions(+), 166 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano