[libvirt PATCH 0/8] Use g_auto for virCaps and LXCDriverConfig (glib chronicles)

Ján Tomko posted 8 patches 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1639152235.git.jtomko@redhat.com
src/bhyve/bhyve_driver.c       | 46 ++++++----------
src/ch/ch_conf.c               | 14 ++---
src/ch/ch_driver.c             |  3 +-
src/hyperv/hyperv_driver.c     | 10 ++--
src/libxl/libxl_capabilities.c | 14 ++---
src/libxl/libxl_conf.c         | 11 ++--
src/libxl/xen_common.c         |  8 +--
src/libxl/xen_xl.c             | 32 ++++-------
src/lxc/lxc_conf.c             | 18 +++----
src/lxc/lxc_conf.h             |  2 +
src/lxc/lxc_container.c        | 12 ++---
src/lxc/lxc_driver.c           | 97 ++++++++++++----------------------
src/lxc/lxc_native.c           | 41 +++++---------
src/lxc/lxc_process.c          | 44 +++++----------
src/test/test_driver.c         | 14 ++---
src/util/vircgroup.c           | 12 ++---
src/util/virfirmware.c         | 18 +++----
src/vmware/vmware_conf.c       |  5 +-
src/vz/vz_driver.c             | 20 +++----
tests/qemucaps2xmltest.c       | 14 ++---
tests/testutilsxen.c           |  5 +-
tests/vboxsnapshotxmltest.c    |  8 +--
tests/virconftest.c            | 24 ++++-----
tests/virfiletest.c            | 14 ++---
tests/virstringtest.c          | 16 +++---
25 files changed, 174 insertions(+), 328 deletions(-)
[libvirt PATCH 0/8] Use g_auto for virCaps and LXCDriverConfig (glib chronicles)
Posted by Ján Tomko 2 years, 3 months ago
Pipeline in progress: https://gitlab.com/janotomko/libvirt/-/pipelines/427100328

Ján Tomko (8):
  lxc: fix error value of lxcNodeGetSecurityModel
  Use g_auto for freeing virCaps
  Use g_auto for stealing virCaps
  lxc: define cleanup function for virLXCDriverConfig
  lxc: use g_auto for virLXCDriverGetConfig
  lxc: remove cleanup from lxcNodeGetSecurityModel
  bhyve: bhyveConnectCompareCPU: remove cleanup label
  Remove empty cleanup sections

 src/bhyve/bhyve_driver.c       | 46 ++++++----------
 src/ch/ch_conf.c               | 14 ++---
 src/ch/ch_driver.c             |  3 +-
 src/hyperv/hyperv_driver.c     | 10 ++--
 src/libxl/libxl_capabilities.c | 14 ++---
 src/libxl/libxl_conf.c         | 11 ++--
 src/libxl/xen_common.c         |  8 +--
 src/libxl/xen_xl.c             | 32 ++++-------
 src/lxc/lxc_conf.c             | 18 +++----
 src/lxc/lxc_conf.h             |  2 +
 src/lxc/lxc_container.c        | 12 ++---
 src/lxc/lxc_driver.c           | 97 ++++++++++++----------------------
 src/lxc/lxc_native.c           | 41 +++++---------
 src/lxc/lxc_process.c          | 44 +++++----------
 src/test/test_driver.c         | 14 ++---
 src/util/vircgroup.c           | 12 ++---
 src/util/virfirmware.c         | 18 +++----
 src/vmware/vmware_conf.c       |  5 +-
 src/vz/vz_driver.c             | 20 +++----
 tests/qemucaps2xmltest.c       | 14 ++---
 tests/testutilsxen.c           |  5 +-
 tests/vboxsnapshotxmltest.c    |  8 +--
 tests/virconftest.c            | 24 ++++-----
 tests/virfiletest.c            | 14 ++---
 tests/virstringtest.c          | 16 +++---
 25 files changed, 174 insertions(+), 328 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/8] Use g_auto for virCaps and LXCDriverConfig (glib chronicles)
Posted by Michal Prívozník 2 years, 3 months ago
On 12/10/21 17:06, Ján Tomko wrote:
> Pipeline in progress: https://gitlab.com/janotomko/libvirt/-/pipelines/427100328
> 
> Ján Tomko (8):
>   lxc: fix error value of lxcNodeGetSecurityModel
>   Use g_auto for freeing virCaps
>   Use g_auto for stealing virCaps
>   lxc: define cleanup function for virLXCDriverConfig
>   lxc: use g_auto for virLXCDriverGetConfig
>   lxc: remove cleanup from lxcNodeGetSecurityModel
>   bhyve: bhyveConnectCompareCPU: remove cleanup label
>   Remove empty cleanup sections
> 
>  src/bhyve/bhyve_driver.c       | 46 ++++++----------
>  src/ch/ch_conf.c               | 14 ++---
>  src/ch/ch_driver.c             |  3 +-
>  src/hyperv/hyperv_driver.c     | 10 ++--
>  src/libxl/libxl_capabilities.c | 14 ++---
>  src/libxl/libxl_conf.c         | 11 ++--
>  src/libxl/xen_common.c         |  8 +--
>  src/libxl/xen_xl.c             | 32 ++++-------
>  src/lxc/lxc_conf.c             | 18 +++----
>  src/lxc/lxc_conf.h             |  2 +
>  src/lxc/lxc_container.c        | 12 ++---
>  src/lxc/lxc_driver.c           | 97 ++++++++++++----------------------
>  src/lxc/lxc_native.c           | 41 +++++---------
>  src/lxc/lxc_process.c          | 44 +++++----------
>  src/test/test_driver.c         | 14 ++---
>  src/util/vircgroup.c           | 12 ++---
>  src/util/virfirmware.c         | 18 +++----
>  src/vmware/vmware_conf.c       |  5 +-
>  src/vz/vz_driver.c             | 20 +++----
>  tests/qemucaps2xmltest.c       | 14 ++---
>  tests/testutilsxen.c           |  5 +-
>  tests/vboxsnapshotxmltest.c    |  8 +--
>  tests/virconftest.c            | 24 ++++-----
>  tests/virfiletest.c            | 14 ++---
>  tests/virstringtest.c          | 16 +++---
>  25 files changed, 174 insertions(+), 328 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal