[PATCH v3 0/4] Introduce TCG domain features

Michal Privoznik posted 4 patches 2 years, 3 months ago
Failed in applying to current master (apply log)
NEWS.rst                                      |  5 ++
docs/formatdomain.rst                         | 11 ++++
docs/schemas/domaincommon.rng                 | 15 ++++-
src/conf/domain_conf.c                        | 58 ++++++++++++++++++-
src/conf/domain_conf.h                        |  7 +++
src/qemu/qemu_command.c                       |  5 ++
src/qemu/qemu_validate.c                      | 17 ++++++
...efault-cpu-tcg-features.x86_64-latest.args | 36 ++++++++++++
.../x86_64-default-cpu-tcg-features.xml       | 56 ++++++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
...default-cpu-tcg-features.x86_64-latest.xml |  1 +
tests/qemuxml2xmltest.c                       |  1 +
12 files changed, 210 insertions(+), 3 deletions(-)
create mode 100644 tests/qemuxml2argvdata/x86_64-default-cpu-tcg-features.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/x86_64-default-cpu-tcg-features.xml
create mode 120000 tests/qemuxml2xmloutdata/x86_64-default-cpu-tcg-features.x86_64-latest.xml
[PATCH v3 0/4] Introduce TCG domain features
Posted by Michal Privoznik 2 years, 3 months ago
v3 of:

https://listman.redhat.com/archives/libvir-list/2021-November/msg00194.html

Note, patches 1/4 and 2/4 from v2 were pushed already.

diff to v2:
- Split feature validation into a separate patch
- Validate that the size is a multiple of MiB, because that's QEMU's
  granularity
- Remembered to write NEWS entry
- Worked in Peter's comments from v2 (mostly to make code more future
  proof)

Michal Prívozník (4):
  conf: Introduce TCG domain features
  qemu: Validate TCG feature is enabled only for TCG domains
  qemu: Generate command line for tb-cache feature
  NEWS: Document TCG features

 NEWS.rst                                      |  5 ++
 docs/formatdomain.rst                         | 11 ++++
 docs/schemas/domaincommon.rng                 | 15 ++++-
 src/conf/domain_conf.c                        | 58 ++++++++++++++++++-
 src/conf/domain_conf.h                        |  7 +++
 src/qemu/qemu_command.c                       |  5 ++
 src/qemu/qemu_validate.c                      | 17 ++++++
 ...efault-cpu-tcg-features.x86_64-latest.args | 36 ++++++++++++
 .../x86_64-default-cpu-tcg-features.xml       | 56 ++++++++++++++++++
 tests/qemuxml2argvtest.c                      |  1 +
 ...default-cpu-tcg-features.x86_64-latest.xml |  1 +
 tests/qemuxml2xmltest.c                       |  1 +
 12 files changed, 210 insertions(+), 3 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/x86_64-default-cpu-tcg-features.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/x86_64-default-cpu-tcg-features.xml
 create mode 120000 tests/qemuxml2xmloutdata/x86_64-default-cpu-tcg-features.x86_64-latest.xml

-- 
2.32.0

Re: [PATCH v3 0/4] Introduce TCG domain features
Posted by Peter Krempa 2 years, 3 months ago
On Thu, Dec 02, 2021 at 09:53:32 +0100, Michal Privoznik wrote:
> v3 of:
> 
> https://listman.redhat.com/archives/libvir-list/2021-November/msg00194.html
> 
> Note, patches 1/4 and 2/4 from v2 were pushed already.
> 
> diff to v2:
> - Split feature validation into a separate patch
> - Validate that the size is a multiple of MiB, because that's QEMU's
>   granularity
> - Remembered to write NEWS entry
> - Worked in Peter's comments from v2 (mostly to make code more future
>   proof)

With the stuff I've pointed out inline resolved:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>