From nobody Sun May 5 20:12:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634813134; cv=none; d=zohomail.com; s=zohoarc; b=eS7hApRJHOq27Vtbm/U9X6mgb1ddjiFfDq61Tw2xooUnPi5pwTJc7TOp+QIcQaGpDpjMRbaI4v4ZVC0n8dVpM9ATqu++/rx7Ng2i1rcHhtUVL62PNUWdAm3b8e+4m5Yaje7N2Aq12bPetBpB2kWJ2gxk6cKghoa0i3Qh/WN4qr4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634813134; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dAWzxJorhmMwJq0GMTxkXqSIQxiEkEPbOimedtMtRDU=; b=cDWl+GKhh1cCQmcTu3JCR9aGQdmEMCGIc49cT7JIEmITO3u2qBJYdRsW1lJPpLW9xoWBhD4Yt/ksk1eFBYakph9vWin5WR+158+QIKMD/CukbFo10qXS20GvTxNnwANWf7lfCZ33aZGSfEVC6bZrairB4h7+q2gv8zJEYV+5Thg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1634813134034442.7756919498996; Thu, 21 Oct 2021 03:45:34 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-507-6JMsWyneMZSyco33WkFugQ-1; Thu, 21 Oct 2021 06:45:31 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1F30802682; Thu, 21 Oct 2021 10:45:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A250460CA0; Thu, 21 Oct 2021 10:45:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4D093180BAD1; Thu, 21 Oct 2021 10:45:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19LAjIYc008865 for ; Thu, 21 Oct 2021 06:45:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id CF8BE19D9F; Thu, 21 Oct 2021 10:45:18 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EF7D1948C for ; Thu, 21 Oct 2021 10:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634813133; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dAWzxJorhmMwJq0GMTxkXqSIQxiEkEPbOimedtMtRDU=; b=hxRYHCswkdzskfZGHbXSemC7SofCAyV3NqJ9lkSSL7LOw+a0rw0gXJjYkAaOKWpeD9rItn aX2345GT4Oa973JDDa+lQNtYzq2oDHXtd2Dc0sV5d2/VPvbeGHAJwi8XQV0f7jQppvCjv+ YWZHc1ldGyFos7sUISsVSQaeXlF12Lk= X-MC-Unique: 6JMsWyneMZSyco33WkFugQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 1/6] qemumigparamstest: Drop "unsupported" test case Date: Thu, 21 Oct 2021 12:45:10 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634813134979100001 Content-Type: text/plain; charset="utf-8" The aim of "unsupported" test case is to check whether our code handles 'CommandNotFound' error returned for 'query-migrate-parameters' monitor command. Well, the command is pretty old and every QEMU that we are dealing with supports it. Thus this test case is useless. Drop it. Signed-off-by: Michal Privoznik --- tests/qemumigparamsdata/unsupported.json | 3 --- tests/qemumigparamsdata/unsupported.reply | 7 ------- tests/qemumigparamsdata/unsupported.xml | 4 ---- tests/qemumigparamstest.c | 1 - 4 files changed, 15 deletions(-) delete mode 100644 tests/qemumigparamsdata/unsupported.json delete mode 100644 tests/qemumigparamsdata/unsupported.reply delete mode 100644 tests/qemumigparamsdata/unsupported.xml diff --git a/tests/qemumigparamsdata/unsupported.json b/tests/qemumigparams= data/unsupported.json deleted file mode 100644 index 0db3279e44..0000000000 --- a/tests/qemumigparamsdata/unsupported.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - -} diff --git a/tests/qemumigparamsdata/unsupported.reply b/tests/qemumigparam= sdata/unsupported.reply deleted file mode 100644 index 2b88ba10c3..0000000000 --- a/tests/qemumigparamsdata/unsupported.reply +++ /dev/null @@ -1,7 +0,0 @@ -{ - "id": "libvirt-1", - "error": { - "class": "CommandNotFound", - "desc": "The command query-migrate-parameters has not been found" - } -} diff --git a/tests/qemumigparamsdata/unsupported.xml b/tests/qemumigparamsd= ata/unsupported.xml deleted file mode 100644 index 8aa3abefc0..0000000000 --- a/tests/qemumigparamsdata/unsupported.xml +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/tests/qemumigparamstest.c b/tests/qemumigparamstest.c index f445c92ff8..4ab40d9d2e 100644 --- a/tests/qemumigparamstest.c +++ b/tests/qemumigparamstest.c @@ -219,7 +219,6 @@ mymain(void) ret =3D -1; \ } while (0) =20 - DO_TEST("unsupported"); DO_TEST("empty"); DO_TEST("basic"); DO_TEST("tls"); --=20 2.32.0 From nobody Sun May 5 20:12:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634813130; cv=none; d=zohomail.com; s=zohoarc; b=nxHEI4zDkN8WF1WOApajavAooyZx0VfOTZ/6BcNErY5mK3xsuh9vxZpUkI5w3yVnFmIH6NLOUwZUUiOwLYx85J1Tbz+ShlYybsyZSsdUL90NOyeRfKCFv8v9hcGIYgfvFN4EBm6kY2MEmBhLhKRpbrp90T2157I2xDh681W/NgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634813130; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/JR0wwWoWSwpdF73/xDVyDX/lWP+f+dQA4sAm9mBf0U=; b=aEWG6UiSuDk9xHv6+6Yy2funPC26dv4O1eOBRFFsQotUKDQlJiRzWa1gi1YaasZWvYke2h+rMd9BC9IBl6MCk0nBhdsCrKe/zcBTtoe3TRv7r1nyc/o+DcSWnqbFQFBsv5Qk7icCoiOol+MdQWI/xLOLFP/nRUs2c1j8JC4/L/A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1634813130806293.9031313136867; Thu, 21 Oct 2021 03:45:30 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-7SCKrvt7OtmMgbnV_Qof7g-1; Thu, 21 Oct 2021 06:45:28 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BB531015DA1; Thu, 21 Oct 2021 10:45:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28D1670F5E; Thu, 21 Oct 2021 10:45:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 981354E58E; Thu, 21 Oct 2021 10:45:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19LAjJFo008873 for ; Thu, 21 Oct 2021 06:45:19 -0400 Received: by smtp.corp.redhat.com (Postfix) id AF9A3196AE; Thu, 21 Oct 2021 10:45:19 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3011019D9F for ; Thu, 21 Oct 2021 10:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634813129; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/JR0wwWoWSwpdF73/xDVyDX/lWP+f+dQA4sAm9mBf0U=; b=Se2Ol43nqp5j9L5IvSRLzQivbBnmE5wW+nlAx4zfHWWxDV+Gm2t0pGFy+Qop3ItsMlJVZc xwmGsSFtT1tdQo0vaZguOEYkVMjvLqCqoDoyp6sDQ2HZBkh1cjS0+opwsx+N900obIFpUK ArRGgq0LlIGHB29XjQD5mLM697BGs5w= X-MC-Unique: 7SCKrvt7OtmMgbnV_Qof7g-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 2/6] qemuMonitorJSONGetMigrationParams: Don't return early on CommandNotFound Date: Thu, 21 Oct 2021 12:45:11 +0200 Message-Id: <486f4bac10ac907e53c82594a19fa59d103ddf5b.1634813020.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634813132659100001 Content-Type: text/plain; charset="utf-8" The qemuMonitorJSONGetMigrationParams() function executes 'query-migrate-parameters' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 2.4 (specifically in commit v2.4.0-rc0~147^2~3) and since the minimum required version is 2.11.0 we can be sure that the command will always exist. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 7bf3a9981b..08cd535045 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3281,11 +3281,6 @@ qemuMonitorJSONGetMigrationParams(qemuMonitor *mon, if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) goto cleanup; =20 - if (qemuMonitorJSONHasError(reply, "CommandNotFound")) { - ret =3D 0; - goto cleanup; - } - if (qemuMonitorJSONCheckReply(cmd, reply, VIR_JSON_TYPE_OBJECT) < 0) goto cleanup; =20 --=20 2.32.0 From nobody Sun May 5 20:12:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634813141; cv=none; d=zohomail.com; s=zohoarc; b=J5d9IuIZ19U8jDBBDHSHN6yFK3GwRXGz7kuLVHSVXSZ/kZT/MXl9wh0Oy/WAb485NTlmxT5E3A4D/siWLN5H1Ys4FQpgJxTfkxF/8W8FV/LSxoxQKxnLB4DK8mD8H25Sqm8Qb+SUqbaRrbm3MjbCBY9Lt81tEXbSETskvDFLEcI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634813141; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DGnnQpl5eswdSMbtt0TujGmZOEuCB4D+4tbNIxWktHQ=; b=WRaeb72buNKJVREFHMJCUcVd9HqjswjldXIGxJi9seLv+umZfboazbBysIaRCX1UZ6RYl0Le3qwQ8p4l9zshapZzL3GbJwMThRUD9NH13YxqEbHz+toeXgkRnoZzTtsr8Ic8t/p4q++Pv1vIkhD7aJtu2mp201udQUEODsKjX+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1634813141148449.727754736356; Thu, 21 Oct 2021 03:45:41 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-98E64p9uPO-VDDEBrbncFQ-1; Thu, 21 Oct 2021 06:45:36 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 832A280DDF1; Thu, 21 Oct 2021 10:45:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA63517010; Thu, 21 Oct 2021 10:45:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 44768181A1D1; Thu, 21 Oct 2021 10:45:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19LAjK3V008885 for ; Thu, 21 Oct 2021 06:45:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 91769196AE; Thu, 21 Oct 2021 10:45:20 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 114FB19D9F for ; Thu, 21 Oct 2021 10:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634813140; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DGnnQpl5eswdSMbtt0TujGmZOEuCB4D+4tbNIxWktHQ=; b=S3qDuN6cXT3mN/uF6sAdvx4k40yfOZIg47gOoXrXfB/xWzt2hbAXvvlHjfaA1xL1RlEC48 2yNn1/I4tmD+FVHSH4F8K1fvJ+du1Hmm0ysyMK078dUKDknGtdhnYVYgGKySpTHxDyezWg nebelzS798/vd7mBaDscS2PhPjMKM/0= X-MC-Unique: 98E64p9uPO-VDDEBrbncFQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 3/6] qemuMonitorJSONGetDumpGuestMemoryCapability: Don't return early on CommandNotFound Date: Thu, 21 Oct 2021 12:45:12 +0200 Message-Id: <8ee983e2a1c5253bafbe66f7bf4860138c96535a.1634813020.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634813141482100001 Content-Type: text/plain; charset="utf-8" The qemuMonitorJSONGetDumpGuestMemoryCapability() command executes 'query-dump-guest-memory-capability' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 2.0 (specifically in commit v2.0.0-rc0~43^2~16) and since the minimum required version is 2.11.0 we can be sure that command will always exist. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 08cd535045..df3e14a153 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3666,11 +3666,6 @@ qemuMonitorJSONGetDumpGuestMemoryCapability(qemuMoni= tor *mon, if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) goto cleanup; =20 - if (qemuMonitorJSONHasError(reply, "CommandNotFound")) { - ret =3D 0; - goto cleanup; - } - if (qemuMonitorJSONCheckReply(cmd, reply, VIR_JSON_TYPE_OBJECT) < 0) goto cleanup; =20 --=20 2.32.0 From nobody Sun May 5 20:12:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634813142; cv=none; d=zohomail.com; s=zohoarc; b=ZVeul027pBVza6PHJLmgUjLJncsv7JxAytFlptq3Qm2si4jU4jPcyqEw7KEL24JI7beQUo23LzJsA2HhrS34txWJIuOe1f/2vhn7/pz4S5oqPwBS900yilqz5tFY4yMjajUQrYLDMrNaHRleu/N6++bMHk95Y56cU9/Gc3GuBXc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634813142; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AnH8HN9BJ4y9FeSDyuhy5bFDhk/TyQ2CDw9gpLfgMnU=; b=PtfuGRCmhDGqkXTccAoSRIjekIHwPQfRcumTLlQ0+Gb5iRmHY6To8vsJ46mJ7tCB7Oqp84qjinK+xojxQfrTovZrmgC+lDKrGJQaSW4mMdcI9K7GqBu+xufaoXdSzAy1SUJFEIcHcU8TJHVhULcy80EfyO2FtlskEPovrG52mTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1634813142334469.1775733578497; Thu, 21 Oct 2021 03:45:42 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-B_IrAnioNDG0p2B5INn3xw-1; Thu, 21 Oct 2021 06:45:37 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1E8C180FD85; Thu, 21 Oct 2021 10:45:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9750C6A8E5; Thu, 21 Oct 2021 10:45:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 48DFD4EA2F; Thu, 21 Oct 2021 10:45:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19LAjLZM008890 for ; Thu, 21 Oct 2021 06:45:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 70EFA19D9F; Thu, 21 Oct 2021 10:45:21 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id E5420196AE for ; Thu, 21 Oct 2021 10:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634813141; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AnH8HN9BJ4y9FeSDyuhy5bFDhk/TyQ2CDw9gpLfgMnU=; b=MtL6jVmuwAs09X/TGvQB27FkBkME7ieq0DFWIgert3gUVEDclTmLZBLN+UdLfR8eLw9kCs BZ2U75gXZfqFyNNBIqALAl7AhyqRuSv7/wy9mxzqwiO2jNPl/dmZGlYG7b1Ej1n05b95VF nBbGQd58dSfDhH1dNH9HkkD0I48z7Ww= X-MC-Unique: B_IrAnioNDG0p2B5INn3xw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 4/6] qemuMonitorJSONGetKVMState: Don't return early on CommandNotFound Date: Thu, 21 Oct 2021 12:45:13 +0200 Message-Id: <59f7b2012a21045855452deb7c501f8fc2ca32e8.1634813020.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634813143731100001 Content-Type: text/plain; charset="utf-8" The qemuMonitorJSONGetKVMState() command executes 'query-kvm' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 0.14 and since the minimum required version is 2.11.0 we can be sure that command will always exist. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index df3e14a153..70e3c70441 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6020,11 +6020,6 @@ int qemuMonitorJSONGetKVMState(qemuMonitor *mon, if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) goto cleanup; =20 - if (qemuMonitorJSONHasError(reply, "CommandNotFound")) { - ret =3D 0; - goto cleanup; - } - if (qemuMonitorJSONCheckReply(cmd, reply, VIR_JSON_TYPE_OBJECT) < 0) goto cleanup; =20 --=20 2.32.0 From nobody Sun May 5 20:12:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634813145; cv=none; d=zohomail.com; s=zohoarc; b=myu7cAyUmvKSayWBFcYEte0laM4v5Q2V4HHxdWDHQHrPcu0VDz7Lwvmn3EdfMfmLgGNdlBEacye/S2pyAhUM2w3bOngwwE2BM6lqpxpI8RmTJZSDdRW8afMdoFKNct0mlVf24wrkuVetzFjeSL2YM21Pnpo1ZLZyJG7KDhYAoOQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634813145; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PS1fylZxfgJG98dXQjToJBWhtAhW0phHxWfOxOiwIdc=; b=ErNYUgLlW6tdXszZf9SGJYNjyC4XNG0BnzwKwvlIC+s3xkDJTKFGyICDTvCF9VWzMoV+qJ8Drmj9wstLAoRiPjjYPbwW/mKQKHMlPydmB+FAmMWyz+Ql69OLoyyYvDoxbETiAjNtNYnwAw0QyGgJ/1NjC66BEFXce47FNlHHcvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1634813145478284.60151703650695; Thu, 21 Oct 2021 03:45:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-ByybeFa0MY66HPS434mWIw-1; Thu, 21 Oct 2021 06:45:40 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC5F918125CD; Thu, 21 Oct 2021 10:45:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8765D6F951; Thu, 21 Oct 2021 10:45:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4FFA24EA31; Thu, 21 Oct 2021 10:45:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19LAjM9S008900 for ; Thu, 21 Oct 2021 06:45:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 50BE1196AE; Thu, 21 Oct 2021 10:45:22 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id C51FA19D9F for ; Thu, 21 Oct 2021 10:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634813144; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PS1fylZxfgJG98dXQjToJBWhtAhW0phHxWfOxOiwIdc=; b=UKcwRiceXMkUsloV4GPAc3wm2Veyr34N2oGr2h/6CPdL8SL0dJnFwoG6o+9KTS7Q7ZjPmA GnxAoYsFOJJZpjMcbDVOMIlm8NfdlO9TPNu7IRc/mviJ5dQ9BJMkMQSyNqEA4tXUGW+lsY d5usfkva4ZP/xjdBPerSo3siZDu0NYQ= X-MC-Unique: ByybeFa0MY66HPS434mWIw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 5/6] qemuMonitorJSONGetMemoryDeviceInfo: Don't return early on CommandNotFound Date: Thu, 21 Oct 2021 12:45:14 +0200 Message-Id: <4e9a6639090ab35150d5d4592ea08710905e788c.1634813020.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634813146094100005 Content-Type: text/plain; charset="utf-8" The qemuMonitorJSONGetMemoryDeviceInfo() command executes 'query-memory-devices' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 2.1 (specifically in commit v2.1.0-rc0~41^2~9) and since the minimum required version is 2.11.0 we can be sure that command will always exist. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 70e3c70441..586b30763b 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7788,11 +7788,6 @@ qemuMonitorJSONGetMemoryDeviceInfo(qemuMonitor *mon, if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) goto cleanup; =20 - if (qemuMonitorJSONHasError(reply, "CommandNotFound")) { - ret =3D -2; - goto cleanup; - } - if (qemuMonitorJSONCheckReply(cmd, reply, VIR_JSON_TYPE_ARRAY) < 0) goto cleanup; =20 --=20 2.32.0 From nobody Sun May 5 20:12:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634813136; cv=none; d=zohomail.com; s=zohoarc; b=eNGgVxbR5w4wj5RYDKYT9pzeour1lYts8NDB5Jo37JR/zRNk/QvjFzTNqxoSThtdTMUL+xLO5G77SzWN2Vkwt0MR/uNTzfs06T9N6W0/e0OLy+lDzX/0ycrWIX4D/Pohi/eqb9bcl46OifFbfsrfRQ5oT/5Et+tvxX2AOniuFbw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634813136; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h87fEbQ6tK0IrWd1UQMvacycUoNO53/D0M0k2Y+53jQ=; b=ViYDwnoCPFI5vsPePuTEgB245glYpVeuoBHIRQ1497AGER40TbtkyvM630VIgs6RA1qTpZr4xDW0U4nt/FYZizF0Klkx5+uqBMZGcu7zQklKY+FnxYfKzrgx+iYsvF+75KpKwqwmqSqFdAqnLnUhxapk4pv5J3vFzwhpdMFkq0o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1634813136756610.6899147593463; Thu, 21 Oct 2021 03:45:36 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-EJIWvZE_NaC7Wh1plxZsAA-1; Thu, 21 Oct 2021 06:45:32 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E4D8880A5E0; Thu, 21 Oct 2021 10:45:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C38A15FC22; Thu, 21 Oct 2021 10:45:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 900634EA29; Thu, 21 Oct 2021 10:45:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19LAjN0b008906 for ; Thu, 21 Oct 2021 06:45:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 30B4B196AE; Thu, 21 Oct 2021 10:45:23 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4C5E19D9F for ; Thu, 21 Oct 2021 10:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634813135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=h87fEbQ6tK0IrWd1UQMvacycUoNO53/D0M0k2Y+53jQ=; b=cyUZZIkrrEGKNLX6m/ZCOjZ7cAJB3h9/dofIYlxp3YAsWtQ0KAHCUGx2uAMXza1eMuyNPm 4LnjX+FENzop3KESPZFbBDoP3I+Ad+oEBBthimv78/yCxmGGUqBta7H80ED8D+U+FwEjvu iV+Dp8wDA0aDkmFF5sl4iSX0iP7ERuo= X-MC-Unique: EJIWvZE_NaC7Wh1plxZsAA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 6/6] qemuMonitorJSONGetMigrationCapabilities: Don't return early on CommandNotFound Date: Thu, 21 Oct 2021 12:45:15 +0200 Message-Id: <38357430ec22b965aa11b159eed3688f061ab84a.1634813020.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634813137547100001 Content-Type: text/plain; charset="utf-8" The qemuMonitorJSONGetMigrationCapabilities() command executes 'query-migrate-capabilities' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 1.2 (specifically in commit v1.2.0-rc0~29^2~11) and since the minimum required version is 2.11.0 we can be sure that command will always exist. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 586b30763b..a7a980fccd 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6518,9 +6518,6 @@ qemuMonitorJSONGetMigrationCapabilities(qemuMonitor *= mon, if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) return -1; =20 - if (qemuMonitorJSONHasError(reply, "CommandNotFound")) - return 0; - if (qemuMonitorJSONCheckReply(cmd, reply, VIR_JSON_TYPE_ARRAY) < 0) return -1; =20 --=20 2.32.0