[PATCH 0/8] qemu: Report proper stats when a backup job is running

Peter Krempa posted 8 patches 2 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1634654476.git.pkrempa@redhat.com
src/qemu/qemu_driver.c           | 31 ++++++-------
src/qemu/qemu_migration_cookie.c |  2 +-
src/qemu/qemu_monitor.c          | 20 +++------
src/qemu/qemu_monitor.h          |  6 +--
src/qemu/qemu_monitor_json.c     | 74 +++++++++++---------------------
src/qemu/qemu_monitor_json.h     |  6 +--
tests/qemumonitorjsontest.c      |  2 +-
7 files changed, 48 insertions(+), 93 deletions(-)
[PATCH 0/8] qemu: Report proper stats when a backup job is running
Posted by Peter Krempa 2 years, 5 months ago
Patch 1 fixes the bug this series is about, patch 2 fixes same thing in
the bulk stats. Patches 3-6 remove some pointless cleanup sections and
patches 7-8 remove the 'backingChain' argument as we always want to
fetch all stats.

Peter Krempa (8):
  qemuDomainBlocksStatsGather: Always fetch stats for the full backing
    chain
  qemuDomainGetStatsBlock: Always fetch stats for the full backing chain
  qemuMonitorJSONBlockStatsUpdateCapacity: Refactor cleanup
  qemuMonitorJSONBlockStatsUpdateCapacityOne: Refactor cleanup
  qemuDomainGetStatsBlock: Refactor cleanup
  qemuMonitorJSONQueryBlockstats: Refactor cleanup
  qemuMonitorGetAllBlockStatsInfo: Remove 'backingChain' argument
  qemuMonitorBlockStatsUpdateCapacity: Remove 'backingChain' argument

 src/qemu/qemu_driver.c           | 31 ++++++-------
 src/qemu/qemu_migration_cookie.c |  2 +-
 src/qemu/qemu_monitor.c          | 20 +++------
 src/qemu/qemu_monitor.h          |  6 +--
 src/qemu/qemu_monitor_json.c     | 74 +++++++++++---------------------
 src/qemu/qemu_monitor_json.h     |  6 +--
 tests/qemumonitorjsontest.c      |  2 +-
 7 files changed, 48 insertions(+), 93 deletions(-)

-- 
2.31.1

Re: [PATCH 0/8] qemu: Report proper stats when a backup job is running
Posted by Michal Prívozník 2 years, 5 months ago
On 10/19/21 4:43 PM, Peter Krempa wrote:
> Patch 1 fixes the bug this series is about, patch 2 fixes same thing in
> the bulk stats. Patches 3-6 remove some pointless cleanup sections and
> patches 7-8 remove the 'backingChain' argument as we always want to
> fetch all stats.
> 
> Peter Krempa (8):
>   qemuDomainBlocksStatsGather: Always fetch stats for the full backing
>     chain
>   qemuDomainGetStatsBlock: Always fetch stats for the full backing chain
>   qemuMonitorJSONBlockStatsUpdateCapacity: Refactor cleanup
>   qemuMonitorJSONBlockStatsUpdateCapacityOne: Refactor cleanup
>   qemuDomainGetStatsBlock: Refactor cleanup
>   qemuMonitorJSONQueryBlockstats: Refactor cleanup
>   qemuMonitorGetAllBlockStatsInfo: Remove 'backingChain' argument
>   qemuMonitorBlockStatsUpdateCapacity: Remove 'backingChain' argument
> 
>  src/qemu/qemu_driver.c           | 31 ++++++-------
>  src/qemu/qemu_migration_cookie.c |  2 +-
>  src/qemu/qemu_monitor.c          | 20 +++------
>  src/qemu/qemu_monitor.h          |  6 +--
>  src/qemu/qemu_monitor_json.c     | 74 +++++++++++---------------------
>  src/qemu/qemu_monitor_json.h     |  6 +--
>  tests/qemumonitorjsontest.c      |  2 +-
>  7 files changed, 48 insertions(+), 93 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal