[libvirt PATCH 0/9] tests: cputest: use g_auto more (glib chronicles)

Ján Tomko posted 9 patches 2 years, 7 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1629470763.git.jtomko@redhat.com
src/qemu/qemu_monitor.h       |   1 +
tests/cputest.c               | 239 +++++++++++-----------------------
tests/qemustatusxml2xmltest.c |   3 +-
tests/qemuxml2argvtest.c      |  10 +-
tests/qemuxml2xmltest.c       |   9 +-
tests/testutils.c             |  30 +++++
tests/testutils.h             |   4 +
tests/testutilsqemu.h         |   1 -
8 files changed, 114 insertions(+), 183 deletions(-)
[libvirt PATCH 0/9] tests: cputest: use g_auto more (glib chronicles)
Posted by Ján Tomko 2 years, 7 months ago
Also improve the compilation times (unoptimized optimization routines
take too long when there are too many branches in a function, which
is the case of cputest's main) and switch qemuxml2* to use the same
approach.

Ján Tomko (9):
  qemu: monitor: define cleanup function for qemuMonitorCPUModelInfo
  tests: use g_auto in cpuTestMakeQEMUCaps
  tests: cputest: use g_auto for virQEMUCaps
  tests: cputest: use g_auto for virCPUData
  tests: cputest: use g_auto for virCPUDef
  tests: cputest: use g_autofree
  tests: cputest: remove unnecessary labels
  tests: cputests: introduce and use virTestRunLog
  tests: qemuxml2*test: switch to virRunTestLog

 src/qemu/qemu_monitor.h       |   1 +
 tests/cputest.c               | 239 +++++++++++-----------------------
 tests/qemustatusxml2xmltest.c |   3 +-
 tests/qemuxml2argvtest.c      |  10 +-
 tests/qemuxml2xmltest.c       |   9 +-
 tests/testutils.c             |  30 +++++
 tests/testutils.h             |   4 +
 tests/testutilsqemu.h         |   1 -
 8 files changed, 114 insertions(+), 183 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/9] tests: cputest: use g_auto more (glib chronicles)
Posted by Michal Prívozník 2 years, 7 months ago
On 8/20/21 4:48 PM, Ján Tomko wrote:
> Also improve the compilation times (unoptimized optimization routines
> take too long when there are too many branches in a function, which
> is the case of cputest's main) and switch qemuxml2* to use the same
> approach.
> 
> Ján Tomko (9):
>   qemu: monitor: define cleanup function for qemuMonitorCPUModelInfo
>   tests: use g_auto in cpuTestMakeQEMUCaps
>   tests: cputest: use g_auto for virQEMUCaps
>   tests: cputest: use g_auto for virCPUData
>   tests: cputest: use g_auto for virCPUDef
>   tests: cputest: use g_autofree
>   tests: cputest: remove unnecessary labels
>   tests: cputests: introduce and use virTestRunLog
>   tests: qemuxml2*test: switch to virRunTestLog
> 
>  src/qemu/qemu_monitor.h       |   1 +
>  tests/cputest.c               | 239 +++++++++++-----------------------
>  tests/qemustatusxml2xmltest.c |   3 +-
>  tests/qemuxml2argvtest.c      |  10 +-
>  tests/qemuxml2xmltest.c       |   9 +-
>  tests/testutils.c             |  30 +++++
>  tests/testutils.h             |   4 +
>  tests/testutilsqemu.h         |   1 -
>  8 files changed, 114 insertions(+), 183 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal