[libvirt PATCH 0/6] Use g_auto for more libxml2 functions (glib chronicles)

Ján Tomko posted 6 patches 2 years, 7 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1629203014.git.jtomko@redhat.com
src/conf/checkpoint_conf.c       |  3 +--
src/conf/cpu_conf.c              | 30 ++++++++------------------
src/conf/domain_conf.c           |  6 ++----
src/conf/interface_conf.c        |  3 +--
src/conf/node_device_conf.c      |  3 +--
src/conf/nwfilter_conf.c         |  3 +--
src/conf/secret_conf.c           |  3 +--
src/conf/snapshot_conf.c         |  3 +--
src/conf/storage_conf.c          |  6 ++----
src/conf/virnetworkobj.c         | 37 +++++++++++---------------------
src/conf/virnetworkportdef.c     | 16 +++++---------
src/conf/virnwfilterbindingdef.c | 16 +++++---------
src/conf/virnwfilterbindingobj.c | 16 +++++---------
src/conf/virsavecookie.c         | 20 ++++++-----------
src/conf/virstorageobj.c         | 21 +++++++-----------
src/esx/esx_vi.c                 |  4 +---
src/libxl/libxl_migration.c      | 14 ++++--------
src/qemu/qemu_capabilities.c     |  6 ++----
src/qemu/qemu_migration_cookie.c | 15 ++++---------
src/security/virt-aa-helper.c    | 23 +++++++-------------
src/storage/storage_util.c       | 23 +++++++-------------
src/test/test_driver.c           | 17 +++++----------
src/util/virxml.c                |  3 +--
src/vbox/vbox_snapshot_conf.c    | 21 ++++++------------
src/vz/vz_driver.c               | 10 +++------
src/vz/vz_sdk.c                  |  6 ++----
tests/cputest.c                  | 35 +++++++++++-------------------
tests/metadatatest.c             | 22 ++++++-------------
tests/qemucaps2xmltest.c         |  8 ++-----
tests/virnetdevbandwidthtest.c   |  6 ++----
30 files changed, 129 insertions(+), 270 deletions(-)
[libvirt PATCH 0/6] Use g_auto for more libxml2 functions (glib chronicles)
Posted by Ján Tomko 2 years, 7 months ago
Use g_auto for the remaining users of xmlFreeDoc and
xmlXPathFreeContext. Also, remove redundant labels where easily
possible.

Ján Tomko (6):
  conf: virCPUDefListParse: reduce scope of variables
  conf: refactor virNetworkLoadState
  Use g_auto for xmlXPathContext everywhere
  Use g_auto for xmlFreeDoc everywhere
  Use g_autofree in affected functions
  Remove redundant labels

 src/conf/checkpoint_conf.c       |  3 +--
 src/conf/cpu_conf.c              | 30 ++++++++------------------
 src/conf/domain_conf.c           |  6 ++----
 src/conf/interface_conf.c        |  3 +--
 src/conf/node_device_conf.c      |  3 +--
 src/conf/nwfilter_conf.c         |  3 +--
 src/conf/secret_conf.c           |  3 +--
 src/conf/snapshot_conf.c         |  3 +--
 src/conf/storage_conf.c          |  6 ++----
 src/conf/virnetworkobj.c         | 37 +++++++++++---------------------
 src/conf/virnetworkportdef.c     | 16 +++++---------
 src/conf/virnwfilterbindingdef.c | 16 +++++---------
 src/conf/virnwfilterbindingobj.c | 16 +++++---------
 src/conf/virsavecookie.c         | 20 ++++++-----------
 src/conf/virstorageobj.c         | 21 +++++++-----------
 src/esx/esx_vi.c                 |  4 +---
 src/libxl/libxl_migration.c      | 14 ++++--------
 src/qemu/qemu_capabilities.c     |  6 ++----
 src/qemu/qemu_migration_cookie.c | 15 ++++---------
 src/security/virt-aa-helper.c    | 23 +++++++-------------
 src/storage/storage_util.c       | 23 +++++++-------------
 src/test/test_driver.c           | 17 +++++----------
 src/util/virxml.c                |  3 +--
 src/vbox/vbox_snapshot_conf.c    | 21 ++++++------------
 src/vz/vz_driver.c               | 10 +++------
 src/vz/vz_sdk.c                  |  6 ++----
 tests/cputest.c                  | 35 +++++++++++-------------------
 tests/metadatatest.c             | 22 ++++++-------------
 tests/qemucaps2xmltest.c         |  8 ++-----
 tests/virnetdevbandwidthtest.c   |  6 ++----
 30 files changed, 129 insertions(+), 270 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/6] Use g_auto for more libxml2 functions (glib chronicles)
Posted by Pavel Hrdina 2 years, 7 months ago
On Tue, Aug 17, 2021 at 02:25:27PM +0200, Ján Tomko wrote:
> Use g_auto for the remaining users of xmlFreeDoc and
> xmlXPathFreeContext. Also, remove redundant labels where easily
> possible.
> 
> Ján Tomko (6):
>   conf: virCPUDefListParse: reduce scope of variables
>   conf: refactor virNetworkLoadState
>   Use g_auto for xmlXPathContext everywhere
>   Use g_auto for xmlFreeDoc everywhere
>   Use g_autofree in affected functions
>   Remove redundant labels

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>