From nobody Sun May 5 21:48:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627033458; cv=none; d=zohomail.com; s=zohoarc; b=clwz4Rxgu+cOaaTSSjVPkLqNpIa3WblGafmSuDnw8ryVeVf10VaD2qEV4wOuN3FNC9M9rrFCU8o+MxfWYNP7WELvauHWpUG+2qgTkq8KT4v6A7ocYq/SptRXpjloTFAvrEADhh6d9SNgsMyuzQzfU+KMtmFvaY+wXu37wmG75lQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627033458; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+dsmodNVwV17bZQzUYJVoJARrVkBCdVIKPf45lYYKIg=; b=Pi8xkx/cIz42vKRdG51SmsCajIqQ22MeIXkieCWfH06bWf0IT3KLs55BKguUBwmnbMsLaN6grKBl1LdT275pDD9sKuCHUWoACIejSdDqbSGZhcjX3cYDJhMvRUU97zV5IwarnoFBSIuEPL0H5GtL5LEY0Ald5lw0DdiBDpgGLs4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1627033458024199.55761541388335; Fri, 23 Jul 2021 02:44:18 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-ZWbdBZ4eMyCFlc_BCI6AZQ-1; Fri, 23 Jul 2021 05:44:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 66D0E107B791; Fri, 23 Jul 2021 09:44:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E5801B5B7; Fri, 23 Jul 2021 09:44:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 80685180BAB0; Fri, 23 Jul 2021 09:44:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9i4U9022888 for ; Fri, 23 Jul 2021 05:44:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id D5EEB5C1D5; Fri, 23 Jul 2021 09:44:04 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4333C5C1D1 for ; Fri, 23 Jul 2021 09:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627033457; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+dsmodNVwV17bZQzUYJVoJARrVkBCdVIKPf45lYYKIg=; b=RzHU3PMhDKnJWXnYrSsbsYTOWWoA1X+FMDM5p+MSOotiYRzFL0smH7iT4l3AcjiMXzw3+Y AHPQr2BFZa77g/USkW7bwfWRoNRB2qIJByloODdFy4xJCX+j7HQ3CYT1EbhoPsKHiAUqft WfynDLrq64ixbuwV/FU43qxM0TTRLzA= X-MC-Unique: ZWbdBZ4eMyCFlc_BCI6AZQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/6] tests: qemucapabilities: Update capabilities for qemu-6.1.0-rc0 on x86_64 Date: Fri, 23 Jul 2021 11:43:53 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627033459358100001 Content-Type: text/plain; charset="utf-8" Update to XXXXXXX (I'll update once paolos fixes are merged) Notable changes are: - stabilization of 'blockdev-reopen' - addition of the 'vmx-tsc-scaling' cpu flag - Supported display types are now in the schema only if they are compiled = in. - rbd image encryption - 'aio-max-batch' iothread property Based on: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg05922.html Reviewed-by: Pavel Hrdina --- Please fetch the full version from the git repository. .../caps_6.1.0.x86_64.replies | 4245 +++++++++-------- .../caps_6.1.0.x86_64.xml | 6 +- 2 files changed, 2240 insertions(+), 2011 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies b/tests/q= emucapabilitiesdata/caps_6.1.0.x86_64.replies index 5fa8a07aa5..dac4f2fb2e 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 50, + "micro": 90, "minor": 0, "major": 6 }, - "package": "v6.0.0-1910-gd0ac9a6147" + "package": "v6.1.0-rc0-47-g8e5c9da9b5" }, "id": "libvirt-2" } [...] diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.1.0.x86_64.xml index a833dc9396..9d04a8b4a5 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml @@ -260,10 +260,10 @@ - 6000050 + 6000090 0 43100243 - v6.0.0-1910-gd0ac9a6147 + v6.1.0-rc0-47-g8e5c9da9b5 x86_64 @@ -285,6 +285,7 @@ + @@ -1652,6 +1653,7 @@ + --=20 2.31.1 From nobody Sun May 5 21:48:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627033459; cv=none; d=zohomail.com; s=zohoarc; b=ZPcpU/85p0WwzZUtLhImUy7dkmqGMSM/Ua7VvGKtSkscorGN9ZMfReYC6d9U1FdYQAXW4V2G8TfuyzRD4Sj38Ip8gjaWK5qBB94cu4WezPdJMvYnUZxJFBtjUKlThk+QDZJm+ItZA8ud8lyCDr8D0gUZB3eENteuilCDVUngwhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627033459; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=49TjE5SSx+JS+wjFTjB+g/xmKDohb0PhfgbKwtHwIPs=; b=S2nOGZfTWsx4bPBcZZQ2l9paMOn9wf64PYutJsbOP90nr/wJ2LFcu9xhWl9HLsOc8xhO5TdYbABfC3maGIWmIMRM9TnDx51DN4DJtS0MSk0IESDEBwv4mIaMaO9BZ6dvxbETR/4p81fQaYlOXrSnPy2B9XWLhJunesfia2zzWZA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1627033459406826.9190171585794; Fri, 23 Jul 2021 02:44:19 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-gLm-orGzP3SnQmBnkExYxg-1; Fri, 23 Jul 2021 05:44:16 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D36A287D542; Fri, 23 Jul 2021 09:44:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B51F55C1D1; Fri, 23 Jul 2021 09:44:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 71EAA4A7CB; Fri, 23 Jul 2021 09:44:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9i5Qp022893 for ; Fri, 23 Jul 2021 05:44:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id DDED25C22A; Fri, 23 Jul 2021 09:44:05 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4497F5C1D5 for ; Fri, 23 Jul 2021 09:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627033458; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=49TjE5SSx+JS+wjFTjB+g/xmKDohb0PhfgbKwtHwIPs=; b=b4dyH8FkSEKA4OVCF3nWQg8bB0NYXOcLpEXfQHVqxya2/A0ZF5ZdWFEmW8RtrDXwazEWz2 3V1Q5I6QX9kGqZ9of4aKfq1cKG7otyPEwRRbQxOV2JKlcQv8nmOipmqSy7Fms8+26KJtId jtIeZmpW2ixiCQYQMBvbNKKFNLjECMk= X-MC-Unique: gLm-orGzP3SnQmBnkExYxg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/6] qemuBlockReopenFormat: Extract @src handling and monitor invocation Date: Fri, 23 Jul 2021 11:43:54 +0200 Message-Id: <3f8dd67d0fff0ce8cbe29d1fc105d3908685b9bf.1627033243.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627033461601100001 Content-Type: text/plain; charset="utf-8" This will simplify testing of the blockdev-reopen code once it's enabled. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_block.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 6627d044cd..c96be8b52d 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3299,6 +3299,22 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSource = *topsrc, } +static int +qemuBlockReopenFormatMon(qemuMonitor *mon, + virStorageSource *src) +{ + g_autoptr(virJSONValue) reopenprops =3D NULL; + + if (!(reopenprops =3D qemuBlockStorageSourceGetBlockdevProps(src, src-= >backingStore))) + return -1; + + if (qemuMonitorBlockdevReopen(mon, &reopenprops) < 0) + return -1; + + return 0; +} + + /** * qemuBlockReopenFormat: * @vm: domain object @@ -3316,7 +3332,6 @@ qemuBlockReopenFormat(virDomainObj *vm, { qemuDomainObjPrivate *priv =3D vm->privateData; virQEMUDriver *driver =3D priv->driver; - g_autoptr(virJSONValue) reopenprops =3D NULL; int rc; /* If we are lacking the object here, qemu might have opened an image = with @@ -3327,13 +3342,10 @@ qemuBlockReopenFormat(virDomainObj *vm, return -1; } - if (!(reopenprops =3D qemuBlockStorageSourceGetBlockdevProps(src, src-= >backingStore))) - return -1; - if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0) return -1; - rc =3D qemuMonitorBlockdevReopen(priv->mon, &reopenprops); + rc =3D qemuBlockReopenFormatMon(priv->mon, src); if (qemuDomainObjExitMonitor(driver, vm) < 0 || rc < 0) return -1; --=20 2.31.1 From nobody Sun May 5 21:48:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627033469; cv=none; d=zohomail.com; s=zohoarc; b=DsjzpqEUu5D6CA+hDX+32emoUL4/w1BmWU9EHyS5o2NThgqTCGv74dF1D//HIvFzMHh8S3TpIvK2CwI8kVHSXRepTphjBYmafIcqDqLQzVF7Dr85mKAynkJ6IOUw0kieTStEi6eUbktdclYpLG988W19ZbXMxe/3mll65/WodDg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627033469; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VoTEjNeew88KOf3TQB9hh5LufjiKydD3NRXb4uKbBvQ=; b=XBjLIP5r2Wgi9/dO/Ls/R9gCGfuiJboLEFyfkmXHr0/6nDHR39es882VHQRpUYZTj1vmv1KgJP5QFGBE+kMXQ4E5DkS8dEKonBzSObD/PtHvB2Yf4JyrWHFGiRv48z7U9mroE7Pch5gehbLv7tSIfBiWixHSevjhVcV7buNPwhs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1627033469933955.8695961222511; Fri, 23 Jul 2021 02:44:29 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-jN7qK_S9MGqTH-jCaY9gig-1; Fri, 23 Jul 2021 05:44:27 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 908A4192CC43; Fri, 23 Jul 2021 09:44:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 718855D9D5; Fri, 23 Jul 2021 09:44:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3B7FE180BAB3; Fri, 23 Jul 2021 09:44:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9i6sJ022898 for ; Fri, 23 Jul 2021 05:44:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id E21A45C230; Fri, 23 Jul 2021 09:44:06 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 544B25C1D5 for ; Fri, 23 Jul 2021 09:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627033468; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VoTEjNeew88KOf3TQB9hh5LufjiKydD3NRXb4uKbBvQ=; b=Gj1D00qZWosa9U25QgmXiz4zS4tOQFXsOnmUDyRgXdLmMmACqiIdKB8eZlaCrPJO4/HR6P T2bLS+owh7vpRsBwXCjqqLdIFLtQjUkOWcTdVrGdjJpzA5Xf4vr9yNCvlYcaBWse+DxyyZ A303YjsQFQfkTD24swB5cKFDrXMOkZQ= X-MC-Unique: jN7qK_S9MGqTH-jCaY9gig-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/6] qemuBlockReopenFormatMon: Adapt to new argument format of 'blockdev-reopen' Date: Fri, 23 Jul 2021 11:43:55 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627033470167100001 Content-Type: text/plain; charset="utf-8" This function was added prior 'blockdev-reopen' being stable and qemu changed the arguments to actually contain an array of block node definitions to reopen. In our case we are just changing between read-only and read-write modes and thus we can keep operating on the nodes one-by-one. Modify the code to add the wrapper array. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_block.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index c96be8b52d..d9b876e5c1 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3304,8 +3304,18 @@ qemuBlockReopenFormatMon(qemuMonitor *mon, virStorageSource *src) { g_autoptr(virJSONValue) reopenprops =3D NULL; + g_autoptr(virJSONValue) srcprops =3D NULL; + g_autoptr(virJSONValue) reopenoptions =3D virJSONValueNewArray(); - if (!(reopenprops =3D qemuBlockStorageSourceGetBlockdevProps(src, src-= >backingStore))) + if (!(srcprops =3D qemuBlockStorageSourceGetBlockdevProps(src, src->ba= ckingStore))) + return -1; + + if (virJSONValueArrayAppend(reopenoptions, &srcprops) < 0) + return -1; + + if (virJSONValueObjectCreate(&reopenprops, + "a:options", &reopenoptions, + NULL) < 0) return -1; if (qemuMonitorBlockdevReopen(mon, &reopenprops) < 0) --=20 2.31.1 From nobody Sun May 5 21:48:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627033470; cv=none; d=zohomail.com; s=zohoarc; b=Ec+bJtu2f5jo98jo6OEnTozdG322swNe2qNYwNH49lU0NUhbz4nS5L+604hniJztGb/m53syyo3gsOX1a3XQxgdgZngKrOo3cd4s1paIj+x4UJbrqYGvVWCjQ1orQJedKDbjH2frYvRPeTc/5JFeMMqKkJSknA85aqimFByde+8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627033470; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XYWCKYZlpSJBqfzoAzhmvg7jhCHQKbCmQdwLSak3MCM=; b=AucCTFspZMSDbM4ZtbYMguSbzD9Ny0X7ybLJcS63Melpuzgw2S/f+lM+PWJ6H7T2iux1Q8u2RDZHF9fYDFhMQQpqj3Fr8OU45d/AkH0zTOfGD7huAq/WeszDNLOclZ8u3fbcm/k+8KZgP/Vt8/vJWsCa4677C7uStwdxm+l+Upc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1627033470961102.67214718314347; Fri, 23 Jul 2021 02:44:30 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-ULdc_-n7NAyQc5EQq8fCyQ-1; Fri, 23 Jul 2021 05:44:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A071A100CF6F; Fri, 23 Jul 2021 09:44:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 81EC55C1D5; Fri, 23 Jul 2021 09:44:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 49D04180BAB2; Fri, 23 Jul 2021 09:44:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9i7th022903 for ; Fri, 23 Jul 2021 05:44:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id E8F7B5C22A; Fri, 23 Jul 2021 09:44:07 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F77C5C1D5 for ; Fri, 23 Jul 2021 09:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627033470; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XYWCKYZlpSJBqfzoAzhmvg7jhCHQKbCmQdwLSak3MCM=; b=dII546rPOpM4KhhpbQMPcO+v1MDjsI+fYbi1QUWW9tRe0uRHB95WajcesD5+T3wRCOWvjD VWwyrK50YDT7uVd+U/HgPuxThXP1zVtQHc7TR0OBlvmEB3OXBhcjZcS0TP54EMLMLKkfgK yTI1xYVMWqXNUe3pxpip9yXYJUL1XXo= X-MC-Unique: ULdc_-n7NAyQc5EQq8fCyQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 4/6] qemumonitorjsontest: Add test case for 'blockdev-reopen' Date: Fri, 23 Jul 2021 11:43:56 +0200 Message-Id: <35453c9c93e310fc37c26d1298c7040df661731b.1627033243.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627033472245100003 Content-Type: text/plain; charset="utf-8" Export 'qemuBlockReopenFormatMon' and use it in a new test case wich will validate the arguments against the QMP schema. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_block.h | 5 +++++ tests/qemumonitorjsontest.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 34 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index d9b876e5c1..eedcfd927f 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3299,7 +3299,7 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSource *= topsrc, } -static int +int qemuBlockReopenFormatMon(qemuMonitor *mon, virStorageSource *src) { diff --git a/src/qemu/qemu_block.h b/src/qemu/qemu_block.h index ff7048eb6c..54601a48a9 100644 --- a/src/qemu/qemu_block.h +++ b/src/qemu/qemu_block.h @@ -265,6 +265,11 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSource *t= opsrc, GHashTable *blockNamedNodeData, virJSONValue **actions); +/* only for use in qemumonitorjsontest */ +int +qemuBlockReopenFormatMon(qemuMonitor *mon, + virStorageSource *src); + int qemuBlockReopenReadWrite(virDomainObj *vm, virStorageSource *src, diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 0b321e8ed8..2122d9d999 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2800,6 +2800,33 @@ testQemuMonitorJSONBlockExportAdd(const void *opaque) return 0; } + +static int +testQemuMonitorJSONBlockdevReopen(const void *opaque) +{ + const testGenericData *data =3D opaque; + g_autoptr(qemuMonitorTest) test =3D NULL; + g_autoptr(virStorageSource) src =3D virStorageSourceNew(); + + if (!(test =3D qemuMonitorTestNewSchema(data->xmlopt, data->schema))) + return -1; + + src->format =3D VIR_STORAGE_FILE_QCOW2; + src->readonly =3D true; + src->nodeformat =3D g_strdup("test node"); + src->nodestorage =3D g_strdup("backing nodename"); + src->backingStore =3D virStorageSourceNew(); + + if (qemuMonitorTestAddItem(test, "blockdev-reopen", "{\"return\":{}}")= < 0) + return -1; + + if (qemuBlockReopenFormatMon(qemuMonitorTestGetMonitor(test), src) < 0) + return -1; + + return 0; +} + + static int testQemuMonitorJSONqemuMonitorJSONGetCPUModelComparison(const void *opaque) { @@ -2997,6 +3024,7 @@ mymain(void) DO_TEST(GetIOThreads); DO_TEST(Transaction); DO_TEST(BlockExportAdd); + DO_TEST(BlockdevReopen); DO_TEST_SIMPLE("qmp_capabilities", qemuMonitorJSONSetCapabilities); DO_TEST_SIMPLE("system_powerdown", qemuMonitorJSONSystemPowerdown); DO_TEST_SIMPLE("system_reset", qemuMonitorJSONSystemReset); --=20 2.31.1 From nobody Sun May 5 21:48:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627033506; cv=none; d=zohomail.com; s=zohoarc; b=N+kBKKxOI2YwPphLr0FHnJOggUJHlbAu5WYQvVa3ySIWmHkxWt53IL4sIrh8/AXeFuhFUAHlX7yS3sHLYlY3SFzou8jcssOo22DP963o+iwGy/waPvURFhRQ9RgRs1XWtg810LtxBBSec3uD2VaWnK5jVxG/pxUl8O4XI06DK/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627033506; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uwYwd9U8vNqjhpHfJWapRVxeH6Epj8OmRfHOtCTR2zg=; b=VRJg8akNP3lb9zeu8CS/7vJaG4GojDAqH//wmr/hUHRUF+hDaeRBYOGfugH49N6+U+jccU5yxVBiLkVHth/eebzqwUvbGCmIWbl5774mnmj8Iec0wB/nCXJHt3gxvSHpg2+PPFszvQUHlvevJTWyh7zjAB8HCU53i0eaOiZ6wX8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1627033506249482.44593945952977; Fri, 23 Jul 2021 02:45:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-tKSccEiHMnGqWKfA_pmcAA-1; Fri, 23 Jul 2021 05:44:33 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9253F87D549; Fri, 23 Jul 2021 09:44:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6FF685D9DE; Fri, 23 Jul 2021 09:44:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3AC03180BAD2; Fri, 23 Jul 2021 09:44:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9i8NE022908 for ; Fri, 23 Jul 2021 05:44:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id EE8655C22A; Fri, 23 Jul 2021 09:44:08 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E3655C1D5 for ; Fri, 23 Jul 2021 09:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627033505; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uwYwd9U8vNqjhpHfJWapRVxeH6Epj8OmRfHOtCTR2zg=; b=YILEQdnRAHUMRLdD3ysadp8KAQOqkIJNYYp+xMELBY03e7fkXPgOJ3JngRaozKos2YtCbq ekMnaP/u085DVSqwu2YJIOq8QSmaH2+k1Qf/uLowsrBe95j00pbK6TrRdDQS2pTtVkNqRn PMialZjT9DYRgmEOF5azAMoSNUjykpA= X-MC-Unique: tKSccEiHMnGqWKfA_pmcAA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 5/6] qemu: capabilities: Enable detection of QEMU_CAPS_BLOCKDEV_REOPEN Date: Fri, 23 Jul 2021 11:43:57 +0200 Message-Id: <5d2a475d164441de0a90e6b76d77fff072693187.1627033243.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627033506904100001 Content-Type: text/plain; charset="utf-8" Base it on the presence of the "blockdev-reopen" QMP command. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 1 + tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 2 +- tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 2 +- tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 2 +- tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 2 ++ 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 6cea8c2eca..c31c80eaf3 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1182,6 +1182,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = =3D { { "query-cpu-model-comparison", QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON }, { "block-export-add", QEMU_CAPS_BLOCK_EXPORT_ADD }, { "query-display-options", QEMU_CAPS_QUERY_DISPLAY_OPTIONS }, + { "blockdev-reopen", QEMU_CAPS_BLOCKDEV_REOPEN }, }; struct virQEMUCapsStringFlags virQEMUCapsMigration[] =3D { diff --git a/tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml b/tests/domainc= apsdata/qemu_6.1.0-q35.x86_64.xml index 62bc6bdf05..98b9c06cd1 100644 --- a/tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml +++ b/tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml @@ -216,7 +216,7 @@ - + diff --git a/tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml b/tests/domainc= apsdata/qemu_6.1.0-tcg.x86_64.xml index 69d5f7e404..a9b4011557 100644 --- a/tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml +++ b/tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml @@ -219,7 +219,7 @@ - + diff --git a/tests/domaincapsdata/qemu_6.1.0.x86_64.xml b/tests/domaincapsd= ata/qemu_6.1.0.x86_64.xml index a21c131d41..91a845204b 100644 --- a/tests/domaincapsdata/qemu_6.1.0.x86_64.xml +++ b/tests/domaincapsdata/qemu_6.1.0.x86_64.xml @@ -216,7 +216,7 @@ - + diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.1.0.x86_64.xml index 9d04a8b4a5..ab89df1ed0 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml @@ -206,6 +206,7 @@ + @@ -217,6 +218,7 @@ + --=20 2.31.1 From nobody Sun May 5 21:48:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627033477; cv=none; d=zohomail.com; s=zohoarc; b=nbApQEWt+aoUwOjvcQ48LsS5lKZph6BgOsGYUxjTjUp4ce6HjhwqkoRi70c6sqy+wYOaEZ6hkZTcKIP6wGi4XXQ5cyJVSthvwDSkOuq+sA12bX0IW7lY8P2ba3h6THt9/tdTE27Jr81qheAcCtJQc3/UvmZx80afAnWCOdeBO6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627033477; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NEkfRJbJnLotISCw3viYgH5lTe01tkAwZKFhBbzx8Ms=; b=eDDq2lUBVzLM0u5+vHq5NwsM08Cah9cQopFX2NNsP4wV8csArVL+fuIagic6jHukOqe2/YwhaMXrbYqPI+Htg5q6V8+BPoQRO6zkd6Ya2OBG7Znm8dLiWYGP48oDBz3jjVuGMu3iHolps2FQOMiClr09bRwK6Dlh3k2sM+5imh4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627033477901994.6720103710238; Fri, 23 Jul 2021 02:44:37 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-573-S0ESymlKObKwdoXbbiTpTg-1; Fri, 23 Jul 2021 05:44:35 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F8E4107B788; Fri, 23 Jul 2021 09:44:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3EEAD19C46; Fri, 23 Jul 2021 09:44:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 017AB4A705; Fri, 23 Jul 2021 09:44:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9iCqV022918 for ; Fri, 23 Jul 2021 05:44:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id 895255C1D1; Fri, 23 Jul 2021 09:44:12 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF82E5C22A for ; Fri, 23 Jul 2021 09:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627033477; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NEkfRJbJnLotISCw3viYgH5lTe01tkAwZKFhBbzx8Ms=; b=dMZVuLZWPVwT7CsmgMdttGIx0z3Pz8pQ+MHCu1/mFznw1wJvKLhSMjP8wJvD/GxBl5wQ++ 5emFjD7RBfkhvI9z5mGGFJv5cYpaasK/bxmN19idVJwfuFesPh5f0q/p0MEneoDFbBW8G6 q3faTmhdAYyzJl98VeaJyWOAt7sB31M= X-MC-Unique: S0ESymlKObKwdoXbbiTpTg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 6/6] NEWS: Mention enablement of incremental backups Date: Fri, 23 Jul 2021 11:43:58 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627033478854100001 Content-Type: text/plain; charset="utf-8" Now that 'blockdev-reopen' will be stable in the upcoming qemu versions we can finally enable incremental backups. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d95750e776..a7a7022f8d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,12 @@ v7.6.0 (unreleased) * **New features** + * qemu: Incremental backup support via ``virDomainBackupBegin`` + + libvirt-7.6 along with the unreleased qemu-6.1 will fully support the = change + block tracking features (block-dirty-bitmaps) to be able to do increme= ntal + backups and management of the checkpoint states via the appropriate AP= Is. + * **Improvements** * **Bug fixes** --=20 2.31.1