[PATCH 0/7] Various fixes

Peter Krempa posted 7 patches 2 years, 8 months ago
Failed in applying to current master (apply log)
src/conf/domain_validate.c | 15 ++++------
src/conf/virnetworkobj.c   | 13 +++------
src/hyperv/hyperv_wmi.c    |  5 ----
src/qemu/qemu_block.c      |  8 ++----
src/qemu/qemu_domain.c     | 57 ++++++++++++++++++--------------------
src/util/virhash.h         |  2 +-
6 files changed, 39 insertions(+), 61 deletions(-)
[PATCH 0/7] Various fixes
Posted by Peter Krempa 2 years, 8 months ago
Fixes for stuff I've noticed when reviewing Tim's hash table cleanups.

This obviously applies on top of his series.

Peter Krempa (7):
  virHashNew: Ensure return value is used
  hypervCreateEmbeddedParam: Don't count elements needlessly
  qemuBlockNodeNameGetBackingChain: Shuffle around variable
    initialization
  virDomainDefValidateAliases: Refactor to avoid cleanup section
  virNetworkObjNew: Remove impossible error handling
  qemu: domain: Move qemuDomainObjPrivateAlloc after
    qemuDomainObjPrivateFree
  qemuDomainObjPrivateAlloc: Fix unlikely memory leak

 src/conf/domain_validate.c | 15 ++++------
 src/conf/virnetworkobj.c   | 13 +++------
 src/hyperv/hyperv_wmi.c    |  5 ----
 src/qemu/qemu_block.c      |  8 ++----
 src/qemu/qemu_domain.c     | 57 ++++++++++++++++++--------------------
 src/util/virhash.h         |  2 +-
 6 files changed, 39 insertions(+), 61 deletions(-)

-- 
2.31.1

Re: [PATCH 0/7] Various fixes
Posted by Tim Wiederhake 2 years, 8 months ago
On Fri, 2021-07-23 at 11:05 +0200, Peter Krempa wrote:
> Fixes for stuff I've noticed when reviewing Tim's hash table
> cleanups.
> 
> This obviously applies on top of his series.
> 
> Peter Krempa (7):
>   virHashNew: Ensure return value is used
>   hypervCreateEmbeddedParam: Don't count elements needlessly
>   qemuBlockNodeNameGetBackingChain: Shuffle around variable
>     initialization
>   virDomainDefValidateAliases: Refactor to avoid cleanup section
>   virNetworkObjNew: Remove impossible error handling
>   qemu: domain: Move qemuDomainObjPrivateAlloc after
>     qemuDomainObjPrivateFree
>   qemuDomainObjPrivateAlloc: Fix unlikely memory leak
> 
>  src/conf/domain_validate.c | 15 ++++------
>  src/conf/virnetworkobj.c   | 13 +++------
>  src/hyperv/hyperv_wmi.c    |  5 ----
>  src/qemu/qemu_block.c      |  8 ++----
>  src/qemu/qemu_domain.c     | 57 ++++++++++++++++++------------------
> --
>  src/util/virhash.h         |  2 +-
>  6 files changed, 39 insertions(+), 61 deletions(-)
> 

LGTM. Series:
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>