From nobody Sat May 4 11:23:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625228294; cv=none; d=zohomail.com; s=zohoarc; b=buMpXD5u1jLbqHEdhKyHMh66zcggWJr3HyK8BnCeoRKKbrt0Kz9MkLnOqbmS3OI0Mtb5+IaIqGP/wE9tYgXEQ7/uzzYXGKFL8m/wi740Fa8g/jVkNEbnZF5fpHoJfMXmMay7mR4MF+kvYySnR+2fzAtT1KKK3/8r8wiW4pK7psw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625228294; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xA3WCfAF4ndVFrU3Juji+3ajwP33WJ8awV6hcbg1gdE=; b=SkRXS6yEgv5ALG6Ro80+0u9nAA9h0hGVqxFAEQGwqPoREmom/9AtpGDZANYb0BExkzQzPokM+Tms72qlh7wYvBnVykg0nZQ0PscqGRyI8ThtINcQN7RjqApXbCU6vd4/KAZ1I8TH8Jc3i/KoCYGDB4dKNENKJSWBffJ4esCpRFc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1625228294091902.3683660217978; Fri, 2 Jul 2021 05:18:14 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-j9NiznZAM-GPcCst6KyHWw-1; Fri, 02 Jul 2021 08:18:11 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B9828A4AE0; Fri, 2 Jul 2021 12:18:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DBCDF5DD68; Fri, 2 Jul 2021 12:18:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A75761809C9A; Fri, 2 Jul 2021 12:18:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 162CI17d024416 for ; Fri, 2 Jul 2021 08:18:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id C24E260864; Fri, 2 Jul 2021 12:18:01 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 324AE60862 for ; Fri, 2 Jul 2021 12:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625228293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xA3WCfAF4ndVFrU3Juji+3ajwP33WJ8awV6hcbg1gdE=; b=RVjp9YjgwdvPj0+UEQNOgKOSyOHhrDaeT5JXY4KaqzER+GIT/OSLM5zAsvPfyrGJ3ZlfXl ptJbQSuxF02GT8AphjtryoA4drnAuWqeH0qE4losLj1C1m3r8pDXGlVvmRoSAs+CsqCx3+ y9LTaIlih4z0bwTGkz/r9scXLN+UAU4= X-MC-Unique: j9NiznZAM-GPcCst6KyHWw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/2] qemu: migration: Use correct flag constant for enabling storage migration Date: Fri, 2 Jul 2021 14:17:57 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625228295772100001 Content-Type: text/plain; charset="utf-8" The 'storageMigration' flag is supposed to be true if storage migration is requested, which is based on VIR_MIGRATE_NON_SHARED_DISK or VIR_MIGRATE_NON_SHARED_INC flags. The assignment to the variable used QEMU_MONITOR_MIGRATE_NON_SHARED_INC (0x04) instead of VIR_MIGRATE_NON_SHARED_INC (0x80), caused libvirtd to skip the actual copy of data. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D1978526 Fixes: da69f4b2084bff140238e450e264d6036ebef898 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index a199758feb..2ec7b7c48b 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4016,7 +4016,7 @@ qemuMigrationSrcRun(virQEMUDriver *driver, bool abort_on_error =3D !!(flags & VIR_MIGRATE_ABORT_ON_ERROR); bool events =3D virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVE= NT); bool bwParam =3D virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_PA= RAM_BANDWIDTH); - bool storageMigration =3D flags & (VIR_MIGRATE_NON_SHARED_DISK | QEMU_= MONITOR_MIGRATE_NON_SHARED_INC); + bool storageMigration =3D flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_M= IGRATE_NON_SHARED_INC); bool cancel =3D false; unsigned int waitFlags; g_autoptr(virDomainDef) persistDef =3D NULL; --=20 2.31.1 From nobody Sat May 4 11:23:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625228294; cv=none; d=zohomail.com; s=zohoarc; b=IYBUgzujGgfZ/Bkkz5FIKCzIhswX53Ku789CktwsNLWhAyeU4MlG3EnkpC0soa/kEsctSTfx+10ZrfJ2a57HbXiyRFsuIq+nthtBUv2jDdI3eQBJ17YZHsxSSxgKf6ybCFBTpMdSnqHqrCgwPXQa3q2XdxCxUyRLjr8DJ7HvuTw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625228294; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J6bOylk9LOSN2wLPPotROmzg0AutHBFMyJ6N2A1ylB4=; b=KoO0dqbdZ5BGw5Ed5CZFNPZvOAwjJDiBYQR/dYX8EoQh4gCRtmoVC/fu1E9iu9b9e/up0KEwHHGvj3+Ieqqi+VXO/EZgmvQKKDcSI63xevyfUgxNUNuidssKnQ6IP6gvQiAq3lP36vmb+gCX/7nZ/YvrsGIngSfcUTAaKIiuHso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625228294481833.3350957941797; Fri, 2 Jul 2021 05:18:14 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-594-EyNptf9oP0ykqFM0RRMMtA-1; Fri, 02 Jul 2021 08:18:11 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42C058A4AE4; Fri, 2 Jul 2021 12:18:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01CD35DA61; Fri, 2 Jul 2021 12:18:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C08DA1809C97; Fri, 2 Jul 2021 12:18:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 162CI2w2024433 for ; Fri, 2 Jul 2021 08:18:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id D5A7C60864; Fri, 2 Jul 2021 12:18:02 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 388A460862 for ; Fri, 2 Jul 2021 12:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625228293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=J6bOylk9LOSN2wLPPotROmzg0AutHBFMyJ6N2A1ylB4=; b=WKQYbA7YiNp2jlti9+fkGT1Hyg4lHSAfzTOobuZyzf4cspXd3q1/WlQq7WL6I2Dyk70DIO A2bdDjkZMpXcAA8/4lPKoXFrDkSaBxtOaWGJp7A4WsoS+OtVqyC2saOv1b0kA84vrbQNG8 ASBsycjGs9lhSxPV3JvDsId2kSvyo14= X-MC-Unique: EyNptf9oP0ykqFM0RRMMtA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/2] NEWS: Mention implications of the bug in migration code Date: Fri, 2 Jul 2021 14:17:58 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625229197732100006 Content-Type: text/plain; charset="utf-8" Wrong flag use could have user-visible implications. Mention the fix. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2536955a4a..2a97b5ece4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,13 @@ v7.6.0 (unreleased) * **Bug fixes** + * qemu: Fix migration with VIR_MIGRATE_NON_SHARED_INC + + libvirt-7.3 introduced a bug where VIR_MIGRATE_NON_SHARED_INC would not + actually migrate the contents of the disk due to broken logic and at t= he + same time could trigger migration of storage when VIR_MIGRATE_TUNNELLE= D is + requested. This release fixes the bug. + v7.5.0 (2021-07-01) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --=20 2.31.1