From nobody Thu May 2 06:45:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625148265; cv=none; d=zohomail.com; s=zohoarc; b=f2Zqj8+jCWWO4BCDCQszBcn9FUKIcJW34PorR2yzXDJkKuZNQjVrWUglJOrPwf0kp642BwZDErblfp4Ao5kfP6UnwOet8mSZrWVkLNMaBNaUgV4/43w3cqzWjKJbXRZOAKEAEfJXrAitA17WNCiS3fsxAB5IY6D+Et/aLtXy1Fk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625148265; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1dmxSBAOacrJ8aHW+/KNjjZ0kK1HNwHlJQuPAl71gQc=; b=WunMO5El8sMd474XOe0voF7cJ3NahTjHFsQWja/IO4KpJPVXhmVrRQPGy99GLMFfz3KXq5X7NbDDwuZzvdDNXPuGr02V8nG15ii0wNDShIyazodFO9gqaFG1pLuqFXs0fWGEmHBBcIwD62OEcPsI8+0yzSHk/IHHxHESbV7IYH4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1625148265363680.233523922779; Thu, 1 Jul 2021 07:04:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-VNADq1REOSWhaEDdG2FEAA-1; Thu, 01 Jul 2021 10:04:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4550780414A; Thu, 1 Jul 2021 14:04:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CFD8560C82; Thu, 1 Jul 2021 14:04:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8BCD34EA2F; Thu, 1 Jul 2021 14:04:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 161E49D9032446 for ; Thu, 1 Jul 2021 10:04:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 59CB42C6EE; Thu, 1 Jul 2021 14:04:09 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B8E435F9B7 for ; Thu, 1 Jul 2021 14:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625148263; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1dmxSBAOacrJ8aHW+/KNjjZ0kK1HNwHlJQuPAl71gQc=; b=Ce3THRbW1hWmdQ+vUkZ5SHITYZy7BeHxyK2R6krrfIrOdO0KY+eL8zVIk53q0VgxOXFrez ihzo5BuV7uXerOtRP4MUjdHjnqQV61hnmlwrC+7ZYFKvs5b7YwZ/gT897NVYt4y4ajnglN qI84oVbUrv6FG28TosDPuc3UDRID8NA= X-MC-Unique: VNADq1REOSWhaEDdG2FEAA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/3] storage_source: Add flag storing whether threshold event was registered with index Date: Thu, 1 Jul 2021 16:03:56 +0200 Message-Id: <44faac6c6935ec9ede707d7456a4578dd468699a.1625148214.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" When users register the threshold event for the top level image with an explicit index (e.g. vda[3]) they are clearly expecting the index in the event. This flag will help avoiding emission of the second event without the index when the client clearly requested one with the index. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/conf/storage_source_conf.h | 5 +++++ src/qemu/qemu_domain.c | 8 ++++++++ tests/qemustatusxml2xmldata/modern-in.xml | 1 + 3 files changed, 14 insertions(+) diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h index 389c7b56d1..40db29c418 100644 --- a/src/conf/storage_source_conf.h +++ b/src/conf/storage_source_conf.h @@ -387,6 +387,11 @@ struct _virStorageSource { char *nfs_group; uid_t nfs_uid; gid_t nfs_gid; + + /* We need a flag to remember that the threshold event for this source= was + * registered with a full index (vda[3]) so that we can properly repor= t just + * one event for it */ + bool thresholdEventWithIndex; }; G_DEFINE_AUTOPTR_CLEANUP_FUNC(virStorageSource, virObjectUnref); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index fc60e15eea..efff6eff86 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1951,6 +1951,7 @@ qemuStorageSourcePrivateDataParse(xmlXPathContextPtr = ctxt, g_autofree char *encalias =3D NULL; g_autofree char *httpcookiealias =3D NULL; g_autofree char *tlskeyalias =3D NULL; + g_autofree char *thresholdEventWithIndex =3D NULL; src->nodestorage =3D virXPathString("string(./nodenames/nodename[@type= =3D'storage']/@name)", ctxt); src->nodeformat =3D virXPathString("string(./nodenames/nodename[@type= =3D'format']/@name)", ctxt); @@ -1990,6 +1991,10 @@ qemuStorageSourcePrivateDataParse(xmlXPathContextPtr= ctxt, if (virStorageSourcePrivateDataParseRelPath(ctxt, src) < 0) return -1; + if ((thresholdEventWithIndex =3D virXPathString("string(./thresholdEve= nt/@indexUsed)", ctxt)) && + virTristateBoolTypeFromString(thresholdEventWithIndex) =3D=3D VIR_= TRISTATE_BOOL_YES) + src->thresholdEventWithIndex =3D true; + return 0; } @@ -2044,6 +2049,9 @@ qemuStorageSourcePrivateDataFormat(virStorageSource *= src, virXMLFormatElement(buf, "objects", NULL, &tmp); + if (src->thresholdEventWithIndex) + virBufferAddLit(buf, "\n"); + return 0; } diff --git a/tests/qemustatusxml2xmldata/modern-in.xml b/tests/qemustatusxm= l2xmldata/modern-in.xml index ba0858a4ff..cc5fd1cb74 100644 --- a/tests/qemustatusxml2xmldata/modern-in.xml +++ b/tests/qemustatusxml2xmldata/modern-in.xml @@ -340,6 +340,7 @@ + --=20 2.31.1 From nobody Thu May 2 06:45:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625148273; cv=none; d=zohomail.com; s=zohoarc; b=E3nNnK1OymmannMrhcuQBG9KsSLIAkFLs9DAMtH+7wyqiHMgGVcrmw/QqbqW1Y5QYYzYqMMGjXcP8T1nrBvpEgDB7swK2QnKquvOOyfFKgarV7Gpyr2jFo0DxnuujbOwt+M6+m/sI7gI+O+E3r7oOjOFIG3RfmxaR27m+7Hi2tM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625148273; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tzbvBPzZmWictp07X8OCclG2Qx3VTwqHvYeKk00oac0=; b=bdtwhw6V6TxwwsoDLjTycsW/HqB8a6+VQcUaBBLwkTARZyTlFQXEtNN0/pu2EbEXMtIohCrVR79HDsM+1rpt0rutC7GtWOAIWnGhcbfk2fMXTydNv3yn3N9M3AyLLJhyRhv0Omv06sWjUuKaBphg+Xn6S8rdavGUSaWFNHLYA0s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1625148273374708.4340210196267; Thu, 1 Jul 2021 07:04:33 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-Pl7H9AsDP_6OhsqyH_HvyQ-1; Thu, 01 Jul 2021 10:04:30 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D033980430B; Thu, 1 Jul 2021 14:04:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B175B60C17; Thu, 1 Jul 2021 14:04:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 799984EA38; Thu, 1 Jul 2021 14:04:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 161E4Awn032454 for ; Thu, 1 Jul 2021 10:04:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 68BA42C6EE; Thu, 1 Jul 2021 14:04:10 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4B1A5F9B7 for ; Thu, 1 Jul 2021 14:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625148272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tzbvBPzZmWictp07X8OCclG2Qx3VTwqHvYeKk00oac0=; b=Cwc9jyvsdAWqlQFs3rhD+q5X+odEEY1wdusHsuf8xMhbes2dxT90Q9H3KwOccLfqTyvcag XJDhcazxdKSi4tTSLBseBsgxj6WFUYYHZZMw3kxOLJPvDWdWslSvy9gIfO5RJfL6asjt+4 9aDiht+YAiwADFRPIb5Qjdh+RJrbIjE= X-MC-Unique: Pl7H9AsDP_6OhsqyH_HvyQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/3] qemu: Prevent two threshold events when it was registered with index Date: Thu, 1 Jul 2021 16:03:57 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Remember whether the user passed an explicit index when registering the event so that we can avoid the top level event when it isn't needed. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_driver.c | 4 ++++ src/qemu/qemu_process.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 235f575901..eeca5074ce 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19604,6 +19604,10 @@ qemuDomainSetBlockThreshold(virDomainPtr dom, if (qemuDomainObjExitMonitor(driver, vm) < 0 || rc < 0) goto endjob; + /* we need to remember whether the threshold was registered with an ex= plicit + * index to fire the correct event */ + src->thresholdEventWithIndex =3D !!strchr(dev, '['); + ret =3D 0; endjob: diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2b03b0ab98..f8916282bf 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1487,7 +1487,8 @@ qemuProcessHandleBlockThreshold(qemuMonitor *mon G_GN= UC_UNUSED, if (virStorageSourceIsLocalStorage(src)) path =3D src->path; - if (src =3D=3D disk->src) { + if (src =3D=3D disk->src && + !src->thresholdEventWithIndex) { g_autofree char *dev =3D qemuDomainDiskBackingStoreGetName(dis= k, 0); eventDevice =3D virDomainEventBlockThresholdNewFromObj(vm, dev= , path, --=20 2.31.1 From nobody Thu May 2 06:45:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625148264; cv=none; d=zohomail.com; s=zohoarc; b=XxTopb8jimAbVNhQ4KYmTXJNLBRmDc/yt9ZfblIFTefk0EFs6OYa/FXqNAvC5MQb6mOSbAVNcF083YUh84u8bGQ1y5VIrJ80HmvD5Bl367Iafr5twSylw50R4jNtCyu0C6GR9WCw0b4NcVJvoNLzFfE/eQwtgswKWrXuSqZY/rY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625148264; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A6shp9sDh1s4FqiNC+NuT/dwXMWT6MQeMgehUTGTebg=; b=EI4K9ZduzyMIPiVUCczlGn71lNHNC5XknRVqZF64HqZOEJGAeMGvKuTHUx/ehkkSW3BlCaIFBh+SJkeNA6yA3z5R2dIaNwEoH3l2KZ+0hCGPcRwq3+sAXzS8ACiui+FPlOYgo5EUqc5/lpl1WuJObr5MRRQRodP8BUIve+jcORw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625148264388457.32631880419353; Thu, 1 Jul 2021 07:04:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-L97tfKTpOIyJqS9Z50pi0A-1; Thu, 01 Jul 2021 10:04:20 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C75E6101999D; Thu, 1 Jul 2021 14:04:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F4B85DF36; Thu, 1 Jul 2021 14:04:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A8E214EA2A; Thu, 1 Jul 2021 14:04:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 161E4BIH032465 for ; Thu, 1 Jul 2021 10:04:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8165F2C6EE; Thu, 1 Jul 2021 14:04:11 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D73E05F9B7 for ; Thu, 1 Jul 2021 14:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625148263; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=A6shp9sDh1s4FqiNC+NuT/dwXMWT6MQeMgehUTGTebg=; b=EV0Vr2haKPqotOAveo5xEcbICBhdmZEaKsAir/hH/aIvGPvI2J2WfY3qrzgPuPltHvH0TK F3vm21L/ObX4+iXxMGbtfkeTstnERa9bF2cLu6Zq3tRHfTBeL6uizn5PwAmp/+CwzptEU6 7GAwoUhjX3JQL+4g7wnGFjZzamf6aVs= X-MC-Unique: L97tfKTpOIyJqS9Z50pi0A-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/3] virDomainSetBlockThreshold: Document that two events are fired when index isn't used Date: Thu, 1 Jul 2021 16:03:58 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Libvirt started emitting two threshold events, once with index and once withouth when the index isn't registered. Document this caveat. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/libvirt-domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 750e32f0ca..0a7d2dd234 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12637,6 +12637,10 @@ int virDomainGetGuestInfo(virDomainPtr domain, * live VM XML for 'backingStore' or 'source' elements of a disk. If index= is * given the threshold is set for the corresponding image. * + * In case when @dev does not contain index the + * VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD event may be emitted twice, once fo= r the + * disk device target without index and once containing the index. + * * Note that the threshold event can be registered also for destinations o= f a * 'virDomainBlockCopy' destination by using the 'index' of the 'mirror' s= ource. * --=20 2.31.1